GNU bug report logs - #75167
[PATCH gnome-team 0/6] Update GNOME Builder to 47.2

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: vivien <at> planete-kraus.eu, 75167 <at> debbugs.gnu.org
Subject: [bug#75167] [PATCH gnome-team 5/6] gnu: Add libspelling.
Date: Sun, 29 Dec 2024 13:34:08 +0900

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/gnome.scm (libspelling): New variable.
> ---
>  gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index fea67718c37..f3568350f79 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13612,6 +13612,40 @@ (define-public sysprof-3.44
>                              (("gtk-update-icon-cache") "true")
>                              (("update-desktop-database") "true"))))))))))
>  
> +(define-public libspelling
> +  (package
> +    (name "libspelling")
> +    (version "0.4.5")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.gnome.org/GNOME/libspelling")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "030s821sb9rsr1ysl79x7id1bsin9idy8z7p85qr9cvw1w3f2s7r"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-before 'check 'setup-home
> +                 (lambda _
> +                   ;; Tests require a writable HOME.
> +                   (setenv "HOME" (getcwd)))))))
> +    (inputs (list enchant gtk gtksourceview sysprof))
> +    (native-inputs
> +     (list gobject-introspection
> +           gi-docgen
> +           pkg-config
> +           vala

Please sort.

> +           ;; For testing

Please properly punctuate line comments (here, by adding trailing '.').

> +           aspell aspell-dict-en))
> +    (home-page "https://gitlab.gnome.org/GNOME/libspelling/")
> +    (synopsis "Spell-checking library for GTK 4")
> +    (description "This package provides a spell-checker for
> +GtkTextView widgets.")
> +    (license license:lgpl2.1+)))

Other than these two nitpicks, LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.