GNU bug report logs - #7516
[PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#7516: closed ([PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path)
 Exclude more VCS dirs)
Date: Fri, 03 Dec 2010 18:53:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 03 Dec 2010 13:58:04 -0500
with message-id <fz39qehef7.fsf <at> fencepost.gnu.org>
and subject line Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs
has caused the GNU bug report #7516,
regarding [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
7516: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7516
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path)
	Exclude more VCS dirs
Date: Mon, 29 Nov 2010 16:04:57 +0200

[Message part 3 (text/plain, inline)]

Package: emacs
Version: 23.2+1-5.1
Severity: wishlist
Tags: patch

2010-11-29  Jari Aalto  <jari.aalto <at> cante.net>

        * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude
        more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone).

-- System Information
Debian Release: squeeze/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-lucid   23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-nox     23.2+1-5.1      GNU Emacs is the extensible self-documenting 

[0001-startup.el-normal-top-level-add-subdirs-to-load-path.patch (text/x-diff, inline)]

From ebdacca7a561c40777a087ef4a16f2752895edab Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Mon, 29 Nov 2010 15:52:58 +0200
Subject: [PATCH] * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude
 more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone).
Organization: Private
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/startup.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/startup.el b/lisp/startup.el
index da0264d..67f5ebc 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -419,7 +419,8 @@ or `CVS', and any subdirectory that contains a file named `.nosearch'."
 	  (push attrs normal-top-level-add-subdirs-inode-list)
 	  (dolist (file contents)
 	    ;; The lower-case variants of RCS and CVS are for DOS/Windows.
-	    (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs"))
+	    (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs"
+				   ".svn" ".hg" ".bzr" ".git" .mtn"))
 	      (when (and (string-match "\\`[[:alnum:]]" file)
 			 ;; Avoid doing a `stat' when it isn't necessary
 			 ;; because that can cause trouble when an NFS server
-- 
1.7.2.3

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 7516-done <at> debbugs.gnu.org
Subject: Re: bug#7516: [PATCH] lisp/startup.el
	(normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs
Date: Fri, 03 Dec 2010 13:58:04 -0500

jari wrote:

> Wouldn't the first two tests be redundant then in previous line:
>
>       (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs"))
>       	      	      	     ========

Why not test it and see?

Anyway, it's hardly a bug but I simplified it anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.