From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 08:59:30 2010 Received: (at submit) by debbugs.gnu.org; 29 Nov 2010 13:59:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN4GP-000596-Dy for submit@debbugs.gnu.org; Mon, 29 Nov 2010 08:59:29 -0500 Received: from emh01.mail.saunalahti.fi ([62.142.5.107]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN4GM-00058t-Rq for submit@debbugs.gnu.org; Mon, 29 Nov 2010 08:59:28 -0500 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh01-2.mail.saunalahti.fi (Postfix) with SMTP id 47C768C5AC for ; Mon, 29 Nov 2010 16:04:59 +0200 (EET) Received: from emh03.mail.saunalahti.fi ([62.142.5.109]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A07BF232EBA; Mon, 29 Nov 2010 16:04:59 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 2B71A158A65 for ; Mon, 29 Nov 2010 16:04:57 +0200 (EET) From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs Mail-Copies-To: poster Date: Mon, 29 Nov 2010 16:04:57 +0200 Message-ID: <877hfwz0mu.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: wishlist Tags: patch 2010-11-29 Jari Aalto * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone). -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-startup.el-normal-top-level-add-subdirs-to-load-path.patch >From ebdacca7a561c40777a087ef4a16f2752895edab Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Mon, 29 Nov 2010 15:52:58 +0200 Subject: [PATCH] * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone). Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Signed-off-by: Jari Aalto --- lisp/startup.el | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lisp/startup.el b/lisp/startup.el index da0264d..67f5ebc 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -419,7 +419,8 @@ or `CVS', and any subdirectory that contains a file named `.nosearch'." (push attrs normal-top-level-add-subdirs-inode-list) (dolist (file contents) ;; The lower-case variants of RCS and CVS are for DOS/Windows. - (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs")) + (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs" + ".svn" ".hg" ".bzr" ".git" .mtn")) (when (and (string-match "\\`[[:alnum:]]" file) ;; Avoid doing a `stat' when it isn't necessary ;; because that can cause trouble when an NFS server -- 1.7.2.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 13:05:52 2010 Received: (at 7516) by debbugs.gnu.org; 29 Nov 2010 18:05:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN86p-00025k-GY for submit@debbugs.gnu.org; Mon, 29 Nov 2010 13:05:51 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN86m-00025V-Ko for 7516@debbugs.gnu.org; Mon, 29 Nov 2010 13:05:49 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oATIBH4v004885; Mon, 29 Nov 2010 13:11:18 -0500 Received: by pastel.home (Postfix, from userid 20848) id ED154A85E0; Mon, 29 Nov 2010 13:11:16 -0500 (EST) From: Stefan Monnier To: Jari Aalto Subject: Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs Message-ID: References: <877hfwz0mu.fsf@picasso.cante.net> Date: Mon, 29 Nov 2010 13:11:16 -0500 In-Reply-To: <877hfwz0mu.fsf@picasso.cante.net> (Jari Aalto's message of "Mon, 29 Nov 2010 16:04:57 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3694=0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7516 Cc: 7516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude > more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone). Wouldn't it make more sense to skip anything that starts with a dot? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 17:28:24 2010 Received: (at 7516) by debbugs.gnu.org; 29 Nov 2010 22:28:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNCCu-00082o-IP for submit@debbugs.gnu.org; Mon, 29 Nov 2010 17:28:24 -0500 Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNCCs-00082U-5R for 7516@debbugs.gnu.org; Mon, 29 Nov 2010 17:28:23 -0500 Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh04-2.mail.saunalahti.fi (Postfix) with SMTP id D78A613BDA0; Tue, 30 Nov 2010 00:33:54 +0200 (EET) Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A039D9CFB47; Tue, 30 Nov 2010 00:33:54 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id 6200D41BE3; Tue, 30 Nov 2010 00:33:51 +0200 (EET) From: Jari Aalto To: Stefan Monnier Subject: Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs Organization: Private References: <877hfwz0mu.fsf@picasso.cante.net> Date: Tue, 30 Nov 2010 00:33:51 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 29 Nov 2010 13:11:16 -0500") Message-ID: <87oc97yd2o.fsf@picasso.cante.net> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7516 Cc: 7516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain 2010-11-29 20:11 Stefan Monnier : >> * startup.el: (normal-top-level-add-subdirs-to-load-path): Exclude >> more VCS directories: .svn, .hg, .bzr, .git and .mtn (monotone). > > Wouldn't it make more sense to skip anything that starts with a dot? Sure. See below. Jari 2010-11-29 Jari Aalto * startup.el (normal-top-level-add-subdirs-to-load-path): Change `member' to `string-match' file test. Skip all dot-files. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-startup.el-normal-top-level-add-subdirs-to-load-path.patch >From 77eb2b69e60378fbfd8e1d70630ec136638381cd Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Mon, 29 Nov 2010 15:52:58 +0200 Subject: [PATCH] startup.el: (normal-top-level-add-subdirs-to-load-path): Skip all dot files. Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Signed-off-by: Jari Aalto --- lisp/startup.el | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lisp/startup.el b/lisp/startup.el index da0264d..5b9b62b 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -419,7 +419,9 @@ or `CVS', and any subdirectory that contains a file named `.nosearch'." (push attrs normal-top-level-add-subdirs-inode-list) (dolist (file contents) ;; The lower-case variants of RCS and CVS are for DOS/Windows. - (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs")) + ;; Skip all dot-files. + (unless (let ((case-fold-search t)) + (string-match "^\\(RCS\\|CVS\\|\\..*\\)$" file)) (when (and (string-match "\\`[[:alnum:]]" file) ;; Avoid doing a `stat' when it isn't necessary ;; because that can cause trouble when an NFS server -- 1.7.2.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 17:28:40 2010 Received: (at 7516) by debbugs.gnu.org; 29 Nov 2010 22:28:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNCD8-00083C-Q9 for submit@debbugs.gnu.org; Mon, 29 Nov 2010 17:28:39 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNCD7-000830-5l for 7516@debbugs.gnu.org; Mon, 29 Nov 2010 17:28:37 -0500 Received: from localhost ([127.0.0.1]:54328) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNCIT-0004CZ-Q7; Mon, 29 Nov 2010 17:34:09 -0500 To: Stefan Monnier Subject: Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs References: <877hfwz0mu.fsf@picasso.cante.net> From: Glenn Morris X-Spook: pipeline KGB threat wire transfer Bush Wired InfoSec X-Ran: %qNkj'G7*9]d]9aiJBj#~5'Z;,1^H3HoYk@zve\/5o,4G]Db_C<>O1D$Y}C9XZDzj$];E8 X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 29 Nov 2010 17:34:09 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7516 Cc: 7516@debbugs.gnu.org, Jari Aalto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Stefan Monnier wrote: > Wouldn't it make more sense to skip anything that starts with a dot? The very next line does: (string-match "\\`[[:alnum:]]" file) so this change seems unnecessary (the function is documented to behave in this way). Empirically, .svn etc directories are already skipped, so I don't see any point to this patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 02 07:33:05 2010 Received: (at 7516) by debbugs.gnu.org; 2 Dec 2010 12:33:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PO8LR-000312-8A for submit@debbugs.gnu.org; Thu, 02 Dec 2010 07:33:05 -0500 Received: from emh05.mail.saunalahti.fi ([62.142.5.111]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PO8LN-00030X-WE for 7516@debbugs.gnu.org; Thu, 02 Dec 2010 07:33:03 -0500 Received: from saunalahti-vams (vs3-11.mail.saunalahti.fi [62.142.5.95]) by emh05-2.mail.saunalahti.fi (Postfix) with SMTP id 261218BF16; Thu, 2 Dec 2010 14:38:43 +0200 (EET) Received: from emh06.mail.saunalahti.fi ([62.142.5.116]) by vs3-11.mail.saunalahti.fi ([62.142.5.95]) with SMTP (gateway) id A04F6620F6C; Thu, 02 Dec 2010 14:38:43 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh06.mail.saunalahti.fi (Postfix) with ESMTP id 3C759E51A3; Thu, 2 Dec 2010 14:38:38 +0200 (EET) Received: from jaalto by picasso.cante.net with local (Exim 4.72) (envelope-from ) id 1PO8Qo-00019D-7Z; Thu, 02 Dec 2010 14:38:38 +0200 Date: Thu, 2 Dec 2010 14:38:38 +0200 From: jari To: Glenn Morris Subject: Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs Message-ID: <20101202123838.GE6537@picasso.cante.net> References: <877hfwz0mu.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: jaalto@picasso.cante.net X-SA-Exim-Scanned: No (on picasso.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 7516 Cc: 7516@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) On 2010-11-29 17:34, Glenn Morris wrote: | Stefan Monnier wrote: | | > Wouldn't it make more sense to skip anything that starts with a dot? | | The very next line does: | | (string-match "\\`[[:alnum:]]" file) Wouldn't the first two tests be redundant then in previous line: (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs")) ======== Jari From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 03 13:52:24 2010 Received: (at 7516-done) by debbugs.gnu.org; 3 Dec 2010 18:52:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POak4-0007lS-NO for submit@debbugs.gnu.org; Fri, 03 Dec 2010 13:52:24 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POak2-0007lF-Ma for 7516-done@debbugs.gnu.org; Fri, 03 Dec 2010 13:52:23 -0500 Received: from localhost ([127.0.0.1]:38260) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POapZ-0001Vf-6M; Fri, 03 Dec 2010 13:58:05 -0500 To: 7516-done@debbugs.gnu.org Subject: Re: bug#7516: [PATCH] lisp/startup.el (normal-top-level-add-subdirs-to-load-path) Exclude more VCS dirs References: <877hfwz0mu.fsf@picasso.cante.net> <20101202123838.GE6537@picasso.cante.net> From: Glenn Morris X-Spook: AIEWS lynch monarchist Leitrim terrorism Mahmoud X-Ran: x6D(E>D{-y,](NGY?UBD>=97Ozfjcv?LAB^JI_!((,[]1J&/w)7T;C+lM"oI4Qi_1:<)$s X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 03 Dec 2010 13:58:04 -0500 In-Reply-To: <20101202123838.GE6537@picasso.cante.net> (jari's message of "Thu\, 2 Dec 2010 14\:38\:38 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7516-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) jari wrote: > Wouldn't the first two tests be redundant then in previous line: > > (unless (member file '("." ".." "RCS" "CVS" "rcs" "cvs")) > ======== Why not test it and see? Anyway, it's hardly a bug but I simplified it anyway. From unknown Sun Jun 22 11:44:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator