Subject: Re: [bug#75159] [PATCH v1 2/5] gnu: Add trompeloeil.

From: Zheng Junjie <[email-masked]>
Date: Mon, 30 Dec 2024 14:38:13 +0800

Ashvith Shetty <[email-masked]> writes:

> * gnu/packages/check.scm (trompeloeil): New variable.
>
> Change-Id: I44d83ff4230a1c836bedc124acb1a40742f17021
> ---
>  gnu/packages/check.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
> index dd32800870..6afd7fefb5 100644
> --- a/gnu/packages/check.scm
> +++ b/gnu/packages/check.scm
> @@ -3805,6 +3805,29 @@ (define-public toml-test
>  tests.  The output format is JSON.")
>      (license license:expat)))
>  
> +(define-public trompeloeil
> +  (package
> +    (name "trompeloeil")
> +    (version "49")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/rollbear/trompeloeil")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0m4bfzcj033qfk3sihbikrhk9krsdbsqk79nsambnsnqqcgc2903"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +      (list
> +        #:tests? #f))

why disable test? Please fix it or add a comment to explain this.

> +    (home-page "https://github.com/rollbear/trompeloeil")
> +    (synopsis "Header only C++14 mocking framework")
> +    (description
> +     "A thread-safe header-only mocking framework for C++11/14 using the Boost Software License 1.0")

maybe "Trompeloeil is a thread-safe header-only mocking framework for C++11/14."

> +    (license license:boost1.0)))
> +
>  (define-public unittest-cpp
>    (package
>      (name "unittest-cpp")