GNU bug report logs - #75156
[PATCH] Please install these elixir-ts-mode fixes

Previous Next

Package: emacs;

Reported by: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>

Date: Sat, 28 Dec 2024 06:50:01 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75156 in the body.
You can then email your comments to 75156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#75156; Package emacs. (Sat, 28 Dec 2024 06:50:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 28 Dec 2024 06:50:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Please install these elixir-ts-mode fixes
Date: Sat, 28 Dec 2024 08:49:00 +0200
[Message part 1 (text/plain, inline)]
Attached are two updates to elixir-ts-mode for minor improvements. Can
someone please install them if there are no concerns.

The patches are from the emacs-30 branch. I can rebase them on master if
required?

Kind regards,
Wilhelm
[Message part 2 (text/html, inline)]
[0002-Add-missing-fortification-matches-for-elixir-ts-mode.patch (text/x-patch, attachment)]
[0001-Always-match-underscore-variables-for-elixir-ts-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#75156; Package emacs. (Sat, 28 Dec 2024 06:54:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: [PATCH] Please install these elixir-ts-mode fixes
Date: Sat, 28 Dec 2024 08:53:32 +0200
[Message part 1 (text/plain, inline)]
On Sat, Dec 28, 2024 at 8:49 AM Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
wrote:

> Attached are two updates to elixir-ts-mode for minor improvements. Can
> someone please install them if there are no concerns.
>
> The patches are from the emacs-30 branch. I can rebase them on master if
> required?
>
> Kind regards,
> Wilhelm
>

I see there is a typo in the commit message, apologies.

fontication, not fortification.

Modified patch attached.
[Message part 2 (text/html, inline)]
[0002-Add-missing-fontification-matches-for-elixir-ts-mode.patch (text/x-patch, attachment)]

Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sat, 28 Dec 2024 08:46:02 GMT) Full text and rfc822 format available.

Notification sent to Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>:
bug acknowledged by developer. (Sat, 28 Dec 2024 08:46:02 GMT) Full text and rfc822 format available.

Message #13 received at 75156-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>, 75156-done <at> debbugs.gnu.org
Subject: Re: bug#75156: [PATCH] Please install these elixir-ts-mode fixes
Date: Sat, 28 Dec 2024 03:44:08 -0500
Version: 30.1

Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:

> On Sat, Dec 28, 2024 at 8:49 AM Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> wrote:
>
>> Attached are two updates to elixir-ts-mode for minor improvements. Can
>> someone please install them if there are no concerns.
>>
>> The patches are from the emacs-30 branch. I can rebase them on master if
>> required?
>>
>> Kind regards,
>> Wilhelm
>>
>
> I see there is a typo in the commit message, apologies.

Thanks.  Installed on emacs-30 as commit 624322d5f6a.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#75156; Package emacs. (Sat, 28 Dec 2024 08:51:01 GMT) Full text and rfc822 format available.

Message #16 received at 75156-done <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 75156-done <at> debbugs.gnu.org
Subject: Re: bug#75156: [PATCH] Please install these elixir-ts-mode fixes
Date: Sat, 28 Dec 2024 10:49:10 +0200
[Message part 1 (text/plain, inline)]
On Sat, Dec 28, 2024 at 10:44 AM Stefan Kangas <stefankangas <at> gmail.com>
wrote:

> Version: 30.1
>
> Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:
>
> > On Sat, Dec 28, 2024 at 8:49 AM Wilhelm Kirschbaum <
> wkirschbaum <at> gmail.com>
> > wrote:
> >
> >> Attached are two updates to elixir-ts-mode for minor improvements. Can
> >> someone please install them if there are no concerns.
> >>
> >> The patches are from the emacs-30 branch. I can rebase them on master if
> >> required?
> >>
> >> Kind regards,
> >> Wilhelm
> >>
> >
> > I see there is a typo in the commit message, apologies.
>
> Thanks.  Installed on emacs-30 as commit 624322d5f6a.
>

Thanks Stefan, much appreciated.

I added two patches to the original email. Do you mind installing the other
patch as well? I attached it for convenience.
[Message part 2 (text/html, inline)]
[0001-Always-match-underscore-variables-for-elixir-ts-mode.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#75156; Package emacs. (Sat, 28 Dec 2024 16:40:01 GMT) Full text and rfc822 format available.

Message #19 received at 75156-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: 75156-done <at> debbugs.gnu.org
Subject: Re: bug#75156: [PATCH] Please install these elixir-ts-mode fixes
Date: Sat, 28 Dec 2024 16:38:08 +0000
Wilhelm Kirschbaum <wkirschbaum <at> gmail.com> writes:

> I added two patches to the original email. Do you mind installing the other
> patch as well? I attached it for convenience.

Sorry, I must have missed that one.  I've now installed that patch also
on emacs-30, as commit 43a8f0de5ec.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 26 Jan 2025 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 138 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.