GNU bug report logs - #75145
[PATCH] services: NetworkManager: configuration-directory

Previous Next

Full log

Message #80 received at 75145 <at> debbugs.gnu.org (full text, mbox):

From: 45mg <45mg.writes <at> gmail.com>
To: Arnaud Daby-Seesaram <ds-ac <at> nanein.fr>, 45mg <45mg.writes <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 75145 <at> debbugs.gnu.org
Subject: Re: [PATCH v5] services: network-manager: Add
 extra-configuration-files field.
Date: Wed, 12 Feb 2025 15:31:11 +0000

Hi Arnaud,

Arnaud Daby-Seesaram <ds-ac <at> nanein.fr> writes:


> --8<---------------cut here---------------start------------->8---
>      (service network-manager-service-type
>               (network-manager-configuration
>                (extra-configuration-files
>                 `(("existing-file" ,(local-file "001-basic.conf"))
>                   ("constructed-file" ,(plain-file "002-unmanaged.conf"
>                                                    "[keyfile]
>      unmanaged-devices=interface-name:wlo1_ap
>      "))))))
> --8<---------------cut here---------------end--------------->8---
>
> adds files named "existing-file" and "constructed-file".  This is the
> expected behaviour (explained in the doc).  However, the example is
> introduced by:
>
> --8<---------------cut here---------------start------------->8---
> For example, to add two files ‘001-basic.conf’ and
> ‘002-unmanaged.conf’:
> --8<---------------cut here---------------end--------------->8---
>
> This may seem counter-intuitive to some readers.

You're right; fixed in the v6 I just sent. I tried to say so via a patch
annotation, but for some reason that didn't work. So I'll say this here
instead: thank you for the very thorough review, and for sticking around
for six revisions :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.