GNU bug report logs - #75141
[PATCH] Add button navigation to treesit-explorer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75141: closed ([PATCH] Add button navigation to treesit-explorer)
Date: Sat, 25 Jan 2025 00:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 24 Jan 2025 18:06:32 -0600
with message-id <CADwFkmk2kT016n5i3d=gznfX58L+jn2XXaCh4Y7LF30=egP=-w <at> mail.gmail.com>
and subject line Re: bug#75141: [PATCH] Add button navigation to treesit-explorer
has caused the debbugs.gnu.org bug report #75141,
regarding [PATCH] Add button navigation to treesit-explorer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75141
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add button navigation to treesit-explorer
Date: Fri, 27 Dec 2024 10:54:04 -0300

[Message part 3 (text/plain, inline)]

Greetings,

Currently, the only way to navigate through treesit-explorer is by the
use of C-n and C-p. Since this buffer is full of buttons, I decided to
add button navigation to it.

This patch adds button navigation to treesit-explorer, for the following
keys:

* forward-button
- f
- n
- TAB

* backward-button
- b
- p
- <backtab>

* Points of discussion

Maybe that's too many keys? The only ones I think that don't really fit
that much are "f" and "b", because they can also go down, but there's no
harm in having extra keys.

Regards,

--
Gabriel Santos

[0001-Add-button-navigation-to-treesit-explorer.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>,
 75141-done <at> debbugs.gnu.org
Subject: Re: bug#75141: [PATCH] Add button navigation to treesit-explorer
Date: Fri, 24 Jan 2025 18:06:32 -0600

Gabriel Santos <gabrielsantosdesouza <at> disroot.org> writes:

> Here is the updated patch, with "f" and "b" removed.

Thanks!  It seems like Yuan already installed it, but never closed the
bug.  So I'm doing that now.

>
> --
> Gabriel Santos
>
>>From 1224d220985edd9de0731b26c0be96eb9f6b35a1 Mon Sep 17 00:00:00 2001
> From: Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
> Date: Fri, 27 Dec 2024 10:43:20 -0300
> Subject: [PATCH] Add button navigation to treesit-explorer
>
> * lisp/treesit.el (treesit--explorer-tree-mode-map):
> Define it as a child of special-mode-map,
> adding keys for button navigation.
> ---
>  lisp/treesit.el | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index e643eb48654..ef27a370bc2 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -4041,6 +4041,16 @@ covers point.  PARSER-NAME are unique."
>    "Mode for displaying syntax trees for `treesit-explore-mode'."
>    nil)
>
> +(defvar-keymap treesit--explorer-tree-mode-map
> +  :doc "Keymap for the treesit tree explorer.
> +
> +Navigates from button to button."
> +  :parent special-mode-map
> +  "n" #'forward-button
> +  "p" #'backward-button
> +  "TAB" #'forward-button
> +  "<backtab>" #'backward-button)
> +
>  (defun treesit-explorer-switch-parser (parser)
>    "Switch explorer to use PARSER."
>    (interactive

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.