From unknown Mon Aug 18 02:38:09 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#75112] [PATCH] gnu: csvkit: Fix tests. Resent-From: Wiktor =?UTF-8?Q?=C5=BBelazny?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Dec 2024 09:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75112 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75112@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173520617316172 (code B ref -1); Thu, 26 Dec 2024 09:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Dec 2024 09:42:53 +0000 Received: from localhost ([127.0.0.1]:40120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQkOL-0004Cm-Go for submit@debbugs.gnu.org; Thu, 26 Dec 2024 04:42:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:55236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQkOJ-0004Cd-8q for submit@debbugs.gnu.org; Thu, 26 Dec 2024 04:42:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQkOI-0004rc-WD for guix-patches@gnu.org; Thu, 26 Dec 2024 04:42:51 -0500 Received: from freeshell.de ([116.202.128.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQkOH-0000yH-6a for guix-patches@gnu.org; Thu, 26 Dec 2024 04:42:50 -0500 Received: from localhost.localdomain (cst-prg-19-252.cust.vodafone.cz [46.135.19.252]) (Authenticated sender: wz) by freeshell.de (Postfix) with ESMTPSA id 02AD2B220B30 for ; Thu, 26 Dec 2024 10:42:43 +0100 (CET) From: Wiktor =?UTF-8?Q?=C5=BBelazny?= Date: Thu, 26 Dec 2024 10:41:07 +0100 Message-ID: <7c73aa954dc114f107c1159659c847d9c61d4788.1735205925.git.wz@freeshell.de> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=116.202.128.144; envelope-from=wz@freeshell.de; helo=freeshell.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/wireservice.scm (csvkit): Fix tests [source]: Apply patch. [native-inputs]: Add (libc-utf8-locales-for-target). * gnu/packages/patches/csvkit-set-locale-for-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. Change-Id: I787c0da270fa4062491efcfa0c55a1b8bbac7b59 --- gnu/local.mk | 1 + .../patches/csvkit-set-locale-for-tests.patch | 13 +++++++++++++ gnu/packages/wireservice.scm | 7 +++++-- 3 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/csvkit-set-locale-for-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index 84160f407a..838c2a06b3 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1131,6 +1131,7 @@ dist_patch_DATA = \ %D%/packages/patches/crc32c-unbundle-googletest.patch \ %D%/packages/patches/crda-optional-gcrypt.patch \ %D%/packages/patches/clucene-contribs-lib.patch \ + %D%/packages/patches/csvkit-set-locale-for-tests.patch \ %D%/packages/patches/cube-nocheck.patch \ %D%/packages/patches/cups-minimal-Address-PPD-injection-issues.patch \ %D%/packages/patches/curl-CVE-2024-8096.patch \ diff --git a/gnu/packages/patches/csvkit-set-locale-for-tests.patch b/gnu/packages/patches/csvkit-set-locale-for-tests.patch new file mode 100644 index 0000000000..52f6a5d517 --- /dev/null +++ b/gnu/packages/patches/csvkit-set-locale-for-tests.patch @@ -0,0 +1,13 @@ +Contents copied from python-agate. See +https://github.com/wireservice/agate/issues/712 for the source and the +rationale. + +diff --git a/tests/__init__.py b/tests/__init__.py +index e69de29..ee8beb5 100644 +--- a/tests/__init__.py ++++ b/tests/__init__.py +@@ -0,0 +1,4 @@ ++import locale ++ ++# The test fixtures can break if the locale is non-US. ++locale.setlocale(locale.LC_ALL, 'en_US.UTF-8') diff --git a/gnu/packages/wireservice.scm b/gnu/packages/wireservice.scm index df630023cf..914945cf54 100644 --- a/gnu/packages/wireservice.scm +++ b/gnu/packages/wireservice.scm @@ -217,10 +217,13 @@ (define-public csvkit (uri (pypi-uri "csvkit" version)) (sha256 (base32 - "08wj0hlmbdmklar12cjzqp91vcxzwifsvmgasszas8kbiyvvgpdy")))) + "08wj0hlmbdmklar12cjzqp91vcxzwifsvmgasszas8kbiyvvgpdy")) + (patches (search-patches + "csvkit-set-locale-for-tests.patch")))) (build-system python-build-system) (native-inputs - (list python-psycopg2 ; to test PostgreSQL support + (list (libc-utf8-locales-for-target) + python-psycopg2 ; to test PostgreSQL support python-sphinx python-sphinx-rtd-theme)) (inputs (list python-agate-dbf python-agate-excel python-agate-sql base-commit: e16cdcf37d8223b3634ec5e658356c3b7f154859 -- 2.46.0 From unknown Mon Aug 18 02:38:09 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Wiktor =?UTF-8?Q?=C5=BBelazny?= Subject: bug#75112: closed (Re: [bug#75112] [PATCH] gnu: csvkit: Fix tests.) Message-ID: References: <875xn2rce3.fsf@kitej> <7c73aa954dc114f107c1159659c847d9c61d4788.1735205925.git.wz@freeshell.de> X-Gnu-PR-Message: they-closed 75112 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 75112@debbugs.gnu.org Date: Sun, 29 Dec 2024 10:51:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1735469463-2594-1" This is a multi-part message in MIME format... ------------=_1735469463-2594-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75112: [PATCH] gnu: csvkit: Fix tests. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75112@debbugs.gnu.org. --=20 75112: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75112 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1735469463-2594-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75112-done) by debbugs.gnu.org; 29 Dec 2024 10:50:56 +0000 Received: from localhost ([127.0.0.1]:53902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRqsp-0000fX-Js for submit@debbugs.gnu.org; Sun, 29 Dec 2024 05:50:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRqsn-0000fJ-6m for 75112-done@debbugs.gnu.org; Sun, 29 Dec 2024 05:50:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1746D240027 for <75112-done@debbugs.gnu.org>; Sun, 29 Dec 2024 11:50:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735469446; bh=Cw9PgNmoKxvMMxfLRQU0IqWKgGvaoQvHmH9kqZc51lY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=R2EpzUWi3i1DubLfOfYoe2bCQtZkMfy8Pfb+fWiS3SvCNDgXjIKltuOcNOXloie1e PFpUxKOKmf7U3WeP95143ac8cVZVrQwv+oZksQAlQrwJWISJE4TkQJPtLKIWr4RZt0 uRKcEgx9eWqqiCaj4/nUwTOHemn4ND/mvvMlzrf56mZxx7ZfXQ8P1uauPQvzFDeVmV xUgqT63V0ECOCNZ7Mdpv5XVjOSaKVcm96nSYBimDEtDVNaZnc1ffXP4fY8GZZorYQc kUFuXqDBubP9O6FbjzOb+oRxax64FPvu6wvtfK1cSfM+Q2y94Ey0At8hiORr1Mk2WD j/WQJpPx7Dugg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YLbcN6TB3z6tm4; Sun, 29 Dec 2024 11:50:44 +0100 (CET) From: Guillaume Le Vaillant To: Wiktor =?utf-8?Q?=C5=BBelazny?= Subject: Re: [bug#75112] [PATCH] gnu: csvkit: Fix tests. In-Reply-To: <7c73aa954dc114f107c1159659c847d9c61d4788.1735205925.git.wz@freeshell.de> ("Wiktor =?utf-8?Q?=C5=BBelazny=22's?= message of "Thu, 26 Dec 2024 10:41:07 +0100") References: <7c73aa954dc114f107c1159659c847d9c61d4788.1735205925.git.wz@freeshell.de> Date: Sun, 29 Dec 2024 10:50:44 +0000 Message-ID: <875xn2rce3.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75112-done Cc: 75112-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Patch applied as 4a4a8c9d2621d4871c4b9c8857bfb0e6e53d7e56. Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCZ3EphA8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j9PzwD+InT/zZfuIFRlIH9pwwEM2w9ELmOfE2LIwlJZ eMnZvloA/2RpqcVmZ4UwG0V8q2PXNYpkP36SDvHOrvuROhFz4TyF =IUmI -----END PGP SIGNATURE----- --=-=-=-- ------------=_1735469463-2594-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Dec 2024 09:42:53 +0000 Received: from localhost ([127.0.0.1]:40120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQkOL-0004Cm-Go for submit@debbugs.gnu.org; Thu, 26 Dec 2024 04:42:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:55236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQkOJ-0004Cd-8q for submit@debbugs.gnu.org; Thu, 26 Dec 2024 04:42:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQkOI-0004rc-WD for guix-patches@gnu.org; Thu, 26 Dec 2024 04:42:51 -0500 Received: from freeshell.de ([116.202.128.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQkOH-0000yH-6a for guix-patches@gnu.org; Thu, 26 Dec 2024 04:42:50 -0500 Received: from localhost.localdomain (cst-prg-19-252.cust.vodafone.cz [46.135.19.252]) (Authenticated sender: wz) by freeshell.de (Postfix) with ESMTPSA id 02AD2B220B30 for ; Thu, 26 Dec 2024 10:42:43 +0100 (CET) From: =?UTF-8?q?Wiktor=20=C5=BBelazny?= To: guix-patches@gnu.org Subject: [PATCH] gnu: csvkit: Fix tests. Date: Thu, 26 Dec 2024 10:41:07 +0100 Message-ID: <7c73aa954dc114f107c1159659c847d9c61d4788.1735205925.git.wz@freeshell.de> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=116.202.128.144; envelope-from=wz@freeshell.de; helo=freeshell.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/wireservice.scm (csvkit): Fix tests [source]: Apply patch. [native-inputs]: Add (libc-utf8-locales-for-target). * gnu/packages/patches/csvkit-set-locale-for-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. Change-Id: I787c0da270fa4062491efcfa0c55a1b8bbac7b59 --- gnu/local.mk | 1 + .../patches/csvkit-set-locale-for-tests.patch | 13 +++++++++++++ gnu/packages/wireservice.scm | 7 +++++-- 3 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/csvkit-set-locale-for-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index 84160f407a..838c2a06b3 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1131,6 +1131,7 @@ dist_patch_DATA = \ %D%/packages/patches/crc32c-unbundle-googletest.patch \ %D%/packages/patches/crda-optional-gcrypt.patch \ %D%/packages/patches/clucene-contribs-lib.patch \ + %D%/packages/patches/csvkit-set-locale-for-tests.patch \ %D%/packages/patches/cube-nocheck.patch \ %D%/packages/patches/cups-minimal-Address-PPD-injection-issues.patch \ %D%/packages/patches/curl-CVE-2024-8096.patch \ diff --git a/gnu/packages/patches/csvkit-set-locale-for-tests.patch b/gnu/packages/patches/csvkit-set-locale-for-tests.patch new file mode 100644 index 0000000000..52f6a5d517 --- /dev/null +++ b/gnu/packages/patches/csvkit-set-locale-for-tests.patch @@ -0,0 +1,13 @@ +Contents copied from python-agate. See +https://github.com/wireservice/agate/issues/712 for the source and the +rationale. + +diff --git a/tests/__init__.py b/tests/__init__.py +index e69de29..ee8beb5 100644 +--- a/tests/__init__.py ++++ b/tests/__init__.py +@@ -0,0 +1,4 @@ ++import locale ++ ++# The test fixtures can break if the locale is non-US. ++locale.setlocale(locale.LC_ALL, 'en_US.UTF-8') diff --git a/gnu/packages/wireservice.scm b/gnu/packages/wireservice.scm index df630023cf..914945cf54 100644 --- a/gnu/packages/wireservice.scm +++ b/gnu/packages/wireservice.scm @@ -217,10 +217,13 @@ (define-public csvkit (uri (pypi-uri "csvkit" version)) (sha256 (base32 - "08wj0hlmbdmklar12cjzqp91vcxzwifsvmgasszas8kbiyvvgpdy")))) + "08wj0hlmbdmklar12cjzqp91vcxzwifsvmgasszas8kbiyvvgpdy")) + (patches (search-patches + "csvkit-set-locale-for-tests.patch")))) (build-system python-build-system) (native-inputs - (list python-psycopg2 ; to test PostgreSQL support + (list (libc-utf8-locales-for-target) + python-psycopg2 ; to test PostgreSQL support python-sphinx python-sphinx-rtd-theme)) (inputs (list python-agate-dbf python-agate-excel python-agate-sql base-commit: e16cdcf37d8223b3634ec5e658356c3b7f154859 -- 2.46.0 ------------=_1735469463-2594-1--