From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 18:23:08 2024 Received: (at submit) by debbugs.gnu.org; 25 Dec 2024 23:23:08 +0000 Received: from localhost ([127.0.0.1]:39343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQaiZ-0007Kb-Ru for submit@debbugs.gnu.org; Wed, 25 Dec 2024 18:23:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:50450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQaiW-0007KC-5U for submit@debbugs.gnu.org; Wed, 25 Dec 2024 18:23:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQagP-0006Iw-Qt for guix-patches@gnu.org; Wed, 25 Dec 2024 18:20:53 -0500 Received: from qs51p00im-qukt01071901.me.com ([17.57.155.8]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQagN-0000Pa-Uz for guix-patches@gnu.org; Wed, 25 Dec 2024 18:20:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1735168850; bh=3AgL5spnVjr7WQc2BEL61h/P5GIgw6lV1AESDgptmlg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type: x-icloud-hme; b=dBS75ab/PdvsUipcEygfy2jgatf5J3N4kQBiHHe4A9CXxs66TcCkNAZJhnMzg89Se FUcXcMd1ng3B0sdiVhR6+9VvBED+LkEg63w/udRalS0SYyl901+h/E0REuuBwjChYm 3J9hzb8Z5DYsjjtTKhsCfrCJcecjFP2s5l2it0H0s3XS/Fvk1GYZS/ZwVnoBg55TFJ BXNSkQ0069Xz0ZR2IcG36jDSwuo0pfpDSV983Wck1JdmnHixVVuE5HFgz4FjYoSDGj GrfFF0K/W1akgvQnikFkaPiV3kaBUcL8yJMlHqwlWq3kFqVbu16GGv95337vYzfzN1 kxkpq9ip7AGOQ== Received: from wongworks.lan (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01071901.me.com (Postfix) with ESMTPSA id 50763628024E; Wed, 25 Dec 2024 23:20:50 +0000 (UTC) From: Andrew Wong To: guix-patches@gnu.org Subject: [PATCH] gnu: gzdoom: Update to 4.13.2 Date: Wed, 25 Dec 2024 18:17:22 -0500 Message-ID: <20241225232043.28431-1-wongandj@icloud.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: EuBW8L6LWkt_Xji4vmAHXCSPJOiK7abU X-Proofpoint-GUID: EuBW8L6LWkt_Xji4vmAHXCSPJOiK7abU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-25_07,2024-12-24_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 mlxscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2412250211 X-Apple-Remote-Links: v=1;h=KCk=;charset=UTF-8 Received-SPF: pass client-ip=17.57.155.8; envelope-from=wongandj@icloud.com; helo=qs51p00im-qukt01071901.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Andrew Wong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Change-Id: I73e6a86944ab3433d4425f3b3c345b509210a16d --- GZDoom has changed a lot since its last update here, and it (and it's new dependency, zmusic) have a lot of new bundled libraries. I'm not sure how to un-bundle most of them, so help on that front would be appreciated. The patches no longer work correctly either, so I've removed them; they seem unnecessary now, anyways. gnu/packages/games.scm | 132 ++++++++---------- .../patches/gzdoom-find-system-libgme.patch | 21 --- .../gzdoom-search-in-installed-share.patch | 23 --- 3 files changed, 56 insertions(+), 120 deletions(-) delete mode 100644 gnu/packages/patches/gzdoom-find-system-libgme.patch delete mode 100644 gnu/packages/patches/gzdoom-search-in-installed-share.patch diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index c2bb9aa1c4..d966f742ef 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -8403,67 +8403,44 @@ (define-public colobot (home-page "https://colobot.info") (license license:gpl3+))) +(define-public zmusic + (package + (name "zmusic") + (version "1.1.14") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ZDoom/ZMusic") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "19arzkbwdj84vw1cfawc6930dfxdhhq4k6yawkkppaphj8qkfhdc")))) + (arguments (list #:tests? #f)) + (build-system cmake-build-system) + (native-inputs (list pkg-config glib)) + (home-page "https://github.com/ZDoom/ZMusic") + (synopsis "GZDoom's music system as a standalone library") + (description "GZDoom's music system as a standalone library, for use with +GZDoom, Raze, and PrBoom+.") + (license license:gpl3))) + (define-public gzdoom (package (name "gzdoom") - (version "4.3.2") + (version "4.13.2") (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/coelckers/gzdoom") + (url "https://github.com/ZDoom/gzdoom") (commit (string-append "g" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0i4hyg72z84fc6ca2ic9q82q5cbgrbd7bynl3kpkypxvyasq08wz")) - (patches (search-patches "gzdoom-search-in-installed-share.patch" - "gzdoom-find-system-libgme.patch")) - (modules '((guix build utils) - (ice-9 regex))) - (snippet - '(begin - ;; Remove files which mustn't be commercially redistributed. See - ;; , the ‘Contribution - ;; Guidelines’ at , and Guix issue #73435. - (for-each - (lambda (directory) - (delete-file-recursively directory) - (substitute* "CMakeLists.txt" - (((string-append "add_subdirectory\\([[:blank:]]*" - directory - "[[:blank:]]*\\)")) - ""))) - '( ;; "wadsrc_extra" ;game_support.pk3 - "wadsrc_bm")) ;brightmaps.pk3 - - ;; Removing game_support.pk3 entirely would break Freedoom & remove - ;; users' ability to play commercial games, despite owning (only) the - ;; non-functional data. That can't be right. Out of an abundance of - ;; caution, remove anything from the PK3 that could conceivably be - ;; derived from copyrightable data that's not freely redistributable. - (display "Keeping only the following game_support.pk3 files:\n") - (let* ((regexps (list "/font\\.inf$" - "/harmony/.*\\.(txt|zs)$" - "/(iwadinfo|mapinfo|sprofs)\\.txt$" - "\\.z$")) - (regexp* (format #f "(~{~a~^|~})" regexps)) - (regexp (make-regexp regexp* regexp/icase))) - (define (keep-file? file stat) - (let ((keep? (regexp-exec regexp file))) - (when keep? - (format #t " ~a~%" file)) - keep?)) - - (for-each delete-file (find-files "wadsrc_extra/static" - (negate keep-file?)))) - - ;; Remove some bundled libraries. XXX There are more, but removing - ;; them would require, at least, patching the build system. - (with-directory-excursion "libraries" - (delete-file-recursively "bzip2") - (delete-file-recursively "game-music-emu") - (delete-file-recursively "jpeg") - (delete-file-recursively "zlib")))))) + (base32 "0zlvrdayrj1rk5x2hwnc57l8pl29bl64zmfq3qc9yfypknj1syfy")) + ;; (patches (search-patches "gzdoom-search-in-installed-share.patch" + ;; "gzdoom-find-system-libgme.patch")) + )) (arguments (list #:tests? #f @@ -8484,30 +8461,33 @@ (define (keep-file? file stat) "-DDYN_GTK=OFF" "-DDYN_MPG123=OFF" "-DDYN_SNDFILE=OFF") - #:phases - #~(modify-phases %standard-phases - (add-before 'configure 'fix-file-names - (lambda* (#:key inputs #:allow-other-keys) - (substitute* "src/CMakeLists.txt" - (("COMMAND /bin/sh") - (string-append "COMMAND " (which "sh")))) - (substitute* - "libraries/zmusic/mididevices/music_fluidsynth_mididevice.cpp" - (("/usr/share/sounds/sf2/FluidR3_GM.sf2") - (search-input-file inputs - "share/soundfonts/FluidR3Mono_GM.sf3"))) - (substitute* - "libraries/zmusic/mididevices/music_timiditypp_mididevice.cpp" - (("(exename = \")(timidity)(\".*)" _ prefix exe suffix) - (string-append prefix - (search-input-file inputs - (string-append "bin/" exe)) - suffix)))))))) + ;; #:phases + ;; #~(modify-phases %standard-phases + ;; (add-before 'configure 'fix-file-names + ;; (lambda* (#:key inputs #:allow-other-keys) + ;; ;; (substitute* "src/CMakeLists.txt" + ;; ;; (("COMMAND /bin/sh") + ;; ;; (string-append "COMMAND " (which "sh")))) + ;; (substitute* + ;; "libraries/zmusic/mididevices/music_fluidsynth_mididevice.cpp" + ;; (("/usr/share/sounds/sf2/FluidR3_GM.sf2") + ;; (search-input-file inputs + ;; "share/soundfonts/FluidR3Mono_GM.sf3"))) + ;; (substitute* + ;; "libraries/zmusic/mididevices/music_timiditypp_mididevice.cpp" + ;; (("(exename = \")(timidity)(\".*)" dum prefix exe suffix) + ;; (string-append prefix + ;; (search-input-file inputs + ;; (string-append "bin/" exe)) + ;; suffix)))))) + )) (build-system cmake-build-system) - (inputs (list bzip2 + (inputs (list zmusic + libvpx + bzip2 fluid-3 fluidsynth - gtk+ + gtk+ libgme libjpeg-turbo libsndfile @@ -8517,7 +8497,7 @@ (define (keep-file? file stat) sdl2 timidity++ zlib)) - (native-inputs (list pkg-config unzip)) + (native-inputs (list pkg-config unzip python)) (synopsis "Modern Doom 2 source port") (description "GZdoom is a port of the Doom 2 game engine, with a modern renderer. It improves modding support with ZDoom's advanced mapping features @@ -8526,9 +8506,9 @@ (define (keep-file? file stat) (home-page "https://zdoom.org/index") ;; The source uses x86 assembly (supported-systems '("x86_64-linux" "i686-linux")) - (license (list license:gpl3+ ; gzdoom game - license:lgpl3+ ; gzdoom renderer - license:expat ; gdtoa + (license (list license:gpl3+ ; gzdoom game + license:lgpl3+ ; gzdoom renderer + license:expat ; gdtoa (license:non-copyleft ; modified dumb "file://dumb/licence.txt" "Dumb license, explicitly GPL compatible."))))) diff --git a/gnu/packages/patches/gzdoom-find-system-libgme.patch b/gnu/packages/patches/gzdoom-find-system-libgme.patch deleted file mode 100644 index a7f277d614..0000000000 --- a/gnu/packages/patches/gzdoom-find-system-libgme.patch +++ /dev/null @@ -1,21 +0,0 @@ ---- /CMakeLists.txt 2020-01-20 21:47:35.460119141 +0100 -+++ /CMakeLists.txt 2020-01-20 21:47:47.690112400 +0100 -@@ -195,12 +195,12 @@ - #endif() - - # GME --#find_path( GME_INCLUDE_DIR gme/gme.h ) --#find_library( GME_LIBRARIES gme ) --#mark_as_advanced( GME_INCLUDE_DIR GME_LIBRARIES ) --#FIND_PACKAGE_HANDLE_STANDARD_ARGS( GME --# REQUIRED_VARS GME_LIBRARIES GME_INCLUDE_DIR --#) -+find_path( GME_INCLUDE_DIR gme/gme.h ) -+find_library( GME_LIBRARIES gme ) -+mark_as_advanced( GME_INCLUDE_DIR GME_LIBRARIES ) -+FIND_PACKAGE_HANDLE_STANDARD_ARGS( GME -+ REQUIRED_VARS GME_LIBRARIES GME_INCLUDE_DIR -+) - - if( MSVC ) - # Eliminate unreferenced functions and data diff --git a/gnu/packages/patches/gzdoom-search-in-installed-share.patch b/gnu/packages/patches/gzdoom-search-in-installed-share.patch deleted file mode 100644 index f312686566..0000000000 --- a/gnu/packages/patches/gzdoom-search-in-installed-share.patch +++ /dev/null @@ -1,23 +0,0 @@ -Lookup gzdoom pk3 files in the installed directory in -addition to the path that is stored in ~/.config/gzdoom/. - -Simply replacing the hardcoded /usr/share would leave the -configfile pointing to outdated guix builds, which could get -garbage collected and break the gzdoom installation. -This ensures that the files installed with the corresponding -build will be used. - ---- /src/d_main.cpp 2018-01-16 22:13:09.700602781 +0200 -+++ /src/d_main.cpp 2018-01-16 22:22:36.560617961 +0200 -@@ -1716,6 +1716,11 @@ - return wad; - } - -+ mysnprintf (wad, countof(wad), "%s/%s", GUIX_OUT_PK3, file); -+ if (DirEntryExists (wad)) { -+ return wad; -+ } -+ - if (GameConfig != NULL && GameConfig->SetSection ("FileSearch.Directories")) - { - const char *key; -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 26 07:25:01 2025 Received: (at control) by debbugs.gnu.org; 26 Jan 2025 12:25:01 +0000 Received: from localhost ([127.0.0.1]:55055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tc1hE-0004ke-Pi for submit@debbugs.gnu.org; Sun, 26 Jan 2025 07:25:01 -0500 Received: from qs51p00im-qukt01080501.me.com ([17.57.155.22]:36249) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tc1hC-0004kN-QH for control@debbugs.gnu.org; Sun, 26 Jan 2025 07:24:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=YMb4Jt0l7hYOoRzMlyPiSdob8P7FVkEkdjvwPYSLRzk=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type:x-icloud-hme; b=QdrzcjGHUGW4Fp5bjWAkXlBPyKUa7XMmyJrk5LsIEGl3XyoGJ/4aeEQ13cXCm+r/J g2dYHpYA0mcKiwe0m3yIn4vqDRlp8IBrsk1xhf7vQMEezqfutpawXvY9NOwEpDVVCd VclGLvRmsVhEfcTL3Keww4HOea2tKIczjA3J5kSqfXS+7MT6hLsyCA3GuGvFStRt1R UI1tzAYeO9ERX4/sfrO437xZUD5BKwwTnhXMmC6222/pOlmkiuw1IZd8F+NwvlkDdC K17lqbjEDEuF6TsruyrSitaFPV1q+b57anL68hjhTqY60IWULRk6/IyeGWIOG+IyMi UwkMvd2P033ag== Received: from [192.168.86.109] (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01080501.me.com (Postfix) with ESMTPSA id 0D799198025E for ; Sun, 26 Jan 2025 12:24:51 +0000 (UTC) Message-ID: <31441eba-316e-4bea-bc5b-72d877a650d1@icloud.com> Date: Sun, 26 Jan 2025 07:24:50 -0500 MIME-Version: 1.0 User-Agent: Icedove Daily Content-Language: en-US To: control@debbugs.gnu.org From: Andrew Wong Subject: close bad patch Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9wVepKV_NZdYbLKKCJEabw5oBSeWL9me X-Proofpoint-GUID: 9wVepKV_NZdYbLKKCJEabw5oBSeWL9me X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-26_04,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=242 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2501260099 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 75104 From unknown Tue Jun 17 22:11:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Feb 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator