Subject: bug#75091: closed (Re: [bug#75091] [PATCH] services: syslog: fix configuration file argument)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 25 Dec 2024 21:50:02 +0000

Your bug report

#75091: [PATCH] services: syslog: fix configuration file argument

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
75091: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75091
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#75091] [PATCH] services: syslog: fix configuration file argument
From: Ludovic Courtès <[email-masked]>
To: 45mg <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Wed, 25 Dec 2024 22:49:23 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

45mg <[email-masked]> skribis:

> * gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
> combined arguments which resulted in an argument like "-f
> /etc/syslog.conf" being passed to syslogd, leading it to ignore the
> argument and execute without a configuration file. Effects of this
> included no log files being written, though the Shepherd service ran
> successfully.
>
> Ref: https://issues.guix.gnu.org/70677#4-lineno7
> Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7

Oops, my bad, I overlooked that.

Applied, thanks!

Ludo’.

Subject: [PATCH] services: syslog: fix configuration file argument
From: 45mg <[email-masked]>
To: [email-masked]
Cc: [email-masked], 45mg <[email-masked]>, [email-masked]
Date: Wed, 25 Dec 2024 12:14:23 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/services/base.scm (syslog-shepherd-service): Separate incorrectly
combined arguments which resulted in an argument like "-f
/etc/syslog.conf" being passed to syslogd, leading it to ignore the
argument and execute without a configuration file. Effects of this
included no log files being written, though the Shepherd service ran
successfully.

Ref: https://issues.guix.gnu.org/70677#4-lineno7
Change-Id: I3dbe00eabd4a10804e554c12e1466483c0b185b7
---
 gnu/services/base.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index fc604f029a..75ce4e8fe5 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1679,7 +1679,7 @@ (define (syslog-shepherd-service config)
    (start #~(make-forkexec-constructor
              (list #$(syslog-configuration-syslogd config)
                    ;; the -f option here is compatible with rsyslog
-                   #$(string-append "-f " syslog.conf)
+                   "-f" #$syslog.conf
                    #$@(syslog-configuration-extra-options config))
              #:file-creation-mask #o137
              #:pid-file "/var/run/syslog.pid"))

base-commit: 3ada4796e9adcea6fce621e639ddbfb181ab6689
-- 
2.47.1