From unknown Sun Jun 22 04:23:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75084: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch Resent-From: Hannes =?UTF-8?Q?M=C3=BCller?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 25 Dec 2024 12:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75084 X-GNU-PR-Package: guile X-GNU-PR-Keywords: To: 75084@debbugs.gnu.org X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173513102310051 (code B ref -1); Wed, 25 Dec 2024 12:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Dec 2024 12:50:23 +0000 Received: from localhost ([127.0.0.1]:36479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQqF-0002c3-29 for submit@debbugs.gnu.org; Wed, 25 Dec 2024 07:50:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:51948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQqC-0002bv-I4 for submit@debbugs.gnu.org; Wed, 25 Dec 2024 07:50:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQQqA-0006kt-U2 for bug-guile@gnu.org; Wed, 25 Dec 2024 07:50:18 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQQq8-0004eo-Mt for bug-guile@gnu.org; Wed, 25 Dec 2024 07:50:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1735131013; x=1735735813; i=h.c.f.mueller@gmx.de; bh=Drf/iPxc8tdGG3N5FHIGc+FxoHkQrpOXsqrcZEk/9D0=; h=X-UI-Sender-Class:MIME-Version:Message-ID:From:To:Subject: Content-Type:Date:cc:content-transfer-encoding:content-type:date: from:message-id:mime-version:reply-to:subject:to; b=njJ5/sgv58GdG9CgAyoOp1ndGcSoIEu5DrMMc55pG5KQiqYoX77Y15dAzLZetE8U +615XWBNA0F2sEh3mXD9psItHA8HKyuj9YDsdZ1XS7O4AKB6BcjMZwD/Vjhnh1hNm OX0lF0YOxGSexJCD+jUzKjjvQ7C83utU+hVeAcSTh3jM9bn0/zUuGn14L8bA3jTOB WLpK6pgAO11VISypz/k3PT72xRdmknCHJytPaZqTsiLjKaW86AUFfOC1AMzggA+hW efpKiEoedTcL6iqrmrmAJFuxj2OAJIXODoONizREMQf9T+135GLUy9KZFMf6TJUMj NAy3Eff+rkWKoyws+A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.194.58.247] ([79.194.58.247]) by trinity-msg-rest-gmx-gmx-live-bbc95d94c-jjgc7 (via HTTP); Wed, 25 Dec 2024 12:50:13 +0000 MIME-Version: 1.0 Message-ID: From: Hannes =?UTF-8?Q?M=C3=BCller?= Content-Type: multipart/mixed; boundary=trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Date: Wed, 25 Dec 2024 12:50:13 +0000 X-UI-CLIENT-META-MAIL-DROP: W10= X-Provags-ID: V03:K1:iF4yDcubdk6LGSJ9fAcB1cxV0fMr/JXUkLLapD28ryS7ByqdJmOi7j+ST8yxUug5K33Lp CSuNOQZ31x32Yu+mNu2iXxpfTsyAG1Cfej2nk6rrS16TJ1pQXBuGHCBKVO6mRkUiqUCZS2H52mkE iWgpP3Y5wto+bQlP0qpDd2I9uciBcxYW1wvAICv2uukCpx2sBggYeILq6lrVtuSYRA/E1iH0R6lQ dkX83DZC0eU7yYSgRysKNm6wGhkIu9iUU4my7F0YIHXzldrWAwC55hT/mAqWSC3+Vvc1aNr/4scy Q/nTF0EcRyy2gdgR1htIQ2KXxMePHGFT5jZcWcdihntRUY8+oCHc5p931i1CiHB8Yo= X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vvxcPwt2QVU=;yziM7XjOOgWlYnmnEOmtqLB0E3D c4J3lNYqRXRxkiXGRNuhRMmyRg7pBBkp56VqHI59BNQWKrwd9+z+dosu4ITiYWHe2TE9tQGDk JhxfrPOjqE8zlJV1y+Jib2OTZRzJQlUar0V5gbDesVkpIC+s09Psha6jGfLHhvGPgSFcSAwca ZCmmeHaYulWXo7yEPpCVA2/tTM/IKZfrbGd4AcUuZPaBaeY3QrW8ri3ZPDuxGYUwx9AuDjPXs FRhvXZvFJyDi3B45xw5apUTsrUtOp7U6kO+EIuU5mtggbHOjgh87cszL3whTqMSXcHQ8ON5TO Jij/r7nH0Iy2lV9zAojuh0S7Rq4K64P6g5lblJndEv4jvYKTNAcq3bf5CWbMz9ECZmTFkcCOo vBv1YjCyNg9KdxGXkrOY4gTTyei6xT1IYWiB8vkVg64xaTesBVi1Gr/Jv2V7g/sR7RTcw9FzT KBnCjf2VI91Nh9fItUYs0GwGJpLoJwMJ1WOtNS0N/J7vLELrz+CayrYvVa+BSDFMQJFRytx0b WtfhhzyWyy3+b7wZlXYr2+S6Zm4b/2Z74GlnA7GZla3KaxgIh5FU3X2nS7HX98tJ63LTmJLRy fQQH70zuJX2UXRO6hYYI3/mekSnbP29fENggPp7XiN73DdPXEn7jfE8xhlScQWW69V1dUgflz nlEvDj7b4zszGsiJmlUB2/FKLeIwzLEZaSetAKC3Qgdjc6pQ/3IUYGj6t3bntjWTo32IML+nE SBou68u5j2Pn1y/ztksfHBXYYe0M9OU4jheYvCnVD1ZOm/iXjv8vjxH14LJp0sEdOSgsOnhF5 GzuC20V65WvXTEMqZIjVvtCdBEWRpFiQDECtX9caxV8R/Slq4hwIreGqTpZtgTZSLDOEJyEGT Nbb5ofDZ9d0nR7zqyZoFYrnwSiXL4TDEmsiI= Received-SPF: pass client-ip=212.227.15.18; envelope-from=h.c.f.mueller@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/html; charset=UTF-8
Dear All,
Please review the attached patch.
 
Thanks,
Hannes
--trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Fix-make-custom-port-in-case-encoding-is-f.patch X-UI-Content-Hash: 2034d527f647b7128267714c095ac0b38613b1b367e9959f5c6e8ff323a8a925 Content-Transfer-Encoding: quoted-printable =46rom 72b85f8e6a369e6aef4c6bd6bb233c0cacb80b03 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Hannes=3D20M=3DC3=3DBCller?=3D <> Date: Sat, 21 Dec 2024 16:55:13 +0100 Subject: [PATCH] Fix make-custom-port in case encoding is #f * module/ice-9/custom-ports.scm (make-custom-port): Code fails if (fluid-ref %default-port-encoding) returns #f. In fact this was the case why readline support on MSYS2 failed for guile 3.0.10, ref. https://github.com/msys2/MSYS2-packages/issues/5079 But later used canonicalize-encoding is prepared to handle #f for encoding. So allow encoding to also handle this case. =2D-- module/ice-9/custom-ports.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/module/ice-9/custom-ports.scm b/module/ice-9/custom-ports.scm index 6010fd94f..bc9de8f64 100644 =2D-- a/module/ice-9/custom-ports.scm +++ b/module/ice-9/custom-ports.scm @@ -127,7 +127,9 @@ (id "custom-port") (print (make-default-print #:id id)) (truncate default-truncate) - (encoding (string->symbol (fluid-ref %default-port-encoding))) + (encoding (if (string? (fluid-ref %default-port-encoding)) + (string->symbol (fluid-ref %default-port-encoding= )) + (fluid-ref %default-port-encoding))) (conversion-strategy (fluid-ref %default-port-conversion-strate= gy)) (close-on-gc? #f)) "Create a custom port whose behavior is determined by the methods passe= d =2D- 2.45.2 --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0-- From unknown Sun Jun 22 04:23:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Hannes =?UTF-8?Q?M=C3=BCller?= Subject: bug#75084: closed (Re: bug#75084: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch) Message-ID: References: <87o6ylq0eg.fsf@gnu.org> X-Gnu-PR-Message: they-closed 75084 X-Gnu-PR-Package: guile Reply-To: 75084@debbugs.gnu.org Date: Fri, 28 Feb 2025 20:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1740774542-29192-1" This is a multi-part message in MIME format... ------------=_1740774542-29192-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75084: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is= -f.patch which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75084@debbugs.gnu.org. --=20 75084: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75084 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1740774542-29192-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75084-done) by debbugs.gnu.org; 28 Feb 2025 20:28:58 +0000 Received: from localhost ([127.0.0.1]:53490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1to6yf-0007aO-Mi for submit@debbugs.gnu.org; Fri, 28 Feb 2025 15:28:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46348) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1to6yb-0007ZT-86 for 75084-done@debbugs.gnu.org; Fri, 28 Feb 2025 15:28:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1to6yV-0003R6-Ff; Fri, 28 Feb 2025 15:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mpM/5TVXADC+pidrctkRccGK4vbU/RNw77FY45MU8FE=; b=oaGX4WKp1zRFrCK8sonD mnthvVijCK6T9kPJLg72/S/MKzzn8aJMjyLOJtAXplb3NlwuBDQOG4kIRhEoniRGFvke4PU+JGetU 5zAVEup6cbcN/7IAhxff+RGhOlDs65KoDsGDA/dnmgjy57C52cIVpsRC+k3bT7zXei6vDp067mj09 ILvsNasWtWVh5vDdw9eFxI3gWMi/Ps6iTH/LHdzxPEEpG22F03GOsIuebrO0h8gRy+RCrXCY6tFmf /mQ2bX8No/1ytfHRrRvkmfUYqd8z7/KraFgq0W72eDml/dqBXDWPGyKLIMjHwo8qkkhVFBWrpe3wt qzrRJ3/Tahowqg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hannes =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#75084: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch In-Reply-To: ("Hannes =?utf-8?Q?M=C3=BCller=22's?= message of "Wed, 25 Dec 2024 12:50:13 +0000") References: Date: Fri, 28 Feb 2025 21:28:39 +0100 Message-ID: <87o6ylq0eg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75084-done Cc: 75084-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Hannes M=C3=BCller skribis: > From 72b85f8e6a369e6aef4c6bd6bb233c0cacb80b03 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Hannes=3D20M=3DC3=3DBCller?=3D <> > Date: Sat, 21 Dec 2024 16:55:13 +0100 > Subject: [PATCH] Fix make-custom-port in case encoding is #f > > * module/ice-9/custom-ports.scm (make-custom-port): Code fails if > (fluid-ref %default-port-encoding) returns #f. In fact this was the > case why readline support on MSYS2 failed for guile 3.0.10, ref. > https://github.com/msys2/MSYS2-packages/issues/5079 > But later used canonicalize-encoding is prepared to handle #f for > encoding. So allow encoding to also handle this case. Applied with the simplification below. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/module/ice-9/custom-ports.scm b/module/ice-9/custom-ports.scm index bc9de8f64..c4376db7b 100644 --- a/module/ice-9/custom-ports.scm +++ b/module/ice-9/custom-ports.scm @@ -127,9 +127,7 @@ (id "custom-port") (print (make-default-print #:id id)) (truncate default-truncate) - (encoding (if (string? (fluid-ref %default-port-encoding)) - (string->symbol (fluid-ref %default-port-encoding)) - (fluid-ref %default-port-encoding))) + (encoding (and=> (fluid-ref %default-port-encoding) string->symbol)) (conversion-strategy (fluid-ref %default-port-conversion-strategy)) (close-on-gc? #f)) "Create a custom port whose behavior is determined by the methods passed --=-=-=-- ------------=_1740774542-29192-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Dec 2024 12:50:23 +0000 Received: from localhost ([127.0.0.1]:36479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQqF-0002c3-29 for submit@debbugs.gnu.org; Wed, 25 Dec 2024 07:50:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:51948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQqC-0002bv-I4 for submit@debbugs.gnu.org; Wed, 25 Dec 2024 07:50:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQQqA-0006kt-U2 for bug-guile@gnu.org; Wed, 25 Dec 2024 07:50:18 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQQq8-0004eo-Mt for bug-guile@gnu.org; Wed, 25 Dec 2024 07:50:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1735131013; x=1735735813; i=h.c.f.mueller@gmx.de; bh=Drf/iPxc8tdGG3N5FHIGc+FxoHkQrpOXsqrcZEk/9D0=; h=X-UI-Sender-Class:MIME-Version:Message-ID:From:To:Subject: Content-Type:Date:cc:content-transfer-encoding:content-type:date: from:message-id:mime-version:reply-to:subject:to; b=njJ5/sgv58GdG9CgAyoOp1ndGcSoIEu5DrMMc55pG5KQiqYoX77Y15dAzLZetE8U +615XWBNA0F2sEh3mXD9psItHA8HKyuj9YDsdZ1XS7O4AKB6BcjMZwD/Vjhnh1hNm OX0lF0YOxGSexJCD+jUzKjjvQ7C83utU+hVeAcSTh3jM9bn0/zUuGn14L8bA3jTOB WLpK6pgAO11VISypz/k3PT72xRdmknCHJytPaZqTsiLjKaW86AUFfOC1AMzggA+hW efpKiEoedTcL6iqrmrmAJFuxj2OAJIXODoONizREMQf9T+135GLUy9KZFMf6TJUMj NAy3Eff+rkWKoyws+A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.194.58.247] ([79.194.58.247]) by trinity-msg-rest-gmx-gmx-live-bbc95d94c-jjgc7 (via HTTP); Wed, 25 Dec 2024 12:50:13 +0000 MIME-Version: 1.0 Message-ID: From: =?UTF-8?Q?Hannes_M=C3=BCller?= To: bug-guile@gnu.org Subject: bug report with patch 0003-Fix-make-custom-port-in-case-encoding-is-f.patch Content-Type: multipart/mixed; boundary=trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Date: Wed, 25 Dec 2024 12:50:13 +0000 X-UI-CLIENT-META-MAIL-DROP: W10= X-Provags-ID: V03:K1:iF4yDcubdk6LGSJ9fAcB1cxV0fMr/JXUkLLapD28ryS7ByqdJmOi7j+ST8yxUug5K33Lp CSuNOQZ31x32Yu+mNu2iXxpfTsyAG1Cfej2nk6rrS16TJ1pQXBuGHCBKVO6mRkUiqUCZS2H52mkE iWgpP3Y5wto+bQlP0qpDd2I9uciBcxYW1wvAICv2uukCpx2sBggYeILq6lrVtuSYRA/E1iH0R6lQ dkX83DZC0eU7yYSgRysKNm6wGhkIu9iUU4my7F0YIHXzldrWAwC55hT/mAqWSC3+Vvc1aNr/4scy Q/nTF0EcRyy2gdgR1htIQ2KXxMePHGFT5jZcWcdihntRUY8+oCHc5p931i1CiHB8Yo= X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vvxcPwt2QVU=;yziM7XjOOgWlYnmnEOmtqLB0E3D c4J3lNYqRXRxkiXGRNuhRMmyRg7pBBkp56VqHI59BNQWKrwd9+z+dosu4ITiYWHe2TE9tQGDk JhxfrPOjqE8zlJV1y+Jib2OTZRzJQlUar0V5gbDesVkpIC+s09Psha6jGfLHhvGPgSFcSAwca ZCmmeHaYulWXo7yEPpCVA2/tTM/IKZfrbGd4AcUuZPaBaeY3QrW8ri3ZPDuxGYUwx9AuDjPXs FRhvXZvFJyDi3B45xw5apUTsrUtOp7U6kO+EIuU5mtggbHOjgh87cszL3whTqMSXcHQ8ON5TO Jij/r7nH0Iy2lV9zAojuh0S7Rq4K64P6g5lblJndEv4jvYKTNAcq3bf5CWbMz9ECZmTFkcCOo vBv1YjCyNg9KdxGXkrOY4gTTyei6xT1IYWiB8vkVg64xaTesBVi1Gr/Jv2V7g/sR7RTcw9FzT KBnCjf2VI91Nh9fItUYs0GwGJpLoJwMJ1WOtNS0N/J7vLELrz+CayrYvVa+BSDFMQJFRytx0b WtfhhzyWyy3+b7wZlXYr2+S6Zm4b/2Z74GlnA7GZla3KaxgIh5FU3X2nS7HX98tJ63LTmJLRy fQQH70zuJX2UXRO6hYYI3/mekSnbP29fENggPp7XiN73DdPXEn7jfE8xhlScQWW69V1dUgflz nlEvDj7b4zszGsiJmlUB2/FKLeIwzLEZaSetAKC3Qgdjc6pQ/3IUYGj6t3bntjWTo32IML+nE SBou68u5j2Pn1y/ztksfHBXYYe0M9OU4jheYvCnVD1ZOm/iXjv8vjxH14LJp0sEdOSgsOnhF5 GzuC20V65WvXTEMqZIjVvtCdBEWRpFiQDECtX9caxV8R/Slq4hwIreGqTpZtgTZSLDOEJyEGT Nbb5ofDZ9d0nR7zqyZoFYrnwSiXL4TDEmsiI= Received-SPF: pass client-ip=212.227.15.18; envelope-from=h.c.f.mueller@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/html; charset=UTF-8
Dear All,
Please review the attached patch.
 
Thanks,
Hannes
--trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0 Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Fix-make-custom-port-in-case-encoding-is-f.patch X-UI-Content-Hash: 2034d527f647b7128267714c095ac0b38613b1b367e9959f5c6e8ff323a8a925 Content-Transfer-Encoding: quoted-printable =46rom 72b85f8e6a369e6aef4c6bd6bb233c0cacb80b03 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Hannes=3D20M=3DC3=3DBCller?=3D <> Date: Sat, 21 Dec 2024 16:55:13 +0100 Subject: [PATCH] Fix make-custom-port in case encoding is #f * module/ice-9/custom-ports.scm (make-custom-port): Code fails if (fluid-ref %default-port-encoding) returns #f. In fact this was the case why readline support on MSYS2 failed for guile 3.0.10, ref. https://github.com/msys2/MSYS2-packages/issues/5079 But later used canonicalize-encoding is prepared to handle #f for encoding. So allow encoding to also handle this case. =2D-- module/ice-9/custom-ports.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/module/ice-9/custom-ports.scm b/module/ice-9/custom-ports.scm index 6010fd94f..bc9de8f64 100644 =2D-- a/module/ice-9/custom-ports.scm +++ b/module/ice-9/custom-ports.scm @@ -127,7 +127,9 @@ (id "custom-port") (print (make-default-print #:id id)) (truncate default-truncate) - (encoding (string->symbol (fluid-ref %default-port-encoding))) + (encoding (if (string? (fluid-ref %default-port-encoding)) + (string->symbol (fluid-ref %default-port-encoding= )) + (fluid-ref %default-port-encoding))) (conversion-strategy (fluid-ref %default-port-conversion-strate= gy)) (close-on-gc? #f)) "Create a custom port whose behavior is determined by the methods passe= d =2D- 2.45.2 --trekuen-7595b832-6b90-48d2-96cb-d16f6b92b5e0-- ------------=_1740774542-29192-1--