GNU bug report logs - #75065
Upon archive download failure print the original error

Previous Next

Full log

View this message in rfc822 format

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 75065-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#75065: Upon archive download failure print the original error
Date: Fri, 27 Dec 2024 21:34:30 +0300

On Fri, 2024-12-27 at 12:01 -0500, Stefan Monnier wrote:
> > `%s` to print `err` or `(cdr err)` would be wrong, since `%s` is
> > for use
> > with strings rather than lists.  IOW, IMO, it should be either
> > 
> >     ...%S" ... err)
> > 
> > or
> > 
> >     ...%s" ... (error-message-string err))
> > 
> > where the first is a bit more "debugging/developer" friendly and
> > the second
> > is a bit more "user" friendly.
> 
> Revising the code of `package.el` I see that those errors&messages
> are
> meant to be exposed to the user, so they should preferably use
> `error-message-string`.
> 
> So I installed the patch below into `master`.
> Thank you!

This is not fair: despite me actively answering on my patch, you took
my changes, just changed one function call to another, and rewritten
the author like if it were you who were writing and debugging the code
and the issue rather than me.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.