GNU bug report logs - #75044
[PATCH] gnu: Add lightdm-mini-greeter.

Previous Next

Package: guix-patches;

Reported by: Feng Shu <tumashu <at> 163.com>

Date: Mon, 23 Dec 2024 09:36:02 UTC

Severity: normal

Tags: patch

Done: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75044 in the body.
You can then email your comments to 75044 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Mon, 23 Dec 2024 09:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Feng Shu <tumashu <at> 163.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 23 Dec 2024 09:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: guix-patches <at> gnu.org 
Subject: [PATCH] gnu: Add lightdm-mini-greeter.
Date: Mon, 23 Dec 2024 17:35:07 +0800

From de4741a39927692bb6063978dfd49b9666727a29 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Mon, 23 Dec 2024 17:19:48 +0800
Subject: [PATCH] gnu: Add lightdm-mini-greeter.

* gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.

Change-Id: I83b9c62cba7228b5b73587f44ac6185340641e22
---
 gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index df5fc0a857..b70f8101e6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
 GTK+, lets you select a desktop session and log in to it.")
     (license license:gpl3+)))
 
+(define-public lightdm-mini-greeter
+  (package
+    (name "lightdm-mini-greeter")
+    (version "0.5.1-ead793")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/prikhi/lightdm-mini-greeter")
+                    (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'customize-default-config-path
+            (lambda _
+              (substitute* "Makefile.am"
+                ;; Have the default config directory sourced from
+                ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
+                ;; lightdm service writes it.
+                (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
+                 "/etc/lightdm/lightdm-mini-greeter.conf"))))
+          (add-after 'install 'fix-.desktop-file
+            (lambda* (#:key outputs #:allow-other-keys)
+              (substitute* (search-input-file
+                            outputs
+                            "share/xgreeters/lightdm-mini-greeter.desktop")
+                (("Exec=lightdm-mini-greeter")
+                 (string-append "Exec="
+                                (search-input-file
+                                 outputs "bin/lightdm-mini-greeter")))))))))
+    (native-inputs
+     (list autoconf automake pkg-config))
+    (inputs
+     (list gtk+ lightdm))
+    (synopsis "Mini Greeter for LightDM")
+    (home-page "https://github.com/prikhi/lightdm-mini-greeter")
+    (description "This package provide a minimal but highly configurable single-user GTK3
+greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
+LightDM GTK3 Greeter.")
+    (license license:gpl3)))
+
 (define-public slim
   (package
     (name "slim")
-- 
2.45.2



--
Information forwarded to tumashu <at> 163.com, guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Wed, 25 Dec 2024 03:05:02 GMT) Full text and rfc822 format available.

Message #8 received at 75044 <at> debbugs.gnu.org (full text, mbox):

From: tumashu <at> 163.com
To: 75044 <at> debbugs.gnu.org
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH v2] gnu: Add lightdm-mini-greeter.
Date: Wed, 25 Dec 2024 11:04:42 +0800

From: Feng Shu <tumashu <at> 163.com>

* gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.

Change-Id: I558add1665d79429e2562c2139777002b7a70466
---
 gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index df5fc0a857..b70f8101e6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
 GTK+, lets you select a desktop session and log in to it.")
     (license license:gpl3+)))
 
+(define-public lightdm-mini-greeter
+  (package
+    (name "lightdm-mini-greeter")
+    (version "0.5.1-ead793")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/prikhi/lightdm-mini-greeter")
+                    (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'customize-default-config-path
+            (lambda _
+              (substitute* "Makefile.am"
+                ;; Have the default config directory sourced from
+                ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
+                ;; lightdm service writes it.
+                (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
+                 "/etc/lightdm/lightdm-mini-greeter.conf"))))
+          (add-after 'install 'fix-.desktop-file
+            (lambda* (#:key outputs #:allow-other-keys)
+              (substitute* (search-input-file
+                            outputs
+                            "share/xgreeters/lightdm-mini-greeter.desktop")
+                (("Exec=lightdm-mini-greeter")
+                 (string-append "Exec="
+                                (search-input-file
+                                 outputs "bin/lightdm-mini-greeter")))))))))
+    (native-inputs
+     (list autoconf automake pkg-config))
+    (inputs
+     (list gtk+ lightdm))
+    (synopsis "Mini Greeter for LightDM")
+    (home-page "https://github.com/prikhi/lightdm-mini-greeter")
+    (description "This package provide a minimal but highly configurable single-user GTK3
+greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
+LightDM GTK3 Greeter.")
+    (license license:gpl3)))
+
 (define-public slim
   (package
     (name "slim")
-- 
2.45.2
Information forwarded to guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Mon, 30 Dec 2024 01:47:02 GMT) Full text and rfc822 format available.

Message #11 received at 75044 <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: 75043 <at> debbugs.gnu.org, 75044 <at> debbugs.gnu.org, 75048 <at> debbugs.gnu.org
Subject: Please review this patch.
Date: Mon, 30 Dec 2024 09:46:27 +0800

Please review this patch, thanks.

--
Information forwarded to guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Mon, 30 Dec 2024 08:58:01 GMT) Full text and rfc822 format available.

Message #14 received at 75044 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: tumashu <at> 163.com
Cc: 75044 <at> debbugs.gnu.org
Subject: Re: [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
Date: Mon, 30 Dec 2024 16:56:49 +0800

[Message part 1 (text/plain, inline)]
tumashu <at> 163.com writes:

> From: Feng Shu <tumashu <at> 163.com>
>
> * gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.
>
> Change-Id: I558add1665d79429e2562c2139777002b7a70466
> ---
>  gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>
> diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
> index df5fc0a857..b70f8101e6 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
>  GTK+, lets you select a desktop session and log in to it.")
>      (license license:gpl3+)))
>  
> +(define-public lightdm-mini-greeter
> +  (package
> +    (name "lightdm-mini-greeter")
> +    (version "0.5.1-ead793")

please use git-version, likes: 

(define-public lightdm-mini-greeter
  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
        (revision "0"))
   (package
      ...
      (source
         (origin
           (method git-fetch)
           (uri (git-reference
                   (url "https://github.com/prikhi/lightdm-mini-greeter")
                   (commit commit)))
           (file-name (git-file-name name version))
           (sha256
            (base32
             "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
      ...)))
   
and add comment for why use commit, not git tag.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/prikhi/lightdm-mini-greeter")
> +                    (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
> +    (build-system glib-or-gtk-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'customize-default-config-path
> +            (lambda _
> +              (substitute* "Makefile.am"
> +                ;; Have the default config directory sourced from
> +                ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
> +                ;; lightdm service writes it.
> +                (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
> +                 "/etc/lightdm/lightdm-mini-greeter.conf"))))
> +          (add-after 'install 'fix-.desktop-file
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (substitute* (search-input-file
> +                            outputs
> +                            "share/xgreeters/lightdm-mini-greeter.desktop")
> +                (("Exec=lightdm-mini-greeter")
> +                 (string-append "Exec="
> +                                (search-input-file
> +                                 outputs "bin/lightdm-mini-greeter")))))))))
> +    (native-inputs
> +     (list autoconf automake pkg-config))
> +    (inputs
> +     (list gtk+ lightdm))
> +    (synopsis "Mini Greeter for LightDM")
> +    (home-page "https://github.com/prikhi/lightdm-mini-greeter")
> +    (description "This package provide a minimal but highly configurable single-user GTK3
> +greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
> +LightDM GTK3 Greeter.")
> +    (license license:gpl3)))
> +
>  (define-public slim
>    (package
>      (name "slim")

I didn't compile, test, everything else looks good.

[signature.asc (application/pgp-signature, inline)]
Information forwarded to tumashu <at> 163.com, tumashu <at> 163.com, zhengjunjie <at> iscas.ac.cn, guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Mon, 30 Dec 2024 13:47:01 GMT) Full text and rfc822 format available.

Message #17 received at 75044 <at> debbugs.gnu.org (full text, mbox):

From: tumashu <at> 163.com
To: 75044 <at> debbugs.gnu.org
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH v3] gnu: Add lightdm-mini-greeter.
Date: Mon, 30 Dec 2024 21:46:29 +0800

From: Feng Shu <tumashu <at> 163.com>

* gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.

Change-Id: I558add1665d79429e2562c2139777002b7a70466
---
 gnu/packages/display-managers.scm | 49 +++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index df5fc0a857..61be09adac 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -543,6 +543,55 @@ (define-public lightdm-gtk-greeter
 GTK+, lets you select a desktop session and log in to it.")
     (license license:gpl3+)))
 
+(define-public lightdm-mini-greeter
+  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
+        (revision "0"))
+    (package
+      (name "lightdm-mini-greeter")
+      ;; Version 0.5.1 release three years ago, so we use a recent commit.
+      (version (git-version "0.5.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/prikhi/lightdm-mini-greeter")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
+      (build-system glib-or-gtk-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'customize-default-config-path
+              (lambda _
+                (substitute* "Makefile.am"
+                  ;; Have the default config directory sourced from
+                  ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
+                  ;; lightdm service writes it.
+                  (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
+                   "/etc/lightdm/lightdm-mini-greeter.conf"))))
+            (add-after 'install 'fix-.desktop-file
+              (lambda* (#:key outputs #:allow-other-keys)
+                (substitute* (search-input-file
+                              outputs
+                              "share/xgreeters/lightdm-mini-greeter.desktop")
+                  (("Exec=lightdm-mini-greeter")
+                   (string-append "Exec="
+                                  (search-input-file
+                                   outputs "bin/lightdm-mini-greeter")))))))))
+      (native-inputs
+       (list autoconf automake pkg-config))
+      (inputs
+       (list gtk+ lightdm))
+      (synopsis "Mini Greeter for LightDM")
+      (home-page "https://github.com/prikhi/lightdm-mini-greeter")
+      (description "This package provide a minimal but highly configurable single-user GTK3
+greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
+LightDM GTK3 Greeter.")
+      (license license:gpl3))))
+
 (define-public slim
   (package
     (name "slim")
-- 
2.47.1
Information forwarded to guix-patches <at> gnu.org:
bug#75044; Package guix-patches. (Mon, 30 Dec 2024 13:49:01 GMT) Full text and rfc822 format available.

Message #20 received at 75044 <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 75044 <at> debbugs.gnu.org
Subject: Re: [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
Date: Mon, 30 Dec 2024 21:48:10 +0800

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:


> please use git-version, likes: 
> and add comment for why use commit, not git tag.

Updated.
Reply sent to Zheng Junjie <zhengjunjie <at> iscas.ac.cn>:
You have taken responsibility. (Thu, 02 Jan 2025 13:04:01 GMT) Full text and rfc822 format available.
Notification sent to Feng Shu <tumashu <at> 163.com>:
bug acknowledged by developer. (Thu, 02 Jan 2025 13:04:02 GMT) Full text and rfc822 format available.

Message #25 received at 75044-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: tumashu <at> 163.com
Cc: 75044-done <at> debbugs.gnu.org
Subject: Re: [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter.
Date: Thu, 02 Jan 2025 21:03:31 +0800

[Message part 1 (text/plain, inline)]
tumashu <at> 163.com writes:

> From: Feng Shu <tumashu <at> 163.com>
>
> * gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.
>
> Change-Id: I558add1665d79429e2562c2139777002b7a70466
> ---
>  gnu/packages/display-managers.scm | 49 +++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
> index df5fc0a857..61be09adac 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -543,6 +543,55 @@ (define-public lightdm-gtk-greeter
>  GTK+, lets you select a desktop session and log in to it.")
>      (license license:gpl3+)))
>  
> +(define-public lightdm-mini-greeter
> +  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
> +        (revision "0"))
> +    (package
> +      (name "lightdm-mini-greeter")
> +      ;; Version 0.5.1 release three years ago, so we use a recent commit.

Change to use an absolute date

> +      (version (git-version "0.5.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/prikhi/lightdm-mini-greeter")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
> +      (build-system glib-or-gtk-build-system)
> +      (arguments
> +       (list
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'customize-default-config-path
> +              (lambda _
> +                (substitute* "Makefile.am"
> +                  ;; Have the default config directory sourced from
> +                  ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
> +                  ;; lightdm service writes it.
> +                  (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
> +                   "/etc/lightdm/lightdm-mini-greeter.conf"))))
> +            (add-after 'install 'fix-.desktop-file
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (substitute* (search-input-file
> +                              outputs
> +                              "share/xgreeters/lightdm-mini-greeter.desktop")
> +                  (("Exec=lightdm-mini-greeter")
> +                   (string-append "Exec="
> +                                  (search-input-file
> +                                   outputs "bin/lightdm-mini-greeter")))))))))
> +      (native-inputs
> +       (list autoconf automake pkg-config))
> +      (inputs
> +       (list gtk+ lightdm))
> +      (synopsis "Mini Greeter for LightDM")
> +      (home-page "https://github.com/prikhi/lightdm-mini-greeter")
> +      (description "This package provide a minimal but highly configurable single-user GTK3
> +greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
> +LightDM GTK3 Greeter.")
> +      (license license:gpl3))))
> +
>  (define-public slim
>    (package
>      (name "slim")
pushed, closing.

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 31 Jan 2025 12:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 134 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.