GNU bug report logs - #75033
[PATCH] gnu: python-pypandoc: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75033 in the body.
You can then email your comments to 75033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: guix-patches <at> gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH] gnu: python-pypandoc: Fix build.
Date: Sun, 22 Dec 2024 14:16:27 -0500

* gnu/packages/python-xyz.scm (python-pypandoc): Fix build
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7cf44d6b6b..217cb93fe7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -33714,7 +33714,7 @@ (define-public python-pypandoc
        (uri (pypi-uri "pypandoc" version))
        (sha256
         (base32 "15x161bxr7hky7rvq0jlgf1kxg6vdf069487casmpyxry7slak3b"))))
-    (build-system pyproject-build-system)
+    (build-system python-build-system)
     (arguments
      `(#:phases (modify-phases %standard-phases
                   (add-before 'check 'disable-tests

base-commit: 1ca065fe68d68a2fa9c3d747f23fd11c8ecfd85b
-- 
2.46.0

Message #8 received at 75033 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Cc: tanguy <at> bioneland.org, me <at> bonfacemunyoki.com, lars <at> 6xq.net, jgart <at> dismail.de,
 marius <at> gnu.org, 75033 <at> debbugs.gnu.org
Subject: Re: [bug#75033] [PATCH] gnu: python-pypandoc: Fix build.
Date: Sun, 22 Dec 2024 19:21:42 +0000

[Message part 1 (text/plain, inline)]

Hi,

Please do not revert to the python build system, just add
missing inputs - python-setuptools and python-wheel.

Check similar cases on the master branch.

Thanks,
Oleg

On Sun, 22 Dec 2024, 19:18 Aaron Covrig, <aaron.covrig.us <at> ieee.org> wrote:

> * gnu/packages/python-xyz.scm (python-pypandoc): Fix build
> ---
>  gnu/packages/python-xyz.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7cf44d6b6b..217cb93fe7 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -33714,7 +33714,7 @@ (define-public python-pypandoc
>         (uri (pypi-uri "pypandoc" version))
>         (sha256
>          (base32 "15x161bxr7hky7rvq0jlgf1kxg6vdf069487casmpyxry7slak3b"))))
> -    (build-system pyproject-build-system)
> +    (build-system python-build-system)
>      (arguments
>       `(#:phases (modify-phases %standard-phases
>                    (add-before 'check 'disable-tests
>
> base-commit: 1ca065fe68d68a2fa9c3d747f23fd11c8ecfd85b
> --
> 2.46.0
>
>
>
>

[Message part 2 (text/html, inline)]

Message #11 received at 75033 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 75033 <at> debbugs.gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH v2] gnu: python-pypandoc: Fix build
Date: Mon, 23 Dec 2024 08:20:19 -0500

* gnu/packages/python-xyz.scm (python-pypandoc): Fix build
---
Added the required by the pyproject-build-system to enable building     
(adds 2 lint warnings regarding python-setuptools and python-pip) and   
addressed the permant redirect from https://github.com/bebraw/pandoc to
https://github.com/JessicaTegner/pypandoc

 gnu/packages/python-xyz.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index fe2b4b6d56..2142f7d754 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -33730,12 +33730,15 @@ (define-public python-pypandoc
                          "skip_test_conversion_with_data_files")) #t)))))
     ;; Ideally, we would supersede texlive-xpatch with texlive-regexpatch once
     ;; the missing etoolbox.sty file is added
-    (native-inputs (list python-poetry-core
-                         (texlive-updmap.cfg (list texlive-xpatch texlive-lm
-                                                   texlive-xcolor))))
+    (native-inputs (list (texlive-updmap.cfg (list texlive-xpatch texlive-lm
+                                                   texlive-xcolor))
+                         ;; Dependencies required by  pyproject-build-system
+                         python-poetry-core
+                         python-setuptools
+                         python-pip))
     (inputs (list pandoc python-pandocfilters))
     (propagated-inputs (list python-wheel))
-    (home-page "https://github.com/bebraw/pypandoc")
+    (home-page "https://github.com/JessicaTegner/pypandoc")
     (synopsis "Python wrapper for pandoc")
     (description "pypandoc is a thin Python wrapper around pandoc
 and pandoc-citeproc.")

base-commit: 30fdffc4b5605431b28a23b03330e850b2184a76
-- 
2.46.0

Message #14 received at 75033 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 75033 <at> debbugs.gnu.org
Subject: pyproject vs python build system
Date: Mon, 23 Dec 2024 08:28:12 -0500

[Message part 1 (text/plain, inline)]

I was under the impression that the pyproject-build-system was not
intended to replace the python-build-system (per it's own
documentation: https://issues.guix.gnu.org/58587#30), or is this 
part of a transitory period where everything moves to
pyproject-build-system before renaming back to the original
python-build-system? Additionally, will the build system be updated to
include all the extra build dependencies implicitly, or will we use
native-inputs in a way similar to how rust uses
cargo-development-inputs?

v/r,

Aaron

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 75033 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Covrig <aaron.covrig.us <at> ieee.org>
To: 75033 <at> debbugs.gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>
Subject: [PATCH v3] gnu: python-pypandoc: Fix build
Date: Mon, 23 Dec 2024 08:30:25 -0500

* gnu/packages/python-xyz.scm (python-pypandoc): Fix build
---
Fixing extra space in previous commit (which adds pyproject required
dependencies and updates the project homepage to remove the redirection)

 gnu/packages/python-xyz.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index fe2b4b6d56..0b978b1537 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -33730,12 +33730,15 @@ (define-public python-pypandoc
                          "skip_test_conversion_with_data_files")) #t)))))
     ;; Ideally, we would supersede texlive-xpatch with texlive-regexpatch once
     ;; the missing etoolbox.sty file is added
-    (native-inputs (list python-poetry-core
-                         (texlive-updmap.cfg (list texlive-xpatch texlive-lm
-                                                   texlive-xcolor))))
+    (native-inputs (list (texlive-updmap.cfg (list texlive-xpatch texlive-lm
+                                                   texlive-xcolor))
+                         ;; Dependencies required by pyproject-build-system
+                         python-poetry-core
+                         python-setuptools
+                         python-pip))
     (inputs (list pandoc python-pandocfilters))
     (propagated-inputs (list python-wheel))
-    (home-page "https://github.com/bebraw/pypandoc")
+    (home-page "https://github.com/JessicaTegner/pypandoc")
     (synopsis "Python wrapper for pandoc")
     (description "pypandoc is a thin Python wrapper around pandoc
 and pandoc-citeproc.")

base-commit: 30fdffc4b5605431b28a23b03330e850b2184a76
-- 
2.46.0

Message #22 received at 75033-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 75033-done <at> debbugs.gnu.org
Cc: Aaron Covrig <aaron.covrig.us <at> ieee.org>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [PATCH] gnu: python-pypandoc: Fix build.
Date: Mon, 23 Dec 2024 11:02:36 -0600

Hi all,

I applied this.

Hi Aaron,

Yes, I think we are moving to the pyproject-build-system.

That documentation should probably be updated.

I'll try to take a look or feel free to update it and Cc the python
team for review.

-- 
all the best,
jgart

https://whereis.social/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.