GNU bug report logs - #75026
[PATCH core-updates 0/7] Update gnutls and curl.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 75026 <at> debbugs.gnu.org
Subject: [bug#75026] [PATCH core-updates 1/7] gnu: gnutls: Update to 3.8.8.
Date: Tue, 24 Dec 2024 15:50:02 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * gnu/packages/tls.scm (gnutls): Update to 3.8.8.
> [source]: Delete patches.
> [arguments]: Mark failing tests via XFAIL_TESTS make flag.
> * gnu/packages/patches/gnutls-skip-trust-store-test.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): De-register it.
>
> Change-Id: I6519b789896dba00de6a1af7a6f772906ce660c1

[...]

> --- a/gnu/packages/patches/gnutls-skip-trust-store-test.patch
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Version 3.5.11 added a test to check that the default trust store is readable.
> -It does not exist in the build environment, so pretend everything is fine.
> -
> -diff a/tests/trust-store.c b/tests/trust-store.c
> ---- a/tests/trust-store.c
> -+++ b/tests/trust-store.c
> -@@ -61,7 +61,7 @@
> - 	} else if (ret < 0) {
> - 		fail("error loading system trust store: %s\n", gnutls_strerror(ret));
> - 	} else if (ret == 0) {
> --		fail("no certificates were found in system trust store!\n");
> -+		success("no trust store in the Guix build environment!\n");


[...]

> +           #~(list (string-append
> +                    "XFAIL_TESTS="
> +                    ;; This test checks that the default trust store is
> +                    ;; readable; expect it to fail since the trust store
> +                    ;; doesn't exist in the build environment.
> +                    "trust-store "

This suggests that the patch above was still useful, after all?  (The
patch still applies apparently:
<https://ci.guix.gnu.org/build/6753571/log>.)

Also, lack of the patch might trigger failures in the test suites of
dependents.  What does ‘guix build -P1 gnutls’ say?

> +                    ;; This one fails only inside the build environment, for
> +                    ;; reasons unknown (see:
> +                    ;; <https://gitlab.com/gnutls/gnutls/-/issues/1634>).
> +                    "tls13/compress-cert-neg2 "))

This is weird, would be interesting to investigate, maybe stracing the
test to see why it would fail in the build environment and not outside
of it?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.