From unknown Sun Aug 10 00:26:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#75020 <75020@debbugs.gnu.org> To: bug#75020 <75020@debbugs.gnu.org> Subject: Status: [PATCH] Fix make-separator-line for ttys not supporting underline Reply-To: bug#75020 <75020@debbugs.gnu.org> Date: Sun, 10 Aug 2025 07:26:13 +0000 retitle 75020 [PATCH] Fix make-separator-line for ttys not supporting under= line reassign 75020 emacs submitter 75020 Gerd M=C3=B6llmann severity 75020 normal tag 75020 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 02:43:24 2024 Received: (at submit) by debbugs.gnu.org; 22 Dec 2024 07:43:25 +0000 Received: from localhost ([127.0.0.1]:48884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPGcW-0004Rs-GH for submit@debbugs.gnu.org; Sun, 22 Dec 2024 02:43:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:35816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPGcU-0004Rk-Ek for submit@debbugs.gnu.org; Sun, 22 Dec 2024 02:43:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPGcU-0007cA-6F for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 02:43:22 -0500 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPGcS-0002Cp-HC for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 02:43:21 -0500 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-aa6aad76beeso492928666b.2 for ; Sat, 21 Dec 2024 23:43:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734853398; x=1735458198; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=YYmKyvLZr80c73TigldWviaZUMbRmynCw5s8n+4Yci0=; b=ZpMKdlMmhyMLRU8uP6fORuvfzKwXNBw5aYMKxa+I4sUdA4P3stiM8pNr+rTWEcg1hD 2WuJNbObsLXUJNpkZXdHodypqv/NoNT6uHNCoDknXcELhO3oBPrtnej8vX9oI7s3NvKD fFImMge1f+2m0YREPYHSByj5UA6xUIlfR82AzLbN8LkvI9oF5fC+IiDoMx9gRL7+Vlyp 5bYxwLuF+JjO89E5R3Qq03pNwlRmwR6maXiQbTXpMlYFmnU9WknaM1svHxSn2s7AXwiM ryr5h4X/rNaI2GIwnJ6BOCWn7VrSQ7iot5ruv1gvfzQlMcKBvfmyO9y6ilm71M0DFM2k WucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734853398; x=1735458198; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YYmKyvLZr80c73TigldWviaZUMbRmynCw5s8n+4Yci0=; b=B8OUoyIyrIgDuaq0HQLLWKiU/wWELXLg5gG0fux35Xfkcj923KqWW6vGGEkLh0j3hF MN4kBLYlwaqEM+PONqc4mXApBxzeaqOvX6UCxHn7/vBLfF69Ij+KKUQq8DD8rawcXXsv Qa5qgVCqM850Qo10EuHtB3E8XXHjHLL0cOJlxCiD3lomrjLcYoIJAVcbhhaN04Gn4W8I ixgT6kLdMctn7LTi6epiLJdASshDINglzw3WqwpC6z/94pRUyY/OLX2DPSuQdxWWoswb yvCGAIOgg+0mBrq1W565+O1TwgT5OA4nSzck7l5s9Xp+nfvdaZrbsHssASkYfmtxUWbp YA+A== X-Gm-Message-State: AOJu0YzlAkGjUezUVLNZuUxOA1dbEb7ZPw64jvW/x/eqNbEF1RBVi4bH GtpegStJtLUX6c3BffHwUGSAShJNvrA9wS62kK1tfHsHMAMSasEQVdJLyw== X-Gm-Gg: ASbGnctNTXX18nldnwqgMwk1hyZP7tlxj+heIL5pqU5xivpYqbnWUrcxuPSHh/R8O2l 2GhvkB0GOVgfE65VJRX+VPRxqvgCkqYmShkx6x7hh2AErY3VFi1s45H4SMBhr3f5CasRNu2mKcp 7VzPjX86gVsdt19MFyYFpB110cEaugqYYqPzAnafWu/HuoG/72IITJzDlujCeUBGvYrCc+xZEgp D/NE87BdlMGaV3DFwRun+NJbs3tOgUMWguyFuHIHYFBgfgw2hqnBLaPcrkhAZb+qb8xo9z/X5VH xlehmFtgWn97yZJuatpQqboelTEEDEQxlmI2im1QsG8j6JcjiICRqmafuyvqvG8RaA== X-Google-Smtp-Source: AGHT+IHHaqZtnKTxsjaRwXLzbWxxuECc3OphR7iDYtKi5ZirAq8mz7fM00vL5JbBdaFcNs4prr2aKQ== X-Received: by 2002:a17:907:3f9b:b0:aa6:5ec2:966c with SMTP id a640c23a62f3a-aac270385acmr807042066b.7.1734853397460; Sat, 21 Dec 2024 23:43:17 -0800 (PST) Received: from pro2 (p200300e0b71f6700b0196211433a3436.dip0.t-ipconnect.de. [2003:e0:b71f:6700:b019:6211:433a:3436]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e8301bdsm360655066b.31.2024.12.21.23.43.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 23:43:16 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix make-separator-line for ttys not supporting underline X-Debbugs-Cc: Date: Sun, 22 Dec 2024 08:43:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch To reproduce, emacs -nw -Q on a terminal not supporting underlining (in my case Terminal.app on macOS). - M-x display-line-number-mode RET - Eval (insert (amke-separator-line)) => the separator line is too long Attached patch fixes that. In GNU Emacs 31.0.50 (build 4, aarch64-apple-darwin24.2.0) of 2024-12-21 built on pro2 Repository revision: cbafbb2dd57993397c0d624461e3611831414e91 Repository branch: cl-packages System Description: macOS 15.2 Configured using: 'configure --without-ns --cache-file /var/folders/1d/k_6t25f94sl83szqbf8gpkrh0000gn/T//config.cache.cl-packages --with-native-compilation --with-mps=yes CC=clang 'CFLAGS=-Wgnu-imaginary-constant -Wunused-result -g -fno-omit-frame-pointer -F /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks -Wno-ignored-attributes -Wno-flag-enum -Wno-missing-method-return-type -Wno-variadic-macros -Wno-strict-prototypes -Wno-availability -Wno-nullability-completeness' --prefix=/Users/gerd/.local' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-make-separator-line-for-ttys-not-supporting-unde.patch >From d481da70010eab163d12f770ed11f8fef171406a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerd=20M=C3=B6llmann?= Date: Sun, 22 Dec 2024 08:35:40 +0100 Subject: [PATCH] Fix make-separator-line for ttys not supporting underline * lisp/simple.el (make-separator-line): Use window-max-chars-per-line instead of window-width. --- lisp/simple.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index cb3b12d4402..bd8466a5b1a 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -745,8 +745,9 @@ make-separator-line (concat (propertize (make-string length ?\s) 'face 'separator-line) "\n") (propertize "\n" 'face '(:inherit separator-line :extend t))) - ;; In terminals (that don't support underline), use a line of dashes. - (concat (propertize (make-string (or length (1- (window-width))) ?-) + ;; In terminals that don't support underline, use a line of dashes. + (concat (propertize (make-string (or length + (1- (window-max-chars-per-line))) ?-) 'face 'separator-line) "\n"))) -- 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 03:22:12 2024 Received: (at 75020) by debbugs.gnu.org; 22 Dec 2024 08:22:12 +0000 Received: from localhost ([127.0.0.1]:48929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHE4-0006EY-I0 for submit@debbugs.gnu.org; Sun, 22 Dec 2024 03:22:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHE2-0006EH-VT for 75020@debbugs.gnu.org; Sun, 22 Dec 2024 03:22:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPHDx-0006Rb-Bn; Sun, 22 Dec 2024 03:22:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vZHx32gv9Eb37HI+vIgKVLJtIJoS+Bg9WTqGBSu3Qws=; b=D5RPuPi8MTJj+E0F+2hE t9Rd4Amj24tfYrGHg/LOK1jAu9BRY1r8byPq5nagzDuV8UNge9yNdD7gPeg4pBTJi35OrM9loECmL syzJw8kOF+5qYTqFnia7rpzOUkRYKn6+SuBW98ZS7b7HcD/V//nUJ+YkUu1vbSwSMcuK27xP9mo2N YQfig9R4LqsLDApulg89emCsKbV21Ffo1aS9uBLbyBoyWm0klhImjcV6fDDRuRrcu3oZx1ANuprcp YOyqscaebsRY3DKmvJUvdIBmcy2DV/XPEpCoC0pHiXo54u5auHCVhJk6kknzCERRBQSFlnj1ywtJr cdswSn2bssWqBA==; Date: Sun, 22 Dec 2024 10:22:02 +0200 Message-Id: <8634ig6sb9.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?utf-8?Q?M=C3=B6llmann?= In-Reply-To: (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Sun, 22 Dec 2024 08:43:14 +0100) Subject: Re: bug#75020: [PATCH] Fix make-separator-line for ttys not supporting underline References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75020 Cc: 75020@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gerd Möllmann > Date: Sun, 22 Dec 2024 08:43:14 +0100 > > To reproduce, emacs -nw -Q on a terminal not supporting underlining (in > my case Terminal.app on macOS). > > - M-x display-line-number-mode RET > - Eval (insert (amke-separator-line)) > > => the separator line is too long > > Attached patch fixes that. Thanks. But I'm not sure this is for make-separator-line to decide. For example, after applying the patch, using this recipe: M-: (insert (make-separator-line)) RET M-x display-line-number-mode RET we will again get a too-long separator line. And with this recipe: M-x display-line-number-mode RET M-: (insert (make-separator-line)) RET M-x display-line-number-mode RET we will get a too-short separator line. So arguably, in these special cases, the caller should pass the required length as the optional argument, because only the caller knows the context in which the function is called and the purpose for which the separator will be used. Which would mean the default of using window-width is correct. Does this make sense? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 03:50:45 2024 Received: (at 75020) by debbugs.gnu.org; 22 Dec 2024 08:50:45 +0000 Received: from localhost ([127.0.0.1]:48976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHfh-0007ep-9Y for submit@debbugs.gnu.org; Sun, 22 Dec 2024 03:50:45 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:52330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHfe-0007eZ-U6 for 75020@debbugs.gnu.org; Sun, 22 Dec 2024 03:50:43 -0500 Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d0d32cd31aso4618731a12.0 for <75020@debbugs.gnu.org>; Sun, 22 Dec 2024 00:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734857377; x=1735462177; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tqtbzcZ4oos2VyEEWkhysdmh4cKD3e/9/XE1+pXwkAc=; b=HWo5phQ38INoKLSzGd0GMpUPaHN3DPsPxxECh62zy4ood50kUHXIW+Zu8CNQcPv4Dp i78tP8izFHCkWqsjfT0LM9PXyaOcRtQygkEyucNj0exGHZe4jC4RVoJW98p+rpywl2Rp X2jxOlie8cREvqFgszA570mBhMHHTZD2zNzCgxSFYOmY3ScOP8sQfahe0uH71ZQH4F43 bWlqQR5KUY3RTgh/VgFE8GBO0BqqZbXwGSVpi0/B4a2fx+YZEtyhqUExYxNupUYW7iwk nxI2CEmxYgzVPsECrmLt588+kecsBrJQI22g9+d/WzOnM6Au1VhdAO1XWNeKKG0mrVoJ kmHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734857377; x=1735462177; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tqtbzcZ4oos2VyEEWkhysdmh4cKD3e/9/XE1+pXwkAc=; b=q2dCx5sDszvmrWFZ+SPjjm1TwI3wHlaSUTLDWdvPeWdDuEOv+5IU6QrZTOoWN8YuNz 0cXRM7HD+rBB0VljptbrjauFf27jbcF8gOZ08NTGAKX8jp0mVdvyWqhZctyfO9Nxe8gl LM7z3WD6P9Ln7lJV0EGyIV+3KfyRyOA6PIlfu1tGNr5YsDjK03rUhaSCoP/UgNiK8SM8 pxMens2uvRR0mnpKSThCHm77PmhO41S8MpLvLAG30Wr6Ha4i/6qZH3n5XUpMNs0sXCdR VSVbV4aax7argAvzMsTofWuM4wTh1YSpsmYXKaF5hJeujO2pkU0oXlGtiSjmS5YD7XQh TQUg== X-Gm-Message-State: AOJu0YyC0+ipQk/YskRt9trs29FTSobvhQ3uINopm+ghSWq6TVs+cAKC 7AEgTOI6Bq9QSLXsjEU+kAVv7ZDtmL57GAMGBUfR6SnCeHunHm3EBATj+A== X-Gm-Gg: ASbGncs6qLyud8iDVmRLH00XpAU154JIeepB6RbbTMxPGawNokpGQHgd6th8gYD1jay Qirv1UG9piEfqsoeDOUScrz/tLGqoY+0oAaglwILxlFbXVSsPg4TuFjsAd9Mnmdyxj0K/mQdFTt GAv9v2nX4uugEnDX1giWVT7a5w2qIb3iTTQJzT8v+Gpbp2BkQCiF6XMqoaS4AALmZsJxzIMdHbo 8CmZlZaVQc5VAdHqu/WUjL9qu1xcYUaIBGg57LX6dtbTAWBqN9YW+9hbL/LYOREdF44FXHX284v VaUjYbFqxItRO00c1/MVIzGHA6uq4HCIg3PNVeUyTtGGrU7xBLa5balDX/dPr/dGyA== X-Google-Smtp-Source: AGHT+IGwq3cMsG2RNdN6mrQiCBcWmynDlySesUF52w+xLnZCFfQf5YGkAIymM7uyVkk+BOEm3KNKFg== X-Received: by 2002:a05:6402:1d53:b0:5d0:bf5e:eb8 with SMTP id 4fb4d7f45d1cf-5d81de06611mr19560863a12.23.1734857376424; Sun, 22 Dec 2024 00:49:36 -0800 (PST) Received: from pro2 (p200300e0b71f6700b0196211433a3436.dip0.t-ipconnect.de. [2003:e0:b71f:6700:b019:6211:433a:3436]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80701c89asm3454014a12.79.2024.12.22.00.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 00:49:35 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#75020: [PATCH] Fix make-separator-line for ttys not supporting underline In-Reply-To: <8634ig6sb9.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Dec 2024 10:22:02 +0200") References: <8634ig6sb9.fsf@gnu.org> Date: Sun, 22 Dec 2024 09:49:34 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75020 Cc: 75020@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Date: Sun, 22 Dec 2024 08:43:14 +0100 >>=20 >> To reproduce, emacs -nw -Q on a terminal not supporting underlining (in >> my case Terminal.app on macOS). >>=20 >> - M-x display-line-number-mode RET >> - Eval (insert (amke-separator-line)) >>=20 >> =3D> the separator line is too long >>=20 >> Attached patch fixes that. > > Thanks. But I'm not sure this is for make-separator-line to decide. > For example, after applying the patch, using this recipe: > > M-: (insert (make-separator-line)) RET > M-x display-line-number-mode RET > > we will again get a too-long separator line. And with this recipe: > > M-x display-line-number-mode RET > M-: (insert (make-separator-line)) RET > M-x display-line-number-mode RET > > we will get a too-short separator line. > > So arguably, in these special cases, the caller should pass the > required length as the optional argument, because only the caller > knows the context in which the function is called and the purpose for > which the separator will be used. Which would mean the default of > using window-width is correct. > > Does this make sense? Yes, makes sense. I noticed this too now with C-h f context-menu-mode, for example. If the separator line size depends on the window which it currently does, one gets different results. And when the help buffer is shown in a different window, and in my case to the left or right, it's almost always too long and wraps to 2 or 3 lines. It looks pretty weird. But whatever, I'll close the bug in a minute. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 03:51:08 2024 Received: (at control) by debbugs.gnu.org; 22 Dec 2024 08:51:08 +0000 Received: from localhost ([127.0.0.1]:48980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHg3-0007fx-Nz for submit@debbugs.gnu.org; Sun, 22 Dec 2024 03:51:07 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:51362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPHg2-0007fo-Hx for control@debbugs.gnu.org; Sun, 22 Dec 2024 03:51:06 -0500 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aa67f31a858so577061966b.2 for ; Sun, 22 Dec 2024 00:51:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734857405; x=1735462205; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:from:to:cc:subject:date:message-id:reply-to; bh=mfQ8/sulBd0OPCaQnOGDNIv0uXL6pBFxx7g97xzc3ik=; b=Bf1QXYMggXYCIgDM5Qu55RjxDqcp5wRi6vCSQBiKVfjw3Ou38S0A6IkJICIxoNVIQS X1KnZK5TC9Mcr8BOQmNHy6aDArwLQHcGuGFgwKbOXPO5RdvKfDHAr++95NUB5c9uucCh sKj4jRExcfsh4qspfY80pJXG1FLr1UshsOxlMHVv4FOnuOuPAzD9ab6VubpvR5JeTgLl XfKYdobWWv7++SE33pQMHCO3lMfFFHeI+x3ZelCMjiQolviAdaa7fiyTcxdQ9WovEtob 6/0EkdrqpQgu5/2PF61mUJgbVnjrLgBtWzjG4YTqQnPaJ6LHzL6a/NrrkVIlMQQBFTWp 1VWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734857405; x=1735462205; h=content-transfer-encoding:mime-version:subject:from:to:message-id :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mfQ8/sulBd0OPCaQnOGDNIv0uXL6pBFxx7g97xzc3ik=; b=gdgLK9Yw4jm/rn8GE5F3OA3+PaWLaUhgwSsRUAki1cNx5P49cZdbGwCC5TURajaqSa KMkBmF2lI1/KcyJ0p7D11DKliRFnyOwzO+1dfdTaMfPydCf7K/3SKI8GQxZIdYp5uzvr j+qic/A/i/kbFhKyAYsvmnN43ydH5h4VwyNcdo6Vk13XHVpC/vRgeYGuTIwMNyhW0d9C jiMNZpSKkvY6pzdefyV8Je6p2/kVO0cxM4wzmPdhWU9LwROKx2ZitPQMADO5FmexiIbs QeztEuVUJDqwXe4DPZx3LzGLcrmr5C2vNTYGPJ3WDBUX6aenyRi7/u68KEblT/4gBYrA m3yg== X-Gm-Message-State: AOJu0YxAX+rmzzZMxmqGDr1G6/f4t+oExdGW/2hAlm7NWK9sLlFaJa1S sClIHzMFAk5DyjUiVqMabipvRyauNgc715LYbKrzlToqkO/YdLnz+gGLBQ== X-Gm-Gg: ASbGnctYG+rk7RrsR8OrCRyNdNiEsQ2x5b5hZH0Ndb8QjR2iki2txzOa4ekz4Lqw6IW BVsKJLaFgJFymjOf5GVcxwAowQlSFtG/5zuropb9edjvAjX7YOGNod1I+R4lnfejf0luLwLbjpK qNDmAqRXKsH59MLJRykkIfvAVKJ0Bkg2pLuLdIUSOUvw7jHVC4XAHE6TKNxSiP4UQDfW3KvlIuL 0e8XWwR6Sc01mpTXfhLpdzASbpOdlc+AeoCd7QW5oxPKmBQ0P8IEM48um2/E6ty+DQoeAHmgAdJ IYhpfmzoAx45oDG7KOuwNTHilzFa6vfF2BcmDyTCOOgqOjH6BwkpsCx0GZpWYMNoMQ== X-Google-Smtp-Source: AGHT+IEQp/kcmWvqIox8tCJVJZ8SE0TDyqxM2fABK/L9aUnUQfxQ+Apz/HkU+oJ3yAdUsShqv8dirw== X-Received: by 2002:a17:907:3f2a:b0:aa6:5603:e03d with SMTP id a640c23a62f3a-aac336631f6mr705121966b.59.1734857405254; Sun, 22 Dec 2024 00:50:05 -0800 (PST) Received: from pro2 (p200300e0b71f6700b0196211433a3436.dip0.t-ipconnect.de. [2003:e0:b71f:6700:b019:6211:433a:3436]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aae7afacd5bsm241179166b.140.2024.12.22.00.50.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 00:50:04 -0800 (PST) Date: Sun, 22 Dec 2024 09:50:03 +0100 Message-Id: To: control@debbugs.gnu.org From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Subject: control message for bug #75020 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 75020 31.1 quit Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.218.45 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.218.45 listed in bl.score.senderscore.com] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gerd.moellmann[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.45 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.45 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.2 MALFORMED_FREEMAIL Bad headers on message from free email service X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 75020 31.1 quit Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.218.45 listed in sa-accredit.habeas.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.45 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.218.45 listed in bl.score.senderscore.com] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.45 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gerd.moellmann[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.2 MALFORMED_FREEMAIL Bad headers on message from free email service -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager close 75020 31.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 07:22:36 2024 Received: (at 75020) by debbugs.gnu.org; 22 Dec 2024 12:22:36 +0000 Received: from localhost ([127.0.0.1]:49297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPKyh-00013B-ST for submit@debbugs.gnu.org; Sun, 22 Dec 2024 07:22:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPKyg-00012z-CD for 75020@debbugs.gnu.org; Sun, 22 Dec 2024 07:22:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPKwT-0001uX-SY; Sun, 22 Dec 2024 07:20:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zZ8ClwAEuS8A6Fk7yL/4h0HuhEy0cXwSHgC4rwbtCsE=; b=VABLadpqiGWGUkAMaWIF cRmAqPCvcZ/KvciWlqnlsBiAa+v4ZKG9cwGV5fKFRYrrruH8sBmOvylZo4eSYhOGIyh8tHjqe4msc /Uh1a6+URHLnnc1FxlVDJSgYZt1+VzduZdJ5jNvoNbm9DWTM3cEZ3KY6zeMK6cn0XGT5fZndxJH10 26P9QdI2kRnEmOEbrXTwl9WOyeI5Sx1dY9Ngdq4WsPI7vx4mbuZ5vwMFwcdIZbMTW3iIV+15z/rBy YML5nkook/BNRHcxILyWJsG+pX9nIBzH6BjBTyYzuhTUtx0xbvB9o1JNHz6X426RThCwG/JQbe6J+ TSz5nBufgA1FlA==; Date: Sun, 22 Dec 2024 14:20:16 +0200 Message-Id: <86zfkn6ha7.fsf@gnu.org> From: Eli Zaretskii To: Gerd =?utf-8?Q?M=C3=B6llmann?= In-Reply-To: (message from Gerd =?utf-8?Q?M?= =?utf-8?Q?=C3=B6llmann?= on Sun, 22 Dec 2024 09:49:34 +0100) Subject: Re: bug#75020: [PATCH] Fix make-separator-line for ttys not supporting underline References: <8634ig6sb9.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75020 Cc: 75020@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gerd Möllmann > Cc: 75020@debbugs.gnu.org > Date: Sun, 22 Dec 2024 09:49:34 +0100 > > Eli Zaretskii writes: > > > Thanks. But I'm not sure this is for make-separator-line to decide. > > For example, after applying the patch, using this recipe: > > > > M-: (insert (make-separator-line)) RET > > M-x display-line-number-mode RET > > > > we will again get a too-long separator line. And with this recipe: > > > > M-x display-line-number-mode RET > > M-: (insert (make-separator-line)) RET > > M-x display-line-number-mode RET > > > > we will get a too-short separator line. > > > > So arguably, in these special cases, the caller should pass the > > required length as the optional argument, because only the caller > > knows the context in which the function is called and the purpose for > > which the separator will be used. Which would mean the default of > > using window-width is correct. > > > > Does this make sense? > > Yes, makes sense. > > I noticed this too now with C-h f context-menu-mode, for example. > If the separator line size depends on the window which it currently > does, one gets different results. > > And when the help buffer is shown in a different window, and in my case > to the left or right, it's almost always too long and wraps to 2 or 3 > lines. It looks pretty weird. So I think we need to have bug reports for those applications where this happens, in particular in C-h. That's where this should be fixed. > But whatever, I'll close the bug in a minute. Thanks! Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 08:20:43 2024 Received: (at 75020) by debbugs.gnu.org; 22 Dec 2024 13:20:43 +0000 Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPLsx-0003qS-4m for submit@debbugs.gnu.org; Sun, 22 Dec 2024 08:20:43 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:61754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPLst-0003q9-MV for 75020@debbugs.gnu.org; Sun, 22 Dec 2024 08:20:41 -0500 Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d3d0205bd5so4543719a12.3 for <75020@debbugs.gnu.org>; Sun, 22 Dec 2024 05:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734873573; x=1735478373; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2t8uYfUmzpAe3NnhsYsvJXjgAGAoi9CuroTz+IXqS0M=; b=JQHT//38raLyumYwTVzqNnPEh++jw6aith1wcWD1oXJrrMRoDtv4lMoKORKhemrTbA hsB80lIHirzr1OtEUuZElJN4tOvHeZ1/ADH8w2SPk4ClItTvU3R4+oQGc3V7iIAFRS83 4ehm2G+iDDB340mki6T7/9wIg4wAt6pzq35Btp62TbQKMRyrjExneaFZsISKO3wvEIgI hVtypzgVdBOLKnv1QVeczJCu52FNiF0c/A8VJdmCYmT/RWjJmvidECc8y6crW13nKtAM FXGqZGutsB1YqolL8/sKxkeJgsHcsY8DJekeXvJri5+hg695osWjK9aI3BEqeZn5/udf KH5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734873573; x=1735478373; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2t8uYfUmzpAe3NnhsYsvJXjgAGAoi9CuroTz+IXqS0M=; b=iH3CLvzJjQVimkxG6sQvwJpboiI+xPscfKHsgB3Kssjq66SNTLH8ZcmX6INa2aQF6j hisCeKFXAD5DGP6HvEFL2Yd1UHgikN+qbiR8zGFw0Ge7546H3gepNnactcpAodi6lHJB 1nm5KvK+/zgl3c3rsrI+rw8lH9CNc/ciVKa4yltiGPYIAsy3iT/tHGMOYySSgfLyW/1+ YwM7JQoL3s/DCSOFIHhTl87dQH5toFMuQ0B1vG3f+LODocFvXTbaEsBhAEtyqJgUnEdS XezXIRFcdy0AtcWsogfhZaOZLe2cBB16vwiBAEdI85Iz3WE6Oq8Lzen+3pIC4Y52iIbe YTqQ== X-Gm-Message-State: AOJu0Yyo4/1G3uu6OBJdGqUTyh1kouhSmeNl2FN00Zwjj/w0t85NK/xk a/ID4a4qUYT4TDA4FqFC4AtGRA48tliONeIwL4vCDdzTRbt9t1Bd5v2YxQ== X-Gm-Gg: ASbGncvsbPAKGPPV8srxT8BNCdk6EjMbs4VDp5aP78ov8a3ae9esO+TWOaSq+Otp0LB Rg5AXsJTX2hBRtp7E+/Vv8+D98G8VGsnCE2U8jILbHSwx7chaw6LCyKG86spLWR+Khse9mQ1ywH YjG38mTH/YUKdiExWHKQhYERIBs76FkcDBa5h4UptGZnUmy4KX66irw0mypSln0F0G82OkDFHSZ BW9zRmXkbbfqAlw7nxja3+aw/v3UCfQL94NH7yMCqXlZHGy/rI6142ONYm6o2Oy+pU0j8FXcfXk xox4oCXa3bK3O99w0OZq0FmbtbJ6vBvSQfHeO6e8oNWbqGeM0CNpdgPZdfIh14JGuA== X-Google-Smtp-Source: AGHT+IEIYiIq5yb60hyOaCcgSFopC44pD1yP531ubu142OFGIia0I7akH+XDlHEgCbtZUkV1cJs/DQ== X-Received: by 2002:a05:6402:5207:b0:5d0:bcdd:ff8f with SMTP id 4fb4d7f45d1cf-5d81dd5ed91mr8340102a12.4.1734873573317; Sun, 22 Dec 2024 05:19:33 -0800 (PST) Received: from pro2 (p200300e0b71f6700b0196211433a3436.dip0.t-ipconnect.de. [2003:e0:b71f:6700:b019:6211:433a:3436]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80701c89asm3653881a12.79.2024.12.22.05.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2024 05:19:32 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: Eli Zaretskii Subject: Re: bug#75020: [PATCH] Fix make-separator-line for ttys not supporting underline In-Reply-To: <86zfkn6ha7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Dec 2024 14:20:16 +0200") References: <8634ig6sb9.fsf@gnu.org> <86zfkn6ha7.fsf@gnu.org> Date: Sun, 22 Dec 2024 14:19:31 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75020 Cc: 75020@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Gerd M=C3=B6llmann >> Cc: 75020@debbugs.gnu.org >> Date: Sun, 22 Dec 2024 09:49:34 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> > Thanks. But I'm not sure this is for make-separator-line to decide. >> > For example, after applying the patch, using this recipe: >> > >> > M-: (insert (make-separator-line)) RET >> > M-x display-line-number-mode RET >> > >> > we will again get a too-long separator line. And with this recipe: >> > >> > M-x display-line-number-mode RET >> > M-: (insert (make-separator-line)) RET >> > M-x display-line-number-mode RET >> > >> > we will get a too-short separator line. >> > >> > So arguably, in these special cases, the caller should pass the >> > required length as the optional argument, because only the caller >> > knows the context in which the function is called and the purpose for >> > which the separator will be used. Which would mean the default of >> > using window-width is correct. >> > >> > Does this make sense? >>=20 >> Yes, makes sense. >>=20 >> I noticed this too now with C-h f context-menu-mode, for example. >> If the separator line size depends on the window which it currently >> does, one gets different results. >>=20 >> And when the help buffer is shown in a different window, and in my case >> to the left or right, it's almost always too long and wraps to 2 or 3 >> lines. It looks pretty weird. > > So I think we need to have bug reports for those applications where > this happens, in particular in C-h. That's where this should be > fixed. Actually, something else was also going on: bug#75024. Now I don't have a terminal anymore where the dashes are used. From unknown Sun Aug 10 00:26:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Jan 2025 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator