GNU bug report logs - #75012
31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75012: closed (31.0.50; Use a different face for
 storage_class in c-ts-mode doxygen comments)
Date: Sat, 04 Jan 2025 08:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 4 Jan 2025 00:23:10 -0800
with message-id <2F744A40-A972-4D7F-BD11-A71FDFEA0B6D <at> gmail.com>
and subject line Re: bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments
has caused the debbugs.gnu.org bug report #75012,
regarding 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75012: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75012
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Filippo Argiolas <filippo.argiolas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Use a different face for storage_class in c-ts-mode
 doxygen comments
Date: Sat, 21 Dec 2024 19:21:29 +0100

Hi, I was experimenting with the new local parser for doxygen comments
in c-ts-mode.

I think current syntax highlighting rules really basic and could use
some love.  One thing that would really help IMHO would be using a
different face for storage class so that e.g.

@param[in] some param

have param and [in] with two different colors. Param type is detected as
"storage_class" and that's usually fontified with font-lock-keyword-face
(e.g. like const and static in C) so I believe that would be the most
obvious choice.

I also have been experimenting with some additional rules in
c-ts-mode-doxygen-comment-font-lock-settings but they may be overkill:

   :language 'doxygen
   :override t
   :feature 'keyword
   '((tag_name) @font-lock-constant-face
     (type) @font-lock-type-face
     (emphasis) @bold
     ((tag_name) @bold (:match ".note" @bold))
     ((tag_name) @warning (:match ".warning" @warning))
     ((tag_name) @error (:match ".error" @error))
     (storageclass) @font-lock-keyword-face)

gets me something like the 'after' screenshot here[1], the 'before' now
is current faces with ef-dream theme.

What do you think?

Thanks,
Filippo


1. https://people.freedesktop.org/~fargiolas/c-ts-doxy/





In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.1.0, NS
 appkit-2575.20 Version 15.1.1 (Build 24B91)) of 2024-12-21 built on mba
Repository revision: 1c960bda91237c92f9f602bcb8538ad500c0bc49
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description:  macOS 15.1.1

Configured using:
 'configure --with-tree-sitter --with-native-compilation'

[Message part 3 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Vincenzo Pupillo <v.pupillo <at> gmail.com>,
 Filippo Argiolas <filippo.argiolas <at> gmail.com>,
 Stefan Kangas <stefankangas <at> gmail.com>, 75012-done <at> debbugs.gnu.org
Subject: Re: bug#75012: 31.0.50; Use a different face for storage_class in
 c-ts-mode doxygen comments
Date: Sat, 4 Jan 2025 00:23:10 -0800

> On Jan 1, 2025, at 10:43 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Wed, 1 Jan 2025 23:00:12 -0600
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, Vincenzo Pupillo <v.pupillo <at> gmail.com>, 75012 <at> debbugs.gnu.org
>> 
>> Yuan Fu <casouri <at> gmail.com> writes:
>> 
>>>> On Dec 25, 2024, at 11:54 PM, Filippo Argiolas <filippo.argiolas <at> gmail.com> wrote:
>>>> 
>>>> I guess I'm still within the trivial realm, patch attached.
>>> 
>>> Thanks! Just to make sure, Eli, are we good to apply Filippo’s patch with assignment waiver?
>> 
>> It's less than the ~15 lines we usually allow for, and Filippo has no
>> other contributions in git, so I think we're good.
>> 
>> Don't forget to add this trailer to the commit message, as usual:
>> 
>> Copyright-paperwork-exempt: yes
> 
> Right.

Ok, thanks. I pushed the patch to master. Thanks again, Fillippo!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.