GNU bug report logs - #74992
guix import go package definition is not valid

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74992 in the body.
You can then email your comments to 74992 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: MSavoritias <email <at> msavoritias.me>
To: guix-patches <at> gnu.org
Subject: guix import go package definition is not valid
Date: Fri, 20 Dec 2024 12:32:39 +0200

Doing:

@localhost ~$ guix import go code.forgejo.org/f3/gof3/v3
guix import: Importing package "code.forgejo.org/f3/gof3/v3"...
guix import: varoitus: Unable to determine repository root of 
'code.forgejo.org/f3/gof3'. Guessing 'code.forgejo.org/f3/gof3'.
(define-public go-code-forgejo-org-f3-gof3
  (package
    (name "go-code-forgejo-org-f3-gof3")
    (version "3.10.1")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://code.forgejo.org/f3/gof3.git")
             (commit (string-append "v" version))))
       (file-name (git-file-name name version))
       (sha256
        (base32 "1ysqlj5aa7bhsyghzhycngg45wclc1j2yhq1l27d5crb0pq0wfwg"))))
    (build-system go-build-system)
    (arguments
     (list
      #:go 1.22
      #:import-path "code.forgejo.org/f3/gof3/v3"
      #:unpack-path "code.forgejo.org/f3/gof3"))
    (propagated-inputs (list go-golang-org-x-crypto
                             go-github-com-xanzy-go-gitlab
                             go-github-com-urfave-cli-v2
                             go-github-com-stretchr-testify
go-github-com-santhosh-tekuri-jsonschema-v6
                             go-github-com-hashicorp-go-version
                             go-github-com-google-go-cmp
                             go-github-com-davidmz-go-pageant
                             go-github-com-42wim-httpsig))
    (home-page "https://code.forgejo.org/f3/gof3")
    (synopsis "gof3")
    (description
     "As a CLI or as a library, @code{GoF3} provides a single 
operation: mirroring.
The origin and destination are designated by the URL of a forge and a 
path to
the resource.  For instance, @@code{mirror --from-type forgejo --from
https://code.forgejo.org/forgejo/lxc-helpers --to-type F3 --to 
/some/directory}
will mirror a project in a local directory using the F3 format.")
    (license license:expat)))

This package definition is not valid.

#:go 1.22 should be written like #:go go-1.22

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure struct-vtable: Wrong type argument in position 1 (expecting 
struct): 1.22


MSavoritias

Message #8 received at 74992 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74992 <at> debbugs.gnu.org
Subject: guix import go package definition is not valid
Date: Fri, 20 Dec 2024 23:57:58 +0000

[Message part 1 (text/plain, inline)]

Hi MSavoritias,

Thank you for reporting that!

It's known issue with importer which might need some after math manual
adjustment anyway (check license, check synopsis, check description,
check native/propagated inputs) which are not 100% accurate.

Summing all above adjust #go to correct one or remove it completely (the
current build go version is 1.21), should be not a big deal.

But, you may improve it! Take a look at the importer's code and maybe
implement the adjustment, WDYT?

--
Oleg,
go-team

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 74992 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74992 <at> debbugs.gnu.org
Subject: guix import go package definition is not valid
Date: Mon, 23 Dec 2024 01:02:29 +0000

[Message part 1 (text/plain, inline)]

This is that part of importer which produces the guess:

,@(if (version>? min-go-version (package-version (go-package)))
                     `(#:go ,(string->number min-go-version))
                     '())

[Message part 2 (text/html, inline)]

Message #14 received at 74992 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74992 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: [PATCH] import/go: Fix #:go formation.
Date: Mon, 23 Dec 2024 02:48:31 +0000

Reported by MSavoritias <email <at> msavoritias.me> in #74992 "guix import go
package definition is not valid".  This change fixes it: instead of
"#:go 1.22" will produce "#:go go-1.22".

* guix/import/go.scm (go-module->guix-package): Fix format for #:go key
argument.

Change-Id: I9db0688b8e2970f5e90b415966d39b45505b7c8e
---
 guix/import/go.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 32cba25b33..915846bed1 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -704,7 +704,9 @@ (define* (go-module->guix-package module-path #:key
         (build-system go-build-system)
         (arguments
          (list ,@(if (version>? min-go-version (package-version (go-package)))
-                     `(#:go ,(string->number min-go-version))
+                     `(#:go ,(string->symbol
+                              (format #f "go-~a"
+                                      (string->number min-go-version))))
                      '())
                #:import-path ,module-path
                ,@(if (string=? module-path root-module-path)

base-commit: 30fdffc4b5605431b28a23b03330e850b2184a76
-- 
2.46.0

Message #17 received at 74992 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74992 <at> debbugs.gnu.org
Cc: poptsov.artyom <at> gmail.com, Simon Tournier <zimon.toutoune <at> gmail.com>
Date: Mon, 23 Dec 2024 09:37:52 +0000

[Message part 1 (text/plain, inline)]

CC interested guixers

This change is a quite trivial but would improve large scale import task.

I need to fix the package variable formation as well, where the
#:import-path contain /v[0-9] suffix.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 74992-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74992-done <at> debbugs.gnu.org
Subject: guix import go package definition is not valid
Date: Sun, 12 Jan 2025 20:08:00 +0000

[Message part 1 (text/plain, inline)]

Hi,

Adjustment is pushed as f0adcca9db6e52aed1148a507085f4088633153a to
master.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.