GNU bug report logs - #74983
[PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro

Previous Next

Full log

Message #8 received at 74983 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Hong Xu <hong <at> topbug.net>, Stefan Kangas <stefankangas <at> gmail.com>
Cc: 74983 <at> debbugs.gnu.org
Subject: Re: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in
 emacs lisp intro
Date: Fri, 20 Dec 2024 09:01:29 +0200

> From: Hong Xu <hong <at> topbug.net>
> Date: Thu, 19 Dec 2024 14:36:29 -0800
> 
> * Since `define-key' is considered legacy and we encourage `keymap-set'
>   now.

Thanks.  But the second chunk is not really right, since we have many
more define-key there than keymap-set.

So my suggestion is not to _replace_ define-key with keymap-set, but
instead describe _both_, explaining that as of Emacs 29 we are
migrating towards keymap-set, which is preferred.

Stefan, WDYT?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.