From unknown Sat Jun 21 02:50:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74983 <74983@debbugs.gnu.org> To: bug#74983 <74983@debbugs.gnu.org> Subject: Status: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Reply-To: bug#74983 <74983@debbugs.gnu.org> Date: Sat, 21 Jun 2025 09:50:47 +0000 retitle 74983 [PATCH] Use `keymap-set' instead of `define-key' in emacs lis= p intro reassign 74983 emacs submitter 74983 Hong Xu severity 74983 wishlist tag 74983 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 17:36:48 2024 Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 22:36:48 +0000 Received: from localhost ([127.0.0.1]:40520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOP8R-0000ai-NR for submit@debbugs.gnu.org; Thu, 19 Dec 2024 17:36:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:40218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOP8Q-0000ab-4D for submit@debbugs.gnu.org; Thu, 19 Dec 2024 17:36:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOP8P-00011E-TF for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 17:36:45 -0500 Received: from sender4-of-o54.zoho.com ([136.143.188.54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOP8L-0003HC-QC for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 17:36:43 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1734647795; cv=none; d=zohomail.com; s=zohoarc; b=JctJRyQGfK8Sckfx5wzcl7xySSe7u/jPYqSiif8WkbaCZV9Two3ApH1XRO3urPZ0eZIEks1EflPshxqOITW/o0vK8uZwYCahycCQm4oq3CU5lBNcOLJqa+tqEgo1ARTDy2lLu0qzI6kwdf0sWo/LjHeQ1+1xF63CIgPf/LXNPso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734647795; h=Content-Transfer-Encoding:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3Or8G3ElSJnTKJeDQeo+FlM4Uwn1v7gxcXN2aCd8zZg=; b=b5G+m/NpSW0FM9YnwTzvl/cwHCNCBPZASTkjWTHTWcj/WdUIPCE6NCm/8aGJnvLVIQfj+cqvI2j/HxOBgu8nAp61TNJlkXUKkZYSt6RoRwIQUwfjlPazj3H7DGTH6mOeCGsI93pUHsxPfCMREm5lW8ympNvns1q0Qj+R5ME0zkg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1734647795; s=zoho; d=topbug.net; i=hong@topbug.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=3Or8G3ElSJnTKJeDQeo+FlM4Uwn1v7gxcXN2aCd8zZg=; b=SvNS6sYSPE/6dJOT5rE+sCpopWkFfft74Q2O18oVyjY5hPXi2wNIJIU2ZzJRelzG FvwmXZ2SSgICoOQViK5lZBYaMHclH9dgKPN9fU+Gk7/VzydKsMjTC0/rtt6TmeeP6xH bPQTyv+PlfepaRhg9eCO+E4jmi5poJEQ4cEq9S4A= Received: by mx.zohomail.com with SMTPS id 1734647793834678.8117045148588; Thu, 19 Dec 2024 14:36:33 -0800 (PST) From: Hong Xu To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Thu, 19 Dec 2024 14:36:29 -0800 Message-ID: <20241219223632.37894-1-hong@topbug.net> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.54; envelope-from=hong@topbug.net; helo=sender4-of-o54.zoho.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.116, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * Since `define-key' is considered legacy and we encourage `keymap-set' now. --- doc/lispintro/emacs-lisp-intro.texi | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/lispintro/emacs-lisp-intro.texi b/doc/lispintro/emacs-lisp-intro.texi index 49916235fbf9..32ad07785c20 100644 --- a/doc/lispintro/emacs-lisp-intro.texi +++ b/doc/lispintro/emacs-lisp-intro.texi @@ -17358,15 +17358,14 @@ Keymaps (global-set-key "\C-x\C-b" 'buffer-menu) @end smallexample -Mode-specific keymaps are bound using the @code{define-key} function, +Mode-specific keymaps are bound using the @code{keymap-set} function, which takes a specific keymap as an argument, as well as the key and -the command. For example, my @file{.emacs} file contains the -following expression to bind the @code{texinfo-insert-@@group} command -to @kbd{C-c C-c g}: +the command. For example, the following expression binds the +@code{texinfo-insert-@@group} command to @kbd{C-c C-c g}: @smallexample @group -(define-key texinfo-mode-map "\C-c\C-cg" 'texinfo-insert-@@group) +(keymap-set texinfo-mode-map "C-c C-c g" 'texinfo-insert-@group) @end group @end smallexample @@ -17396,7 +17395,7 @@ Keymaps write a function to insert a word; but I prefer key strokes consistent with other Texinfo mode key bindings.) -You will see numerous @code{define-key} expressions in +You will see numerous @code{keymap-set} expressions in @file{loaddefs.el} as well as in the various mode libraries, such as @file{cc-mode.el} and @file{lisp-mode.el}. -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 02:01:41 2024 Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 07:01:41 +0000 Received: from localhost ([127.0.0.1]:41400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX12-0007Qy-VK for submit@debbugs.gnu.org; Fri, 20 Dec 2024 02:01:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX10-0007Qd-Lb for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 02:01:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOX0t-0002PQ-Ji; Fri, 20 Dec 2024 02:01:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OO+BQUXyfl6dyVZwzFZZfT5MmGflM7AUuA882Wlm/L4=; b=A0hhfIe7m72j JR2o/e9bcbVjSmHvyJFzVhvrW0qsQnelCuD8BOeWCK4L2oKA/1U0L4cCtgfBUQxPU+LCgEVXvKJR6 nOitJqCs6U5cWch+PXRCO8Cxjkh8FnFimeM74SFJ9+awCBXSdvwp4aUryLIOIm2Yu8SF9/pfbZZYu +JIgzdi1so6tEEGF4i7YgbedFnu44UHl9briS47ESpRw+cJ+WNWb6JDYeXM/27Uh7YJH3sSQlDyPX d0eNc7JltPIB9jooRdIJLNbgIXdgMkZkR6Z/hDVA9IsZCiaG0zjl8z4gx8TnOSJe/VFSYjmtJ/ExV 3Qjwntux1f7caQcwXKZLrw==; Date: Fri, 20 Dec 2024 09:01:29 +0200 Message-Id: <86pllmkfcm.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu , Stefan Kangas In-Reply-To: <20241219223632.37894-1-hong@topbug.net> (message from Hong Xu on Thu, 19 Dec 2024 14:36:29 -0800) Subject: Re: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro References: <20241219223632.37894-1-hong@topbug.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74983 Cc: 74983@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Hong Xu > Date: Thu, 19 Dec 2024 14:36:29 -0800 > > * Since `define-key' is considered legacy and we encourage `keymap-set' > now. Thanks. But the second chunk is not really right, since we have many more define-key there than keymap-set. So my suggestion is not to _replace_ define-key with keymap-set, but instead describe _both_, explaining that as of Emacs 29 we are migrating towards keymap-set, which is preferred. Stefan, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 04:36:39 2024 Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 09:36:39 +0000 Received: from localhost ([127.0.0.1]:41697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOZR1-0006NP-1a for submit@debbugs.gnu.org; Fri, 20 Dec 2024 04:36:39 -0500 Received: from mail-ed1-f45.google.com ([209.85.208.45]:53715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOZQy-0006N7-Oz for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 04:36:37 -0500 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5d7e527becaso2658261a12.3 for <74983@debbugs.gnu.org>; Fri, 20 Dec 2024 01:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734687331; x=1735292131; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=xOGCLSDwkP2rhQVLG5magfnz+rKHyixKA9Nfc4Pe4LI=; b=aHO1X2O/3keSJCsYTrf4cIlAk1CdH8P8cpGPw/ZJAv2nEzR+kSxYZ1ESWaGdMEB29z 9xhMMGdpEiON4vBdT5Wj6PaMbCU1Ts0RBtyIb1/M9IybalJCLShcA0KXGek/MEUUOdEc PKkOnJWFK/9S7BE5QlQtdUfoLicuxiHrsUp7gOMMsOt7nEFlOpVFBsPLRDVhDXF9DwKp n4Q720dPhczCW+h2X5Ayckf3QETFx57ZY9jM3rrKmjl44XRpuv1YJa+huANa9cjXt4Vf VIAJJ46jgiJ+zUBgO7Ey6EC6yERRsdu1S3ITo+DsAUAdKL206npZ9yV2ylgqQIfP3WbB kCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734687331; x=1735292131; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xOGCLSDwkP2rhQVLG5magfnz+rKHyixKA9Nfc4Pe4LI=; b=RKQynzGoqh98rzNGYe+k+g10f49T+PwHRwh8HNB1NN55G1tEnw/zoTwae6wEYcl1kZ K/KUXcOw8cpxsOWKyUPI8ZooiFkfP/J0F1QYlDJ/9hQmJGq2Zm2LR6df6awBBYdfmRJB uC7rJItLM8Jiq4GVcmLxzzQwhwqJIhn28wqZ7dWoph/YevDwkozlMjavc95acS4DuN9v lezkNDqj6K1gQipswFJq2GZXpocA05UXAPGWRcyaI2Kdjb1JZWdOaN5kcKbixLOvvxAl mf4AcZ9QJ89mLaQKMFOt+ctgBOGRmf3xqJm6EjQYlUUfBxJZIBpOTellvDwPIsQKnua9 ewGg== X-Gm-Message-State: AOJu0YxNMylDrsKMmts5bd8W9G2ftIrdbLD/CrjM0dWgLxST1+A13EQr VG/NE5kcEVfD7qvqoNIOndZfj98MwDoP+JJgVu7omND2CMYUE7o2qJ9dUMP8meife8YvxOaz/9x d7v9Yg55jyIhr2hs53rue6EYKXI8= X-Gm-Gg: ASbGncvYDeBnMjitUkUe/wHdXnTVL8nOGRLuCxyj6AENQoC51C14WKYhgIYwNQbs96x WyG/tX6Pl3fRbSq4LudovBJFXJ6M+0OA2cgJx2ek= X-Google-Smtp-Source: AGHT+IFvwVr+tr7sx+L9N7CIQTFU339DEAR3AjcZ+LY0ZYQwdwLIfUfIV0izGe1OhZrYsS/Vnfg41Uos6QnaxiQ19Y8= X-Received: by 2002:a05:6402:5291:b0:5d2:7396:b0ed with SMTP id 4fb4d7f45d1cf-5d81ddb3ae6mr3980241a12.14.1734687330748; Fri, 20 Dec 2024 01:35:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Dec 2024 04:35:30 -0500 From: Stefan Kangas In-Reply-To: <86pllmkfcm.fsf@gnu.org> References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 20 Dec 2024 04:35:30 -0500 Message-ID: Subject: Re: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro To: Eli Zaretskii , Hong Xu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74983 Cc: 74983@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Hong Xu >> Date: Thu, 19 Dec 2024 14:36:29 -0800 >> >> * Since `define-key' is considered legacy and we encourage `keymap-set' >> now. > > Thanks. But the second chunk is not really right, since we have many > more define-key there than keymap-set. > > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. > > Stefan, WDYT? I'd tend to agree. Users will have to recognize define-key for a long time indeed, not just in our sources (which are relatively easily fixable in comparison) but also in online forums, third-party packages, and so on. I didn't yet look at the patch though. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 10:43:38 2024 Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 15:43:38 +0000 Received: from localhost ([127.0.0.1]:43701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfAA-0007cy-DL for submit@debbugs.gnu.org; Fri, 20 Dec 2024 10:43:38 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:55660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfA6-0007cp-TS for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 10:43:36 -0500 Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKFXqBf003024; Fri, 20 Dec 2024 15:43:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b= eFLxv25vl9eCwSjqrvW+tlPyVe0WmNXoNJM51vtMctq8OIVJf3zJR3uTYngZHSeH sn7wjmNo+HSKudOhzsrtQyW8d7lXNlYtVO/CVdCKm90fe4n3fHRW3oOdSf/be0l0 xyHKVMFAK8731i2/DY/KUee6k9qpafulsxvXPb0TdLPc4Huuy54eXHsM5iUl4+5e Rbju2YKnivd7ucxZTMJ8laHC/HgYxwui5492QrLxX/nf8LDH94MC7bTmcH7HFX2e zog44t0UYwvyOTNm2AVnmHbEvWO/hhViMiZ6efOksnoqsWfpmPU5krMjqTEDhw5L SvRS4NcJhLl5m6nhASq9IA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43h0xb5hg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 15:43:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKESNOs032928; Fri, 20 Dec 2024 15:43:32 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43h0fjtptp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 15:43:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QhEw5tCb9iD2JLwt8zzA4bkB8MaTvo/w9CFTpZSZ/F+FRLFTXoNncnvfwPxO4PrkTKW9KIFI7/bbY7EN8VWAJpULX2IXaHArvhi1coHVA2xd9Qqrh7mSmdClAPEl+3en9R2ylTC7aZfSY7cQ4FLN2O4CK7RP45K/SaHMJF6JGB9FQhF3H1DGKQm8e2a6u9S0FFCDdkxDxF0ilCmlLcQYA4C2FOHHlcoZtRM3aHJedQpKq+qGu3+PluN86ZN3L+gyo5FlWC4o9I7dOJvzIMffneghnxjwj1MA4GiKAL9aU7CDRcXVHItPKzCXteQg1uCUWpmpqwoEBu3oH95+r8fUxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b=ghNVhOzYYa0Vk7iizDDpzVt7lKaUSunJ8GH6U9SKbX/W7Ytwtq3z4ABicx9KidaN86ykz0Yqay7+KCoBtkeLAPJs8v0XF1MzXW0mz5L+o4/dnjHz+w9DCCwZz4k5xMuFtlHEDocV5H8WQIxEmgFoOjRiF2xM2kQXDla8PZPi25ARNJhednynIdfT+LiSpRR6eCgTvzFfM6xMqzsJww6YBemaFvgCb3W4SVJcBfbowhO9Eoxa79GCO3c0dvuWP3hoQPvTuyMavME2oq7VkrDi4BUCgC+9mEv6BI/a8Tncr37rxSFymtcMVsd7ZMY+FBctnkytmqeKp7kqZQWNuyRqkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b=xVUFcsQGsjm8i/hRByfbRx1dlbufSzB7fa4WLJT7YjGC3kcoTFPyOcJpwqMEhzuG94WxqkefKjP0wBAaYAODJFhiU0025/vlpwm9FOXlw4q7O3dI/Zb+KkYpQSdgpnRhKFr9Hs2m6L4JKXxo0Y7pTGUUB3yzoJIArWLAKeyMy+o= Received: from DS7PR10MB5232.namprd10.prod.outlook.com (2603:10b6:5:3aa::24) by SJ0PR10MB4526.namprd10.prod.outlook.com (2603:10b6:a03:2d6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.17; Fri, 20 Dec 2024 15:43:16 +0000 Received: from DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324]) by DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324%5]) with mapi id 15.20.8251.015; Fri, 20 Dec 2024 15:43:15 +0000 From: Drew Adams To: Eli Zaretskii , Hong Xu , Stefan Kangas Subject: RE: [External] : bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Thread-Topic: [External] : bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Thread-Index: AQHbUq0wqKHW0ubYQ0KgxO4alosl3LLvRj+A Date: Fri, 20 Dec 2024 15:43:15 +0000 Message-ID: References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> In-Reply-To: <86pllmkfcm.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5232:EE_|SJ0PR10MB4526:EE_ x-ms-office365-filtering-correlation-id: 55722b79-6432-42ea-456a-08dd210d0506 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?iE5ZMSBU4ewl/ohzP6ZkcPtMqFCsAqnTQY/kJSgzVFuI1/FgKWw+bBJPbn3X?= =?us-ascii?Q?drvkqI9gWoKFgOH0QVjESkLc0sHQEYkiYAQzG7wIxpXs2icieaZLg/vcywyh?= =?us-ascii?Q?O4JiNTglC+Lo2gAPupLQpRxMy7V+kcEc3R6q7izGYeao2jBs7nBgbY4hAnP0?= =?us-ascii?Q?NpZ3qrVoMAkSWH6TnNawPcrDsThh4pform+F+noWmmB9Qj6Hi1eYWRta63LW?= =?us-ascii?Q?hP2Kj00NKB8Ai6m0OX8+V/14o6OpntRumtvai1UGmLTdaPZMmOBqC2xrc/Ra?= =?us-ascii?Q?jTcnW3NFsb7IUQJIEgH4YL+RryivHJ/6K8jdWOpnVNlSdKkd0q0oeMjIpBMg?= =?us-ascii?Q?qY4GZ1d7wBSMbIPWhoJtGSLdlaRir/vpNCthEaZXpa9zfnEy71vVOP+Gthrj?= =?us-ascii?Q?MxJiIJykGi8AVrlKzq5U3qN24U6uT0ZtxofgnASnXbd3a3uES0KyQRoLea7K?= =?us-ascii?Q?Gi/5sIECgii9AfodPUdXQS3juTvfDIF+HiTmJCfvjhku4BQf2fRfv9tU5PKN?= =?us-ascii?Q?/RFc4R/72fTK+4XRNbUK67YaeTj4qJa1NSxRV/bt6oO2Zq4Hq6OnOjNHDnHa?= =?us-ascii?Q?f+dSTB6nYlfDtqrF7h69yWWCLv3Mx7vG3l1CX1WeCWhWnVvvkbs4y311el/C?= =?us-ascii?Q?0LDJVP3YO4iYtiZs9g4VJFqkUPw4v/6z/XERuKgmFQww7Ls9R56gJC3mq2ZQ?= =?us-ascii?Q?B4XPICStu3M8xuIWpJFQyplRc1AKVzo9xi5sioKf+IDOY4Qn0gh496oQcPHs?= =?us-ascii?Q?uj/x2NVqbCca34FVVJLi8fvyTnNwaYvHGBtrbMnLU0mTaV+ceK+SE/8F7w7A?= =?us-ascii?Q?FFwc6xRxppaPAtthhKNwRJuQpB5w1MO7CF9VYGPFvIllDaFPUQcjlBUAfV3W?= =?us-ascii?Q?O7lClN3KsXd5HP9fnUCHsaK5YM4rGcWOc5xXgyuRDu0Nsv2DHO2KDLTRSfwJ?= =?us-ascii?Q?4MWFNEHNnfJZrm1QfxD7Ve7RUtYrtifOA2bKX905nNLRTzqK6y8tkdIzabZW?= =?us-ascii?Q?cAOz8M6VfyyjlJ+oPTgrvgoYtUJ18wyxv+F8JSp9xBtXvBE/J8hC07DpnHdl?= =?us-ascii?Q?czNWKy6e9VzepbdWU6It78/DnIRblB078tBoGSdw3yE2rYZlCxjLJaEUZTb9?= =?us-ascii?Q?Zm8AXsog9MM5mpVvxF1TI2lUupCjzbKTaMhm1OW0WKnp83aSAAnHNpkw124f?= =?us-ascii?Q?rcwvTYBPWWcmnDc3aThFETxarCcFwd/+SVFRzjTTnQvwmicESk8V+cUMZiSG?= =?us-ascii?Q?uS6Pj2L/2FrnSgDUkCuQFnA/uzok5ZLL/nfwG5fQOex0MiAgKIE/iPL499yC?= =?us-ascii?Q?HrnSFtZFQ5InhTcQkjC41D+AtKnjYok+PIFoMNgO7gjUsNGeUjwQnXJy7xSV?= =?us-ascii?Q?TDcAWyXrdrUsgWngnRfEynyKKbBFQ4jS6vspDP1fvu+Q1BHYHv7SmC01GUd2?= =?us-ascii?Q?5EFJdlW0CubjClyrTgDPYigicpktetco?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB5232.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?olAoxWfzCznQ4Dv56/CRJbmrZlbvJbl8YKQKYWPo0dcsFqEwxqQEVGEbD44D?= =?us-ascii?Q?RWKXQVC6gkCz3/9pAENI87igzaEicsd/D462wgpk2S8zuO6q7U0WDN9JinK0?= =?us-ascii?Q?F7OOasMxr59/XHxt+7TlGdx501wTeoEbz75S8wKdtqAMlrgQPY+qOjXXnL2b?= =?us-ascii?Q?3lJA5S259TeuG/O8+/BlZdUZ9HPzLjTVmMzgQGGjmFnF+vBU2cUEr0+FbKMA?= =?us-ascii?Q?/8/0gHJ49XNxlKwOiWwLiWF2r5k3GFa/p6a/3RjDHrVsJ01Jw6dqSpQgN1zJ?= =?us-ascii?Q?2GMs01flpZYQXfK3px3MwjrbW2BW+Vwk1NOtbbLbxvED2Mi0fil1LAFYN9YU?= =?us-ascii?Q?UjprvHgjn5eL5D5SobeKOjw0iRYMCJjBnPM6jWLNmbJCxqQgXww40CsoZR0e?= =?us-ascii?Q?biS0EDIOjeVMwtaTas9yXufrRUv8tgBPNM2nxVHWu+zyIeRb7+5Hn6OWplTa?= =?us-ascii?Q?nJgMrMNz/rnDdGxrCzP9NL7XFfQo+P9KWeCbUaj2Ov4REWYhfYYhvLEejKuT?= =?us-ascii?Q?rpnheTGo0LWbjMC573S5khO09/68hT7sq15C3BUIwEgpq1TsJ2GqirIHWmdD?= =?us-ascii?Q?qb/92i7R3UdTwkuCe/Ky6q65SbyNN/KwHEgfEtPkx3XwuqFXOyI4CrtM/T3u?= =?us-ascii?Q?AssAdIdV4uQlaWBjfg+5ByvuaI84jMdzF2FuM4x1kML/BJWDAt95AP6x5Zvz?= =?us-ascii?Q?kGS8ZbW/1UqheT2vBldj9qLYcDXPYi32ZruwXEdhh6CC0jsZXEUIWGxerpA8?= =?us-ascii?Q?atrSIIKLinOuBA0yuwI0zZTLwJW6k1+7yLfYt0VI4gq+RoP0K8z7DlSJnzFT?= =?us-ascii?Q?P31iY4G3avLSHcxS66klMh3RsXgtNeG9upL15/er183+ydBXTSp9omGwtec4?= =?us-ascii?Q?xOxYBNGusL5hxL3n4F/LH9RcYgvT0+/2wmWMFXMzaowL6sjpZRVMx2C3/sKQ?= =?us-ascii?Q?/9i+0NJ0mFNVOezT1aAgrToO3lp9zu0gr4dEPaIUsbyks2pinqPU4+lIbKHc?= =?us-ascii?Q?/WcAu7aZIHCDLfJPy9iVfRa0L+bhd4D3Jas7AktOq0SAEL4Ntjh0Su0Wl8Js?= =?us-ascii?Q?kW3fWY29GI7TgQIal0s9CF7gX/fDmkhIUOXu17UvwzryIP4ThL4/p0BQqw3k?= =?us-ascii?Q?Zx//52wUQeXUmZ+P4Bb/HOlkhoR6givwC2Ylu1LohQSmMl7B1jGMY6Uhy4OV?= =?us-ascii?Q?h7x9R8rjbZkl1XgmZT5BXkblyRtqwisLGxw/r2FlZ63/OMeuhQWwmvMHCrqn?= =?us-ascii?Q?U8eZ1ZbQTwp620HFhulp88JxRy4pLvPS/N3N1dkgvA8+1VKmbsDtiyxj3hMM?= =?us-ascii?Q?6viIBLcSEfTHxPbnV5LkEMLALCtvXPCwyZjyDpd25G44lRuFu8PURjoT2Gwr?= =?us-ascii?Q?KL89YulIrH0qkWRFSlB9yO8IlrVFluRd0xtpSAeOZnwipELk5NFzoRThW7Kd?= =?us-ascii?Q?20IG0SWTmb1nDrlslXtYxkT9EK75MZf8Pv9vuIEv6h0SbcX1qQXM5K8jG8Xw?= =?us-ascii?Q?bYANDi1W++8g3ivqVJYYr1tNXJ0yt0g/NjtyrRKHsUGmB0MN5sMPtHBvzQer?= =?us-ascii?Q?Db5jiiVNi6AHO3sSACpzPefiB/0Zz47R0xx2oWLR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p83PnuzkzBQ1I0DhN58ezoIigwqbEn2PCTmHjxQJkZYrxM/b3RUgfIU1FVR9LDvX4BwEcrN055q23RRvjmRrSm6Q+09Nq6hJFeZ8P0rn+Xv9La1GqH8B01UxDOjUZQ+dgY22GJirlsnISBdwfv6DgDPNzY9oMuZB9QqMecEtniAnk7btJ0h+6WmYCE5m93PFwXs2dMSpX8XnFE95f+GUaCu6aaURLT8JrrS+NE89y5rd138UYlhnY41X8/CQEQ29+CA++/Sk1xzy5XagCJXhPBly8v2r5C9zZKqzw1zQyv0ZwqiXTR3zNJ0LDdIcZOIOsrftT18ub2fHgj4i9iH6rpjNerpW+CnQ0rL+6mbaXbdxyiU8a3awoNEtThhTpN61tk5Gm9ypUarDQDrK4Esyzo9Ik+kY3BTXNHuykA2nrbBKVTefxfMlrDtUOFIfRmHMDkpOinDNAoKByp7mLWyd412OPdlZOUVT79A+6f4Vlxuk1Jj9FkSmb6McArrsiBF+xyiMZiy/tHoWuzwefEFB4bprRC56X1qqa8TaPZ/3pFO38JC1Zn73JkYq2DKo3OCdYKkPKlq5b2UZxCyeOdrv4V76gUIAC+qfwFCq7wDtX78= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5232.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55722b79-6432-42ea-456a-08dd210d0506 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2024 15:43:15.9047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mWyFPFjBWBb5rWFt+5NrCChC/rERcialTwJWpBSXgbjYi0l6bZKL+6R4XscymVhikX4rpHw5sSkM8opRSfD7cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4526 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-20_05,2024-12-19_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2412200126 X-Proofpoint-GUID: UqFtRvJaaMJ4YDbEoK41bYhdFCenMMFK X-Proofpoint-ORIG-GUID: UqFtRvJaaMJ4YDbEoK41bYhdFCenMMFK X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74983 Cc: "74983@debbugs.gnu.org" <74983@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. +1. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 16:50:32 2024 Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 21:50:32 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOktE-0008Pz-Ae for submit@debbugs.gnu.org; Fri, 20 Dec 2024 16:50:32 -0500 Received: from sender4-of-o52.zoho.com ([136.143.188.52]:21297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOktA-0008Pp-Af for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 16:50:31 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1734731419; cv=none; d=zohomail.com; s=zohoarc; b=YYhs154hDxV9sNR1XsUUdwiAPCqdzQsoTE7fyKlxNgtxX2vT4qkU4hfGY9WA0ZisJf6PUxUSke2E2SjMzA/hZTM2SljCw3nCOQ+JR08jy065IT82/ahe19yD/+o+z2vaJ6ch4G+NNaI/Kk+xtTDyHP66Exn4q4CGua0WcvVPz7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1734731419; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=XVrv6OTjsFrGt/Zx9qidfyJ7oMaj3bCceDNWiFF/QuI=; b=JcNdXEfFqwmfi8KEKG6l9TRB/Qs1YscKYDhYgxmfOAu6qWpTb5vh5HYaf6/sX2qZffysBQtuQGBseymdmx2FyX1SXuicQ+iR6iFbhLj1ggDFNz+Kk4MAeTIcEGXS55vpx22SW4kApvfA980w/+VMKmuQMY4lZBndwXDxA2oU2TU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=topbug.net; spf=pass smtp.mailfrom=hong@topbug.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1734731419; s=zoho; d=topbug.net; i=hong@topbug.net; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=XVrv6OTjsFrGt/Zx9qidfyJ7oMaj3bCceDNWiFF/QuI=; b=VP2zZP0JzUVnJy3vUDOAjDjKnR4w29HnJpq3IUJXC6ZZWfn2192fPSSlR0rLl0sa XRd69hb5MRAM40MiJqxGkMetlEkhoIZM70hMIhaybcH4hq5EunSBjVqDVd97dbG6aLC du6OjgHKZO2sGpTWo+hZOsze4nky90myVUCQQWww= Received: by mx.zohomail.com with SMTPS id 1734731416348196.17964682139427; Fri, 20 Dec 2024 13:50:16 -0800 (PST) From: Hong Xu To: Eli Zaretskii Subject: Re: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro In-Reply-To: <86pllmkfcm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2024 09:01:29 +0200") References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Fri, 20 Dec 2024 13:50:15 -0800 Message-ID: <877c7u58iw.fsf@topbug.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74983 Cc: Stefan Kangas , 74983@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii wrote: >> From: Hong Xu >> Date: Thu, 19 Dec 2024 14:36:29 -0800 >> >> * Since `define-key' is considered legacy and we encourage `keymap-set' >> now. > > Thanks. But the second chunk is not really right, since we have many > more define-key there than keymap-set. > > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. Thanks, I agree. I've made a followup patch. For some reason the followup patch didn't attach to the Message ID of this thread and a new bug 74999 was created. -- Hong From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 02:20:47 2024 Received: (at 74983) by debbugs.gnu.org; 21 Dec 2024 07:20:47 +0000 Received: from localhost ([127.0.0.1]:45049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOtn5-00017A-7x for submit@debbugs.gnu.org; Sat, 21 Dec 2024 02:20:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOtn2-00016s-QU; Sat, 21 Dec 2024 02:20:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOtmx-0003k6-EW; Sat, 21 Dec 2024 02:20:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yZzVyMsSxf14Ha7Q2f3GPeolQ0FL9hJKH8hs/TDPOXk=; b=O6es5nZYM3xs lM/dDeVeyVFMxKbYwmyYUjMObRzkWpnYQ66e7CxIr53AfDYmEvQKYPDnuyGAN8ysRq51dfLyPkW2B T2hrRHS85NJlWzV+3R8Up6b4EQtsI8ADdw2ADz188T6X3BxQEiXChzW13KSgunGpFZ8G4Hx/wzWt/ jLaUaIL5XXfj6bkTn6xEkfE5/sTNIKnc+1sSpuShxn6rNfG1VMHvDrSm5xxEOTrmh+OqOnqmVNWFh Q1mDCRZbOT7AzCGXx5b5prRojPv2u3xvPmT3v6TQrOCb4FYozh1Hd6NVQj1BGrQCFfYjXFvZ8OuHg +cQNwGTHPAevgT7cj4Uxrw==; Date: Sat, 21 Dec 2024 09:20:38 +0200 Message-Id: <86wmft8ptl.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-Reply-To: <877c7u58iw.fsf@topbug.net> (message from Hong Xu on Fri, 20 Dec 2024 13:50:15 -0800) Subject: Re: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> <877c7u58iw.fsf@topbug.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74983 Cc: stefankangas@gmail.com, 74983@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 74983 74999 thanks > From: Hong Xu > Cc: Stefan Kangas , 74983@debbugs.gnu.org > Date: Fri, 20 Dec 2024 13:50:15 -0800 > > On 2024-12-19 Thu 23:01 GMT-08, Eli Zaretskii wrote: > > >> From: Hong Xu > >> Date: Thu, 19 Dec 2024 14:36:29 -0800 > >> > >> * Since `define-key' is considered legacy and we encourage `keymap-set' > >> now. > > > > Thanks. But the second chunk is not really right, since we have many > > more define-key there than keymap-set. > > > > So my suggestion is not to _replace_ define-key with keymap-set, but > > instead describe _both_, explaining that as of Emacs 29 we are > > migrating towards keymap-set, which is preferred. > > Thanks, I agree. I've made a followup patch. For some reason the > followup patch didn't attach to the Message ID of this thread and a new > bug 74999 was created. I've now merged them. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 20:26:23 2025 Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:26:23 +0000 Received: from localhost ([127.0.0.1]:41153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tT9yg-0000Vq-Ne for submit@debbugs.gnu.org; Wed, 01 Jan 2025 20:26:22 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:42012) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tT9ye-0000VR-Nb for control@debbugs.gnu.org; Wed, 01 Jan 2025 20:26:21 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso20961049a12.0 for ; Wed, 01 Jan 2025 17:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735781175; x=1736385975; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=HbzEC3VsTB3NNibkUf33B+fyvoMli2pOdsysvM2Ga5Y=; b=gd2W4SPU4Xuo/kqyz+UhgBz7qYFtvqTGHyfKTGMh6UWGAfC3hQVwsMGYdYThaFfsyS QONwh3bPLUgdlT66lHF80n1uXKNVSMfaoG9tDI13xI5vER6+hURaUubPfgHvuWZRiW1t MdKi/Kfau84AxxoWhSa5ZI6xeOdbAjTzZOpuecikwPEwYgGb+FYUk63K+3bYLk7MSSlc pkEl7ZAFoF7/1aofhTRPvK30FGbQzMYs0D3LaHRSTt9MPKBmQ9GP0TZhzR4oXJwXZ/gD CSaWqiSmVdT7fhTFYGqbRDRb/L5aW7qOCPGgiYe8hg3uU9o/kv7G2XoxIkRM3STXgtgn LSIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735781175; x=1736385975; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HbzEC3VsTB3NNibkUf33B+fyvoMli2pOdsysvM2Ga5Y=; b=MK68nTZ3MctNBqDsRaUUY09A/c6JD5N8Nh8Au2UmrIUfyHoMG7VMvK8l2Qekfo5vNY RuqZBJjFB4RwVld5rLy0gLahYCD+LijvLcVCQxlyG/+qNq6qWRtCu3mqBvXndboImmeq 7i+YOVxsKa6/v6UhaaPGKnF/a15npxNV9RkgMbqAqfvqHXWgB62iTHyIsr34zyT0Am7T cp+DJFio4HeMyvRA35By90t8lTUBomtjKIwUMZvtpBZooYKZi9TLfFsRFAuiyK/WUFtY xtbRN5IyAsMNz+hjB4OZMhe71gRBVadOXLuF7pvPm4p7eAexlDe+wEj+s0JYAHBPUIYw wH5A== X-Gm-Message-State: AOJu0YwTGvp1JmWOo2103DOWqdq+YrDBhlRY+r7487axkSlIwOf9bNAw wHyQkowh95rodO7oMdiHZJ6UZe+w+PaFR8hBsyg+KeMuRUe818zfpp5wgJb4rPdnscrRJEbzTZo k3J1eS1r99v63LS4b6DNjQTxZYDezTpMI X-Gm-Gg: ASbGnctb7ITlYoQ2sEfwOilWN7WmItlWeG5T8sn4HqYJKeCrHqimuM9w0Hd1xHxtWtk 4AmB5HN9fB/vxuHZ7FiVsgAHvcUDh5RWIeViuu6qT X-Google-Smtp-Source: AGHT+IEFkYrK1MWX5Gw6zf+0V0fGIPmIVXNhNhJYZ8b+BJeVh9bThDkM1kxarrZ5uG8ty3PHp7TMJkCC2bjfE0wPK8U= X-Received: by 2002:a05:6402:3495:b0:5d0:f6ed:4cd1 with SMTP id 4fb4d7f45d1cf-5d81e7509c9mr41707483a12.10.1735781174630; Wed, 01 Jan 2025 17:26:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 19:26:14 -0600 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 1 Jan 2025 19:26:14 -0600 Message-ID: Subject: control message for bug #74999 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 74999 wishlist quit From unknown Sat Jun 21 02:50:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Feb 2025 12:24:19 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator