From unknown Sun Jun 15 09:00:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m Resent-From: Charalampos Mitrodimas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2024 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 74971@debbugs.gnu.org Cc: Charalampos Mitrodimas X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173461490231532 (code B ref -1); Thu, 19 Dec 2024 13:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 13:28:22 +0000 Received: from localhost ([127.0.0.1]:37917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOGZi-0008CW-D2 for submit@debbugs.gnu.org; Thu, 19 Dec 2024 08:28:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:58946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOGZf-0008CO-Vu for submit@debbugs.gnu.org; Thu, 19 Dec 2024 08:28:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGZf-0004Ja-KB for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 08:28:19 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGZd-0006I0-OP for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 08:28:19 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 69FE5240027 for ; Thu, 19 Dec 2024 14:28:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734614893; bh=DdmDatiV2sTHJI7O443mjrHj8kCPaZv2zTS8O13XeOM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=q+FTi3Kv2aa32zdzxtZHkjolTc0he/6Aqqkj9CTSLbrpx5Izbx2jdugd3ajWd6U7D hJ+KhA8w3r3MQnT7BZKpJE07n/6tnEsN+JEjyflDLEDVHZQpEzmeRrC3QxyV3MqCW/ DT52IOL9cUbqRSPqa1hVVkxo6HyTxxgDe2DtI7Sg8bYzYc8e94D7OEgAk50e8bJC3v 4sMp4FYgPZ9+b85urmLAgPLUYkAF31S5cnQFbvhfdvOTS5X5d/D55bgKPP/xmI2347 5Vzi56Sj8nwzbFp7c3TP2N8UDaCNe5R3EEsNKL6CBWqqw2oBn556gHTwlRVq4LTsnn yMaN7uFCoUnjw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YDWZh50llz6tsb; Thu, 19 Dec 2024 14:28:12 +0100 (CET) From: Charalampos Mitrodimas Date: Thu, 19 Dec 2024 13:28:05 +0000 Message-ID: <20241219132805.9262-1-charmitro@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=charmitro@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Resolve warnings caused by mismatched format specifiers in `NSLog` and `fprintf` calls. This was observed when compiled with Clang version 19.1.6 (arm64-apple-darwin). * src/nsterm.m: Cast `IOReturn` (aka `int`) to `unsigned int` for `%x` format specifiers in `NSLog`. Warnings fixed: - "format specifies type 'unsigned int' but the argument has type 'IOReturn' (aka 'int')" --- src/nsterm.m | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index c705a3c78f4..5793bb961e8 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -6955,8 +6955,12 @@ In that case we use UCKeyTranslate (ns_get_shifted_character) #ifndef NS_IMPL_GNUSTEP if (NS_KEYLOG) - fprintf (stderr, "keyDown: code =%x\tfnKey =%x\tflags = %x\tmods = %x\n", - code, fnKeysym, flags, emacs_event->modifiers); + fprintf (stderr, + "keyDown: code = %x\tfnKey = %x\tflags = %x\tmods = " + "%x\n", + (unsigned int) code, (unsigned int) fnKeysym, + (unsigned int) flags, + (unsigned int) emacs_event->modifiers); #endif /* If it was a function key or had control-like modifiers, pass @@ -10761,7 +10765,7 @@ - (CGContextRef) getContext IOReturn lockStatus = IOSurfaceLock (surface, 0, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to lock surface: %x", lockStatus); + NSLog (@"Failed to lock surface: %x", (unsigned int)lockStatus); [self copyContentsTo:surface]; @@ -10808,7 +10812,7 @@ - (void) releaseContext IOReturn lockStatus = IOSurfaceUnlock (currentSurface, 0, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to unlock surface: %x", lockStatus); + NSLog (@"Failed to unlock surface: %x", (unsigned int)lockStatus); } @@ -10849,7 +10853,8 @@ - (void) copyContentsTo: (IOSurfaceRef) destination lockStatus = IOSurfaceLock (source, kIOSurfaceLockReadOnly, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to lock source surface: %x", lockStatus); + NSLog (@"Failed to lock source surface: %x", + (unsigned int) lockStatus); sourceData = IOSurfaceGetBaseAddress (source); destinationData = IOSurfaceGetBaseAddress (destination); @@ -10861,7 +10866,7 @@ - (void) copyContentsTo: (IOSurfaceRef) destination lockStatus = IOSurfaceUnlock (source, kIOSurfaceLockReadOnly, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to unlock source surface: %x", lockStatus); + NSLog (@"Failed to unlock source surface: %x", (unsigned int)lockStatus); } #undef CACHE_MAX_SIZE -- 2.47.1 From unknown Sun Jun 15 09:00:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 07:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Charalampos Mitrodimas , Gerd =?UTF-8?Q?M=C3=B6llmann?= , Stefan Kangas Cc: 74971@debbugs.gnu.org Received: via spool by 74971-submit@debbugs.gnu.org id=B74971.173519968128343 (code B ref 74971); Thu, 26 Dec 2024 07:55:01 +0000 Received: (at 74971) by debbugs.gnu.org; 26 Dec 2024 07:54:41 +0000 Received: from localhost ([127.0.0.1]:39938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQihc-0007N5-Gy for submit@debbugs.gnu.org; Thu, 26 Dec 2024 02:54:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQiha-0007Ms-JB for 74971@debbugs.gnu.org; Thu, 26 Dec 2024 02:54:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQihV-0005zg-7y; Thu, 26 Dec 2024 02:54:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nliWs9fipkhHSuRXCWaxwBZcQZMMYDjmNIa0a764AX4=; b=X7+GeQE7PrVQdqLyG4I/ tk2hSC+FqFnKIYBiG8v/chXqyd/NDjimVJaNOR/AMm1MMLhiD2GOTDRnVAjnaln0bs4Jw5ShK/LhP eOl2nWRSd/Bua4wKec/FU+Snxy3uhYZLQXducXWgo1M6TnOGyi+fd8Lqcx3HANieIZHo698xGQt1O B3W5TK0phh/3h8IFOgN8QZf87so0fM+dAvHj5byug+K54PhRF+DeWcd6tyVGcTUwYmOlPUIkEWLos j4+rz4UXlCG4MVDul5igbewBhb1cN5FLIIOdz9NFnbtdfIqIwo/bcP2DVwZv6komxpcYQ1jeWNriw nVK6COUKlB9IlA==; Date: Thu, 26 Dec 2024 09:54:31 +0200 Message-Id: <86frmazxoo.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20241219132805.9262-1-charmitro@posteo.net> (message from Charalampos Mitrodimas on Thu, 19 Dec 2024 13:28:05 +0000) References: <20241219132805.9262-1-charmitro@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Charalampos Mitrodimas > From: Charalampos Mitrodimas > Date: Thu, 19 Dec 2024 13:28:05 +0000 > > Resolve warnings caused by mismatched format specifiers in `NSLog` and > `fprintf` calls. > > This was observed when compiled with Clang version > 19.1.6 (arm64-apple-darwin). > > * src/nsterm.m: Cast `IOReturn` (aka `int`) to `unsigned int` for `%x` > format specifiers in `NSLog`. > > Warnings fixed: > - "format specifies type 'unsigned int' but the argument has type > 'IOReturn' (aka 'int')" > --- > src/nsterm.m | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/src/nsterm.m b/src/nsterm.m > index c705a3c78f4..5793bb961e8 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -6955,8 +6955,12 @@ In that case we use UCKeyTranslate (ns_get_shifted_character) > > #ifndef NS_IMPL_GNUSTEP > if (NS_KEYLOG) > - fprintf (stderr, "keyDown: code =%x\tfnKey =%x\tflags = %x\tmods = %x\n", > - code, fnKeysym, flags, emacs_event->modifiers); > + fprintf (stderr, > + "keyDown: code = %x\tfnKey = %x\tflags = %x\tmods = " > + "%x\n", > + (unsigned int) code, (unsigned int) fnKeysym, > + (unsigned int) flags, > + (unsigned int) emacs_event->modifiers); > #endif > > /* If it was a function key or had control-like modifiers, pass > @@ -10761,7 +10765,7 @@ - (CGContextRef) getContext > > IOReturn lockStatus = IOSurfaceLock (surface, 0, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to lock surface: %x", lockStatus); > + NSLog (@"Failed to lock surface: %x", (unsigned int)lockStatus); > > [self copyContentsTo:surface]; > > @@ -10808,7 +10812,7 @@ - (void) releaseContext > > IOReturn lockStatus = IOSurfaceUnlock (currentSurface, 0, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to unlock surface: %x", lockStatus); > + NSLog (@"Failed to unlock surface: %x", (unsigned int)lockStatus); > } > > > @@ -10849,7 +10853,8 @@ - (void) copyContentsTo: (IOSurfaceRef) destination > > lockStatus = IOSurfaceLock (source, kIOSurfaceLockReadOnly, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to lock source surface: %x", lockStatus); > + NSLog (@"Failed to lock source surface: %x", > + (unsigned int) lockStatus); > > sourceData = IOSurfaceGetBaseAddress (source); > destinationData = IOSurfaceGetBaseAddress (destination); > @@ -10861,7 +10866,7 @@ - (void) copyContentsTo: (IOSurfaceRef) destination > > lockStatus = IOSurfaceUnlock (source, kIOSurfaceLockReadOnly, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to unlock source surface: %x", lockStatus); > + NSLog (@"Failed to unlock source surface: %x", (unsigned int)lockStatus); > } > > #undef CACHE_MAX_SIZE > -- > 2.47.1 Thanks. Stefan and Gerd, would you please review this and advise or install? From unknown Sun Jun 15 09:00:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Charalampos Mitrodimas , Gerd =?UTF-8?Q?M=C3=B6llmann?= , Stefan Kangas Cc: 74971@debbugs.gnu.org Received: via spool by 74971-submit@debbugs.gnu.org id=B74971.173520023130183 (code B ref 74971); Thu, 26 Dec 2024 08:04:02 +0000 Received: (at 74971) by debbugs.gnu.org; 26 Dec 2024 08:03:51 +0000 Received: from localhost ([127.0.0.1]:39962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQiqV-0007qk-4h for submit@debbugs.gnu.org; Thu, 26 Dec 2024 03:03:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQiqT-0007qO-1z for 74971@debbugs.gnu.org; Thu, 26 Dec 2024 03:03:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQih6-0005x7-0B; Thu, 26 Dec 2024 02:54:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nliWs9fipkhHSuRXCWaxwBZcQZMMYDjmNIa0a764AX4=; b=crkPLf/Jt2iEprVyQNko K2Ngzcl6CLJeZuWqtBwSAttWsI7t20w3rMoMhLriZFS8E07FFTjJJf1foplVYQg4aYqkLs8Q3+GXC tO/fPYx/CHTXmV3oVnAcnTmUjMVXbwGPW9mK1miYhqvxTwc1BxI+F95bDZOWIIh0busKR6gVsiYTs AmgYYHX7rpqFvMbXvvHERs6OMTPt1twP5Ntbrv58lBLLGT+CCA1SaxcBbbXF+cvSbN4yyzPd8UiTd TVjKFJJNW4bR9eSG/TaMmiY9GQDi0+C0FMl3B0GblIsDFmkr/C3vCOhZnvPratrFofLrPbpBrzbTn vynxUIxPLWTyug==; Date: Thu, 26 Dec 2024 09:54:05 +0200 Message-Id: <86h66qzxpe.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <20241219132805.9262-1-charmitro@posteo.net> (message from Charalampos Mitrodimas on Thu, 19 Dec 2024 13:28:05 +0000) References: <20241219132805.9262-1-charmitro@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Charalampos Mitrodimas > From: Charalampos Mitrodimas > Date: Thu, 19 Dec 2024 13:28:05 +0000 > > Resolve warnings caused by mismatched format specifiers in `NSLog` and > `fprintf` calls. > > This was observed when compiled with Clang version > 19.1.6 (arm64-apple-darwin). > > * src/nsterm.m: Cast `IOReturn` (aka `int`) to `unsigned int` for `%x` > format specifiers in `NSLog`. > > Warnings fixed: > - "format specifies type 'unsigned int' but the argument has type > 'IOReturn' (aka 'int')" > --- > src/nsterm.m | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/src/nsterm.m b/src/nsterm.m > index c705a3c78f4..5793bb961e8 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -6955,8 +6955,12 @@ In that case we use UCKeyTranslate (ns_get_shifted_character) > > #ifndef NS_IMPL_GNUSTEP > if (NS_KEYLOG) > - fprintf (stderr, "keyDown: code =%x\tfnKey =%x\tflags = %x\tmods = %x\n", > - code, fnKeysym, flags, emacs_event->modifiers); > + fprintf (stderr, > + "keyDown: code = %x\tfnKey = %x\tflags = %x\tmods = " > + "%x\n", > + (unsigned int) code, (unsigned int) fnKeysym, > + (unsigned int) flags, > + (unsigned int) emacs_event->modifiers); > #endif > > /* If it was a function key or had control-like modifiers, pass > @@ -10761,7 +10765,7 @@ - (CGContextRef) getContext > > IOReturn lockStatus = IOSurfaceLock (surface, 0, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to lock surface: %x", lockStatus); > + NSLog (@"Failed to lock surface: %x", (unsigned int)lockStatus); > > [self copyContentsTo:surface]; > > @@ -10808,7 +10812,7 @@ - (void) releaseContext > > IOReturn lockStatus = IOSurfaceUnlock (currentSurface, 0, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to unlock surface: %x", lockStatus); > + NSLog (@"Failed to unlock surface: %x", (unsigned int)lockStatus); > } > > > @@ -10849,7 +10853,8 @@ - (void) copyContentsTo: (IOSurfaceRef) destination > > lockStatus = IOSurfaceLock (source, kIOSurfaceLockReadOnly, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to lock source surface: %x", lockStatus); > + NSLog (@"Failed to lock source surface: %x", > + (unsigned int) lockStatus); > > sourceData = IOSurfaceGetBaseAddress (source); > destinationData = IOSurfaceGetBaseAddress (destination); > @@ -10861,7 +10866,7 @@ - (void) copyContentsTo: (IOSurfaceRef) destination > > lockStatus = IOSurfaceUnlock (source, kIOSurfaceLockReadOnly, nil); > if (lockStatus != kIOReturnSuccess) > - NSLog (@"Failed to unlock source surface: %x", lockStatus); > + NSLog (@"Failed to unlock source surface: %x", (unsigned int)lockStatus); > } > > #undef CACHE_MAX_SIZE > -- > 2.47.1 Thanks. Stefan and Gerd, would you please review this and advise or install? From unknown Sun Jun 15 09:00:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2024 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Charalampos Mitrodimas , Stefan Kangas , 74971@debbugs.gnu.org Received: via spool by 74971-submit@debbugs.gnu.org id=B74971.173520079131881 (code B ref 74971); Thu, 26 Dec 2024 08:14:02 +0000 Received: (at 74971) by debbugs.gnu.org; 26 Dec 2024 08:13:11 +0000 Received: from localhost ([127.0.0.1]:39980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQizW-0008I9-PS for submit@debbugs.gnu.org; Thu, 26 Dec 2024 03:13:11 -0500 Received: from mail-ej1-f53.google.com ([209.85.218.53]:46261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQizU-0008Hv-LX for 74971@debbugs.gnu.org; Thu, 26 Dec 2024 03:13:09 -0500 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aa67333f7d2so931741466b.0 for <74971@debbugs.gnu.org>; Thu, 26 Dec 2024 00:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735200723; x=1735805523; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+zjIjbikLrznOiEhHXp/jajEBDwcB71pIoyBNwHLYgI=; b=US6hGyBu1wo4drJ2wPNlAVT+SWB50C6xLp8bLpW+iJLEMr/XOmtMQfmbcDmatsKluZ TAbMfusR6cdw7qxdvJqBdnsaTdbpGbbUbJmAeNBn6JQ+r0sTzeXcXNX+AwX/ME2Ywef9 kdk7XV3AiZEoSXMw66OKcjtdX66md+Qq+z0UajvqpGyn8YBK0lWin63KNIpfd6IFatIE 5jGEKyigJvQexlPUecVWPdYIGnUcFLixrdeeKX9dQbFMvbZllmdiVFEDD1E7RjTapxmQ 2PBDOxu3a1ynCo2ppwG+4iCayrIjBSXNZ5nn801Jx62gzwDluXsWeXkIcAVTWflJKKFe tDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735200723; x=1735805523; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+zjIjbikLrznOiEhHXp/jajEBDwcB71pIoyBNwHLYgI=; b=oiIkgyBE8e3PDM+vMs7enizClIMfBvfMhiMGDYLKkA5Vf48qHXUFbYy+mxbedFSdKh evqu16cVi2V1KrtaQzQxl3fpiamQ4WEyxIIH18w7uArzdnpoFnKu+fev13+6A2PTtQvk r6iszD5FQ8EQTO29SJ+5xD0nxEBvgmyaqtVLErTE60jL2ftDEZAdqGRw3Zw5sYot2n9T nwr7jngpugiuhD5q5Od2OhmcP9WGFZ3rU25mWLC0lr72YoetXVQyqtFD8h4BT7jLbNOz EyQQbxBAQhsnubbcekJc0aZ9cCLGr+QY07W2ziN8SY9epacUU6APLBDWeYxvamIehgCv LyfA== X-Forwarded-Encrypted: i=1; AJvYcCX05WayUNhQI5j5/HWk0xQ+7v9PTKeDxV8D/grUKBnUsIUVhajxd3knRXBgRJN6bsltH/VbJQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwTxRrM/ca2JAjNXhFz3791b1NJt8HScRtk+S9N+aMtALItUP7H gXTW7v+ULqYHJSBj/c65rT/z1crtKxUqu92SZueEITKNNWi0dnUFlc6j+A== X-Gm-Gg: ASbGncvTuC3a1k+/b1GGsC9rJcctQ5Bx6dqinAURp+ylDl5io8wUSxQZ6HZqMeYtZwH WPxwOtNcGAd7VNSsw05/UakBZv7tVpUdk9JbsyRGeTp+is5dYYW0Mi5OzkGRWFQPGXs62H28xm0 O3NzBJZbbzZ9IF+/Rl26tPYzVPlUfmJeA90u4yjhPJcwNxCxmwb7bp7bQetGSnopmlts69Wc9yR AJnmVigz4ZMoMPWHAZRjF6TOLMK6mlPIBi4JrsGc48FW/whcw9puh2sMmWC9Z1Z727Yd7DCDe7g ZUKCkqubz8xHlqxpPOGY+Zc5qCbIzbE4vP2YvJ1L6vjWvVNC5p9J5dUB2mJy0jLVQQ== X-Google-Smtp-Source: AGHT+IGL+tBZdKPrlHfNG8oHtpgRN67VgOafyRT8SAa72jPssH6KqHJGgRP2lubd6XOvbD0b7w6JLw== X-Received: by 2002:a17:907:9715:b0:aac:619:e914 with SMTP id a640c23a62f3a-aac2ad88fcfmr2113860266b.16.1735200722430; Thu, 26 Dec 2024 00:12:02 -0800 (PST) Received: from pro2 (p200300e0b747910049c6927f9e8bb023.dip0.t-ipconnect.de. [2003:e0:b747:9100:49c6:927f:9e8b:b023]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e89490dsm907158166b.45.2024.12.26.00.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 00:12:02 -0800 (PST) From: Gerd =?UTF-8?Q?M=C3=B6llmann?= In-Reply-To: <86h66qzxpe.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Dec 2024 09:54:05 +0200") References: <20241219132805.9262-1-charmitro@posteo.net> <86h66qzxpe.fsf@gnu.org> Date: Thu, 26 Dec 2024 09:12:01 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Stefan and Gerd, would you please review this and advise or install? LGTM. Apparently clang 19 became more picky. From unknown Sun Jun 15 09:00:03 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Charalampos Mitrodimas Subject: bug#74971: closed (Re: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m) Message-ID: References: <20241219132805.9262-1-charmitro@posteo.net> X-Gnu-PR-Message: they-closed 74971 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 74971@debbugs.gnu.org Date: Thu, 26 Dec 2024 15:15:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1735226103-11975-1" This is a multi-part message in MIME format... ------------=_1735226103-11975-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74971: [PATCH] Fix format specifier warnings in nsterm.m which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74971@debbugs.gnu.org. --=20 74971: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74971 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1735226103-11975-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74971-done) by debbugs.gnu.org; 26 Dec 2024 15:14:15 +0000 Received: from localhost ([127.0.0.1]:41878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQpZ1-00035c-Au for submit@debbugs.gnu.org; Thu, 26 Dec 2024 10:14:15 -0500 Received: from mail-ed1-f44.google.com ([209.85.208.44]:59667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQpYw-00035M-1I for 74971-done@debbugs.gnu.org; Thu, 26 Dec 2024 10:14:13 -0500 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5d3e8f64d5dso11267857a12.3 for <74971-done@debbugs.gnu.org>; Thu, 26 Dec 2024 07:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735225989; x=1735830789; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=kr7YFWBZYzMNhUmYmxImkTaNT1uMhURlsmWFquS+DUA=; b=PNFGm69NItVDb+A9wXqQsPNbAOMQ8hXCqyZuPgL3A2u+BIcxxIce1R1F0LLXi1zFol e1p5iErlKD+ezDJX4hWSlNkPPkXhXlOtz3SF1NYd4GoflOBXcYobEkJ1Kib577ogMSCL e6lR8YqnfZWv9rKq/Jq9TzZgWALo87xs1EI5FEOjLoyM+kNqYqhQzECXaAjB90QwtR3f 8p1WjR+7BsiCWmvWqBW44t+MnrMHgupDQ17RiexcH0wUDI1FnvykpgBak08qdHdUJ72M mvgnwnWZ9l2Q5hAI3NGbDLYnauRK9j/Irpna1Hp65KBhv2vgZUf/t5zdmDP7mFqERde9 sEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735225989; x=1735830789; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kr7YFWBZYzMNhUmYmxImkTaNT1uMhURlsmWFquS+DUA=; b=lLLZg8NGEvviFNeGAIjfoGxxUBXGOZwP3Ora4G4hggpRO8KLOqU1VfE+E2r7RoQ6TJ mxnw/Hb7Lasi08FP6w0QOGhpL5cJTZGo2i5gZ3SRj2y4LFKjwGC4UB8f748CkzpGzGnd ALyJywA2f5urIZosThsRpRxLsOo9TVq65BVhUG+lZiKtdZO0j2QXerAabplZPGpqIrER fTstOLQXyteQAYRjG9K9gM5QEoNK8+FpHAvYCLnKsDizVrxIUOvYkPf1UXnNkvfaoGCG ggXulmF+z/jeiUV+n0ZIN+COvP3BwC0fLcoFpOInmi2ALs5Jsf8dey+V2m7Z+r6kgQyO hhww== X-Forwarded-Encrypted: i=1; AJvYcCVyuFBY9LExYxcUNSJto0coQJ9wyzXY5hqzO8+pBpUIN2CTloPDNfoXisOJ4UnHfJstfsM5z8Ru786m@debbugs.gnu.org X-Gm-Message-State: AOJu0YzdcKR/ZgoXvZT5KVnWhrY0DlzZfrIta8Kwq8Yg62OEK4f1H4nR IVciS7e3LDtGsr7gxU9RcbU6vz4Qv0lO7CrlXryPnYDjgOt40gHImwRpYoK48uBUD6xHmiW58+7 UmONLvjanpl947FzFHA/Lse1S+U4= X-Gm-Gg: ASbGncvufSFsq/RipQYhruviwG4H1skAxFmt8WcwGjdjHe4bvkjoYlF713FDsWoiHxl x0VurgVaGZJKnszwMPls1lZZhciy2ESpIQCNcTf8= X-Google-Smtp-Source: AGHT+IEJHmHeXKY/vDBUf5IuzMbDKp7pVykiYzRqWlxS9m/QwrP6SmGnmMLQQUNUPuWlyTixuM5RhmnV+j4+MXaWZ1g= X-Received: by 2002:a05:6402:321b:b0:5d3:bc56:3b24 with SMTP id 4fb4d7f45d1cf-5d81ddd6558mr24324691a12.4.1735225989001; Thu, 26 Dec 2024 07:13:09 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 26 Dec 2024 15:13:08 +0000 From: Stefan Kangas In-Reply-To: References: <20241219132805.9262-1-charmitro@posteo.net> <86h66qzxpe.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 26 Dec 2024 15:13:08 +0000 Message-ID: Subject: Re: bug#74971: [PATCH] Fix format specifier warnings in nsterm.m To: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74971-done Cc: Charalampos Mitrodimas , 74971-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Gerd M=C3=B6llmann writes: > Eli Zaretskii writes: > >> Stefan and Gerd, would you please review this and advise or install? > > LGTM. Apparently clang 19 became more picky. Thanks, installed on master as commit ab388851569. Closing. ------------=_1735226103-11975-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 13:28:22 +0000 Received: from localhost ([127.0.0.1]:37917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOGZi-0008CW-D2 for submit@debbugs.gnu.org; Thu, 19 Dec 2024 08:28:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:58946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOGZf-0008CO-Vu for submit@debbugs.gnu.org; Thu, 19 Dec 2024 08:28:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGZf-0004Ja-KB for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 08:28:19 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOGZd-0006I0-OP for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 08:28:19 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 69FE5240027 for ; Thu, 19 Dec 2024 14:28:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734614893; bh=DdmDatiV2sTHJI7O443mjrHj8kCPaZv2zTS8O13XeOM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=q+FTi3Kv2aa32zdzxtZHkjolTc0he/6Aqqkj9CTSLbrpx5Izbx2jdugd3ajWd6U7D hJ+KhA8w3r3MQnT7BZKpJE07n/6tnEsN+JEjyflDLEDVHZQpEzmeRrC3QxyV3MqCW/ DT52IOL9cUbqRSPqa1hVVkxo6HyTxxgDe2DtI7Sg8bYzYc8e94D7OEgAk50e8bJC3v 4sMp4FYgPZ9+b85urmLAgPLUYkAF31S5cnQFbvhfdvOTS5X5d/D55bgKPP/xmI2347 5Vzi56Sj8nwzbFp7c3TP2N8UDaCNe5R3EEsNKL6CBWqqw2oBn556gHTwlRVq4LTsnn yMaN7uFCoUnjw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YDWZh50llz6tsb; Thu, 19 Dec 2024 14:28:12 +0100 (CET) From: Charalampos Mitrodimas To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix format specifier warnings in nsterm.m Date: Thu, 19 Dec 2024 13:28:05 +0000 Message-ID: <20241219132805.9262-1-charmitro@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=charmitro@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Charalampos Mitrodimas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Resolve warnings caused by mismatched format specifiers in `NSLog` and `fprintf` calls. This was observed when compiled with Clang version 19.1.6 (arm64-apple-darwin). * src/nsterm.m: Cast `IOReturn` (aka `int`) to `unsigned int` for `%x` format specifiers in `NSLog`. Warnings fixed: - "format specifies type 'unsigned int' but the argument has type 'IOReturn' (aka 'int')" --- src/nsterm.m | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index c705a3c78f4..5793bb961e8 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -6955,8 +6955,12 @@ In that case we use UCKeyTranslate (ns_get_shifted_character) #ifndef NS_IMPL_GNUSTEP if (NS_KEYLOG) - fprintf (stderr, "keyDown: code =%x\tfnKey =%x\tflags = %x\tmods = %x\n", - code, fnKeysym, flags, emacs_event->modifiers); + fprintf (stderr, + "keyDown: code = %x\tfnKey = %x\tflags = %x\tmods = " + "%x\n", + (unsigned int) code, (unsigned int) fnKeysym, + (unsigned int) flags, + (unsigned int) emacs_event->modifiers); #endif /* If it was a function key or had control-like modifiers, pass @@ -10761,7 +10765,7 @@ - (CGContextRef) getContext IOReturn lockStatus = IOSurfaceLock (surface, 0, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to lock surface: %x", lockStatus); + NSLog (@"Failed to lock surface: %x", (unsigned int)lockStatus); [self copyContentsTo:surface]; @@ -10808,7 +10812,7 @@ - (void) releaseContext IOReturn lockStatus = IOSurfaceUnlock (currentSurface, 0, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to unlock surface: %x", lockStatus); + NSLog (@"Failed to unlock surface: %x", (unsigned int)lockStatus); } @@ -10849,7 +10853,8 @@ - (void) copyContentsTo: (IOSurfaceRef) destination lockStatus = IOSurfaceLock (source, kIOSurfaceLockReadOnly, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to lock source surface: %x", lockStatus); + NSLog (@"Failed to lock source surface: %x", + (unsigned int) lockStatus); sourceData = IOSurfaceGetBaseAddress (source); destinationData = IOSurfaceGetBaseAddress (destination); @@ -10861,7 +10866,7 @@ - (void) copyContentsTo: (IOSurfaceRef) destination lockStatus = IOSurfaceUnlock (source, kIOSurfaceLockReadOnly, nil); if (lockStatus != kIOReturnSuccess) - NSLog (@"Failed to unlock source surface: %x", lockStatus); + NSLog (@"Failed to unlock source surface: %x", (unsigned int)lockStatus); } #undef CACHE_MAX_SIZE -- 2.47.1 ------------=_1735226103-11975-1--