From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2024 07:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 74964@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1734594857467 (code B ref -1); Thu, 19 Dec 2024 07:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 07:54:17 +0000 Received: from localhost ([127.0.0.1]:37306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBMP-00007T-E3 for submit@debbugs.gnu.org; Thu, 19 Dec 2024 02:54:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:41996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBMN-00007K-KM for submit@debbugs.gnu.org; Thu, 19 Dec 2024 02:54:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOBMN-0003We-E8 for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 02:54:15 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOBML-0004YU-Pz for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 02:54:14 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-436202dd730so3128795e9.2 for ; Wed, 18 Dec 2024 23:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1734594851; x=1735199651; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MuGBwAoctzWd9f8ZCw+/Nmpi9QshsPtpVynGgJESsAc=; b=cV1g+oxGdVGUJVgYyOQG2GQDHJFGwTUcso1d+DC57goorzPARck109e/zbGFdzaVfO raqQP8SaBWkxiljrvs9dsMljUByIAP1K/FGy0krgyCIv7d9HwS0ggevHOa3M2Cij84Hp rDJd+3Goaxov9XD8tOP1yuifkTifTfeys1yRqQh86DPPWUCSa7X5FDX6PPLp5zLE/vBT 6eNqhSEXjJr6QazP9YOJZR34h3WqezLVkDWZGItPN9zuCT5PSt+OpfTWyYmxOHRr411S X0s9L7GFeBffKVkm7o1Ztp7zn1auHJA9Vl/lVBgHPzQAVzCJmtQISTnPL3d0P5vgcZ39 be0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734594851; x=1735199651; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MuGBwAoctzWd9f8ZCw+/Nmpi9QshsPtpVynGgJESsAc=; b=vg7AeRu+Loa6WhhqXFV5hKPgHq6/lMkXMwcczwaIKOHLwWyvGRqwUZLCeq5taOXOV/ DZug9AdadiUAvOzMyImxWrMfnCGKkLI8gYMj6B7G46LvocT3XcE4h3g9+pxKuXuxE4Dg VHk0K/72fR/FJzygy4KWqKNW9ipW0n9raXSyPsXtDoeGrXYh+zLv2gXE60scPwXNwzSx O/5sB08U3IR6z9s9P3+yEYYVoDW1Bg4R7OdPvz4Jq8qTxBKJ2StXJS0Xv+h/Z6CRS8pK GdQ44IK2uabt9yjlOtZNcnUTG0lzJNoHlwIy3ybCwtiq/v3iWSL9J3CjbQjJKoZAgA9+ ceDg== X-Gm-Message-State: AOJu0YzNFUgg97zh3E8w5b2GGr7Y2/btKwEfTgX3v5xyCVF9V1Uj2hBt pOoI1iTJvii+VGpORRvblvN6kMXQ3wp9vgxmVVyhcdpjd7r2cqmcjfa6mL+32CuGS027/KGiL2K DW3kVAauTkyX9/4CsP8zd1lZavmwHcDutV+28Fmaj8iX625CEugnFoQ== X-Gm-Gg: ASbGnct9HI01wzzxZKk9GwUvlFD8wr4nXz+deHUaWRFop6JvwukxhaF5183H7s5ljFP VuwDfKTN5ttuuhYZ8FLdILREZdNFmmhbyx0yX4GYr9ug/W5cKK5ckrBYgM3mIFPoVp77djuuw X-Google-Smtp-Source: AGHT+IEJmOU4j4lm7D9LovBNMDwGMZ3j6TaN9MTFKga18zWRuS7PupbuXD2NyT8E+Ttr97bJLP7CbEfNHoJulDq1aWc= X-Received: by 2002:a05:600c:4fc5:b0:435:192:63ca with SMTP id 5b1f17b1804b1-436553f4d35mr49091895e9.21.1734594850329; Wed, 18 Dec 2024 23:54:10 -0800 (PST) MIME-Version: 1.0 From: Yikai Zhao Date: Thu, 19 Dec 2024 15:53:58 +0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=i@blahgeek.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) How to reproduce: With following content in /tmp/test/.dir-locals.el: ((nil . ((my/test . "test"))) (c-mode . ((eval . (when (eq major-mode 'c-mode) (c++-mode)))))) ;; I use this code because I want my projects' .h files always opened in c++ mode Then open a new file test.c in the folder. Expected behavior: my/test variable is set. Actual behavior: my/test variable is not set. Emacs 29 and 30 does give me the expected result. From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Yikai Zhao , 74964@debbugs.gnu.org Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.17347116804223 (code B ref 74964); Fri, 20 Dec 2024 16:22:02 +0000 Received: (at 74964) by debbugs.gnu.org; 20 Dec 2024 16:21:20 +0000 Received: from localhost ([127.0.0.1]:43768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfke-000162-0v for submit@debbugs.gnu.org; Fri, 20 Dec 2024 11:21:20 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:53249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfkb-00015m-K9 for 74964@debbugs.gnu.org; Fri, 20 Dec 2024 11:21:18 -0500 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43624b2d453so22705215e9.2 for <74964@debbugs.gnu.org>; Fri, 20 Dec 2024 08:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734711612; x=1735316412; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ytGZ0nI53VBxEzcjd3viq0QEuZU3im5u1tYkU2H4xBc=; b=NyS5DIWGqEuPP+m2uqRi7Z/KJDzo50UTztUBS2RVLauRimkqk3wUaX1207HbLussZ1 phsAM59R9UOjh7F4i3T0rzkoWF9S/1wneZqA7OWA/3AQVAU096MBlGTujOBx68wm49op nnKLkPJ81SE0IP+CcuGsNg3n1FEuQzt4lOlHDxiSUgaQM6gbfR5Ht6i74aLmBuTxys22 H6wN2D9a5pnJR1mj3DoZIuAAKF/kz+UOSk1wVXtvJIkBPYKhAM23PF/wpwsyE+E9PraR PFEg9j+hUncZGKfBBxoi6ebr7MFNN8g5jtFU/1C/9j6hhqOwdXdlgRRYuhLkmvzhvd7n szMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734711612; x=1735316412; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ytGZ0nI53VBxEzcjd3viq0QEuZU3im5u1tYkU2H4xBc=; b=JU9Bh0+lFy/cH/ytXirv6Qe0/vhfdEJ9HGNZ0bilZUWQjbFGLcNbMI5x6WnzTeFS0n W1nMmVxyDDYeYSWZQvR1pel9V2ApTYhDVrE/al6bGTz0E0Za/sGxsEcL1rFjIbHhjKWJ ry/6HfKOfWIki+0IkiQbYgTuFUbvg1qUFwb019bO4i13gDbVTzNy4cwd2hgFULtEx2UF hTDeh0PrbjNpZbmkgd+jX82K0U+0JfRroN9+9p+LxtT4sp1WQwIaI4xfvdI2Kt8ik2sN x9WF8S8YjwMNrBQ8lLYaV85DlX8iK7eoOMuNXB3uSOi4QaW2Jmzg6d5qJkvmZjcuL2Ba 2qjg== X-Gm-Message-State: AOJu0Yx0/I15nlZlCks2EHiIiK1L4uYjO3qjfm3qEnsWGRQ/U8wO3WI2 4a686/+85TSmdbpqpTVs4KtqTl3vbs3VBNkpK5fDwzwmj6yM/o0t X-Gm-Gg: ASbGncuYsEoazG5bFGEpOEMctFbjdQf9/pGjFfTfeGwl+Dl1Aj72Q4CwUhLxSbRf0iZ +w4k/+tSm4kZseA6+9bnyRKGylMG4lpZlvFJaNu5qcRwL6QS5+/zO2TAHA3L7wLGsZrEO/5187H VyY8Kks4SHSBWYXu8joSCJvu9iphiXwPhLx0C5yAUjO4Ru5KLs/yg+gA57abDH6lxwjFJ2phKKD ui3XyywZygYGestjaFaNzQ1UqpzEK6n3bcgaRdQL4yX X-Google-Smtp-Source: AGHT+IHF7ouBlRFKoyQeX46hxigSLibzGetOCC0uzL4mMpELNZ4Q1dCr/3H6DcQqcHYkSHdxLXkTaQ== X-Received: by 2002:a05:600c:1c95:b0:434:a1d3:a321 with SMTP id 5b1f17b1804b1-4366835c1b0mr36967085e9.3.1734711611564; Fri, 20 Dec 2024 08:20:11 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:6b71:e408:124e:fe15]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656af6c4esm83710115e9.4.2024.12.20.08.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 08:20:11 -0800 (PST) From: Robert Pluim In-Reply-To: (Yikai Zhao's message of "Thu, 19 Dec 2024 15:53:58 +0800") References: Date: Fri, 20 Dec 2024 17:20:10 +0100 Message-ID: <87zfkqtjgl.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 19 Dec 2024 15:53:58 +0800, Yikai Zhao said: Yikai> How to reproduce: Yikai> With following content in /tmp/test/.dir-locals.el: Yikai> ((nil . ((my/test . "test"))) Yikai> (c-mode . ((eval . (when (eq major-mode 'c-mode) Yikai> (c++-mode)))))) Yikai> ;; I use this code because I want my projects' .h files always opened Yikai> in c++ mode Yikai> Then open a new file test.c in the folder. Yikai> Expected behavior: my/test variable is set. Yikai> Actual behavior: my/test variable is not set. Yikai> Emacs 29 and 30 does give me the expected result. Stefan, reverting f713258416f (Bug#74349) fixes this Robert -- From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 03:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Yikai Zhao , 74964@debbugs.gnu.org Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.17348385804473 (code B ref 74964); Sun, 22 Dec 2024 03:37:01 +0000 Received: (at 74964) by debbugs.gnu.org; 22 Dec 2024 03:36:20 +0000 Received: from localhost ([127.0.0.1]:48608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPClP-0001A4-NN for submit@debbugs.gnu.org; Sat, 21 Dec 2024 22:36:20 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPClN-00019j-8e for 74964@debbugs.gnu.org; Sat, 21 Dec 2024 22:36:18 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7366C80834; Sat, 21 Dec 2024 22:36:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734838569; bh=o1CzJtbdRHa/4tlUHKOyqO21gtu5HazFa1RigVeFBK8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JXyXyFELohkhiN2+aiq14NndIqirOOplwuhNV5zs5llLyyXUN4kFy4z1VqqcUi8XH 86v5ny/qBEdoX1CRYOQij0428E4aJSsXsFjCmNMBs+v8BfQyPD9XsVwoONlpQ7AYH1 qNjeNggLBk6B/OBnGIO2Jr6l19YyvTZglW7NfB69VJGYWB2jtC/iP0mPKAAQZ13LCe tmg72f2rlQFXpG72v/vAdAS5c3g1XXDgILgrQgO37wJkMeroEIH9RQdpX9UB5Zhn5Z Ng2klMjvo+oV53i4wzIstIV8xL+h+Ui/BrF4clgd3alt0o0edX3KUJ0d8yF8zlosBe kJKUNAVqELDaA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7E38A80039; Sat, 21 Dec 2024 22:36:09 -0500 (EST) Received: from asado (unknown [199.119.74.1]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3AFF71204C9; Sat, 21 Dec 2024 22:36:09 -0500 (EST) From: Stefan Monnier In-Reply-To: <87zfkqtjgl.fsf@gmail.com> (Robert Pluim's message of "Fri, 20 Dec 2024 17:20:10 +0100") Message-ID: References: <87zfkqtjgl.fsf@gmail.com> Date: Sat, 21 Dec 2024 22:36:07 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.400 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>>> On Thu, 19 Dec 2024 15:53:58 +0800, Yikai Zhao said: > > Yikai> How to reproduce: > Yikai> With following content in /tmp/test/.dir-locals.el: > > Yikai> ((nil . ((my/test . "test"))) > Yikai> (c-mode . ((eval . (when (eq major-mode 'c-mode) > Yikai> (c++-mode)))))) > Yikai> ;; I use this code because I want my projects' .h files always opened > Yikai> in c++ mode We need to offer our users a better solution than such a hack. E.g. a dir-local way to set `auto-mode-alist` and/or `major-mode-remap-alist`. > Stefan, reverting f713258416f (Bug#74349) fixes this How 'bout a patch like the one below? Stefan diff --git a/lisp/files.el b/lisp/files.el index c92fc0608dd..594ee83efbe 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -4488,11 +4485,15 @@ hack-one-local-variable--obsolete (substitute-command-keys instead) (format-message "use `%s' instead" instead))))))) +(defvar hack-local-variables--inhibit nil + "List of file/dir local variables to ignore.") + (defun hack-one-local-variable (var val) "Set local variable VAR with value VAL. If VAR is `mode', call `VAL-mode' as a function unless it's already the major mode." (pcase var + ((guard (memq var hack-local-variables--inhibit)) nil) ('mode (let ((mode (intern (concat (downcase (symbol-name val)) "-mode")))) @@ -4500,7 +4501,8 @@ hack-one-local-variable ('eval (pcase val (`(add-hook ',hook . ,_) (hack-one-local-variable--obsolete hook))) - (let ((enable-local-variables nil)) ;FIXME: Should be buffer-local! + (let ((hack-local-variables--inhibit ;; FIXME: Should be buffer-local! + (cons 'eval hack-local-variables--inhibit))) (save-excursion (eval val t)))) (_ (hack-one-local-variable--obsolete var) From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , yikai@z1k.dev Cc: rpluim@gmail.com, 74964@debbugs.gnu.org Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.173599094212040 (code B ref 74964); Sat, 04 Jan 2025 11:43:01 +0000 Received: (at 74964) by debbugs.gnu.org; 4 Jan 2025 11:42:22 +0000 Received: from localhost ([127.0.0.1]:53654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU2Xu-000388-CI for submit@debbugs.gnu.org; Sat, 04 Jan 2025 06:42:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59290) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU2Xs-00037r-18 for 74964@debbugs.gnu.org; Sat, 04 Jan 2025 06:42:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU2Xm-0002yb-8I; Sat, 04 Jan 2025 06:42:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ym+4iLeYp/RDQ47FIn6V+JVUEnhAGy5qg1+GilZ+5xY=; b=GRXJn35UXbzN edUeF+Ar1BS8dPM67mwAJ+23P6U1Js8SVT34E/CZb4fDLJpAEbf+XVnVnZqyck3vGZBCFrkOUG1GE 2rJ508cLkBqCsogJyMet4+8MRZbvBRyiLipbfA20S4ZCqvfp6c5yZ3oaqdhiq0N0wWOUIe7NvNgJU WMAaQuUpO7b6rPTLRy9lKvFEd15WnjZ4avKMFU1VRN7fzlesHbKEE1OYcpDexuQFoEssXoR5mJp8D p/jagcqCmXKRCcR4zw4jQcO2yOL6wjwAbCtrJdZ8L/f4ZweSTAxYd46x/0xrSvouyM4G1BytaIy5j t0LGzXxipk862NAWHFWKMQ==; Date: Sat, 04 Jan 2025 13:42:11 +0200 Message-Id: <86jzbaerfw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: <87zfkqtjgl.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! > Cc: Yikai Zhao , 74964@debbugs.gnu.org > Date: Sat, 21 Dec 2024 22:36:07 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > >>>>>> On Thu, 19 Dec 2024 15:53:58 +0800, Yikai Zhao said: > > > > Yikai> How to reproduce: > > Yikai> With following content in /tmp/test/.dir-locals.el: > > > > Yikai> ((nil . ((my/test . "test"))) > > Yikai> (c-mode . ((eval . (when (eq major-mode 'c-mode) > > Yikai> (c++-mode)))))) > > Yikai> ;; I use this code because I want my projects' .h files always opened > > Yikai> in c++ mode > > We need to offer our users a better solution than such a hack. > E.g. a dir-local way to set `auto-mode-alist` and/or `major-mode-remap-alist`. > > > Stefan, reverting f713258416f (Bug#74349) fixes this > > How 'bout a patch like the one below? > > > Stefan > > > diff --git a/lisp/files.el b/lisp/files.el > index c92fc0608dd..594ee83efbe 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -4488,11 +4485,15 @@ hack-one-local-variable--obsolete > (substitute-command-keys instead) > (format-message "use `%s' instead" instead))))))) > > +(defvar hack-local-variables--inhibit nil > + "List of file/dir local variables to ignore.") > + > (defun hack-one-local-variable (var val) > "Set local variable VAR with value VAL. > If VAR is `mode', call `VAL-mode' as a function unless it's > already the major mode." > (pcase var > + ((guard (memq var hack-local-variables--inhibit)) nil) > ('mode > (let ((mode (intern (concat (downcase (symbol-name val)) > "-mode")))) > @@ -4500,7 +4501,8 @@ hack-one-local-variable > ('eval > (pcase val > (`(add-hook ',hook . ,_) (hack-one-local-variable--obsolete hook))) > - (let ((enable-local-variables nil)) ;FIXME: Should be buffer-local! > + (let ((hack-local-variables--inhibit ;; FIXME: Should be buffer-local! > + (cons 'eval hack-local-variables--inhibit))) > (save-excursion (eval val t)))) > (_ > (hack-one-local-variable--obsolete var) > > > > > From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: rpluim@gmail.com, 74964@debbugs.gnu.org, Stefan Monnier Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.173606414710842 (code B ref 74964); Sun, 05 Jan 2025 08:03:02 +0000 Received: (at 74964) by debbugs.gnu.org; 5 Jan 2025 08:02:27 +0000 Received: from localhost ([127.0.0.1]:59670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tULad-0002oo-0X for submit@debbugs.gnu.org; Sun, 05 Jan 2025 03:02:27 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:54349) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tULaa-0002oF-0w for 74964@debbugs.gnu.org; Sun, 05 Jan 2025 03:02:25 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-436326dcb1cso88842555e9.0 for <74964@debbugs.gnu.org>; Sun, 05 Jan 2025 00:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1736064138; x=1736668938; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PiVpZaQR7Id/BZAUr/yEmBGvqkM10CyhT3grjOmX8o0=; b=cHAujG+xFtOOGPlDjMcRQLQFWtiWHhuWyGl6MYjy0Ap/mKmKqKo+ce05DZDHkb5+jH lmAf5oYuIoKrOIvAHeMFFQ/R9ZdbZumekV1iEyUSR0rw786+QFgpOlsjTo7xL0ZI3SwW YeQHaEwFDNV2KrbmfBnQaADWpqFPg479rYQwLdHc5UlbX8ygQgaH6g6jGf36FH8lksqk mWU5JkcH2k97jQdKFyb0oB8vkGe6GH0/lZmgflcwpmpK9/A8cOLFMoqssJQXfMFQSiPx oQA2k41elvIJmhUfmEOiRGm6hjmpTn5AlZ8fcSGk9lCw2X27p0utGGtv0HEUrLWjHyPa JoiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736064138; x=1736668938; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PiVpZaQR7Id/BZAUr/yEmBGvqkM10CyhT3grjOmX8o0=; b=u5C/PPTuax84t7t5EGErrFKKZ29ZAIcD+MrrJ/sFu2hR8SiHUw7uL82PCERAzVPc+D 4AvChmyVpGKjY3iIt8fuAD4FMXxhJOQ5SEOlSp+cjNacjSNBWInRbh8JVjGGCw3Z0LRE mFGwpc4E6NVLCi1JgV621bP/SJXbqx9aIP0XmZ+C0F2EqL5tdYHiwKul/nc3TsVAxaKN MDEyKd41OQcdET6jm2Lkr7UFPA8LpapBhuHk007kzTkmPDdQ+ogahxrlzJmnwisXpEct rrkbtZ4itkByRB1dKd16RMPKT1r/B/LSA+C06x2EbVRy7wI/tFotjvSUDns6Hn0yW1+s NYUA== X-Forwarded-Encrypted: i=1; AJvYcCXmOzI9YiD7T/Fe/tLVA46AxU4/nyscfIiXSGhWszwPNDr8JARHlXgqczv9obeNariXWXS5tg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwXVsp7noB8yGYEaERYBV+NCRVu50pEtOWnzRJTLCD9pnXJmxT2 eYzLez5UBtUwlOmnlstWNNK+rbb9KjyyGx03zxggFS1b1dnQ0eGG4YIoBJWco9ct18M8ZKwyvr+ TbwXXGWR5El/KM15zxUOzhP7tjJlhnflJ6mDYSg== X-Gm-Gg: ASbGncsBimjUbXNwB2e/4LzF/ukjsN/n0re6IctY6L+EAk8oZlZDkMAqpgxmX/z6m5J TwxxQd2Rja9ovfF4Hb76l/xjCyEZhqEN34eOtrEgLxvtrH7qxhFLsr8e5lVLUPGKhNUZGStxM X-Google-Smtp-Source: AGHT+IHpn1OfT1yl7hLnWm479igeTLB2715SW1n3yhFRGvt8TedFyNKAsfPYKEhA0GB75W5Anj3m5nEdKHtUD67pXy8= X-Received: by 2002:a05:600c:3b9d:b0:436:6160:5b81 with SMTP id 5b1f17b1804b1-43668643bd7mr456601125e9.14.1736064137799; Sun, 05 Jan 2025 00:02:17 -0800 (PST) MIME-Version: 1.0 References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> In-Reply-To: <86jzbaerfw.fsf@gnu.org> From: Yikai Zhao Date: Sun, 5 Jan 2025 16:02:06 +0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This patch does fix the issue for me. Thanks. On Sat, Jan 4, 2025 at 7:42=E2=80=AFPM Eli Zaretskii wrote: > > Ping! > > > Cc: Yikai Zhao , 74964@debbugs.gnu.org > > Date: Sat, 21 Dec 2024 22:36:07 -0500 > > From: Stefan Monnier via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > >>>>>> On Thu, 19 Dec 2024 15:53:58 +0800, Yikai Zhao s= aid: > > > > > > Yikai> How to reproduce: > > > Yikai> With following content in /tmp/test/.dir-locals.el: > > > > > > Yikai> ((nil . ((my/test . "test"))) > > > Yikai> (c-mode . ((eval . (when (eq major-mode 'c-mode) > > > Yikai> (c++-mode)))))) > > > Yikai> ;; I use this code because I want my projects' .h files al= ways opened > > > Yikai> in c++ mode > > > > We need to offer our users a better solution than such a hack. > > E.g. a dir-local way to set `auto-mode-alist` and/or `major-mode-remap-= alist`. > > > > > Stefan, reverting f713258416f (Bug#74349) fixes this > > > > How 'bout a patch like the one below? > > > > > > Stefan > > > > > > diff --git a/lisp/files.el b/lisp/files.el > > index c92fc0608dd..594ee83efbe 100644 > > --- a/lisp/files.el > > +++ b/lisp/files.el > > @@ -4488,11 +4485,15 @@ hack-one-local-variable--obsolete > > (substitute-command-keys instead) > > (format-message "use `%s' instead" instead))))))) > > > > +(defvar hack-local-variables--inhibit nil > > + "List of file/dir local variables to ignore.") > > + > > (defun hack-one-local-variable (var val) > > "Set local variable VAR with value VAL. > > If VAR is `mode', call `VAL-mode' as a function unless it's > > already the major mode." > > (pcase var > > + ((guard (memq var hack-local-variables--inhibit)) nil) > > ('mode > > (let ((mode (intern (concat (downcase (symbol-name val)) > > "-mode")))) > > @@ -4500,7 +4501,8 @@ hack-one-local-variable > > ('eval > > (pcase val > > (`(add-hook ',hook . ,_) (hack-one-local-variable--obsolete hoo= k))) > > - (let ((enable-local-variables nil)) ;FIXME: Should be buffer-loca= l! > > + (let ((hack-local-variables--inhibit ;; FIXME: Should be buffer-l= ocal! > > + (cons 'eval hack-local-variables--inhibit))) > > (save-excursion (eval val t)))) > > (_ > > (hack-one-local-variable--obsolete var) > > > > > > > > > > From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yikai Zhao Cc: rpluim@gmail.com, 74964@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.173606831824335 (code B ref 74964); Sun, 05 Jan 2025 09:12:02 +0000 Received: (at 74964) by debbugs.gnu.org; 5 Jan 2025 09:11:58 +0000 Received: from localhost ([127.0.0.1]:59840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUMfu-0006KR-2S for submit@debbugs.gnu.org; Sun, 05 Jan 2025 04:11:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46364) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUMfr-0006K2-Fx for 74964@debbugs.gnu.org; Sun, 05 Jan 2025 04:11:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUMfj-0007Dq-PG; Sun, 05 Jan 2025 04:11:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t/j0MXNnY16IRbE9w+jddooev8MtydFGbJ5ra4odNUs=; b=IoLxRbglIseC 3NBKhMFaRlhY96FnwixHX0OpEwBcXtZtw9c3fW6apF6HGa9Rih3tGuUSEggYeC4S01cRJxuJwF37g Uwpy8Zl2u+LBPdqQhMYBEr0FSqah/tEUfh4mXVfUjOKxAc+2iLT6ju8ihIJ8mmVnyoe3h39LtWhpg KZjOLbESg0TLqk1BjyAV2NN0V0mn40Q87EPR26PCAc0z2wAOh+Zo1B2DqygiQk1xqd/fO2iRvSbTF ivPf4gmhaD1+BRCuekFB46R/UwuXfKcyaAgZeMCAUm2JSbGCpEfsg08KG8pf2qlTih+2aHB/NXKZg fATadjrgfueOQ/d9LDe+kA==; Date: Sun, 05 Jan 2025 11:11:45 +0200 Message-Id: <861pxhaalq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Yikai Zhao on Sun, 5 Jan 2025 16:02:06 +0800) References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yikai Zhao > Date: Sun, 5 Jan 2025 16:02:06 +0800 > Cc: Stefan Monnier , rpluim@gmail.com, 74964@debbugs.gnu.org > > This patch does fix the issue for me. Thanks. Thanks for testing. Stefan, please install, and thanks. From unknown Thu Jun 19 14:30:02 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Yikai Zhao Subject: bug#74964: closed (Re: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode) Message-ID: References: X-Gnu-PR-Message: they-closed 74964 X-Gnu-PR-Package: emacs Reply-To: 74964@debbugs.gnu.org Date: Sun, 05 Jan 2025 15:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1736089562-572-1" This is a multi-part message in MIME format... ------------=_1736089562-572-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74964: 31.0.50 master; .dir-locals.el vars does not work with changing maj= or mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74964@debbugs.gnu.org. --=20 74964: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74964 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1736089562-572-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74964-done) by debbugs.gnu.org; 5 Jan 2025 15:05:17 +0000 Received: from localhost ([127.0.0.1]:34803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUSBp-00008C-5e for submit@debbugs.gnu.org; Sun, 05 Jan 2025 10:05:17 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4957) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUSBm-00006I-Hw for 74964-done@debbugs.gnu.org; Sun, 05 Jan 2025 10:05:16 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3CE9D44107B; Sun, 5 Jan 2025 10:05:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1736089507; bh=kLZSdQLptRqdlzprqC0jPDd7vmg4zSF3lQ3JCUEc9HA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hNWbvdm7cOSp0fVxB8xBq/Nq1qdT+bh3Lv4us0S1suUuPLTPutHfHWtpvw2UP4giG EIgD918kOoLxry4+I9ohCOjUsa/dGP0OrZ5mdUsJJmEo47UegTCQwp7oPEdBNBFQv/ WjDK0L7iM0f3yP4vkPXgMbl7VdKRTznZW6G4+VZkz2CPjQQWLNt3hBrnnf8A0FRYS+ Rlql+YLgEZBo0pYKSmEAwVGy35zauaeqGikaO0LSKRp+zr1nfQiO5oBoB3qoN3mKmN 3gnwIKWkFvUvl5aEAZWnp6QDI864J7lgFwFu3k4cf3O7ltTgJvkwuM48mVWQjZm8pj G4cKgVgGz0CCQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2ED75441022; Sun, 5 Jan 2025 10:05:07 -0500 (EST) Received: from pastel (104-195-230-250.cpe.teksavvy.com [104.195.230.250]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F2695120406; Sun, 5 Jan 2025 10:05:06 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode In-Reply-To: <861pxhaalq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Jan 2025 11:11:45 +0200") Message-ID: References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> <861pxhaalq.fsf@gnu.org> Date: Sun, 05 Jan 2025 10:05:06 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74964-done Cc: rpluim@gmail.com, Yikai Zhao , 74964-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> This patch does fix the issue for me. Thanks. Thank you for confirming! > Thanks for testing. Stefan, please install, and thanks. Closing, Stefan ------------=_1736089562-572-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Dec 2024 07:54:17 +0000 Received: from localhost ([127.0.0.1]:37306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBMP-00007T-E3 for submit@debbugs.gnu.org; Thu, 19 Dec 2024 02:54:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:41996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBMN-00007K-KM for submit@debbugs.gnu.org; Thu, 19 Dec 2024 02:54:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOBMN-0003We-E8 for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 02:54:15 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOBML-0004YU-Pz for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2024 02:54:14 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-436202dd730so3128795e9.2 for ; Wed, 18 Dec 2024 23:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1734594851; x=1735199651; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MuGBwAoctzWd9f8ZCw+/Nmpi9QshsPtpVynGgJESsAc=; b=cV1g+oxGdVGUJVgYyOQG2GQDHJFGwTUcso1d+DC57goorzPARck109e/zbGFdzaVfO raqQP8SaBWkxiljrvs9dsMljUByIAP1K/FGy0krgyCIv7d9HwS0ggevHOa3M2Cij84Hp rDJd+3Goaxov9XD8tOP1yuifkTifTfeys1yRqQh86DPPWUCSa7X5FDX6PPLp5zLE/vBT 6eNqhSEXjJr6QazP9YOJZR34h3WqezLVkDWZGItPN9zuCT5PSt+OpfTWyYmxOHRr411S X0s9L7GFeBffKVkm7o1Ztp7zn1auHJA9Vl/lVBgHPzQAVzCJmtQISTnPL3d0P5vgcZ39 be0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734594851; x=1735199651; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MuGBwAoctzWd9f8ZCw+/Nmpi9QshsPtpVynGgJESsAc=; b=vg7AeRu+Loa6WhhqXFV5hKPgHq6/lMkXMwcczwaIKOHLwWyvGRqwUZLCeq5taOXOV/ DZug9AdadiUAvOzMyImxWrMfnCGKkLI8gYMj6B7G46LvocT3XcE4h3g9+pxKuXuxE4Dg VHk0K/72fR/FJzygy4KWqKNW9ipW0n9raXSyPsXtDoeGrXYh+zLv2gXE60scPwXNwzSx O/5sB08U3IR6z9s9P3+yEYYVoDW1Bg4R7OdPvz4Jq8qTxBKJ2StXJS0Xv+h/Z6CRS8pK GdQ44IK2uabt9yjlOtZNcnUTG0lzJNoHlwIy3ybCwtiq/v3iWSL9J3CjbQjJKoZAgA9+ ceDg== X-Gm-Message-State: AOJu0YzNFUgg97zh3E8w5b2GGr7Y2/btKwEfTgX3v5xyCVF9V1Uj2hBt pOoI1iTJvii+VGpORRvblvN6kMXQ3wp9vgxmVVyhcdpjd7r2cqmcjfa6mL+32CuGS027/KGiL2K DW3kVAauTkyX9/4CsP8zd1lZavmwHcDutV+28Fmaj8iX625CEugnFoQ== X-Gm-Gg: ASbGnct9HI01wzzxZKk9GwUvlFD8wr4nXz+deHUaWRFop6JvwukxhaF5183H7s5ljFP VuwDfKTN5ttuuhYZ8FLdILREZdNFmmhbyx0yX4GYr9ug/W5cKK5ckrBYgM3mIFPoVp77djuuw X-Google-Smtp-Source: AGHT+IEJmOU4j4lm7D9LovBNMDwGMZ3j6TaN9MTFKga18zWRuS7PupbuXD2NyT8E+Ttr97bJLP7CbEfNHoJulDq1aWc= X-Received: by 2002:a05:600c:4fc5:b0:435:192:63ca with SMTP id 5b1f17b1804b1-436553f4d35mr49091895e9.21.1734594850329; Wed, 18 Dec 2024 23:54:10 -0800 (PST) MIME-Version: 1.0 From: Yikai Zhao Date: Thu, 19 Dec 2024 15:53:58 +0800 Message-ID: Subject: 31.0.50 master; .dir-locals.el vars does not work with changing major mode To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=i@blahgeek.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) How to reproduce: With following content in /tmp/test/.dir-locals.el: ((nil . ((my/test . "test"))) (c-mode . ((eval . (when (eq major-mode 'c-mode) (c++-mode)))))) ;; I use this code because I want my projects' .h files always opened in c++ mode Then open a new file test.c in the folder. Expected behavior: my/test variable is set. Actual behavior: my/test variable is not set. Emacs 29 and 30 does give me the expected result. ------------=_1736089562-572-1-- From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2025 08:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , rpluim@gmail.com, 74964-done@debbugs.gnu.org Received: via spool by 74964-done@debbugs.gnu.org id=D74964.17370162036202 (code D ref 74964); Thu, 16 Jan 2025 08:31:01 +0000 Received: (at 74964-done) by debbugs.gnu.org; 16 Jan 2025 08:30:03 +0000 Received: from localhost ([127.0.0.1]:59928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYLGM-0001bp-US for submit@debbugs.gnu.org; Thu, 16 Jan 2025 03:30:03 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:48285) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tYLGJ-0001aX-Q5 for 74964-done@debbugs.gnu.org; Thu, 16 Jan 2025 03:30:00 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so360474f8f.0 for <74964-done@debbugs.gnu.org>; Thu, 16 Jan 2025 00:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1737016193; x=1737620993; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tex28gAo1ALpLIupyaPY0SNzlc4qNN5tnAhV6+lOL1E=; b=FiuNklgIwEjkwDkbbVwlYqWdjBr/Cnlb0KAIM1EtztBLP1lRbnBfj9J3O8KAv6fI7c 6MiNQNGnsu74Pn+qSi2XCBmjj6qKe2uAY5Ajf/k2ZPZ+yK70bnFquVVe+4MierRkUmJF guEpp9+oBLXCnCFiYS5sh2RtQ/s1nN80iFOc31Lw2KwYzKwIdA7OayXOThFqgSDScl+3 3DzL7KBtshuH1PRLx0dx8MjMJoLfKTJSQ2zRiH50xLk5Mb8R1OujNbZ3/DmHDSZY2wTY gy+kp3+fKx8E8TLSPlwFBA2dkZYg0IZbAKzULZymcN8UyKxLXyUi2Xocn4CLeDszgSJ2 kN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737016193; x=1737620993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tex28gAo1ALpLIupyaPY0SNzlc4qNN5tnAhV6+lOL1E=; b=AdDjPRgL1ZUKC/58cAQdzbinPu1UoaZ5EKOh+CcHqqLhvSKzbp4Fpve3tyqkA5Jvyi GB7bVEdK64uEIuLzfeypASgFg6H2LqPfBv+aBvs8TB4hgXXqMQFvSnr/Mc5QHuLDWs/B lLiYMrldC9lwAMi+sElZBY8Iokg2GZnS8a8dkUCwg6JNFkuSfk8zCs9G0xg3Lg0l9s52 k/r/OKIY9Q2Mj5u6OgYudMs/rrbus+pVFZmcPS8gioqBVrOPTPhQD+mEaJVuamy+FTM9 j2ldtXs9CDIhJpjTyuT/SSFXmbFC+ERvJKIs98hkdp9o/fEdCb9IpcO1IFiTFWn5Br2i 6/nA== X-Forwarded-Encrypted: i=1; AJvYcCXiUHkFPt3yOk7qWCr475jZ0qudYMdea1HJIrc78+ITEU2XbVvB14jD0PwlM5q8mkgBjNs69oIEQgDR@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywn3AoiLKnYYxMeYBPzimuthUbRGVRTbXuWlG+E04gM5RL96Yan 4iRdRR4d+oIeLjckWk8TTj+g7NNb6klI4DGa6ikW8RDE2JAHWrcX+B1Kfw9GYoxmUfXUGn6wa4p V3rNN8elQ+zDat8RxOfNZjl3g54Z6qhTAaXhjqA== X-Gm-Gg: ASbGnct38IOnXrYdAx+N8c8v0IVbWN3R7D3ha7esbgitETh2N25qxmHzACgwjKYHOJ3 j8QPUz9eoMNMT9OLkqVxwIbMKBZ5CFEIYHstge8OesXnI5vlFoAx/3k3QuL38hH5ycQUniz2o X-Google-Smtp-Source: AGHT+IGxKAe2NwRhH60kfjinef1TOXwgSjprDHiPTlfJPdbCcmljZMjVLyMJqCwwv5zFs5VkoM25k9ws2fifL/j94xI= X-Received: by 2002:a05:6000:18a8:b0:388:c790:1dff with SMTP id ffacd0b85a97d-38a8733fd71mr26929608f8f.47.1737016193027; Thu, 16 Jan 2025 00:29:53 -0800 (PST) MIME-Version: 1.0 References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> <861pxhaalq.fsf@gnu.org> In-Reply-To: From: Yikai Zhao Date: Thu, 16 Jan 2025 16:29:40 +0800 X-Gm-Features: AbW1kvYL7qLSBx6smrdDSLm4TiJ-QfJpt_LvaVNqqAocAniMN6KPJdQMaw9qFfU Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Stefan, Sorry to bring this back again. The original issue is indeed fixed, however there's another related issue remaining. With the following .dir-locals.el code: ((nil . ((my/test . "test") (eval . (setq-local my/test2 "test2")))) (c-mode . ((eval . (when (eq major-mode 'c-mode) (c++-mode)))))) The `my/test` variable will be set after your fix. But the `my/test2` variable is still not set. On Sun, Jan 5, 2025 at 11:05=E2=80=AFPM Stefan Monnier wrote: > > >> This patch does fix the issue for me. Thanks. > > Thank you for confirming! > > > Thanks for testing. Stefan, please install, and thanks. > > Closing, > > > Stefan > From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 04:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yikai Zhao Cc: Eli Zaretskii , 74964@debbugs.gnu.org, rpluim@gmail.com, 74964-done@debbugs.gnu.org Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.17370884873096 (code B ref 74964); Fri, 17 Jan 2025 04:35:02 +0000 Received: (at 74964) by debbugs.gnu.org; 17 Jan 2025 04:34:47 +0000 Received: from localhost ([127.0.0.1]:35580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYe4D-0000nl-4P for submit@debbugs.gnu.org; Thu, 16 Jan 2025 23:34:47 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26120) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYe49-0000nM-Fl; Thu, 16 Jan 2025 23:34:42 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C3154808AD; Thu, 16 Jan 2025 23:34:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1737088475; bh=nnX8M+/NUOgmVSa3EVmfkErD7HtDUotQRi1YIG4E4zw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U+cSP5ArOI9M9Uxc73iolBlNbWVFm4Wk6gUqCL+mzKIVvYUtDxVLsi7Ar46Qq55KJ 2a1S976GVV11oFv5K5plE2XvsODtTSwTTUkI+S4wnwhCWSzq/YexSWBbrWBm9vFfi3 Bf3Ts3Ns59tj4k1SuKyHfa19rxjixzCnsyI4OoDoiEu/ACEADCD7sExPnE/fMoOed8 Gabf3I2otiDO4nWH6JhnkS5S3JQLQC3zOu7Hj7eSokl/kUUwmNVEWlCBY1L3fXP7s4 pdzNNJxu9LzWmrKPJdfZ1/Ja0d4ZdUc9AS9kDeT8u+TDRFKCQR/UiB3wILEzxSlbp5 v13M/JFRBMqaw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EAD7880024; Thu, 16 Jan 2025 23:34:34 -0500 (EST) Received: from pastel (104-195-232-86.cpe.teksavvy.com [104.195.232.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B0BE6120415; Thu, 16 Jan 2025 23:34:34 -0500 (EST) From: Stefan Monnier In-Reply-To: (Yikai Zhao's message of "Thu, 16 Jan 2025 16:29:40 +0800") Message-ID: References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> <861pxhaalq.fsf@gnu.org> Date: Thu, 16 Jan 2025 23:34:34 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain > ((nil . ((my/test . "test") > (eval . (setq-local my/test2 "test2")))) > (c-mode . ((eval . (when (eq major-mode 'c-mode) > (c++-mode)))))) [ Sigh! This is starting to make me remember the ugly hacks I added to try and avoid inf-loops in my type checker. ] How 'bout the patch below? Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=files.patch diff --git a/lisp/files.el b/lisp/files.el index e9f69fcd33c..9981e7083c3 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -4490,15 +4490,15 @@ hack-one-local-variable--obsolete (substitute-command-keys instead) (format-message "use `%s' instead" instead))))))) -(defvar hack-local-variables--inhibit nil - "List of file/dir local variables to ignore.") +(defvar hack-local-variables--inhibit-eval nil + "List of `eval' forms to ignore in file/dir local variables.") (defun hack-one-local-variable (var val) "Set local variable VAR with value VAL. If VAR is `mode', call `VAL-mode' as a function unless it's already the major mode." (pcase var - ((guard (memq var hack-local-variables--inhibit)) nil) + ((and 'eval (guard (memq val hack-local-variables--inhibit-eval))) nil) ('mode (let ((mode (intern (concat (downcase (symbol-name val)) "-mode")))) @@ -4506,8 +4506,8 @@ hack-one-local-variable ('eval (pcase val (`(add-hook ',hook . ,_) (hack-one-local-variable--obsolete hook))) - (let ((hack-local-variables--inhibit ;; FIXME: Should be buffer-local! - (cons 'eval hack-local-variables--inhibit))) + (let ((hack-local-variables--inhibit-eval ;; FIXME: Should be buffer-local! + (cons val hack-local-variables--inhibit-eval))) (save-excursion (eval val t)))) (_ (hack-one-local-variable--obsolete var) --=-=-=-- From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Yikai Zhao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 05:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 74964@debbugs.gnu.org, rpluim@gmail.com, 74964-done@debbugs.gnu.org Received: via spool by 74964-submit@debbugs.gnu.org id=B74964.173709333718564 (code B ref 74964); Fri, 17 Jan 2025 05:56:01 +0000 Received: (at 74964) by debbugs.gnu.org; 17 Jan 2025 05:55:37 +0000 Received: from localhost ([127.0.0.1]:35725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYfKS-0004pH-EB for submit@debbugs.gnu.org; Fri, 17 Jan 2025 00:55:36 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:57471) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tYfKP-0004oe-40 for 74964@debbugs.gnu.org; Fri, 17 Jan 2025 00:55:33 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4362f61757fso16081455e9.2 for <74964@debbugs.gnu.org>; Thu, 16 Jan 2025 21:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; s=google; t=1737093327; x=1737698127; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Hjt7aAMp1jeJqDbcyAnORAjojs9c11l1XHg5EWA9ITE=; b=Cs5n/GTTOhatWQaVIw5oYa4oBV8/vS3ufHhxfVEVTKLXRWP60nPYygp18raXfVcwFP mCjaUQxRWSS/c9CCtPISFF7w6+GTIn9dRh5s+ubIv10/50dWxGWfAA0r+TP2skIrSoZ0 C+8RJTbT3P65DtOZyn5VZDwIV9oHzgEYTs2LTGA+qbeKKDxB0Vp8pCbSKR7CBOpRQLUe 9q7UFnuLOtGviWgUhZzcCIcUMF/Md4PYTDqY040wMoOb6yEr6bITKUOLp7IJk9zWr4nj uwM4g62Umsr/2PB/1xiLN6CAi8iEnvnDW9TZ/XWxoXv/42/e/KEzZ5enXQ2gYt6nYNLT rTBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737093327; x=1737698127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hjt7aAMp1jeJqDbcyAnORAjojs9c11l1XHg5EWA9ITE=; b=POfj0dpl0vrudQFouHvcTe58eG05vY548zLDOFe7RrP1UKgCtv2iMTVFyuhtuqBdi5 tlVWBGC9A6t231S6ohdj62FRuJsESV2uh607Srt1Lved2hUkxIbcBpOE0ZwkrkfQ/BkH ZRhyThAjZSgTlUK3rSj9sfdRDCTpMXHZdw6UGsYFjeK/ZZMORDlmTSYsYDK3sXneZ5QM oO6OqRhKZ3DE+j+0b07mCr8DjGGdJ9Ha0aSJmDKHemodc5f8qtzZeLuwh0S92eyFx669 Yur8j/gYUZQtgj7AsGqVb0e6J2GTGOvYuNE+FWMtpHGQH91yh5Jt3RWCua2yORMglonv vNhQ== X-Gm-Message-State: AOJu0YxDhBxVS1A/NMSscy3LVUPHTZGrJZnHWC34F2sb4jZTosaQ72tu yWjR0xMCcMzX7jqCPoWbTJmH/ksgC1wpP5qs/qQ0W20/rnwHI+35V4RA7r8XzilnrdJYlC6bAbw aOzr6UXlClgb9w+kx5kZBoQxgsLrPJRh4r/m+NQ== X-Gm-Gg: ASbGncuBdh/l53DlpAd876+E93NysYI2eeHJltwwYBKHh6uHuHrMJw98msV5AFPkhGN cemm5yffBLFNYcS8d/2YAYZvfxRlssy2u2CJEhXj01NCgv16tlDfJHT1b9IMg+bkUxgbFlXJM X-Google-Smtp-Source: AGHT+IEHFolHCpXbhQdBjL+HWuI5TNXbZV0fIgeLFmnbiWqHEV3YMpkmYmdYwvXxmdybmwAhhqLwPfMrMd6gJDtz+9I= X-Received: by 2002:a05:6000:2a9:b0:385:ed16:c97 with SMTP id ffacd0b85a97d-38bf57d2d6bmr929251f8f.49.1737093326583; Thu, 16 Jan 2025 21:55:26 -0800 (PST) MIME-Version: 1.0 References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> <861pxhaalq.fsf@gnu.org> In-Reply-To: From: Yikai Zhao Date: Fri, 17 Jan 2025 13:55:15 +0800 X-Gm-Features: AbW1kvYzs62dhnUs7l-HeJ8BXEQW4XASlox98Y15Vpxh6EysADkQ3wy8as4kLKo Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Thanks! It fixes the issue for me. On Fri, Jan 17, 2025 at 12:34=E2=80=AFPM Stefan Monnier wrote: > > > ((nil . ((my/test . "test") > > (eval . (setq-local my/test2 "test2")))) > > (c-mode . ((eval . (when (eq major-mode 'c-mode) > > (c++-mode)))))) > > [ Sigh! This is starting to make me remember the ugly hacks I added to > try and avoid inf-loops in my type checker. ] > > How 'bout the patch below? > > > Stefan From unknown Thu Jun 19 14:30:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74964: 31.0.50 master; .dir-locals.el vars does not work with changing major mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2025 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yikai Zhao Cc: Eli Zaretskii , rpluim@gmail.com, 74964-done@debbugs.gnu.org Received: via spool by 74964-done@debbugs.gnu.org id=D74964.173712148421882 (code D ref 74964); Fri, 17 Jan 2025 13:45:01 +0000 Received: (at 74964-done) by debbugs.gnu.org; 17 Jan 2025 13:44:44 +0000 Received: from localhost ([127.0.0.1]:36426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tYmeR-0005gr-MS for submit@debbugs.gnu.org; Fri, 17 Jan 2025 08:44:43 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64238) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tYmeO-0005gb-Qo for 74964-done@debbugs.gnu.org; Fri, 17 Jan 2025 08:44:41 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BCFC6807F1; Fri, 17 Jan 2025 08:44:34 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1737121473; bh=OqH6qUwtciwOr9WRIS8uBdIltw9Hq5t96rbqPI14RCY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QFwpzOPFbH9fy4uCdQTyw2m/FjQx+8CJhWx0BKS2hBENW0ce4ba4I52HSRXQ4GxRq nofMgUks6b4odBqb3retQuh0ng2hiZdE5KTUuQlGvKguqxyifZqZ0q4FYep3VKTwMW 1bFD5deAiTAIq7MTVUVKk5ei5Us0fpxhY4Xr92XT5wtPn2eBgCgvcJRGtANx7Nqr/s 6zSfH98okCeV3ZdWlyyvz3lO9TZsX3QxQGpT0UeBhgRhK8dCDd3N0KwwiF5n68y0vk VAWmL5c34KNtOUA92uIcl/HXz/TEq7ukjerHjiR/HnCzlploBvAe0fmntfvWfywlV0 ixHIknHgg5ahA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E5F818053B; Fri, 17 Jan 2025 08:44:33 -0500 (EST) Received: from pastel (104-195-232-86.cpe.teksavvy.com [104.195.232.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ADC041204A5; Fri, 17 Jan 2025 08:44:33 -0500 (EST) From: Stefan Monnier In-Reply-To: (Yikai Zhao's message of "Fri, 17 Jan 2025 13:55:15 +0800") Message-ID: References: <87zfkqtjgl.fsf@gmail.com> <86jzbaerfw.fsf@gnu.org> <861pxhaalq.fsf@gnu.org> Date: Fri, 17 Jan 2025 08:44:31 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Thanks! It fixes the issue for me. Great, pushed to `master`. Stefan