From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: ARISAWA Akihiro Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Nov 2010 01:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7496@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129081979219485 (code B ref -1); Sat, 27 Nov 2010 01:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2010 01:03:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PM9Bz-000549-DI for submit@debbugs.gnu.org; Fri, 26 Nov 2010 20:03:12 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PM9Br-00053c-So for submit@debbugs.gnu.org; Fri, 26 Nov 2010 20:03:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PM9H7-0006Zt-Sw for submit@debbugs.gnu.org; Fri, 26 Nov 2010 20:08:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:55993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PM9H7-0006Zp-RB for submit@debbugs.gnu.org; Fri, 26 Nov 2010 20:08:25 -0500 Received: from [140.186.70.92] (port=36149 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PM9H6-0003ij-V6 for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 20:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PM9H5-0006Zd-Rg for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 20:08:24 -0500 Received: from mbf.ocn.ne.jp ([122.28.14.167]:52358 helo=smtp.mbf.ocn.ne.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PM9H5-0006ZB-3a for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 20:08:23 -0500 Received: from nagi.lyrical.homelinux.net (p3210-ipbf901kokuryo.gunma.ocn.ne.jp [122.24.212.210]) by smtp.mbf.ocn.ne.jp (Postfix) with ESMTP id DA9CE53BA for ; Sat, 27 Nov 2010 10:08:17 +0900 (JST) Received: from nagi.lyrical.homelinux.net (localhost [127.0.0.1]) by nagi.lyrical.homelinux.net (Postfix) with ESMTP id 8DAAF94061 for ; Sat, 27 Nov 2010 10:08:40 +0900 (JST) From: ARISAWA Akihiro Date: Sat, 27 Nov 2010 10:08:39 +0900 Message-ID: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: HP-UX 11.00-11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) In GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.12) of 2010-05-15 on nagi, modified by Debian configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Hi, When I call `copy-keymap' with a keymap which contains recursive binding, the emacs crashed. I can reproduce it by following sexp. (let ((map (make-sparse-keymap))) (define-key map " " map) (copy-keymap map)) Regards, ARISAWA From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Nov 2010 02:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: ARISAWA Akihiro Cc: 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.129082656831504 (code B ref 7496); Sat, 27 Nov 2010 02:57:02 +0000 Received: (at 7496) by debbugs.gnu.org; 27 Nov 2010 02:56:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMAxM-0008C4-Ig for submit@debbugs.gnu.org; Fri, 26 Nov 2010 21:56:08 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMAxF-0008BX-Iw for 7496@debbugs.gnu.org; Fri, 26 Nov 2010 21:56:07 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiQKADsD8ExFxKB0/2dsb2JhbACiEXtyvw6FRwSEXI1t X-IronPort-AV: E=Sophos;i="4.59,264,1288584000"; d="scan'208";a="83844718" Received: from 69-196-160-116.dsl.teksavvy.com (HELO ceviche.home) ([69.196.160.116]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 26 Nov 2010 22:01:28 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 3C72D660DC; Fri, 26 Nov 2010 22:01:28 -0500 (EST) From: Stefan Monnier Message-ID: References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> Date: Fri, 26 Nov 2010 22:01:28 -0500 In-Reply-To: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> (ARISAWA Akihiro's message of "Sat, 27 Nov 2010 10:08:39 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > When I call `copy-keymap' with a keymap which contains recursive binding, > the emacs crashed. > I can reproduce it by following sexp. > (let ((map (make-sparse-keymap))) > (define-key map " " map) > (copy-keymap map)) I'm not surprised. There are many ways to address it: - try and make sure we better handle the "using up all memory" case rather than crashing. This is very difficult. We already try to do it, but clearly it's not working that well. - try and detect such cycles and either signal an error or reproduce the same cycle in the copy. We have added such things in several other cases, so we should probably do that. - don't use cyclic keymaps and especially don't copy them. - don't use copy-keymap, instead: inherit. Stefan From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: ARISAWA Akihiro Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Nov 2010 05:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7496@debbugs.gnu.org Cc: Stefan Monnier Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.129083429710712 (code B ref 7496); Sat, 27 Nov 2010 05:05:02 +0000 Received: (at 7496) by debbugs.gnu.org; 27 Nov 2010 05:04:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMCy0-0002mj-BG for submit@debbugs.gnu.org; Sat, 27 Nov 2010 00:04:56 -0500 Received: from mbf.ocn.ne.jp ([122.28.14.167] helo=smtp.mbf.ocn.ne.jp) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PMCxw-0002mU-CI for 7496@debbugs.gnu.org; Sat, 27 Nov 2010 00:04:53 -0500 Received: from nagi.lyrical.homelinux.net (p3210-ipbf901kokuryo.gunma.ocn.ne.jp [122.24.212.210]) by smtp.mbf.ocn.ne.jp (Postfix) with ESMTP id 85B3E44DC; Sat, 27 Nov 2010 14:10:17 +0900 (JST) Received: from nagi.lyrical.homelinux.net (localhost [127.0.0.1]) by nagi.lyrical.homelinux.net (Postfix) with ESMTP id 9A9BE94061; Sat, 27 Nov 2010 14:10:40 +0900 (JST) From: ARISAWA Akihiro In-Reply-To: (Stefan Monnier's message of "Fri, 26 Nov 2010 22:01:28 -0500") References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Date: Sat, 27 Nov 2010 14:10:40 +0900 Message-ID: <87zksvz6zz.fsf@nagi.lyrical.homelinux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Stefan Monnier writes: >> When I call `copy-keymap' with a keymap which contains recursive binding, >> the emacs crashed. > - don't use cyclic keymaps and especially don't copy them. > - don't use copy-keymap, instead: inherit. OK. I use cycle binding in global-map, and the evernote-mode.el calls (copy-keymap global-map). http://code.google.com/p/emacs-evernote-mode/ So, I will suggest to the author that evernote-mode.el uses set-keymap-parent instead of copy-keymap. Regards, ARISAWA From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 01:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: ARISAWA Akihiro , 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157092932715758 (code B ref 7496); Sun, 13 Oct 2019 01:16:01 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 01:15:27 +0000 Received: from localhost ([127.0.0.1]:34530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJSTn-000466-0Q for submit@debbugs.gnu.org; Sat, 12 Oct 2019 21:15:27 -0400 Received: from quimby.gnus.org ([80.91.231.51]:44344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJSTk-00045u-G2 for 7496@debbugs.gnu.org; Sat, 12 Oct 2019 21:15:25 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJSTe-0002NI-8y; Sun, 13 Oct 2019 03:15:20 +0200 From: Lars Ingebrigtsen References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> Date: Sun, 13 Oct 2019 03:15:17 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 26 Nov 2010 22:01:28 -0500") Message-ID: <874l0dh2e2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> When I call `copy-keymap' with a keymap which contains recursive binding, >> the emacs crashed. >> I can reproduce it by following sexp. > >> (let ((map (make-sparse-keymap))) >> (define-key map " [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> When I call `copy-keymap' with a keymap which contains recursive binding, >> the emacs crashed. >> I can reproduce it by following sexp. > >> (let ((map (make-sparse-keymap))) >> (define-key map " " map) >> (copy-keymap map)) > > I'm not surprised. There are many ways to address it: > - try and make sure we better handle the "using up all memory" case > rather than crashing. This is very difficult. We already try to do > it, but clearly it's not working that well. > - try and detect such cycles and either signal an error or reproduce the > same cycle in the copy. We have added such things in several other > cases, so we should probably do that. While this is a pretty obscure, Emacs shouldn't crash on stuff like this. I first considered whether just to check for EQ in Fcopy_keymap, but it's possible to have nested keymaps that are mutually recursive, so that won't work. So I just added a recursion counter and refuse to copy when we've reached level 100. It does not protect against the case where the keymap is a char table where one of the entries is the same keymap, but I don't know whether that's a thing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 21:15:29 2019 Received: (at control) by debbugs.gnu.org; 13 Oct 2019 01:15:29 +0000 Received: from localhost ([127.0.0.1]:34533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJSTp-00046L-B6 for submit@debbugs.gnu.org; Sat, 12 Oct 2019 21:15:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:44360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJSTo-00046E-9L for control@debbugs.gnu.org; Sat, 12 Oct 2019 21:15:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJSTl-0002NR-LQ for control@debbugs.gnu.org; Sun, 13 Oct 2019 03:15:27 +0200 Date: Sun, 13 Oct 2019 03:15:25 +0200 Message-Id: <8736fxh2du.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #7496 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 7496 fixed close 7496 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 7496 fixed close 7496 27.1 quit From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 06:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.15709499176982 (code B ref 7496); Sun, 13 Oct 2019 06:59:02 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 06:58:37 +0000 Received: from localhost ([127.0.0.1]:34828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJXps-0001oY-Nm for submit@debbugs.gnu.org; Sun, 13 Oct 2019 02:58:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJXpq-0001oJ-Tr for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 02:58:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJXpk-0005BW-AA; Sun, 13 Oct 2019 02:58:28 -0400 Received: from [176.228.60.248] (port=1260 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJXpj-00052U-5j; Sun, 13 Oct 2019 02:58:28 -0400 Date: Sun, 13 Oct 2019 09:58:20 +0300 Message-Id: <83zhi5ku7n.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <874l0dh2e2.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Oct 2019 03:15:17 +0200) References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Sun, 13 Oct 2019 03:15:17 +0200 > Cc: ARISAWA Akihiro , 7496@debbugs.gnu.org > > >> (let ((map (make-sparse-keymap))) > >> (define-key map " " map) > >> (copy-keymap map)) > > > > I'm not surprised. There are many ways to address it: > > - try and make sure we better handle the "using up all memory" case > > rather than crashing. This is very difficult. We already try to do > > it, but clearly it's not working that well. > > - try and detect such cycles and either signal an error or reproduce the > > same cycle in the copy. We have added such things in several other > > cases, so we should probably do that. > > While this is a pretty obscure, Emacs shouldn't crash on stuff like > this. I first considered whether just to check for EQ in Fcopy_keymap, > but it's possible to have nested keymaps that are mutually recursive, > so that won't work. > > So I just added a recursion counter and refuse to copy when we've > reached level 100. What happens in the current master without that limitation? We have since added stack overflow protection -- doesn't it kick in in this case? From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Eli Zaretskii Cc: ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157098941631149 (code B ref 7496); Sun, 13 Oct 2019 17:57:02 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 17:56:56 +0000 Received: from localhost ([127.0.0.1]:36864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJi6y-00086L-Ev for submit@debbugs.gnu.org; Sun, 13 Oct 2019 13:56:56 -0400 Received: from quimby.gnus.org ([80.91.231.51]:35164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJi6w-00086C-6P for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 13:56:54 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJi6q-0003bA-8W; Sun, 13 Oct 2019 19:56:50 +0200 From: Lars Ingebrigtsen References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> Date: Sun, 13 Oct 2019 19:56:47 +0200 In-Reply-To: <83zhi5ku7n.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Oct 2019 09:58:20 +0300") Message-ID: <87blukbkbk.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > What happens in the current master without that limitation? We have > since added stack overflow protection -- doesn't it kick in in this > case? No, Emacs just crashes hard. I haven't examined why, though -- I didn't know about the new stack overflow protection. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > What happens in the current master without that limitation? We have > since added stack overflow protection -- doesn't it kick in in this > case? No, Emacs just crashes hard. I haven't examined why, though -- I didn't know about the new stack overflow protection. It's easy to reproduce, though: Just eval this form and Emacs will segfault (if it's older than yesterday's): (let ((map (make-sparse-keymap))) (define-key map " " map) (copy-keymap map)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157099246227924 (code B ref 7496); Sun, 13 Oct 2019 18:48:02 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 18:47:42 +0000 Received: from localhost ([127.0.0.1]:36973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJiu4-0007GI-B0 for submit@debbugs.gnu.org; Sun, 13 Oct 2019 14:47:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJiu1-0007G2-7D for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 14:47:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJitv-0007dC-2e; Sun, 13 Oct 2019 14:47:31 -0400 Received: from [176.228.60.248] (port=1097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJitt-0003bO-3A; Sun, 13 Oct 2019 14:47:30 -0400 Date: Sun, 13 Oct 2019 21:47:22 +0300 Message-Id: <8336fwlbyd.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87blukbkbk.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Oct 2019 19:56:47 +0200) References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: monnier@iro.umontreal.ca, ari@mbf.ocn.ne.jp, 7496@debbugs.gnu.org > Date: Sun, 13 Oct 2019 19:56:47 +0200 > > Eli Zaretskii writes: > > > What happens in the current master without that limitation? We have > > since added stack overflow protection -- doesn't it kick in in this > > case? > > No, Emacs just crashes hard. I haven't examined why, though -- I didn't > know about the new stack overflow protection. Maybe because the stack overflow happens during GC. From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Eli Zaretskii , ari@mbf.ocn.ne.jp, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157099830129374 (code B ref 7496); Sun, 13 Oct 2019 20:25:02 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 20:25:01 +0000 Received: from localhost ([127.0.0.1]:37117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJkQG-0007dh-Kw for submit@debbugs.gnu.org; Sun, 13 Oct 2019 16:25:01 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJkQF-0007dR-8q for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 16:24:59 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 43CC781196; Sun, 13 Oct 2019 16:24:53 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8163C8004C; Sun, 13 Oct 2019 16:24:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1570998291; bh=WS8Kmh7PYukynRb7vrk4f81v8WWA4KEzkON01WX7S6M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iRP+8WMuMk2vGjJqxrs22VZRDCkMSIv4mnbEvQckhDS+PW4e0zTpzm2l5PPXoVSFz ORcglPtmRKCx3LCss1HUqaIOkK97D9DXqVwFelJ5CrPZ4WNAmbkYK9i4RMvcpjjxdw eYT1XT2rtI8vAtIpaVZeuGLxE++iMRt+ZdWKyH1EG57SI8NbYfeRskNwA3qDeBjgnt XJdgvSVd1P0YYnOn3Z6kyjDi9n4HbiBlI8RNrcxvMMYNkfOx9gnu+OiSGneLQR4qRG MW/DJTsBFouwc8SAE1/dqIOJQUPhs2pVOGAmAE1yjV7BFdqtQiqgiuHUCCByev6p67 yr+TRJFM5e2TA== Received: from pastel (unknown [216.154.35.246]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3B0D61201D5; Sun, 13 Oct 2019 16:24:51 -0400 (EDT) From: Stefan Monnier Message-ID: References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> Date: Sun, 13 Oct 2019 16:24:49 -0400 In-Reply-To: <87blukbkbk.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Oct 2019 19:56:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (let ((map (make-sparse-keymap))) > (define-key map " " map) > (copy-keymap map)) BTW, copy-keymap should pretty much never be used. And as a consequence its performance is largely irrelevant, so it could be re-implemented in Elisp ;-) Stefan From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Stefan Monnier Cc: Eli Zaretskii , ari@mbf.ocn.ne.jp, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.15709988995813 (code B ref 7496); Sun, 13 Oct 2019 20:35:01 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 20:34:59 +0000 Received: from localhost ([127.0.0.1]:37126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJkZv-0001Vh-9K for submit@debbugs.gnu.org; Sun, 13 Oct 2019 16:34:59 -0400 Received: from quimby.gnus.org ([80.91.231.51]:38204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJkZs-0001VY-Su for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 16:34:57 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJkZn-0005Bg-27; Sun, 13 Oct 2019 22:34:53 +0200 From: Lars Ingebrigtsen References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> Date: Sun, 13 Oct 2019 22:34:50 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 13 Oct 2019 16:24:49 -0400") Message-ID: <87eezg8jv9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > BTW, copy-keymap should pretty much never be used. > And as a consequence its performance is largely irrelevant, so it could > be re-implemented in Elisp ;-) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > BTW, copy-keymap should pretty much never be used. > And as a consequence its performance is largely irrelevant, so it could > be re-implemented in Elisp ;-) Yes, I wondered whether I should just do that -- almost everything it does is available from Lisp land, I think -- except map_char_table, which I didn't investigate closely. (copy-keymap is used 76 times in the Emacs tree.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 21:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen Cc: Eli Zaretskii , ari@mbf.ocn.ne.jp, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157100197518955 (code B ref 7496); Sun, 13 Oct 2019 21:27:01 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 21:26:15 +0000 Received: from localhost ([127.0.0.1]:37183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJlNX-0004ve-13 for submit@debbugs.gnu.org; Sun, 13 Oct 2019 17:26:15 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJlNU-0004vP-NG for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 17:26:13 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 37B5581196; Sun, 13 Oct 2019 17:26:07 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8B7BC80EB9; Sun, 13 Oct 2019 17:26:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571001965; bh=RlKSw0nxI2u2veAgrwU6FUdh7r1zlbpibtHJOeu5pso=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dJsrrzMJDU8mGOwdb37y4ohwEBtz3reBnN6GECHHBENfUe6nAT8Ge5Ih2vSZ4LjWY X9LUf/d0Es8Jaa75zYjaui38fe3/MnEtqTHseiuWQFXDuFT9nY+p+q8k8rHIeG3bmr kpbvxmFrmzwI8kVRyUB1uK6uzcPpDgMQGYuEZUDcmNTCAbGcgQrCShRpW44UvvXffR maMz1GNECoM524IpcqeOVhrS2phjougsEkEqokMgvmQeDvZAe4FXPfO7iNEO57Yl09 NgPE5D1aI9zcWgYEO88cZ8p3QAcfBbEZt1UEGhqC1j0IEoalHyYdAshlKLhDxO+3Rj 3kN2GjRoNZ8mQ== Received: from pastel (unknown [216.154.35.246]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3902412019C; Sun, 13 Oct 2019 17:26:05 -0400 (EDT) From: Stefan Monnier Message-ID: References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> <87eezg8jv9.fsf@gnus.org> Date: Sun, 13 Oct 2019 17:26:04 -0400 In-Reply-To: <87eezg8jv9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Oct 2019 22:34:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > (copy-keymap is used 76 times in the Emacs tree.) Yes, I know. I've had it in my TODO to get this number down, but never got around to it. Stefan From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2019 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Ingebrigtsen , Eli Zaretskii Cc: ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157100270220252 (code B ref 7496); Sun, 13 Oct 2019 21:39:02 +0000 Received: (at 7496) by debbugs.gnu.org; 13 Oct 2019 21:38:22 +0000 Received: from localhost ([127.0.0.1]:37204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJlZG-0005GX-0r for submit@debbugs.gnu.org; Sun, 13 Oct 2019 17:38:22 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:55778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJlZB-0005GE-PR for 7496@debbugs.gnu.org; Sun, 13 Oct 2019 17:38:18 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9DLThLO017010; Sun, 13 Oct 2019 21:38:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=nosS8GlTVuEzQ96O/Em3NH1sfq1ft0we3UNT7f+8AqM=; b=focflSDO/e+xShOZJaX17Etsfn62rybGrYjrw27JyXUYXTDEX7WtcB2+4gour0zoMpJh wN3Z1UeYxQFW1iAhy+Ldfjvjxd8ve3YuHFG+0EdgKVckH3qJR1/5VbI9WRePgfDb1pec LgV5snPfyUmVeBg87iVmc5Meyu42KuLuw1VEKDBq6/pOBLfbBNvrO2v4qRS8Lb+3+7vT vqqUsmC0G3kX5AI2ZBx83i3SzncVYUobX1xM9hqvDCqP/pJ3pR8YudlpBn78l5wKMBZ3 1YSvPnC5KSZ+pdYCat5GS+GGgwRLevRgNaQA8lHRugig2g/Rzl4Blue4la8WdcOYMo72 GQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2vk7fqvtx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 13 Oct 2019 21:38:11 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9DLbwm6066346; Sun, 13 Oct 2019 21:38:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2vks05fwsm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 13 Oct 2019 21:38:10 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9DLc7Zn012906; Sun, 13 Oct 2019 21:38:07 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 13 Oct 2019 21:38:06 +0000 (UTC) From: Drew Adams References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> In-Reply-To: <87blukbkbk.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9409 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=100 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=444 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910130216 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9409 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=100 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=463 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910130215 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > It's easy to reproduce, though: Just eval this form and Emacs will > segfault (if it's older than yesterday's): >=20 > (let ((map (make-sparse-keymap))) > (define-key map " " map) > (copy-keymap map)) FWIW, on MS Windows, Emacs 26.3, emacs -Q hangs if I do that, after showing this message in the echo area: Re-entering top level after C stack overflow. Have to kill the process with the Task Manager. From unknown Tue Aug 19 10:04:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7496: 23.2; copy recursive keymap cause crash Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Oct 2019 06:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Drew Adams Cc: larsi@gnus.org, ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org Received: via spool by 7496-submit@debbugs.gnu.org id=B7496.157103337127225 (code B ref 7496); Mon, 14 Oct 2019 06:10:02 +0000 Received: (at 7496) by debbugs.gnu.org; 14 Oct 2019 06:09:31 +0000 Received: from localhost ([127.0.0.1]:37752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJtXv-000753-0p for submit@debbugs.gnu.org; Mon, 14 Oct 2019 02:09:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJtXt-00074r-Je for 7496@debbugs.gnu.org; Mon, 14 Oct 2019 02:09:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJtXn-0000i3-B0; Mon, 14 Oct 2019 02:09:23 -0400 Received: from [176.228.60.248] (port=2705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJtXk-0005eu-FX; Mon, 14 Oct 2019 02:09:23 -0400 Date: Mon, 14 Oct 2019 09:09:14 +0300 Message-Id: <83v9srkgdx.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Drew Adams on Sun, 13 Oct 2019 21:38:06 +0000 (UTC)) References: <871v67o9ns.fsf@nagi.lyrical.homelinux.net> <874l0dh2e2.fsf@gnus.org> <83zhi5ku7n.fsf@gnu.org> <87blukbkbk.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 13 Oct 2019 21:38:06 +0000 (UTC) > From: Drew Adams > Cc: ari@mbf.ocn.ne.jp, monnier@iro.umontreal.ca, 7496@debbugs.gnu.org > > > It's easy to reproduce, though: Just eval this form and Emacs will > > segfault (if it's older than yesterday's): > > > > (let ((map (make-sparse-keymap))) > > (define-key map " " map) > > (copy-keymap map)) > > FWIW, on MS Windows, Emacs 26.3, emacs -Q hangs if I > do that, after showing this message in the echo area: > > Re-entering top level after C stack overflow. > > Have to kill the process with the Task Manager. Thanks for testing. So the stack overflow protection does kick in.