GNU bug report logs - #74952
[PATCH] guix-install.sh: Use "command -v nologin" instead of "which nologin".

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Simon Josefsson via Bug reports for GNU Guix <bug-guix <at> gnu.org>
Cc: 74952 <at> debbugs.gnu.org
Subject: Re: bug#74952: [PATCH] guix-install.sh: Use "command -v nologin"
 instead of "which nologin".
Date: Wed, 18 Dec 2024 16:55:21 -0500

On Wed, Dec 18, 2024 at 09:35:27PM +0100, Simon Josefsson via Bug reports for GNU Guix wrote:
> Hi!
> 
> In a small container image, I do not have the 'which' tool installed.  I
> believe 'command -v' is always available since it is /bin/sh standard.
> How about changing the idiom for user/group additions from 'which' to
> 'command -v'?  See attached patch.

Agreed, I don't think we need to require `which` here.

It can also be removed from REQUIRE in 'etc/guix-install.sh'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.