From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 09:22:40 2024 Received: (at submit) by debbugs.gnu.org; 18 Dec 2024 14:22:40 +0000 Received: from localhost ([127.0.0.1]:34012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNuwh-0005zZ-FN for submit@debbugs.gnu.org; Wed, 18 Dec 2024 09:22:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:52782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNuwc-0005zN-H4 for submit@debbugs.gnu.org; Wed, 18 Dec 2024 09:22:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNuuR-00068j-LA for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2024 09:20:20 -0500 Received: from thaodan.de ([2a03:4000:4f:f15::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNuuN-0002Rc-Rx for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2024 09:20:19 -0500 Received: from NordStern (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id B97F3D0004F for ; Wed, 18 Dec 2024 16:20:03 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1734531603; bh=oIynBIHTWCemWzP5neFJ3KmCZz0Qi38c/7u4eGSe9us=; h=From:To:Subject:Date; b=KYlEQKEYmzEKaaFt2pnVUxvoXJh5bzeQZO/ISob9GYvLttU0atbw3PAD/hVbmYGq+ 0AAkltf0Q7WVGdkSGn6ZqGlwYn/7tiULHYh/rM16+9J6bbScgDHNRX8wonip77R6k/ 4AWZep58+SPSTq8sj+An1UaZYa50tBwoMVHQMs2I4dKs6FWB8wJ2gUc9OuSG8wvDX7 PWZHq+wrvhR5JiL8U6jXeHWbTiRsPp9I1y3RVTXQPZAb3lLjq/S4cKeqYsV88OjvK5 EU0FaVL6FUybiv68mwTARRBzv//eEK3rXVrd6RRUdsYvy4O+H22cRdCHnXiH7o6dtm zpKnfsdQQdeOGS//K4gqrCGgbEShZrOIHz99t8efpmlu2E8/5MrQCfWlnKdz+E3Gjl mrzc3tP5+8wWnJ0fDQDal5/P/bSxemwzUO3UT9jGp1jQWBhdOBIvr5Fzbqxg55eqOf YdRhue6xXCr4FkdBhjs9vXW7FidO3yvsC3NravYqzSaR3M31xAhJcxNAdZMY5ss3V2 QqHc751lO5mwJaRH1OISeFsgMugGvkduta8ftgg3m9/ZY3X5Y/oSPx20pRUeW9r3y5 9SiEssXcj94nSXfI8DR2IQegK9wmVoY1lEo5BsebvcDiveEObsppVfoQ8r7XhycziU 0Qro0wQZ2I1RruP5yEwZuweY= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: bug-gnu-emacs@gnu.org Subject: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too X-Debbugs-Cc: Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Wed, 18 Dec 2024 16:19:59 +0200 Message-ID: <87frml6pkg.fsf@thaodan.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a03:4000:4f:f15::1; envelope-from=bjorn.bidar@thaodan.de; helo=thaodan.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Include gdbinit inside auto-mode-alist. Since gdb 11.1 it's the preferred name of gdbinit. Please also include into Emacs 30 if possible. In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2) Repository revision: eaf5bf736e1dd5eb977a16a3f1b3dfd3da3c4612 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101014 System Description: openSUSE Tumbleweed Configured using: 'configure --disable-build-details --without-pop --with-mailutils --without-hesiod --with-gameuser=:games --with-kerberos --with-kerberos5 --with-file-notification=inotify --with-modules --enable-autodepend --enable-link-time-optimization --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --localstatedir=/var --sharedstatedir=/var/lib --libexecdir=/usr/libexec --with-file-notification=yes --libdir=/usr/lib64 --with-native-compilation=aot --enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp --with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff --with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm --with-tree-sitter --with-x-toolkit=gtk --without-pgtk --with-toolkit-scroll-bars --x-includes=/usr/include --x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo --build=x86_64-suse-linux --with-dumping=pdumper build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4 -mno-xop -mfma -mbmi -mbmi2 -maes -mpclmul -mno-gfni -mvpclmulqdq -mno-3dnow -madx -mabm -mno-cldemote -mclflushopt -mclwb -mclzero -mcx16 -mno-enqcmd -mf16c -mfsgsbase -mfxsr -mno-hle -msahf -mno-lwp -mlzcnt -mmovbe -mno-movdir64b -mno-movdiri -mmwaitx -mno-pconfig -mpku -mprfchw -mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize -mno-sgx -msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg -mwbnoinvd -mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile -mno-amx-int8 -mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl -mno-avxvnni -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert -mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint -mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -D_GNU_SOURCE -DGDK_DISABLE_DEPRECATION_WARNINGS -DGLIB_DISABLE_DEPRECATION_WARNINGS -pipe -Wno-pointer-sign -Wno-unused-variable -Wno-unused-label -DPDMP_BASE='\''"emacs-gtk"'\''' LDFLAGS=-Wl,-O2 'CXX=sccache c++' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-files.el-auto-mode-alist-Include-gdbinit-too.patch >From 1ba2ce9320513efa0fb4b2d6a5022bb9d635af68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= Date: Wed, 18 Dec 2024 16:07:34 +0200 Subject: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too Since gdb 11.1 .gdbinit can be also called gdbinit saved inside $XDG_CONFIG_HOME or $HOME/Library/Preferences/gdb on Apple Hosts. https://lists.gnu.org/archive/html/info-gnu/2021-09/msg00007.html --- lisp/files.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index 9f13804540b..6fe037f30e7 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -3001,11 +3001,12 @@ auto-mode-alist ("\\.css\\'" . css-mode) ("\\.mixal\\'" . mixal-mode) ("\\.gcov\\'" . compilation-mode) - ;; Besides .gdbinit, gdb documents other names to be usable for init + ;; gdbinit can be gdbinit or .gdbinit the exact prefix does not matter. + ;; Besides gdbinit, gdb documents other names to be usable for init ;; files, cross-debuggers can use something like ;; .PROCESSORNAME-gdbinit so that the host and target gdbinit files ;; don't interfere with each other. - ("/\\.[a-z0-9-]*gdbinit" . gdb-script-mode) + ("/[.a-z0-9-]*gdbinit" . gdb-script-mode) ;; GDB 7.5 introduced OBJFILE-gdb.gdb script files; e.g. a file ;; named 'emacs-gdb.gdb', if it exists, will be automatically ;; loaded when GDB reads an objfile called 'emacs'. -- 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 20:01:42 2024 Received: (at 74946) by debbugs.gnu.org; 19 Dec 2024 01:01:42 +0000 Received: from localhost ([127.0.0.1]:36609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO4v7-0004Cm-QO for submit@debbugs.gnu.org; Wed, 18 Dec 2024 20:01:42 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:59486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tO4v5-0004Cc-7N for 74946@debbugs.gnu.org; Wed, 18 Dec 2024 20:01:40 -0500 Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d3bbb0f09dso320892a12.2 for <74946@debbugs.gnu.org>; Wed, 18 Dec 2024 17:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734570038; x=1735174838; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5Ns8I5s9NOKI4BaEgUkNgD/u7p6HUACABVqUCLyx9Q=; b=f9RosLjSGZ498SKnXxeMD3G1F9V6wQTYPk53/647ZxjF9qkgswV91KREMt2YZiZtOa COnfHSbJxGup9zRkWbwFjgbpCXUosdG7m+3yxlk/+PsVa+tP6EIVWP5Bsm3uBqt5iioy FpvBi5HgcT4C9FhayCPH47n6K8UdzqLm3K8zySNbv4RdWJNOhx6nyZSgMQ8gnX0XBJZt yGpYV91GM4KaxdrQElba/gfukU0Q5fT8TiTl/Ym+wwHtVOi2gMA6qpmhSpY/mdfvbhxz ntOf3lcVEAoGSY0i9eCbiABBgl6a81o9OBY3RjxWmV1cudpspHimCxlp3RZGvu6WYGSv IUJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734570038; x=1735174838; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=T5Ns8I5s9NOKI4BaEgUkNgD/u7p6HUACABVqUCLyx9Q=; b=QVUccO03z6cqOiWPQMLBw5penGACgKY5t3EiEsK8F5tVPPFsg2BzbYr6TL6wKuR+bs RfhLrQlt6awSngnHqPmC8DhMC/B8FNyBsoAtb+ciJ9uexCMMUzg1T9uvU/A51DFue6cI dCXFzOmHdody29vArwcVjfE+n3+ET4aB4T/Nrk20BloYYolv5DPmTTyt4IVVAq3WvnRy LJEygoKguj+/o1xYI28Q2sar1sI4CP0iFBfceCW1BY4EGRV2HrvZH8+IS/VH5eE/xJHc IRAqFTzGkOkCAW8r1CwfnTfP/RU3+Bl+wiuVLNtZ653TMAo32mudwZCzOJY50W3+T4MI lRbA== X-Forwarded-Encrypted: i=1; AJvYcCU6Fitr4KF4E0WbObh3bVOeVvLcurQrKcSqwHIpZU8I8k48Ef5+nMRo70GZfqh1njaB0fWJvg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwZpMLi6GukGQKfq9H3Vux9WXECuWNKv2TumfHhKbGnFzgAK+80 t1uvAxJLFINr70iOoAXj/ESgfmtW9XKd7VNBe5DPxvbwGhP0KgzngZphonDOSxjCinXCzovJxHH 1sjvQEP3YipAqpss++AH0J6ujPYg= X-Gm-Gg: ASbGncv9P1bsHn9Jm+kMU/dRozElPUTe7SGo6cHw29cC6r2/GNsSHXCufMXCxlkEcjw UABp5BwQogMliYU1t+sYfQbXwfyEEaLPyd+eTyw== X-Google-Smtp-Source: AGHT+IGgF112YrkXVwkgWKWMWhzQYcTaMxaB0VPJqpHfkYf8EQBBYwLirIg4itoPTX6q2VorbcyVPtS4LHoNu5/TvKg= X-Received: by 2002:a05:6402:239c:b0:5d8:f8:e6f5 with SMTP id 4fb4d7f45d1cf-5d800f8e773mr1225401a12.0.1734570038028; Wed, 18 Dec 2024 17:00:38 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 18 Dec 2024 20:00:37 -0500 From: Stefan Kangas In-Reply-To: <87frml6pkg.fsf@thaodan.de> References: <87frml6pkg.fsf@thaodan.de> MIME-Version: 1.0 Date: Wed, 18 Dec 2024 20:00:37 -0500 Message-ID: Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too To: =?UTF-8?B?QmrDtnJuIEJpZGFy?= , 74946@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74946 Cc: Eli Zaretskii , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of te= xt editors" writes: > From 1ba2ce9320513efa0fb4b2d6a5022bb9d635af68 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D > Date: Wed, 18 Dec 2024 16:07:34 +0200 > Subject: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too > > Since gdb 11.1 .gdbinit can be also called gdbinit saved inside > $XDG_CONFIG_HOME or $HOME/Library/Preferences/gdb on Apple Hosts. > > https://lists.gnu.org/archive/html/info-gnu/2021-09/msg00007.html > --- > lisp/files.el | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/files.el b/lisp/files.el > index 9f13804540b..6fe037f30e7 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -3001,11 +3001,12 @@ auto-mode-alist > ("\\.css\\'" . css-mode) > ("\\.mixal\\'" . mixal-mode) > ("\\.gcov\\'" . compilation-mode) > - ;; Besides .gdbinit, gdb documents other names to be usable for ini= t > + ;; gdbinit can be gdbinit or .gdbinit the exact prefix does not mat= ter. > + ;; Besides gdbinit, gdb documents other names to be usable for init I'd leave the comment as is. > ;; files, cross-debuggers can use something like > ;; .PROCESSORNAME-gdbinit so that the host and target gdbinit files > ;; don't interfere with each other. > - ("/\\.[a-z0-9-]*gdbinit" . gdb-script-mode) > + ("/[.a-z0-9-]*gdbinit" . gdb-script-mode) Thanks, but shouldn't that be - ("/\\.[a-z0-9-]*gdbinit" . gdb-script-mode) + ("/\\.?[a-z0-9-]*gdbinit" . gdb-script-mode) ? > Please also include into Emacs 30 if possible. If Eli and Andrea agrees, I think we could do it. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 03:14:13 2024 Received: (at 74946) by debbugs.gnu.org; 19 Dec 2024 08:14:13 +0000 Received: from localhost ([127.0.0.1]:37336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBfg-00018O-JM for submit@debbugs.gnu.org; Thu, 19 Dec 2024 03:14:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOBfe-000187-AM for 74946@debbugs.gnu.org; Thu, 19 Dec 2024 03:14:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOBfY-0000Ha-Do; Thu, 19 Dec 2024 03:14:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SVr5xjVeFCtEGG1UI8PB5vJmgfZne4IJjDG6XXRXWNY=; b=awj4h0XH6VBx xUpvbfZHhw9k+GSmdv7UtlgAgm/XKs5s1su/Ywdknewk+xPekF7Av4Bau2uFUMX281uWCbZHF3zx3 eiBlosnYS07lHhOqaILvt+2kVAfzk4joOEAub64+/wdo1OSu9RP8y7DCB+rK97kCu4l13h/8YZXpx z7iZ9ejsw5SVbvWR0KulST07s4hDBTd6X+WVwh2uTx90amJtjv2smhj/VlIaPpUBmwLI7mF894Gvc 6Du+ino6PPC4OccQw6rZUb4xwcGCXJJ6F7It3JkUoDeKCmidKpvnAEBROkIEoJdBMh514mAMtMLcs BnUkdruvEORVQPsz3LUO1g==; Date: Thu, 19 Dec 2024 10:14:00 +0200 Message-Id: <86o718ks3b.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 18 Dec 2024 20:00:37 -0500) Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too References: <87frml6pkg.fsf@thaodan.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74946 Cc: bjorn.bidar@thaodan.de, acorallo@gnu.org, 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 18 Dec 2024 20:00:37 -0500 > Cc: Eli Zaretskii , Andrea Corallo > > > Please also include into Emacs 30 if possible. > > If Eli and Andrea agrees, I think we could do it. It looks innocent enough, but at this point I'd like to limit changes on the release branch to only really urgent and important ones (or documentation). We have lived with this outdated code for several years (GDB 11.1 was released in 2022), so this change doesn't look urgent to me. Btw, if we want to fix this entry, we should perhaps do a more thorough job. For example, on my system I have files with the following base names: .gdbinit.in .gdbinit _gdbinit (for MS-DOS) gdb.ini (likewise) gdbinit gdbinit.in SOMETHING-gdbinit .gdbinit.loader gdbinit-history.exp (not a GDB init file) gdbinit.5 (likewise) gdbinit.c (likewise) .gdbinit.py.in (likewise) Should we improve the regexp to DTRT for those additional files, but without false positives? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 16:29:10 2024 Received: (at 74946) by debbugs.gnu.org; 19 Dec 2024 21:29:10 +0000 Received: from localhost ([127.0.0.1]:40336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOO4z-0005mc-NP for submit@debbugs.gnu.org; Thu, 19 Dec 2024 16:29:10 -0500 Received: from thaodan.de ([185.216.177.71]:56632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOO4x-0005mN-2w for 74946@debbugs.gnu.org; Thu, 19 Dec 2024 16:29:08 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 0AAA7D00099; Thu, 19 Dec 2024 23:29:01 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1734643741; bh=/WmWysFh2TPzpimjaEoPo+ReiHC5zTH5qrsXocEru74=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=C3y5tA8CKqqJ0dzPTfhmJr9ahh7QJgbGTZ3YoHDq5hYeBLbJpI+MNucNxKIZvJSLW r9vgK1IDnZn49JAERyazh0RbqR5yK8Aog4cPg16snhSsuAl0NmVegvrEm/3hqjqu7D tNZrWlM2i5EZwNPLANBlfcaeUL5sLhsDiHpqY8jqlFRGb4VsnOdoEGPnZMRAfd+5u2 sKJ+hv92QqlDPgsYeVbA8RtO0CnWpLrXXQXfoJWmWjmKm2TpM5MHBQYKAOuPPgd6l7 iJSLRD74tj3UajaE+qtOTaIZsKalfPIp7IwzUYx6pvUDiOuIQxwfsn517qOxCVPj6a z5s6nGIU3xOQJ6CkoTrj/VypnNatwGf46ig9EenSfcIARtBB/X8lcHVbQ0Sa9V0iXD MVEkZgo6muQk/bNPK57AsoR+nyhts45vMZvWQEfWvy0ttnWiMGVL4c0EDjwVvL6G11 bLs0akHA9uGauFg/Q9slGZFc/P29JRarVxVANXHxct1NBtL4rigJKJLfOHFMuD5tzu rAI4ZMZv3sXagQjPDjT5kdiM/LuZINiXjLSDQXsnFBSHTrAdWPOMN/TQVYoOWzYE0Z V+L6Kzuc1/E5pucu4u4T59InQbjTUmE4iHl+zDi7g+XMeWdzvAhTEXCdW5ApfW743A Bqd/KMaJCAexB1souC1gIWdQ= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too In-Reply-To: <86o718ks3b.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2024 10:14:00 +0200") References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Thu, 19 Dec 2024 23:29:00 +0200 Message-ID: <87frmjtl9f.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Wed, 18 Dec 2024 20:00:37 -0500 >> Cc: Eli Zaretskii , Andrea Corallo >> >> > Please also include into Emacs 3 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74946 Cc: acorallo@gnu.org, Stefan Kangas , 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Wed, 18 Dec 2024 20:00:37 -0500 >> Cc: Eli Zaretskii , Andrea Corallo >> >> > Please also include into Emacs 30 if possible. >> >> If Eli and Andrea agrees, I think we could do it. > > It looks innocent enough, but at this point I'd like to limit changes > on the release branch to only really urgent and important ones (or > documentation). We have lived with this outdated code for several > years (GDB 11.1 was released in 2022), so this change doesn't look > urgent to me. Not really that urgent but to new users of Emacs it would be beneficial if things would work out of the box. I thought at first Emacs just didn't support the file. > Btw, if we want to fix this entry, we should perhaps do a more > thorough job. For example, on my system I have files with the > following base names: > > .gdbinit.in > .gdbinit > _gdbinit (for MS-DOS) > gdb.ini (likewise) Is this a gdbinit file? The extension looks off. > gdbinit > gdbinit.in > SOMETHING-gdbinit > .gdbinit.loader > gdbinit-history.exp (not a GDB init file) > gdbinit.5 (likewise) > gdbinit.c (likewise) > .gdbinit.py.in (likewise) > > Should we improve the regexp to DTRT for those additional files, but > without false positives? With Stefan correction all these without extension match. What are the official extensions? gdbinit.in sounds like a normal extension for gdbinit template in the source but the others such as gdb.ini look off. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 17:56:33 2024 Received: (at 74946) by debbugs.gnu.org; 19 Dec 2024 22:56:33 +0000 Received: from localhost ([127.0.0.1]:40542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOPRY-0001Sr-Kj for submit@debbugs.gnu.org; Thu, 19 Dec 2024 17:56:33 -0500 Received: from mail-ed1-f41.google.com ([209.85.208.41]:61735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOPRV-0001Sc-V9 for 74946@debbugs.gnu.org; Thu, 19 Dec 2024 17:56:30 -0500 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3d0205bd5so1782134a12.3 for <74946@debbugs.gnu.org>; Thu, 19 Dec 2024 14:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734648924; x=1735253724; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=GcPF46nFg2Es/DahSSINk6sDVbHgd/UFI+jMqFutIeI=; b=XCHz/bKCuWyX9PzQvmTYxs9c1eQ/xGuuY/c1b86xxGigcP5E8o0bRsNKVYADwvGwXH LMLH49WWBxCy328N/kw5q35538CAybdL7o6XNo88J365a9dCOLu3gKuW323zYucjiNRD sSxWRRsVEVpZ09sGzO9A5v6TX9gdkRoeqC0/d48+10CChh4V0kLxt3tFEZDeVdUk3J73 ZzNFFRoTtNSMlr5JZT6lHyV04yeIAzmXUdZ03Lph1d6Tqavu/7Evo+BMeDXiMA+AEb4S GRZA2P5bNeSM/3450EbqDrwa7fXyvM13DtyNOSv/KvWPkwGXG7zRl2cfTyicbYtkYZOL amtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734648924; x=1735253724; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GcPF46nFg2Es/DahSSINk6sDVbHgd/UFI+jMqFutIeI=; b=rYyCpuAZtlU97FDkb58/+q3LSSQS8ra+bxUHPZi7OcXHgyLyV18jVJ7ZjK+q038SHU QEKkzCElCPRH/y5h23ymjsNobXFtOnZKoOqZM/dT3+F3I1SyWW11WK4mKSzRInKjgtV9 GFKx3pXDbTQITwS0FSrLWkLRyWoFJUdk+3vvljhTNMhh/SpAOjZFOUlKJpysc+RuwauR CHrp2AWWrS69LTw7ESJdcM+gl+pJaZPE/AOGaA7oMohEf7S2RrcuKXez6KvMJhxs7qmg KaeXLDkFwkTz4nGS39nPz4TVoOoVDw2qcWvESGZVp1PlYj/Uw+3DojfOti2g4Z30mHc1 xC+Q== X-Forwarded-Encrypted: i=1; AJvYcCUJyzbJHUc+R1ZGA2X51OThGGp0bwmyWwRc4t/0cveUgxADvauZbAY58MbBITKlowIgtdngOQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwOvxFQAkTpcjcg4K04LN/Ogap0Mhl5WRaSAsgHgCpFQnRTVhF/ CHmi+cfDRTf4ODXh7RNlKtORmrPiFSCjEC53q+1e/+U3vgsnkgN2CEMfpPQC47DPT4cTAaKwn1i ESEcuyOXgpXrmchAuC2NTLNZ9KzI= X-Gm-Gg: ASbGncurmpFLMbdHncI3SFrsBjAVqix6xE1khteGnkvmjb+lFCueEHdAZkQnFdbT4jV hGJlUDQv+mHJEv68DQJP9pVbGwFpHd2YA+kPWNQ== X-Google-Smtp-Source: AGHT+IGgO75zvyopmvGQhFM/lxVvpB8p4wcOEu01kh8XQDuy2axMZEYF4Trifb7/IOuQ9uUiKyrYVHGodGmbHxOMvF8= X-Received: by 2002:a05:6402:84c:b0:5d0:b925:a8a with SMTP id 4fb4d7f45d1cf-5d81dda80bemr533234a12.16.1734648923805; Thu, 19 Dec 2024 14:55:23 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Dec 2024 17:55:22 -0500 From: Stefan Kangas In-Reply-To: <86o718ks3b.fsf@gnu.org> References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 19 Dec 2024 17:55:22 -0500 Message-ID: Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000ea2c880629a76ce7" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74946 Cc: bjorn.bidar@thaodan.de, acorallo@gnu.org, 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ea2c880629a76ce7 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Btw, if we want to fix this entry, we should perhaps do a more > thorough job. For example, on my system I have files with the > following base names: > > .gdbinit.in > .gdbinit > _gdbinit (for MS-DOS) > gdb.ini (likewise) > gdbinit > gdbinit.in > SOMETHING-gdbinit > .gdbinit.loader > gdbinit-history.exp (not a GDB init file) > gdbinit.5 (likewise) > gdbinit.c (likewise) > .gdbinit.py.in (likewise) > > Should we improve the regexp to DTRT for those additional files, but > without false positives? Maybe something like the below patch? BTW, should the .gdbinit.py.in file be in python-mode perhaps? And what about gdbinit.5? --000000000000ea2c880629a76ce7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Match-more-gdbinit-files.patch" Content-Disposition: attachment; filename="0001-Match-more-gdbinit-files.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 70edde6933e5f227_0.1 RnJvbSBhNWE1ZGNkMDQ1MmNhZGZlZTk4OGEwMjU2YzEwODc3ODM1ZWVmY2VmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUaHUsIDE5IERlYyAyMDI0IDIzOjUxOjM4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g TWF0Y2ggbW9yZSBnZGJpbml0IGZpbGVzCgoqIGxpc3AvZmlsZXMuZWwgKGF1dG8tbW9kZS1hbGlz dCk6IE1hdGNoIG1vcmUgZ2RiaW5pdCBmaWxlcywKaW5jbHVkaW5nIFhERywgYW5kIE1TLVdpbmRv d3MuICBBdm9pZCBmYWxzZSBwb3NpdGl2ZXMuCihCdWcjNzQ5NDYpCihzZXQtYXV0by1tb2RlLS1m aW5kLW1hdGNoaW5nLWFsaXN0LWVudHJ5KTogQnJlYWsgb3V0IGZ1bmN0aW9uLi4uCihzZXQtYXV0 by1tb2RlLS1hcHBseS1hbGlzdCk6IC4uLmZyb20gaGVyZS4KKiB0ZXN0L2xpc3AvZmlsZXMtdGVz dHMuZWwgKGZpbGVzLXRlc3RzLWF1dG8tbW9kZS1hbGlzdCk6IE5ldwp0ZXN0LgotLS0KIGxpc3Av ZmlsZXMuZWwgICAgICAgICAgICB8IDU2ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0KIHRlc3QvbGlzcC9maWxlcy10ZXN0cy5lbCB8IDE3ICsrKysrKysrKysrKwogMiBm aWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCA5ZjEzODA0NTQwYi4uNjhj ZTJlMGMyNzMgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApA QCAtMzAwNSw3ICszMDA1LDcgQEAgYXV0by1tb2RlLWFsaXN0CiAgICAgIDs7IGZpbGVzLCBjcm9z cy1kZWJ1Z2dlcnMgY2FuIHVzZSBzb21ldGhpbmcgbGlrZQogICAgICA7OyAuUFJPQ0VTU09STkFN RS1nZGJpbml0IHNvIHRoYXQgdGhlIGhvc3QgYW5kIHRhcmdldCBnZGJpbml0IGZpbGVzCiAgICAg IDs7IGRvbid0IGludGVyZmVyZSB3aXRoIGVhY2ggb3RoZXIuCi0gICAgICgiL1xcLlthLXowLTkt XSpnZGJpbml0IiAuIGdkYi1zY3JpcHQtbW9kZSkKKyAgICAgKCIvWy5fXT9bQS1aYS16MC05LV0q XFwoPzpnZGJpbml0XFwoPzpcXC5cXCg/OmluaT9cXHxsb2FkZXJcXClcXCk/XFx8Z2RiXFwuaW5p XFwpXFwnIiAuIGdkYi1zY3JpcHQtbW9kZSkKICAgICAgOzsgR0RCIDcuNSBpbnRyb2R1Y2VkIE9C SkZJTEUtZ2RiLmdkYiBzY3JpcHQgZmlsZXM7IGUuZy4gYSBmaWxlCiAgICAgIDs7IG5hbWVkICdl bWFjcy1nZGIuZ2RiJywgaWYgaXQgZXhpc3RzLCB3aWxsIGJlIGF1dG9tYXRpY2FsbHkKICAgICAg OzsgbG9hZGVkIHdoZW4gR0RCIHJlYWRzIGFuIG9iamZpbGUgY2FsbGVkICdlbWFjcycuCkBAIC0z NDA0LDYgKzM0MDQsMzUgQEAgbWFnaWMtbW9kZS1yZWdleHAtbWF0Y2gtbGltaXQKICAgIlVwcGVy IGxpbWl0IG9uIGBtYWdpYy1tb2RlLWFsaXN0JyByZWdleHAgbWF0Y2hlcy4KIEFsc28gYXBwbGll cyB0byBgbWFnaWMtZmFsbGJhY2stbW9kZS1hbGlzdCcuIikKIAorKGRlZnVuIHNldC1hdXRvLW1v ZGUtLWZpbmQtbWF0Y2hpbmctYWxpc3QtZW50cnkgKGFsaXN0IG5hbWUgY2FzZS1pbnNlbnNpdGl2 ZSkKKyAgIkZpbmQgZmlyc3QgbWF0Y2hpbmcgZW50cnkgaW4gQUxJU1QgZm9yIGZpbGUgTkFNRS4K KworSWYgQ0FTRS1JTlNFTlNJVElWRSwgdGhlIGZpbGUgc3lzdGVtIG9mIGZpbGUgTkFNRSBpcyBj YXNlLWluc2Vuc2l0aXZlLiIKKyAgKGxldCAobW9kZSkKKyAgICAod2hpbGUgbmFtZQorICAgICAg KHNldHEgbW9kZQorICAgICAgICAgICAgKGlmIGNhc2UtaW5zZW5zaXRpdmUKKyAgICAgICAgICAg ICAgICA7OyBGaWxlc3lzdGVtIGlzIGNhc2UtaW5zZW5zaXRpdmUuCisgICAgICAgICAgICAgICAg KGxldCAoKGNhc2UtZm9sZC1zZWFyY2ggdCkpCisgICAgICAgICAgICAgICAgICAoYXNzb2MtZGVm YXVsdCBuYW1lIGFsaXN0ICdzdHJpbmctbWF0Y2gpKQorICAgICAgICAgICAgICA7OyBGaWxlc3lz dGVtIGlzIGNhc2Utc2Vuc2l0aXZlLgorICAgICAgICAgICAgICAob3IKKyAgICAgICAgICAgICAg IDs7IEZpcnN0IG1hdGNoIGNhc2Utc2Vuc2l0aXZlbHkuCisgICAgICAgICAgICAgICAobGV0ICgo Y2FzZS1mb2xkLXNlYXJjaCBuaWwpKQorICAgICAgICAgICAgICAgICAoYXNzb2MtZGVmYXVsdCBu YW1lIGFsaXN0ICdzdHJpbmctbWF0Y2gpKQorICAgICAgICAgICAgICAgOzsgRmFsbGJhY2sgdG8g Y2FzZS1pbnNlbnNpdGl2ZSBtYXRjaC4KKyAgICAgICAgICAgICAgIChhbmQgYXV0by1tb2RlLWNh c2UtZm9sZAorICAgICAgICAgICAgICAgICAgICAobGV0ICgoY2FzZS1mb2xkLXNlYXJjaCB0KSkK KyAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtZGVmYXVsdCBuYW1lIGFsaXN0ICdzdHJpbmct bWF0Y2gpKSkpKSkKKyAgICAgIChpZiAoYW5kIG1vZGUKKyAgICAgICAgICAgICAgIChub3QgKGZ1 bmN0aW9ucCBtb2RlKSkKKyAgICAgICAgICAgICAgIChjb25zcCBtb2RlKQorICAgICAgICAgICAg ICAgKGNhZHIgbW9kZSkpCisgICAgICAgICAgKHNldHEgbW9kZSAoY2FyIG1vZGUpCisgICAgICAg ICAgICAgICAgbmFtZSAoc3Vic3RyaW5nIG5hbWUgMCAobWF0Y2gtYmVnaW5uaW5nIDApKSkKKyAg ICAgICAgKHNldHEgbmFtZSBuaWwpKSkKKyAgICBtb2RlKSkKKwogKGRlZnVuIHNldC1hdXRvLW1v ZGUtLWFwcGx5LWFsaXN0IChhbGlzdCBrZWVwLW1vZGUtaWYtc2FtZSBkaXItbG9jYWwpCiAgICJI ZWxwZXIgZnVuY3Rpb24gZm9yIGBzZXQtYXV0by1tb2RlJy4KIFRoaXMgZnVuY3Rpb24gdGFrZXMg YW4gYWxpc3Qgb2YgdGhlIHNhbWUgZm9ybSBhcwpAQCAtMzQyNSwyOSArMzQ1NCw4IEBAIHNldC1h dXRvLW1vZGUtLWFwcGx5LWFsaXN0CiAgICAgICAgICh3aGVuIChhbmQgKHN0cmluZ3AgcmVtb3Rl LWlkKQogICAgICAgICAgICAgICAgICAgIChzdHJpbmctbWF0Y2ggKHJlZ2V4cC1xdW90ZSByZW1v dGUtaWQpIG5hbWUpKQogICAgICAgICAgIChzZXRxIG5hbWUgKHN1YnN0cmluZyBuYW1lIChtYXRj aC1lbmQgMCkpKSkKLSAgICAgICAgKHdoaWxlIG5hbWUKLSAgICAgICAgICA7OyBGaW5kIGZpcnN0 IG1hdGNoaW5nIGFsaXN0IGVudHJ5LgotICAgICAgICAgIChzZXRxIG1vZGUKLSAgICAgICAgICAg ICAgICAoaWYgY2FzZS1pbnNlbnNpdGl2ZS1wCi0gICAgICAgICAgICAgICAgICAgIDs7IEZpbGVz eXN0ZW0gaXMgY2FzZS1pbnNlbnNpdGl2ZS4KLSAgICAgICAgICAgICAgICAgICAgKGxldCAoKGNh c2UtZm9sZC1zZWFyY2ggdCkpCi0gICAgICAgICAgICAgICAgICAgICAgKGFzc29jLWRlZmF1bHQg bmFtZSBhbGlzdCAnc3RyaW5nLW1hdGNoKSkKLSAgICAgICAgICAgICAgICAgIDs7IEZpbGVzeXN0 ZW0gaXMgY2FzZS1zZW5zaXRpdmUuCi0gICAgICAgICAgICAgICAgICAob3IKLSAgICAgICAgICAg ICAgICAgICA7OyBGaXJzdCBtYXRjaCBjYXNlLXNlbnNpdGl2ZWx5LgotICAgICAgICAgICAgICAg ICAgIChsZXQgKChjYXNlLWZvbGQtc2VhcmNoIG5pbCkpCi0gICAgICAgICAgICAgICAgICAgICAo YXNzb2MtZGVmYXVsdCBuYW1lIGFsaXN0ICdzdHJpbmctbWF0Y2gpKQotICAgICAgICAgICAgICAg ICAgIDs7IEZhbGxiYWNrIHRvIGNhc2UtaW5zZW5zaXRpdmUgbWF0Y2guCi0gICAgICAgICAgICAg ICAgICAgKGFuZCBhdXRvLW1vZGUtY2FzZS1mb2xkCi0gICAgICAgICAgICAgICAgICAgICAgICAo bGV0ICgoY2FzZS1mb2xkLXNlYXJjaCB0KSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgKGFz c29jLWRlZmF1bHQgbmFtZSBhbGlzdCAnc3RyaW5nLW1hdGNoKSkpKSkpCi0gICAgICAgICAgKGlm IChhbmQgbW9kZQotICAgICAgICAgICAgICAgICAgIChub3QgKGZ1bmN0aW9ucCBtb2RlKSkKLSAg ICAgICAgICAgICAgICAgICAoY29uc3AgbW9kZSkKLSAgICAgICAgICAgICAgICAgICAoY2FkciBt b2RlKSkKLSAgICAgICAgICAgICAgKHNldHEgbW9kZSAoY2FyIG1vZGUpCi0gICAgICAgICAgICAg ICAgICAgIG5hbWUgKHN1YnN0cmluZyBuYW1lIDAgKG1hdGNoLWJlZ2lubmluZyAwKSkpCi0gICAg ICAgICAgICAoc2V0cSBuYW1lIG5pbCkpKQorICAgICAgICAoc2V0cSBtb2RlIChzZXQtYXV0by1t b2RlLS1maW5kLW1hdGNoaW5nLWFsaXN0LWVudHJ5CisgICAgICAgICAgICAgICAgICAgIGFsaXN0 IG5hbWUgY2FzZS1pbnNlbnNpdGl2ZS1wKSkKICAgICAgICAgKHdoZW4gKGFuZCBkaXItbG9jYWwg bW9kZQogICAgICAgICAgICAgICAgICAgIChub3QgKHNldC1hdXRvLW1vZGUtLWRpci1sb2NhbC12 YWxpZC1wIG1vZGUpKSkKICAgICAgICAgICAobWVzc2FnZSAiSWdub3JpbmcgaW52YWxpZCBtb2Rl IGAlcyciIG1vZGUpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZmlsZXMtdGVzdHMuZWwgYi90ZXN0 L2xpc3AvZmlsZXMtdGVzdHMuZWwKaW5kZXggYWQ1NGFkZGYwNmIuLjBlZGM3OGQwMWU1IDEwMDY0 NAotLS0gYS90ZXN0L2xpc3AvZmlsZXMtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2ZpbGVzLXRl c3RzLmVsCkBAIC0xNjgwLDYgKzE2ODAsMjMgQEAgZmlsZXMtdGVzdHMtLWNoZWNrLXNoZWJhbmcK ICAgICAgICh3aGVuIChlcSBleHBlY3RlZC1tb2RlICdzaC1iYXNlLW1vZGUpCiAgICAgICAgIChz aG91bGQgKGVxIHNoLXNoZWxsIGV4cGVjdGVkLWRpYWxlY3QpKSkpKSkKIAorKGVydC1kZWZ0ZXN0 IGZpbGVzLXRlc3RzLWF1dG8tbW9kZS1hbGlzdCAoKQorICAoY2wtZmxldCAoKGZpbmQgKGZpbGUg bW9kZSAmb3B0aW9uYWwgY2FzZS1pbnNlbnNpdGl2ZSkKKyAgICAgICAgICAgICAgKGVxIG1vZGUg KHNldC1hdXRvLW1vZGUtLWZpbmQtbWF0Y2hpbmctYWxpc3QtZW50cnkKKyAgICAgICAgICAgICAg ICAgICAgICAgIGF1dG8tbW9kZS1hbGlzdCAoY29uY2F0ICIvaG9tZS9zdGVmYW5rLyIgZmlsZSkg Y2FzZS1pbnNlbnNpdGl2ZSkpKSkKKyAgICAoc2hvdWxkIChmaW5kICIuZ2RiaW5pdC5pbiIgIydn ZGItc2NyaXB0LW1vZGUpKQorICAgIChzaG91bGQgKGZpbmQgIi5nZGJpbml0IiAjJ2dkYi1zY3Jp cHQtbW9kZSkpCisgICAgKHNob3VsZCAoZmluZCAiX2dkYmluaXQiICMnZ2RiLXNjcmlwdC1tb2Rl KSkgOyBmb3IgTVMtRE9TCisgICAgKHNob3VsZCAoZmluZCAiZ2RiLmluaSIgIydnZGItc2NyaXB0 LW1vZGUpKSAgOyBsaWtld2lzZQorICAgIChzaG91bGQgKGZpbmQgImdkYmluaXQiICMnZ2RiLXNj cmlwdC1tb2RlKSkKKyAgICAoc2hvdWxkIChmaW5kICJnZGJpbml0LmluIiAjJ2dkYi1zY3JpcHQt bW9kZSkpCisgICAgKHNob3VsZCAoZmluZCAiU09NRVRISU5HLWdkYmluaXQiICMnZ2RiLXNjcmlw dC1tb2RlKSkKKyAgICAoc2hvdWxkIChmaW5kICIuZ2RiaW5pdC5sb2FkZXIiICMnZ2RiLXNjcmlw dC1tb2RlKSkKKyAgICAoc2hvdWxkLW5vdCAoZmluZCAiZ2RiaW5pdC1oaXN0b3J5LmV4cCIgIydn ZGItc2NyaXB0LW1vZGUpKSA7IG5vdCBhIEdEQiBpbml0IGZpbGUKKyAgICAoc2hvdWxkLW5vdCAo ZmluZCAiZ2RiaW5pdC41IiAjJ2dkYi1zY3JpcHQtbW9kZSkpICAgICAgICA7IGxpa2V3aXNlCisg ICAgKHNob3VsZC1ub3QgKGZpbmQgImdkYmluaXQuYyIgIydnZGItc2NyaXB0LW1vZGUpKSAgICAg ICAgOyBsaWtld2lzZQorICAgIChzaG91bGQtbm90IChmaW5kICIuZ2RiaW5pdC5weS5pbiIgIydn ZGItc2NyaXB0LW1vZGUpKSkpICAgICAgIDsgbGlrZXdpc2UKKwogKGVydC1kZWZ0ZXN0IGZpbGVz LXRlc3RzLWF1dG8tbW9kZS1pbnRlcnByZXRlciAoKQogICAiVGVzdCB0aGF0IGBzZXQtYXV0by1t b2RlJyBkZWR1Y2VzIGNvcnJlY3QgbW9kZXMgZnJvbSBzaGViYW5ncy4iCiAgIDs7IFN0cmFpZ2h0 Zm9yd2FyZCBpbnRlcnByZXRlciBpbnZvY2F0aW9uLgotLSAKMi40Ny4xCgo= --000000000000ea2c880629a76ce7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 20:33:30 2024 Received: (at 74946) by debbugs.gnu.org; 20 Dec 2024 01:33:30 +0000 Received: from localhost ([127.0.0.1]:40778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tORtR-0000Ab-Vn for submit@debbugs.gnu.org; Thu, 19 Dec 2024 20:33:30 -0500 Received: from thaodan.de ([185.216.177.71]:37812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tORtP-0000AL-CC for 74946@debbugs.gnu.org; Thu, 19 Dec 2024 20:33:28 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id B316CD00038; Fri, 20 Dec 2024 03:33:19 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1734658399; bh=MqfsXOA3rOhzlz0b3KFh6WLECSk9oZ4bxVin0RKJ0sI=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=eGGw2GsVcIvEZbatnfNsEQ3tTHPiShdsbJmmBBlVAKhN0L11uO53Vpu2o5kYwLhxT 2lM4Tmkq7Xcw0VlySdvhydAt2PwIo/f/BCKWs4ah300J8Eb6FYytUELFgJIS34zaT0 5HmsJ9MyzWJKpuqI/p+sIPg7irG6STr7IuNnnq9hewVJf/kZUx/PJ/q4xD9tJD9rIx 3bWRmBDgH/Iu2Is3zskwKXlGPwWEbpWQzQzaS+11k4PllT2gZuYxklJEMMEug0EDv6 or+FUQMqU+0j9iPLyzapNlqvLtYrZCi4Nch8VIOweMr+BZyrrxw9zFwNR5emk+RuKw /7wHIbBwjq6mYwM1aUVqhw0cqF7mCFVkjSjmPJNmxYyJQj1Jw1sLSlEN/m/513QCo6 yPlze49PeyjiXoTsjEQw0Zna+OnM1WmoKQLnTzYyPoQwIeh61+K6KVmADW1QIQBFpM lhwiqf4mG640jgsrSOdsgjjBVP/K2biSxqlbMlXsws89qErxoY42eqaA8RxGzUvUDT Rr+OFUN8fTOSoXI4PUvqs4/oRskjxZxzrAh6DYvimo5gFq5jrxs0TwMU9V6/n0NmHo aQ+Vl24qJN1/dDKUpqznr8TC/LcTnGwirPvhgtIeOmgr66G0j9PJZYbBIKO/Ht1+8+ 3bE8bQrLg+i7J3QkzZLdtvZg= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Stefan Kangas Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too In-Reply-To: (Stefan Kangas's message of "Thu, 19 Dec 2024 17:55:22 -0500") References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Fri, 20 Dec 2024 03:33:18 +0200 Message-ID: <87h66zm941.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Kangas writes: > Eli Zaretskii writes: > >> Btw, if we want to fix this entry, we should perhaps do a more >> thorough job. For example, on my system I have files with the >> following base names: >> [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in sa-accredit.habeas.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [185.216.177.71 listed in bl.score.senderscore.com] 1.2 INVALID_MSGID Message-Id is not valid, according to RFC 2822 X-Debbugs-Envelope-To: 74946 Cc: Eli Zaretskii , acorallo@gnu.org, 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Stefan Kangas writes: > Eli Zaretskii writes: > >> Btw, if we want to fix this entry, we should perhaps do a more >> thorough job. For example, on my system I have files with the >> following base names: >> >> .gdbinit.in >> .gdbinit >> _gdbinit (for MS-DOS) >> gdb.ini (likewise) >> gdbinit >> gdbinit.in >> SOMETHING-gdbinit >> .gdbinit.loader >> gdbinit-history.exp (not a GDB init file) >> gdbinit.5 (likewise) >> gdbinit.c (likewise) >> .gdbinit.py.in (likewise) >> >> Should we improve the regexp to DTRT for those additional files, but >> without false positives? > > Maybe something like the below patch? > > BTW, should the .gdbinit.py.in file be in python-mode perhaps? > And what about gdbinit.5? That's a man page file. > From a5a5dcd0452cadfee988a0256c10877835eefcef Mon Sep 17 00:00:00 2001 > From: Stefan Kangas > Date: Thu, 19 Dec 2024 23:51:38 +0100 > Subject: [PATCH] Match more gdbinit files > > * lisp/files.el (auto-mode-alist): Match more gdbinit files, > including XDG, and MS-Windows. Avoid false positives. > (Bug#74946) > (set-auto-mode--find-matching-alist-entry): Break out function... > (set-auto-mode--apply-alist): ...from here. > * test/lisp/files-tests.el (files-tests-auto-mode-alist): New > test. > --- > lisp/files.el | 56 +++++++++++++++++++++++----------------- > test/lisp/files-tests.el | 17 ++++++++++++ > 2 files changed, 49 insertions(+), 24 deletions(-) > > diff --git a/lisp/files.el b/lisp/files.el > index 9f13804540b..68ce2e0c273 100644 > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -3005,7 +3005,7 @@ auto-mode-alist > ;; files, cross-debuggers can use something like > ;; .PROCESSORNAME-gdbinit so that the host and target gdbinit files > ;; don't interfere with each other. > - ("/\\.[a-z0-9-]*gdbinit" . gdb-script-mode) > + ("/[._]?[A-Za-z0-9-]*\\(?:gdbinit\\(?:\\.\\(?:ini?\\|loader\\)\\)?\\|gdb\\.ini\\)\\'" . gdb-script-mode) .gdbinit.loader seems to be Mozilla thing. It might be better to either let users manually set the mode for these files or allow for text to be after .gdbinit. > ;; GDB 7.5 introduced OBJFILE-gdb.gdb script files; e.g. a file > ;; named 'emacs-gdb.gdb', if it exists, will be automatically > ;; loaded when GDB reads an objfile called 'emacs'. > @@ -3404,6 +3404,35 @@ magic-mode-regexp-match-limit > "Upper limit on `magic-mode-alist' regexp matches. > Also applies to `magic-fallback-mode-alist'.") > > +(defun set-auto-mode--find-matching-alist-entry (alist name case-insensitive) > + "Find first matching entry in ALIST for file NAME. > + > +If CASE-INSENSITIVE, the file system of file NAME is case-insensitive." > + (let (mode) > + (while name > + (setq mode > + (if case-insensitive > + ;; Filesystem is case-insensitive. > + (let ((case-fold-search t)) > + (assoc-default name alist 'string-match)) > + ;; Filesystem is case-sensitive. > + (or > + ;; First match case-sensitively. > + (let ((case-fold-search nil)) > + (assoc-default name alist 'string-match)) > + ;; Fallback to case-insensitive match. > + (and auto-mode-case-fold > + (let ((case-fold-search t)) > + (assoc-default name alist 'string-match)))))) > + (if (and mode > + (not (functionp mode)) > + (consp mode) > + (cadr mode)) > + (setq mode (car mode) > + name (substring name 0 (match-beginning 0))) > + (setq name nil))) > + mode)) > + This function looks very useful for applications with preferential orders of files as in e.g. a .dotfile and .dotconfig/file. It could also be a generic function. > (defun set-auto-mode--apply-alist (alist keep-mode-if-same dir-local) > "Helper function for `set-auto-mode'. > This function takes an alist of the same form as > @@ -3425,29 +3454,8 @@ set-auto-mode--apply-alist > (when (and (stringp remote-id) > (string-match (regexp-quote remote-id) name)) > (setq name (substring name (match-end 0)))) > - (while name > - ;; Find first matching alist entry. > - (setq mode > - (if case-insensitive-p > - ;; Filesystem is case-insensitive. > - (let ((case-fold-search t)) > - (assoc-default name alist 'string-match)) > - ;; Filesystem is case-sensitive. > - (or > - ;; First match case-sensitively. > - (let ((case-fold-search nil)) > - (assoc-default name alist 'string-match)) > - ;; Fallback to case-insensitive match. > - (and auto-mode-case-fold > - (let ((case-fold-search t)) > - (assoc-default name alist 'string-match)))))) > - (if (and mode > - (not (functionp mode)) > - (consp mode) > - (cadr mode)) > - (setq mode (car mode) > - name (substring name 0 (match-beginning 0))) > - (setq name nil))) > + (setq mode (set-auto-mode--find-matching-alist-entry > + alist name case-insensitive-p)) > (when (and dir-local mode > (not (set-auto-mode--dir-local-valid-p mode))) > (message "Ignoring invalid mode `%s'" mode) > diff --git a/test/lisp/files-tests.el b/test/lisp/files-tests.el > index ad54addf06b..0edc78d01e5 100644 > --- a/test/lisp/files-tests.el > +++ b/test/lisp/files-tests.el > @@ -1680,6 +1680,23 @@ files-tests--check-shebang > (when (eq expected-mode 'sh-base-mode) > (should (eq sh-shell expected-dialect)))))) > > +(ert-deftest files-tests-auto-mode-alist () > + (cl-flet ((find (file mode &optional case-insensitive) > + (eq mode (set-auto-mode--find-matching-alist-entry > + auto-mode-alist (concat "/home/stefank/" file) case-insensitive)))) > + (should (find ".gdbinit.in" #'gdb-script-mode)) > + (should (find ".gdbinit" #'gdb-script-mode)) > + (should (find "_gdbinit" #'gdb-script-mode)) ; for MS-DOS > + (should (find "gdb.ini" #'gdb-script-mode)) ; likewise > + (should (find "gdbinit" #'gdb-script-mode)) > + (should (find "gdbinit.in" #'gdb-script-mode)) > + (should (find "SOMETHING-gdbinit" #'gdb-script-mode)) > + (should (find ".gdbinit.loader" #'gdb-script-mode)) > + (should-not (find "gdbinit-history.exp" #'gdb-script-mode)) ; not a GDB init file > + (should-not (find "gdbinit.5" #'gdb-script-mode)) ; likewise > + (should-not (find "gdbinit.c" #'gdb-script-mode)) ; likewise > + (should-not (find ".gdbinit.py.in" #'gdb-script-mode)))) ; likewise > + > (ert-deftest files-tests-auto-mode-interpreter () > "Test that `set-auto-mode' deduces correct modes from shebangs." > ;; Straightforward interpreter invocation. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 01:46:23 2024 Received: (at 74946) by debbugs.gnu.org; 20 Dec 2024 06:46:23 +0000 Received: from localhost ([127.0.0.1]:41368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOWmE-0006il-Se for submit@debbugs.gnu.org; Fri, 20 Dec 2024 01:46:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOWmC-0006iX-Fg for 74946@debbugs.gnu.org; Fri, 20 Dec 2024 01:46:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOWm6-0005ss-VD; Fri, 20 Dec 2024 01:46:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0m7NaXFBVO87/8oonRh9gE3XabxkGhZaDqhd6UztPBY=; b=Cd6a5YscRWSp1OuNxqcR RcPUmIH2E4WUOPdVovOkbwcXRzvcSz6QFBKk6vVTPyL703yAcbe4qygFP+zAvWGMsvgbGMueZnLmq /irTK3Nk+3j4zaiT67O4eeWxtwmdCXxJpMfdnyKvLwgZjW9vl8TXvmbv4s6uHmJp4puN7cw5BjxjA PxnMEWaeACD2AbGCFXsWtHs6McrS6rLCynXXGaKJTLM4n1tOS03njlc/oDps5xfwaftd6E6ghkIj3 wRE+Fyg4I0xMN7YfWEGUZRycpWp7ywS+C37/UlYjLYpZKFUbI1Q6SJ66zx2O1zpc5RzTPXiMM2QpI zl8RjEHRTg9rXA==; Date: Fri, 20 Dec 2024 08:46:12 +0200 Message-Id: <86seqikg23.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn?= Bidar In-Reply-To: <87frmjtl9f.fsf@> (message from =?utf-8?Q?Bj=C3=B6rn?= Bidar on Thu, 19 Dec 2024 23:29:00 +0200) Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> <87frmjtl9f.fsf@> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74946 Cc: acorallo@gnu.org, stefankangas@gmail.com, 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Björn Bidar > Cc: Stefan Kangas , 74946@debbugs.gnu.org, > acorallo@gnu.org > Date: Thu, 19 Dec 2024 23:29:00 +0200 > > Eli Zaretskii writes: > > > It looks innocent enough, but at this point I'd like to limit changes > > on the release branch to only really urgent and important ones (or > > documentation). We have lived with this outdated code for several > > years (GDB 11.1 was released in 2022), so this change doesn't look > > urgent to me. > > Not really that urgent but to new users of Emacs it would be > beneficial if things would work out of the box. I thought at first Emacs > just didn't support the file. I understand, but my main worry is the potential unintended consequences. Regexps are tricky, as we all know. > > Btw, if we want to fix this entry, we should perhaps do a more > > thorough job. For example, on my system I have files with the > > following base names: > > > > .gdbinit.in > > .gdbinit > > _gdbinit (for MS-DOS) > > gdb.ini (likewise) > > Is this a gdbinit file? The extension looks off. Yes, gdb.ini is a gdbinit file. But if supporting it is problematic or causes too many complications, I'm okay with not supporting that particular file name. > > gdbinit > > gdbinit.in > > SOMETHING-gdbinit > > .gdbinit.loader > > gdbinit-history.exp (not a GDB init file) > > gdbinit.5 (likewise) > > gdbinit.c (likewise) > > .gdbinit.py.in (likewise) > > > > Should we improve the regexp to DTRT for those additional files, but > > without false positives? > > With Stefan correction all these without extension match. What are the > official extensions? gdbinit.in sounds like a normal extension for > gdbinit template in the source but the others such as gdb.ini look off. So we should at least allow the ".in" extension? Also, note that the current regexp doesn't end with a \\' so it could be a partial match with, say, /foo/bar/gdbinit-but-not-really. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 02:05:54 2024 Received: (at 74946) by debbugs.gnu.org; 20 Dec 2024 07:05:54 +0000 Received: from localhost ([127.0.0.1]:41409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX57-0007eH-KI for submit@debbugs.gnu.org; Fri, 20 Dec 2024 02:05:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOX55-0007e4-H3 for 74946@debbugs.gnu.org; Fri, 20 Dec 2024 02:05:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOX50-0003Vy-0s; Fri, 20 Dec 2024 02:05:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=srMbWGoeRCe5m1nqS9y2NUlMhR9SEvmnSyAYx8ej3jw=; b=I276gZjdcJ3P W4opP/0eegREHtfGIEMrMaIrz4rmfva4N4aOSXibiBIbqtHPM1G146H1xjv6KNj3Q4ElhSazg3i2p cFoTXVBds32Rt9PGgvUZf5a7qyzkAilWAnomKxt+/WlVw+fE8PICevigo18GyaeJZDDNwhND+wwnK 8J9Hvu0dzJbZOtInkREnZyWWVse45oloj2OyO6/3u2L0DwILjWoZE2npo1tgf0rZ8SCrkKJ1r9Tgi qN/Bbt132Uuil2Xw7VbzdGhjpk00owbyrl2+iP+oQUhy7qa1yUEZdzBkOYzYcpN2pkzW6voxpo9Jx lExRyhHoE55ZzvHKe8YYfg==; Date: Fri, 20 Dec 2024 09:05:41 +0200 Message-Id: <86o716kf5m.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 19 Dec 2024 17:55:22 -0500) Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74946 Cc: bjorn.bidar@thaodan.de, acorallo@gnu.org, 74946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 19 Dec 2024 17:55:22 -0500 > Cc: bjorn.bidar@thaodan.de, 74946@debbugs.gnu.org, acorallo@gnu.org > > > .gdbinit.in > > .gdbinit > > _gdbinit (for MS-DOS) > > gdb.ini (likewise) > > gdbinit > > gdbinit.in > > SOMETHING-gdbinit > > .gdbinit.loader > > gdbinit-history.exp (not a GDB init file) > > gdbinit.5 (likewise) > > gdbinit.c (likewise) > > .gdbinit.py.in (likewise) > > > > Should we improve the regexp to DTRT for those additional files, but > > without false positives? > > Maybe something like the below patch? Maybe. Try it against any similar name you have on your system. I used "locate -b gdbinit" to find matching files on mine. > BTW, should the .gdbinit.py.in file be in python-mode perhaps? Yes, it should be. > And what about gdbinit.5? It's a roff file (source of a man page). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 03:07:27 2024 Received: (at 74946) by debbugs.gnu.org; 20 Dec 2024 08:07:27 +0000 Received: from localhost ([127.0.0.1]:41535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOY2h-000245-7g for submit@debbugs.gnu.org; Fri, 20 Dec 2024 03:07:27 -0500 Received: from thaodan.de ([185.216.177.71]:50214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOY2f-00023o-Ey for 74946@debbugs.gnu.org; Fri, 20 Dec 2024 03:07:25 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id C4E63D00072; Fri, 20 Dec 2024 10:07:18 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1734682039; bh=SioC/zhorGQoRRU4f4rAH0qsanVcyOnuL5xSHjrnQlM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Za+T9RejXexAk6KvvI3M+hvhPBX/I2EtSlzR8v7DQ0tWCdtR6s/wBjYtDXBAtwndG 8v49KJXIfhV7Q/VHfBhUaapj9ZH7Br0lijF3F9wZykg3QmEXTnkGfvidhRCQO/ie8N FEyg/f44Aj1GVxgoaBAQWTqn+uf/AK5To/IIU20kU2vq1qZTddQvTcnbssJX+MrpCH 5cs3PEVggXGJIqcxhBSwntfYpnybbOUKK7g9RL/S52ckI9xCruNDw4VSoh+0cDIN8z hdPcSl7DBqZIv5bvG+LOP2cmzBrIDf/K1kESrxyR4ap8pGIlFTDgXhHz60j6RSVNcu T66mNP9KH3dM0JTK6va9I1RTNG94YPCK8Ci+mUawtg11ju4TGtEWZztFP4cBiDj6Es SeZ9lVgETtXXIjeX6WUcTB8Ci5PkLgmr7RaDps+db5GlFTOCqQJMuNZn7piYhKZnpB MiLrck0MhGhBdV2uEfCggtZhE9ZqU74yKMfG6YWCzYgGG5U9o/3gJ7kahrEjUx3LqU ENmMPg3P2bCF1rgL8GQut+ukZot1ehRmTT/RX7g4XQhO7JNShfQuKbh9Ti1NXLerY2 MCH4SF26eeJHsvAWXQqtd6d5PkpGf63amIDZSAB6Sc/fTozVG1yALwPwY9w9T9VoW7 4HqutcWBWkhuJG8OeNtSKuQM= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Eli Zaretskii Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too In-Reply-To: <86seqikg23.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2024 08:46:12 +0200") References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> <86seqikg23.fsf@gnu.org> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Fri, 20 Dec 2024 10:07:17 +0200 Message-ID: <87cyhmn5fu.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Eli Zaretskii writes: >> From: Björn Bidar >> Cc: Stefan Kangas , 74946@debbugs.gnu.org, >> acorallo@gnu.org >> Date: Thu, 19 Dec 2024 23:29:00 +0200 >> >> Eli Zaretskii List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: Stefan Kangas , 74946@debbugs.gnu.org, >> acorallo@gnu.org >> Date: Thu, 19 Dec 2024 23:29:00 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > It looks innocent enough, but at this point I'd like to limit changes >> > on the release branch to only really urgent and important ones (or >> > documentation). We have lived with this outdated code for several >> > years (GDB 11.1 was released in 2022), so this change doesn't look >> > urgent to me. >>=20 >> Not really that urgent but to new users of Emacs it would be >> beneficial if things would work out of the box. I thought at first Emacs >> just didn't support the file. > > I understand, but my main worry is the potential unintended > consequences. Regexps are tricky, as we all know. Yeah I get it np. Your call. The risks are low I'd say. >> > Btw, if we want to fix this entry, we should perhaps do a more >> > thorough job. For example, on my system I have files with the >> > following base names: >> > >> > .gdbinit.in >> > .gdbinit >> > _gdbinit (for MS-DOS) >> > gdb.ini (likewise) >>=20 >> Is this a gdbinit file? The extension looks off. > > Yes, gdb.ini is a gdbinit file. But if supporting it is problematic > or causes too many complications, I'm okay with not supporting that > particular file name. I later got that too. The gdb manual states that gdb.ini is the official name of gdb on DOS systems. I think it should be fine as the chance for false-positives in low on this one. >> > gdbinit >> > gdbinit.in >> > SOMETHING-gdbinit >> > .gdbinit.loader >> > gdbinit-history.exp (not a GDB init file) >> > gdbinit.5 (likewise) >> > gdbinit.c (likewise) >> > .gdbinit.py.in (likewise) >> > >> > Should we improve the regexp to DTRT for those additional files, but >> > without false positives? >>=20 >> With Stefan correction all these without extension match. What are the >> official extensions? gdbinit.in sounds like a normal extension for >> gdbinit template in the source but the others such as gdb.ini look off. > > So we should at least allow the ".in" extension? Also, note that the > current regexp doesn't end with a \\' so it could be a partial match > with, say, /foo/bar/gdbinit-but-not-really. I think so yes. In most instances the .in extension should also match the preceding match it I think. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 21:09:21 2024 Received: (at 74946-done) by debbugs.gnu.org; 22 Dec 2024 02:09:21 +0000 Received: from localhost ([127.0.0.1]:48488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPBPB-0005Vw-Er for submit@debbugs.gnu.org; Sat, 21 Dec 2024 21:09:20 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:52461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPBP5-0005VZ-G5 for 74946-done@debbugs.gnu.org; Sat, 21 Dec 2024 21:09:15 -0500 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d0d32cd31aso4424366a12.0 for <74946-done@debbugs.gnu.org>; Sat, 21 Dec 2024 18:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734833286; x=1735438086; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UN9N3bSdkHmr/tygazKyLhQAq4A4e0ttkz4A7J+/Cyk=; b=Ey2qkn/4NjmV1cDEWS+49YNOGUpJ24tu/ab8T6fNvzEiaB6JuugoYMq/IuFb+R8Na9 A2ALJJQJjQ5CfoM1rpByBP/dLcHH9BQZ2FQYqOro3xAb1eggYwdRVvi4uZ4W3zVmzOyd Wuk2+MTXhobq7sVGQ9Gsjws9rsyIVb060L/xPW6r3FejUkugMoAYPR7HCcCrpkf0nuFQ d8m3kwlru45Z4z/ikSfUTuwE58MhP0o1AaQIfuWs0eB7bUJShk4i5VsHhUSfM1Lr4xBS v8I8JFKmd46jLnG/NxAX7RhxgH6YR9W48BXlm8zbXo3+rIGeXlB99lEkKOLxxH/6gT0/ htlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734833286; x=1735438086; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UN9N3bSdkHmr/tygazKyLhQAq4A4e0ttkz4A7J+/Cyk=; b=dMXQH8CVv0f+Ops4L0RJ+Kn0sPfJ72H4cZSh8KDLqlT+Mf+PJ59gkqyRYU8PX07o7i B5tcFy2zlFo4qRDk+cuzPecyhGBbKvL7r7HMMK13oPSQbN9KhkhjR8Rb0I3TmfXeS9DB TA61K4Br6Un+PBXMdk2+Ffw0Bjy6SOiLHLQDQxPy/dHtlOgSqgr3ulNfsbYME7bj2L55 k05U9cb7IJjvBrKJWiZ+g9bgxhwQ0Mn8nLQOpEgVq5Jkq66MwAAmbbcrPQdwGrvxm3fp FEjhu/leg71sEjkZyCHZ+8b/Fdzuz/nOJHulpTd5XRUG2yLB1nAz8ZR6z7GrDb0WrUNY 8mGg== X-Forwarded-Encrypted: i=1; AJvYcCXCg9upEGae6TburJULvaGbhe4TZrJT7jt8wgG7JLpvEcSNyhVeKRFIYxppy9wabWKqkRbfMZmo/ILA@debbugs.gnu.org X-Gm-Message-State: AOJu0YxL0KsZqS9F+LFkdGJ9gY+ZHTX/Zwm8wBQkz0kSTBKWLjsd+AVi DV6YWUD+4WFSD7QxZujw+DVwmVBYnNMxwW5eyqrU5TCy9V4E0QEEQh0OY+0NMCzANjfGFKkFr08 0BLvP3PAhRmnbmveI+ilHZeU8bqE= X-Gm-Gg: ASbGncvyijjTSPfKH95+bXYT9GHVTB+w5X7O1+EYkV3/yEGB3fyRJMX+3tCr6iKwSUa KNeNik+SNjOBrEcZVteXiCqxY5R/hMQBRMeclqR4= X-Google-Smtp-Source: AGHT+IGbqhQmrFNNmqtTgMBP3SZtQDTdNc+0noU3uhle33hKuaxNJwZX7/YN/ybQoIbqTUZ7WiQ+p8HZeZkdocbnBK0= X-Received: by 2002:a05:6402:3884:b0:5d3:ff93:f5f9 with SMTP id 4fb4d7f45d1cf-5d81ddd625dmr17966009a12.20.1734833285328; Sat, 21 Dec 2024 18:08:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 22 Dec 2024 02:08:05 +0000 From: Stefan Kangas In-Reply-To: <86o716kf5m.fsf@gnu.org> References: <87frml6pkg.fsf@thaodan.de> <86o718ks3b.fsf@gnu.org> <86o716kf5m.fsf@gnu.org> MIME-Version: 1.0 Date: Sun, 22 Dec 2024 02:08:05 +0000 Message-ID: Subject: Re: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74946-done Cc: bjorn.bidar@thaodan.de, acorallo@gnu.org, 74946-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Thu, 19 Dec 2024 17:55:22 -0500 >> Cc: bjorn.bidar@thaodan.de, 74946@debbugs.gnu.org, acorallo@gnu.org >> >> > .gdbinit.in >> > .gdbinit >> > _gdbinit (for MS-DOS) >> > gdb.ini (likewise) >> > gdbinit >> > gdbinit.in >> > SOMETHING-gdbinit >> > .gdbinit.loader >> > gdbinit-history.exp (not a GDB init file) >> > gdbinit.5 (likewise) >> > gdbinit.c (likewise) >> > .gdbinit.py.in (likewise) >> > >> > Should we improve the regexp to DTRT for those additional files, but >> > without false positives? >> >> Maybe something like the below patch? > > Maybe. Try it against any similar name you have on your system. I > used "locate -b gdbinit" to find matching files on mine. Everything makes sense to me, so I pushed the change to master. I'm closing this bug report with this message. Please report back if you notice any problems. Thanks! From unknown Sat Sep 20 02:11:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Jan 2025 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator