GNU bug report logs - #74939
Compiler warning for tex-font.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arash Esbati <arash <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74939: closed (Compiler warning for tex-font.el)
Date: Thu, 19 Dec 2024 06:34:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 19 Dec 2024 07:31:06 +0100
with message-id <m2msgsqj4l.fsf <at> macmutant.fritz.box>
and subject line Re: bug#74939: Compiler warning for tex-font.el
has caused the debbugs.gnu.org bug report #74939,
regarding Compiler warning for tex-font.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74939: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74939
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arash Esbati <arash <at> gnu.org>
To: "auctex-bugs" <bug-auctex <at> gnu.org>
Subject: Compiler warning for tex-font.el
Date: Wed, 18 Dec 2024 10:18:08 +0100

Hi all,

Emacs from master has obsoleted usage of font-lock face variables
(3d3c109460).  Building AUCTeX with this version, the only warning
omitted is:

In tex-font-lock-syntactic-face-function:
tex-font.el:155:35: Warning: ‘font-lock-comment-face’ is an obsolete
variable (as of 31.1); use the quoted symbol instead:
'font-lock-comment-face

I think we can easily fix this with this change:

--8<---------------cut here---------------start------------->8---
diff --git a/tex-font.el b/tex-font.el
index 84dfe71b..018c6e89 100644
--- a/tex-font.el
+++ b/tex-font.el
@@ -143,16 +143,14 @@
 (defvar tex-font-lock-keywords tex-font-lock-keywords-1
   "Default expressions to highlight in TeX modes.")

-
 (defface tex-math-face
   '((t :inherit font-lock-string-face))
   "Face used to highlight TeX math expressions."
   :group 'tex)
-(defvar tex-math-face 'tex-math-face)

 ;; Use string syntax but math face for $...$.
 (defun tex-font-lock-syntactic-face-function (state)
-  (if (nth 3 state) tex-math-face font-lock-comment-face))
+  (if (nth 3 state) 'tex-math-face 'font-lock-comment-face))

 ;;;###autoload
 (defun tex-font-setup ()
--8<---------------cut here---------------end--------------->8---

Any comments?

Best, Arash

[Message part 3 (message/rfc822, inline)]

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 74939-done <at> debbugs.gnu.org
Subject: Re: bug#74939: Compiler warning for tex-font.el
Date: Thu, 19 Dec 2024 07:31:06 +0100

Hi Keita,

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

> I'm fine with your idea. :-)

Thanks for having a look.  I installed that change and therefore closing
this report.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.