GNU bug report logs - #74934
30.0.92; Unexpected behavior by which-function-mode in erc-mode buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74934 in the body.
You can then email your comments to 74934 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Anush V <j <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.92; Unexpected behavior by which-function-mode in erc-mode
 buffers
Date: Tue, 17 Dec 2024 19:43:51 -0500

Hello Maintainers,

I guess this is probably unexpected behavior by which-function-mode in erc-mode
buffers and so reporting this.


steps to reproduce:
emacs --no-init
M-x erc
;; join some channel.
M-x which-function-mode

Current behavior:
In erc buffers, which-function-mode displays either "[n/a]" or a string based on
the chat history in the mode line.

Expected behavior:
which-function-mode shouldn’t be adding any string to mode line in erc buffers


Thank you for your time!

* * *

In GNU Emacs 30.0.92 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo
version 1.18.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: Guix System

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash
 SHELL=/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/bash --prefix=/gnu/store/dgpfiflaxb8j33jcbqk29wadcykajl51-emacs-next-30.0.92-0.881d593 --enable-fast-install --with-cairo --with-modules --with-native-compilation=aot --disable-build-details'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2
LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

--
Regards,
Anush V

Message #8 received at 74934 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Anush V <j <at> gnu.org>
Cc: emacs-erc <at> gnu.org, 74934 <at> debbugs.gnu.org
Subject: Re: bug#74934: 30.0.92; Unexpected behavior by which-function-mode
 in erc-mode buffers
Date: Tue, 17 Dec 2024 18:24:02 -0800

[Message part 1 (text/plain, inline)]

Hi Anush,

Appreciate you reporting this.

Anush V <j <at> gnu.org> writes:

> steps to reproduce:
> emacs --no-init
> M-x erc
> ;; join some channel.
> M-x which-function-mode
>
> Current behavior:
> In erc buffers, which-function-mode displays either "[n/a]" or a string based on
> the chat history in the mode line.

FTR, I'm able to reproduce it.

> Expected behavior:
> which-function-mode shouldn’t be adding any string to mode line in erc buffers

The first of the attached patches should hopefully address the issue.

Thanks,
J.P.

[0001-5.6.1-Disable-which-func-mode-in-erc-imenu-buffers.patch (text/x-patch, attachment)]

[0002-5.6.1-Add-lisp-imenu-generic-expression-for-ERC-hack.patch (text/x-patch, attachment)]

Message #11 received at 74934 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "J.P." <jp <at> neverwas.me>
Cc: emacs-erc <at> gnu.org, 74934 <at> debbugs.gnu.org, j <at> gnu.org
Subject: Re: bug#74934: 30.0.92;
 Unexpected behavior by which-function-mode in erc-mode buffers
Date: Wed, 18 Dec 2024 15:43:40 +0200

> Cc: emacs-erc <at> gnu.org, 74934 <at> debbugs.gnu.org
> From: "J.P." <jp <at> neverwas.me>
> Date: Tue, 17 Dec 2024 18:24:02 -0800
> 
> > steps to reproduce:
> > emacs --no-init
> > M-x erc
> > ;; join some channel.
> > M-x which-function-mode
> >
> > Current behavior:
> > In erc buffers, which-function-mode displays either "[n/a]" or a string based on
> > the chat history in the mode line.
> 
> FTR, I'm able to reproduce it.
> 
> > Expected behavior:
> > which-function-mode shouldn’t be adding any string to mode line in erc buffers
> 
> The first of the attached patches should hopefully address the issue.

Is this for the release branch?  That is, is this a recent regression?

And if so, what is the second patch for?

Thanks.

Message #14 received at 74934 <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: emacs-erc <at> gnu.org, 74934 <at> debbugs.gnu.org, j <at> gnu.org
Subject: Re: bug#74934: 30.0.92; Unexpected behavior by which-function-mode
 in erc-mode buffers
Date: Wed, 18 Dec 2024 08:27:04 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: emacs-erc <at> gnu.org, 74934 <at> debbugs.gnu.org
>> From: "J.P." <jp <at> neverwas.me>
>> Date: Tue, 17 Dec 2024 18:24:02 -0800
>> 
>> > steps to reproduce:
>> > emacs --no-init
>> > M-x erc
>> > ;; join some channel.
>> > M-x which-function-mode
>> >
>> > Current behavior:
>> > In erc buffers, which-function-mode displays either "[n/a]" or a string based on
>> > the chat history in the mode line.
>> 
>> FTR, I'm able to reproduce it.
>> 
>> > Expected behavior:
>> > which-function-mode shouldn’t be adding any string to mode line in erc buffers
>> 
>> The first of the attached patches should hopefully address the issue.
>
> Is this for the release branch?  That is, is this a recent regression?

No, this is for Emacs master (and ERC 5.6.1). AFAICT, the bug has been
with us since at least Emacs 26.3, although "[n/a]" used to be "[???]".

>
> And if so, what is the second patch for?

For anyone wondering, the second patch is for contributors working on
ERC (I will add a news item). If you load ERC and invoke the function
`erc-imenu-add-devel-patterns' in your config, your next visit to
erc-backend.el should allow you to see something like

  ERC response 311 314
  ERC response 312
  ERC response 313
  ERC response 315 318 323 369
  ERC response 317
  ERC response 319
  ERC response 311

after typing

  M-x imenu <RET> 31 <TAB>

(whereas before you'd see nothing). Hitting RET on the first candidate
should take you to

  (define-erc-response-handler (311 314)
    "WHOIS/WHOWAS notices." nil ...)

As mentioned in the comment, I'd much rather it generate something like

  erc-server-311
  erc-server-314
  ...
  erc-server-311

but I don't know how to do that or if it's even possible. (If anyone out
there has any clues, please share. TIA.)

Message #19 received at 74934-done <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: 74934-done <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, emacs-erc <at> gnu.org, j <at> gnu.org
Subject: Re: bug#74934: 30.0.92; Unexpected behavior by which-function-mode
 in erc-mode buffers
Date: Sun, 22 Dec 2024 11:51:57 -0800

"J.P." <jp <at> neverwas.me> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Is this for the release branch?  That is, is this a recent regression?
>
> No, this is for Emacs master (and ERC 5.6.1). AFAICT, the bug has been
> with us since at least Emacs 26.3, although "[n/a]" used to be "[???]".

This has been installed as

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d1c670f0

>
>>
>> And if so, what is the second patch for?
>
> For anyone wondering, the second patch is for contributors working on
> ERC (I will add a news item).

I moved the dev utility to

  test/lisp/erc/resources/erc-tests-common.el

and changed it to only modify the local binding of the variable
`imenu-generic-expression'. Installed as:

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e9591fae

Thanks and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.