Subject: bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention

From: Stefan Kangas <[email-masked]>
Date: Thu, 13 Feb 2025 10:06:40 -0800

"Basil L. Contovounesios" <[email-masked]> writes:

> Basil L. Contovounesios [2025-02-02 19:27 +0100] wrote:
>
>>   ;; -*- lexical-binding: t -*-
>>   (require 'cl-lib)
>>   (require 'ert)
>>   (defun       foo () (cl-nreconc '(1 2 3) '(4 5 6)))
>>   (ert-deftest foo () (cl-nreconc '(a b c) '(d e f)))
>>
>> Byte-compiling this gives only one 'cl-nreconc on constant list' warning
>> instead of two.
>
> Fixed one instance of this in our test suite:
>
>  Fix uncaught cl-nreconc on constant list
>  b8c8ae92dba 2025-02-13 18:40:26 +0100
>  https://git.sv.gnu.org/cgit/emacs.git/commit/?id=b8c8ae92dba

Thanks for looking into this, and for the above fix.