From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 18:48:05 2024 Received: (at submit) by debbugs.gnu.org; 16 Dec 2024 23:48:05 +0000 Received: from localhost ([127.0.0.1]:56709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNKon-0001Rp-6i for submit@debbugs.gnu.org; Mon, 16 Dec 2024 18:48:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:58602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNKoi-0001RK-Ai for submit@debbugs.gnu.org; Mon, 16 Dec 2024 18:48:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNKog-0007aj-JX for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 18:47:58 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNKoc-0001WY-TN for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 18:47:57 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso6173889a12.0 for ; Mon, 16 Dec 2024 15:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734392873; x=1734997673; darn=gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:from:to:cc:subject:date:message-id:reply-to; bh=MlrAXzF+AjbiHmBH3FzIiRoHI4e4kZi7+UVRPtyvT6s=; b=cvm6EAdHldjTuG4LkkmfI9E5VbqpJS+SNqhPLSz6LLjizci9H/NSn7yzNBGpM4DXZP TvdN1in3bygw6QV1Bc5MDqkY488/NQB6kMKcDdOn6b7aOjvnNj88OUxqVCtg7bqf8QMv 8D0EFK9PWKUA205Dmuuk71+96lfa1DHcIuSlJ5zSXdV4zJsvajG+6MX8RCzh+IB5JzZf WO1Pl1GXRPcFhXAfyPo9r253YCy7MsHMsL960CY27dk0sdvaoNK9R9xNMj9sLHxoaezJ 6FJx8+hLbx+lED9BSrrdHbapDTpc6bXzuoTrewJEql02S3BRw4N5MU6j0nCZeCdikW09 5Luw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734392873; x=1734997673; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MlrAXzF+AjbiHmBH3FzIiRoHI4e4kZi7+UVRPtyvT6s=; b=gybnWcqxzg5l340cplrPolyK8qnDumH1Ib447BfN+SzQYl7olft+IB0ntEI6ihlgsg fwcnZpeIcPpho9Fm/PELqfvhMEjkwzW2L3N6ZKTqVpEiTN9YD5QAm1AuYqeCo+mYMYWc KDSm6QiiFPa4+oMTAxtwk6ivEznGhMXjVmxvY4qga0tHZkienDAker/H418igs2E6WVL K1EC+UchwwMpW7pboyeguLOijn3gpBN9mLyXzV/SC0R0JG+r8+7SkzXlj5153/gG+JN+ XvOuDjOiW6YoCayVp65bAxLWCAQa0zHZMbfsHbbP62A8HoMhQLwl6zy9fPdNNO32lhLj B6jQ== X-Gm-Message-State: AOJu0Yz73DpA3jLNJJ9oTGZa8Gqeo7DlSTWrL5RrNlQ6f5Mdl0EUVvbV mbju+qntyf0NVjQmaJ2Ji/DlfNgnMwkfZkXZ+3u+bej/x2cOKzpG147xFASccU/r8XTiQXKvvDF iRoFeIZqbJUHDytpmXkyGoq0QorgzU3/D X-Gm-Gg: ASbGncsvQ67mI17b7vsK1h6f2/3z+VWRSXb+5HYnPUBiKtQUSlF1jU399GWbgXdP1rL 9R5NmSW04VSAB0eEP/X1aEzcqnb89IdHIEqN6EEk= X-Google-Smtp-Source: AGHT+IH2fbHOabTgjRCuLKhQYAnVISbhGk5W5NQJyCcXmXql0Sffpa1KJ4Z+teofgXfnh/6t19Px36DKSG/bxcOPK5I= X-Received: by 2002:a05:6402:528f:b0:5d2:7456:9812 with SMTP id 4fb4d7f45d1cf-5d63c39fba0mr12505125a12.22.1734392873153; Mon, 16 Dec 2024 15:47:53 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 16 Dec 2024 23:47:52 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 16 Dec 2024 23:47:52 +0000 Message-ID: Subject: 31.0.50; 'should' defeats warning from set-advertised-calling-convention To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: minor Create a file foo.el with this content: ;; -*- lexical-binding: t; -*- (defun foo (&optional a) a) (set-advertised-calling-convention 'foo '(a) '"31.1") (foo) Create a second file bar.el with this: ;; -*- lexical-binding: t; -*- (load "foo") (require 'ert) (foo) (should (foo)) Byte-compile bar.el and observe that there is only one warning: bar.el:4:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but req= uires 1 Expected is two warnings, like this: bar.el:4:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but req= uires 1 bar.el:5:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but req= uires 1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 13:28:00 2025 Received: (at 74920) by debbugs.gnu.org; 2 Feb 2025 18:28:00 +0000 Received: from localhost ([127.0.0.1]:36258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teehL-0007Tq-Rc for submit@debbugs.gnu.org; Sun, 02 Feb 2025 13:28:00 -0500 Received: from mta-05-3.privateemail.com ([198.54.118.212]:58437) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teehJ-0007TX-Ot for 74920@debbugs.gnu.org; Sun, 02 Feb 2025 13:27:58 -0500 Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 4YmJ5f3DjZz3hhTw; Sun, 2 Feb 2025 13:27:50 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=contovou.net; s=default; t=1738520870; bh=yXrZqCbwE6jeDzvBCZQ8r5qx/+e7ThIZJfGZ58U03qQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EtxUtYJjvhj2b8/HGaBivyaTUor3zySVUj9uKH7S2QluoqYvGy6LxyYVuVVL3vvab QSizjhFUTtQQAX+kBui0OC0cHm94RGXmgbSXho9L7kowPkn2LYJbkyqaVF1jAljsH8 +t/4P346dJV9JZ8nnJkIiJk3W1YdtHQ5zNjtm8V+3cE1c+KPaUmDlbr7o6wzomhWET M/n6nx+gZRfr6Qq8ZliR463nlAZlPQ8A2mc8SQtz4x9cbLs95sD9kaXxjJ/OUX3xb3 Ri6ujsx4+ulbzWAC4I6nOs/Rm3kg7l+3nXjNn7q1Wzf3ajtWriv9xZzqLga8IOMzmr ZG6Mj65oVzGDw== Received: from localhost (unknown [31.46.243.74]) by mta-05.privateemail.com (Postfix) with ESMTPA; Sun, 2 Feb 2025 13:27:48 -0500 (EST) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention In-Reply-To: (Stefan Kangas's message of "Mon, 16 Dec 2024 23:47:52 +0000") References: Date: Sun, 02 Feb 2025 19:27:43 +0100 Message-ID: <87zfj4xkv4.fsf@contovou.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74920 Cc: 74920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas [2024-12-16 23:47 +0000] wrote: > Create a file foo.el with this content: > > ;; -*- lexical-binding: t; -*- > (defun foo (&optional a) a) > (set-advertised-calling-convention 'foo '(a) '"31.1") > (foo) > > Create a second file bar.el with this: > > ;; -*- lexical-binding: t; -*- > (load "foo") > (require 'ert) > (foo) > (should (foo)) > > Byte-compile bar.el and observe that there is only one warning: > > bar.el:4:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but r= equires 1 > > Expected is two warnings, like this: > > bar.el:4:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but r= equires 1 > bar.el:5:2: Warning: =E2=80=98foo=E2=80=99 called with 0 arguments, but r= equires 1 It's not just 'should', and not just set-advertised-calling-convention: ;; -*- lexical-binding: t -*- (require 'cl-lib) (require 'ert) (defun foo () (cl-nreconc '(1 2 3) '(4 5 6))) (ert-deftest foo () (cl-nreconc '(a b c) '(d e f))) Byte-compiling this gives only one 'cl-nreconc on constant list' warning instead of two. The macroexpansion of (should (cl-nreconc '(a b c) '(d e f))) gives some hints as to why the warning could be lost, since the direct call to cl-nreconc is turned into an indirect one. But ERT seems to give rise to false negatives regardless of 'should'. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 03:53:30 2025 Received: (at 74920) by debbugs.gnu.org; 3 Feb 2025 08:53:31 +0000 Received: from localhost ([127.0.0.1]:37718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tesCw-0001mW-Fh for submit@debbugs.gnu.org; Mon, 03 Feb 2025 03:53:30 -0500 Received: from mta-07-3.privateemail.com ([198.54.118.214]:56762) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tesCt-0001mF-UE for 74920@debbugs.gnu.org; Mon, 03 Feb 2025 03:53:28 -0500 Received: from mta-07.privateemail.com (localhost [127.0.0.1]) by mta-07.privateemail.com (Postfix) with ESMTP id 4YmgJJ1k2mz3hhTt; Mon, 3 Feb 2025 03:53:20 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=contovou.net; s=default; t=1738572800; bh=scN+F7gO4QXABnzbGzg7xe9v6LnhmQkdXXsFvaU/gWE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hzznLXbZYn9oi0L7TfP5Jdpftrx8agp118d9X7O17Fy6g5+GFKyhwCBXVrC2odPIU ZXmBeg17ko+T34er0Fz2x3cYn/CX1NTBM1iktbSEo6C/tVCuocBmd+ZCqWVbdHhExx h6ZdHw6ff/jdxFkOF9XO1phjDyJIMUdLQj4lnva8XqPMxK1T6wOP64v1HsjKsBNihT V1tA2inJdiMkgbqfwocnzcGoNxSVEfq4MwN+Bwsd58RhOCwWSa00Hk/LO7O0gfZC6f f5LQNaLm/URoZpbbdjI8P18JyKWs0H/6Lb2Y0EtTBgeOGvWAnLsnv8DRoRcTfTUA6M 5frV7Jmtg//Gw== Received: from localhost (unknown [31.46.243.74]) by mta-07.privateemail.com (Postfix) with ESMTPA; Mon, 3 Feb 2025 03:53:18 -0500 (EST) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention In-Reply-To: <87zfj4xkv4.fsf@contovou.net> (Basil L. Contovounesios's message of "Sun, 02 Feb 2025 19:27:43 +0100") References: <87zfj4xkv4.fsf@contovou.net> Date: Mon, 03 Feb 2025 09:53:13 +0100 Message-ID: <87cyfz76km.fsf@contovou.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74920 Cc: 74920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil L. Contovounesios [2025-02-02 19:27 +0100] wrote: > It's not just 'should', and not just set-advertised-calling-convention: > > ;; -*- lexical-binding: t -*- > (require 'cl-lib) > (require 'ert) > (defun foo () (cl-nreconc '(1 2 3) '(4 5 6))) > (ert-deftest foo () (cl-nreconc '(a b c) '(d e f))) > > Byte-compiling this gives only one 'cl-nreconc on constant list' warning > instead of two. > > The macroexpansion of (should (cl-nreconc '(a b c) '(d e f))) gives some > hints as to why the warning could be lost, since the direct call to > cl-nreconc is turned into an indirect one. > > But ERT seems to give rise to false negatives regardless of 'should'. Ah, I think the case of cl-nreconc is affected by it being proclaimed as inline in cl-macs.el. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 12:51:38 2025 Received: (at 74920) by debbugs.gnu.org; 13 Feb 2025 17:51:38 +0000 Received: from localhost ([127.0.0.1]:45349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tidNB-0001a0-ML for submit@debbugs.gnu.org; Thu, 13 Feb 2025 12:51:38 -0500 Received: from mta-06-4.privateemail.com ([198.54.122.146]:52661) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tidN6-0001Zk-M9 for 74920@debbugs.gnu.org; Thu, 13 Feb 2025 12:51:36 -0500 Received: from mta-06.privateemail.com (localhost [127.0.0.1]) by mta-06.privateemail.com (Postfix) with ESMTP id 4Yv2mZ1H0Yz3hhW8; Thu, 13 Feb 2025 12:51:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=contovou.net; s=default; t=1739469086; bh=CgaBo94U0MrcKAYBVkLVlxWy/q8xG7gJOPlgBuDd2Qs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Mrxkv+fh8XW+HcauQ2bAyIgy2EkC74ZhHeZuZxkFM3S6DgmngFius7n82E6PFm48F rKhxCtznceRHE2LOoadzIcv1BDtbQPvoqBhq3MSqWj/OMSmChYkfPa9QmJ3oD275/D aZc0rNFaPOANK/MLxjEsUBbcYrauvlBfmaSuNq3XwaBySWJLuX65diFctzdKqnSsej N/xbOOClDTmKhb2pI7w0+y7+7rGr8mlgv1H9QuI5vyHIZvxWrASSBsDfJnSPHxxde3 0dYGpA4/MvV20A+KaqTTGesjdqMpX4YcHgrFvKcUGw3nqtz74s9HTOuzinZs1Jl2TF zRbuhkHZHgDLg== Received: from localhost (unknown [146.70.196.137]) by mta-06.privateemail.com (Postfix) with ESMTPA; Thu, 13 Feb 2025 12:51:24 -0500 (EST) From: "Basil L. Contovounesios" To: Stefan Kangas Subject: Re: bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention In-Reply-To: <87zfj4xkv4.fsf@contovou.net> References: <87zfj4xkv4.fsf@contovou.net> Date: Thu, 13 Feb 2025 18:51:21 +0100 Message-ID: <87v7tdag2u.fsf@contovou.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74920 Cc: 74920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil L. Contovounesios [2025-02-02 19:27 +0100] wrote: > ;; -*- lexical-binding: t -*- > (require 'cl-lib) > (require 'ert) > (defun foo () (cl-nreconc '(1 2 3) '(4 5 6))) > (ert-deftest foo () (cl-nreconc '(a b c) '(d e f))) > > Byte-compiling this gives only one 'cl-nreconc on constant list' warning > instead of two. Fixed one instance of this in our test suite: Fix uncaught cl-nreconc on constant list b8c8ae92dba 2025-02-13 18:40:26 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=b8c8ae92dba -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 13:06:52 2025 Received: (at 74920) by debbugs.gnu.org; 13 Feb 2025 18:06:52 +0000 Received: from localhost ([127.0.0.1]:45403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tidbw-0002HM-7G for submit@debbugs.gnu.org; Thu, 13 Feb 2025 13:06:52 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:56415) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tidbr-0002H4-J9 for 74920@debbugs.gnu.org; Thu, 13 Feb 2025 13:06:49 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5deb0d6787cso1717644a12.0 for <74920@debbugs.gnu.org>; Thu, 13 Feb 2025 10:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739470001; x=1740074801; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=4msDcTwf0pwyMfh77A7gHSHA8YW7siXYkZ+LJ1JWJAI=; b=SFyloGRyH3eEc8Tc4En38oXVBk/PsdIIIR1FereuXzGovzO9GDeJOeAlR93sKaXUZd DD3uebk3CszGS6zDaRsGQ6ITPrhmNm8TVVkyj035884WoTPUAuD73wsNG0Emtz2pO6vz r4Lm2II/0Wxff1sNHabFW5D4xkrKtznuhSJDp50JV7DtWxrqP9inYQgaQGjnRlbk0aG0 7acO+EetNNtu74SnqC+jT1oOYH7lmLE8nS2mmhEVxkswZZJ1OjDM3ozSpmoNYA2xJjo/ VuXhoAQa0GyDYlHRozTvOhs5xKdYYh750Op2fRZG+2RGx3rezinzUIJwUwS8TGqDpW8r A+kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739470001; x=1740074801; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4msDcTwf0pwyMfh77A7gHSHA8YW7siXYkZ+LJ1JWJAI=; b=awb1SsB8MG2R5oE0UXV3+Ms6jQZyO1nd2rFfbrU63ywyntp09FF0NqwZyJgJMpZDz0 sILDiDn7fpkqxCQgzljGUWtOBcVqs6f7EVTS9f0b9uubgiWT1Mx3jiJX0/RtDg+XHVTd N9mp73i6LomIY6nLYYvuRDKn3q38xxvVjZ3V0/Y90tI2QfJH/2m0M69mfHNgUgzU4kgp CclVAuollQtjGkF9ndHvaQQtjlV5zAM4C8hOe5JpTTr8/Rxt5AbglnTky3Pkp2+QsCpM bapM1hvKyNItt000qKUQOWE3ZBrwfSJ6ybNKZC2iijighgteZ3W/z+BTEfVI3xK981Pa OfqA== X-Gm-Message-State: AOJu0YxG5RbC4ejSIcl5sgmflUHrspSkSHy2PWcvVqKBQcLPag9XXtaN rbMpEfzuKn0b+yimB+sQ/Gjubz8Eb2163prMCflEdTzO8KEatuVW87uJgDkY+jnzaeYOo78AX92 +fz6Yob/04sPC9JKKDSgMgnS3TGfHj80U4Z/5cA== X-Gm-Gg: ASbGncsVRAn1AnVYQd+LMHl8yDDoD+d1QJYfzw7EsvWDCeCKnvYMMZYPCs7cYRxaWqS kIYwntNrHZO/zR2NURalk/xFBeDuwYO559EoN7UQgwPbOpvkRVpsMPp5GgehoU/0kEvKymSKAeT g= X-Google-Smtp-Source: AGHT+IH4gGdGKVnJsUSABMsXfwMWGMjBgmRzHj/dn64jd1Vhk7osG51OkkUsZLRzOw7FAvsMWq0oa8BMdGT3a9W1WI8= X-Received: by 2002:a05:6402:254c:b0:5de:5718:296 with SMTP id 4fb4d7f45d1cf-5deaddaa923mr7312550a12.13.1739470001234; Thu, 13 Feb 2025 10:06:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Feb 2025 10:06:40 -0800 From: Stefan Kangas In-Reply-To: <87v7tdag2u.fsf@contovou.net> References: <87zfj4xkv4.fsf@contovou.net> <87v7tdag2u.fsf@contovou.net> MIME-Version: 1.0 Date: Thu, 13 Feb 2025 10:06:40 -0800 X-Gm-Features: AWEUYZncSw1B7lW2VsHTWGVFS4dOKfFWvjtSQxwXGz0c2UEZuF4lUPdvJltovpk Message-ID: Subject: Re: bug#74920: 31.0.50; 'should' defeats warning from set-advertised-calling-convention To: "Basil L. Contovounesios" Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74920 Cc: 74920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Basil L. Contovounesios" writes: > Basil L. Contovounesios [2025-02-02 19:27 +0100] wrote: > >> ;; -*- lexical-binding: t -*- >> (require 'cl-lib) >> (require 'ert) >> (defun foo () (cl-nreconc '(1 2 3) '(4 5 6))) >> (ert-deftest foo () (cl-nreconc '(a b c) '(d e f))) >> >> Byte-compiling this gives only one 'cl-nreconc on constant list' warning >> instead of two. > > Fixed one instance of this in our test suite: > > Fix uncaught cl-nreconc on constant list > b8c8ae92dba 2025-02-13 18:40:26 +0100 > https://git.sv.gnu.org/cgit/emacs.git/commit/?id=b8c8ae92dba Thanks for looking into this, and for the above fix.