Subject: bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables

From: Robert Pluim <[email-masked]>
Date: Mon, 16 Dec 2024 19:15:03 +0100

>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <[email-masked]> said:
    Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
    Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <[email-masked]>
    Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
    Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables

    Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
    Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
    Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
    Björn> (gnus-treat-display-face, gnus-treat-display-face)
    Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
    Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
    Björn> (gnus-treat-body-boundary): Fix custom types to
    Björn> include all possible choices mentioned in the docstrings
    Björn> and manual.

The commit message only needs to mention the type you actually
changed, in this case `gnus-article-treat-head-custom'

    Björn> ---
    Björn>  lisp/gnus/gnus-art.el | 5 ++++-
    Björn>  1 file changed, 4 insertions(+), 1 deletion(-)

    Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
    Björn> index 8243e4e632b..13dfb737243 100644
    Björn> --- a/lisp/gnus/gnus-art.el
    Björn> +++ b/lisp/gnus/gnus-art.el
    Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
 
    Björn>  (defvar gnus-article-treat-head-custom
    Björn>    '(choice (const :tag "Off" nil)
    Björn> -	   (const :tag "Header" head)))
    Björn> +	   (const :tag "Header" head)
    Björn> +           (const :tag "First" first)
    Björn> +           (const :tag "Last" last)
    Björn> +           (boolean :tag "All body parts" t)))

`t' is a const, not a boolean, the same as `nil', in the context of
defcustom. Plus a lot of the docstrings look cut&paste, so Iʼm not
entirely sure that itʼs the existing type that is wrong rather than
the docstring.

Robert
--