GNU bug report logs - #74914
30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp

Previous Next

Full log

Message #27 received at 74914-done <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Troy Brown <brownts <at> troybrown.dev>, 74914-done <at> debbugs.gnu.org
Cc: Dmitry Gutov <dmitry <at> gutov.dev>,
 Felician Nemeth <felician.nemeth <at> gmail.com>
Subject: Re: bug#74914: 30.0.90;
 Eglot: Incorrect parameter highlighted in signatureHelp
Date: Mon, 6 Jan 2025 10:55:26 +0000

I pushed this patch yesterday.  Thanks everyone, closing the bug.

On Sun, Jan 5, 2025 at 2:20 AM Troy Brown <brownts <at> troybrown.dev> wrote:
>
> On Sat, Dec 28, 2024 at 10:22 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:
> >
> > So, does this fix the problem for you?
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 816a1e67eca..51c19d5681a 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -3416,7 +3416,7 @@ eglot--sig-info
> >                                          'font-lock-function-name-face))))
> >         ;; Now to the parameters
> >         (cl-loop
> > -       with active-param = (or sig-active activeParameter)
> > +       with active-param = (or activeParameter sig-active)
> >          for i from 0 for parameter across parameters do
> >          (eglot--dbind ((ParameterInformation)
> >                         ((:label parlabel))
> >
>
> I'm not sure how the diff was created, as I couldn't get it to apply
> cleanly, but yes, this change does fix the issue.



-- 
João Távora

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.