GNU bug report logs - #74914
30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp

Previous Next

Package: emacs;

Reported by: Troy Brown <brownts <at> troybrown.dev>

Date: Mon, 16 Dec 2024 15:20:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.90

Done: João Távora <joaotavora <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Troy Brown <brownts <at> troybrown.dev>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Felician Nemeth <felician.nemeth <at> gmail.com>, João Távora <joaotavora <at> gmail.com>, 74914 <at> debbugs.gnu.org
Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp
Date: Sat, 4 Jan 2025 21:20:42 -0500
On Sat, Dec 28, 2024 at 10:22 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:
>
> So, does this fix the problem for you?
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 816a1e67eca..51c19d5681a 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -3416,7 +3416,7 @@ eglot--sig-info
>                                          'font-lock-function-name-face))))
>         ;; Now to the parameters
>         (cl-loop
> -       with active-param = (or sig-active activeParameter)
> +       with active-param = (or activeParameter sig-active)
>          for i from 0 for parameter across parameters do
>          (eglot--dbind ((ParameterInformation)
>                         ((:label parlabel))
>

I'm not sure how the diff was created, as I couldn't get it to apply
cleanly, but yes, this change does fix the issue.




This bug report was last modified 132 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.