From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 15:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 74914@debbugs.gnu.org Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= X-Debbugs-Original-To: "simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors" Received: via spool by submit@debbugs.gnu.org id=B.173436237328655 (code B ref -1); Mon, 16 Dec 2024 15:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Dec 2024 15:19:33 +0000 Received: from localhost ([127.0.0.1]:55571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNCse-0007S6-MJ for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:19:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:50002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNCsc-0007Ry-Tz for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:19:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNCsc-00041X-M0 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 10:19:30 -0500 Received: from mail-ej1-f48.google.com ([209.85.218.48]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNCsa-0000DB-JD for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 10:19:30 -0500 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a9e44654ae3so649701866b.1 for ; Mon, 16 Dec 2024 07:19:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734362366; x=1734967166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t90peEa6qUdvl7OyQlycR2BcqWEp463SRPDYqbUsD28=; b=GuFBoinKbx4hzXHuq2nYtDGvemMi8ueH0tddJXsNvOJHviiXsFfA/VKZ23BgFIKArX tczG4NiEDTsCdO7S1hXhL4/9KIOw7Cv6ryS2wpA+eqx9lXqZC9Gm2UTCssRG8HO1zaNr Ng8xKcYguSWUrQ6edTPo5B12LF4du+B8kWMExEQ0asiUP5Vkz+22WMW/gXQGVGbync6d tE/w3SdSZtzz5o6vYpIcRbKrW9ylC2kHwttaG1lI0F5QlH6BYXZWlP7vQKKFXtEFAs6u /u3ZlQIXOFvoAZX23yxfIDeXrWQu8dD6/iIHctXB2ypNhI1g90lUmwTo6ugeA5yBdwN5 Gxqw== X-Gm-Message-State: AOJu0YwB+2U4NLjUBQH1Qy4TpfmByZ6SxxBCInpNfIagRRfssRf3Rmkz NH8qFnN6PUAq/TccVo/mpQ2UsTQ0C+XznKCXB+62SLFwM7Iethh09tMDK4Ju0Rk= X-Gm-Gg: ASbGncutABKijdnTu35mj+8YEPrproqs5rrqZZ46a2Nw3Z037su8c15WUmf1UkTXVen 3ECMF7YUBC/lOr4AW0S5MREsnNxAEmlv1fCilZ7ySwWBUGOa3Z1HAgdPfromzuf7pWrrHQtrScB qiaScWJEDOWKcvhp7X6K9ExSV+o7QI50m+Imllu2oi1sEkuKjve/XeqrLJHHqhqIvPEUYdZMmYB xYD7jEHzwHw8aGrcGgkY/8Uvaa79TIc3De8vzFbpLLH5J00KEENwbP3MeGsL41sL/CqFZ6Ss1gF 7N0jgMuERuOGmWb/58Ng X-Google-Smtp-Source: AGHT+IFOX5QWWCeCUnRV10USeScbgWLRxwKg6q5Zy5BxPza2oLnkamH3EVXvlhbOXID1+U5r0jTyBA== X-Received: by 2002:a17:906:478a:b0:aa6:a21b:2a9 with SMTP id a640c23a62f3a-aab77ed4d3dmr1260738966b.57.1734362365965; Mon, 16 Dec 2024 07:19:25 -0800 (PST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab96390cbesm340022166b.158.2024.12.16.07.19.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 07:19:25 -0800 (PST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d647d5df90so4310596a12.2 for ; Mon, 16 Dec 2024 07:19:25 -0800 (PST) X-Received: by 2002:a17:907:7851:b0:aa6:9b02:7fd0 with SMTP id a640c23a62f3a-aab76d1a271mr1137822366b.0.1734362365173; Mon, 16 Dec 2024 07:19:25 -0800 (PST) MIME-Version: 1.0 From: Troy Brown Date: Mon, 16 Dec 2024 10:19:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.218.48; envelope-from=troy.s.brown@gmail.com; helo=mail-ej1-f48.google.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.13, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I'm working with a language server that provides an `activeParameter` field both in SignatureHelp (set to 0) as well as in SignatureInformation (set to 1). Under this condition, for the signature output in the echo area, Eglot always displays the first parameter (i.e., index 0). According to the LSP specification, when an `activeParameter` field is specified in SignatureInformation "this is used in place of `SignatureHelp.activeParameter`". The following is a partial log covering this transaction: [jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97] {"jsonrpc":"2.0","id":97,"method":"textDocument/signatureHelp","params":{"t= extDocument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib= .adb"},"position":{"line":102,"character":38}}} [jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri"= :"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnostics"= :[{"range":{"start":{"line":102,"character":38},"end":{"line":102,"characte= r":39}},"source":"libadalang","message":"Missing ';'"},{"range":{"start":{"line":102,"character":38},"end":{"line":102,"char= acter":39}},"source":"libadalang","message":"Skipped token )"},{"range":{"start":{"line":0,"character":0},"end":{"line":0,"chara= cter":0}},"severity":4,"source":"ada.project","message":""}]}} [jsonrpc] e[09:50:52.445] <-- textDocument/hover[95] {"jsonrpc":"2.0","id":95,"result":null} [jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96] {"jsonrpc":"2.0","id":96,"result":null} [jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97] {"jsonrpc":"2.0","id":97,"result":{"signatures":[{"label":"function Internal (Name : String; Thing : String) return GType","documentation":"","parameters":[{"label":"Name"},{"label":"Thing"}]= ,"activeParameter":1}],"activeSignature":0,"activeParameter":0}} I believe the reason for Eglot's behavior is due to the way "active-param" is specified in the cl-loop within `eglot--sig-info`. ```text with active-param =3D (or sig-active activeParameter) ``` The value of activeParameter in SignatureInformation (activeParameter) should be given higher priority (i.e., listed first) over the activeParameter specified in SignatureHelp (sig-active). From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: Acknowledgement (30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp) Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Dec 2024 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 74914@debbugs.gnu.org Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.173496928316337 (code B ref 74914); Mon, 23 Dec 2024 15:55:02 +0000 Received: (at 74914) by debbugs.gnu.org; 23 Dec 2024 15:54:43 +0000 Received: from localhost ([127.0.0.1]:55741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPklW-0004FR-Mt for submit@debbugs.gnu.org; Mon, 23 Dec 2024 10:54:42 -0500 Received: from mail-ej1-f52.google.com ([209.85.218.52]:58569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPklU-0004FB-S7 for 74914@debbugs.gnu.org; Mon, 23 Dec 2024 10:54:41 -0500 Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-aa68b513abcso841649966b.0 for <74914@debbugs.gnu.org>; Mon, 23 Dec 2024 07:54:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734969275; x=1735574075; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WBupv/IpecrnfJO2jdZAtF/ksquLBZaBa/Jj81KGsNE=; b=aswE3u6pEL4hOD7xWZYZChNpWr7T6bVIYm71v3/JU2Y+Jji07MeFjgPO98W9ttDMA2 R9mOuQJFme2e+h9r14d1BHjbEVeXwiJp0i8m9QNK7klJ4Bp+v3IKGOmgZWXKdz5LZqrx FrVwOwQ+AzNpdeBWIGWdelmA6pVQB0tenLghOXR3ZEHBbijMg5yTi+qVwc2sMBpkEoF8 JEi/ruTgCKQaqNCEx0FrQCC5NXlXFIp+ANerAzytoUBw4CvfGcGNG5WtS5+dtK2tXm/r 403zvZugDyQG/hlnp1ki1yozfxkMz3GC0L0LzYhJRDcutE2o2v39wovNEVT9OACxx6G+ /xjQ== X-Gm-Message-State: AOJu0YzHrxPQ2MbT1/Zo8loc6GOoH7yT7yqdP8wDgZ+jBt8uA9UP+Iz1 VtSYcAvN4QBEyg3Vr3VyyrkfX8GhMKX3FGjLAO7t7R9GTYHwlIjZrCWQW2hV9ng= X-Gm-Gg: ASbGnct5+laFgt2WvNG67cEtSTXItRj9VNY2zctf+nbr8Fqzhh0JdK7evbYrOWkyDCA jH/6BRAGKih4ESGb1ztRhrjRu/GeQUUxqeYi1O0uGUN0xdQvXlRovsEI6QpWUDsBsRD7w4759We B665hNg6FXZkUj0e0ZyMnJfDcSN+ipZEvZ+glzN8z8xPBPh4Cz4oQyJQYWZjbjNWuYHhIBLFjvb cUI1AhvPFi3H8Tyv0m19ykEK75A01Goue16yGIKb2nz+5jMmiScLWHHvs/tMqOMc3XmaDwbXzot 9ytaHcoyfC48t+FL819e X-Google-Smtp-Source: AGHT+IGxho66FtUw451cPNi9agqRhc1zGCpDQyiKelqhdr2vaiaUgL1+HOGmg0TKj2/NA6/8UNMsmg== X-Received: by 2002:a17:907:2d1e:b0:aa6:bcc2:4da1 with SMTP id a640c23a62f3a-aac2874a98amr1195665066b.7.1734969274315; Mon, 23 Dec 2024 07:54:34 -0800 (PST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0f016e2fsm529133366b.160.2024.12.23.07.54.34 for <74914@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 07:54:34 -0800 (PST) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aa696d3901bso23659466b.1 for <74914@debbugs.gnu.org>; Mon, 23 Dec 2024 07:54:34 -0800 (PST) X-Received: by 2002:a17:907:2da6:b0:aa6:7ab4:4597 with SMTP id a640c23a62f3a-aac3353bafcmr914570566b.39.1734969273881; Mon, 23 Dec 2024 07:54:33 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Troy Brown Date: Mon, 23 Dec 2024 10:54:22 -0500 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) FYI, this appears to be a regression introduced by e33c0a549153fa3894f3b5e9c5e42ce07a1a68c7 Troy. From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 11:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown , joaotavora@gmail.com Cc: felician.nemeth@gmail.com, 74914@debbugs.gnu.org Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.173538564431509 (code B ref 74914); Sat, 28 Dec 2024 11:35:02 +0000 Received: (at 74914) by debbugs.gnu.org; 28 Dec 2024 11:34:04 +0000 Received: from localhost ([127.0.0.1]:49481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV51-0008C1-KW for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:34:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV4z-0008BB-8Q for 74914@debbugs.gnu.org; Sat, 28 Dec 2024 06:34:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRV4t-00087i-Fl; Sat, 28 Dec 2024 06:33:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tFty5J7wOWcpCZk4a9IQ6+/dJx8a68hx2O6+E5ycYTw=; b=PdZEX0UTpDGgahf8oYUW +vUrjkfDMGdIM7EjtGk5DIdxCMyCizB51fsqyzmTcNTlTTqHMtbqLc0JB5M/u98Bg3HsDr2OmtJkc iFWQXCPpLKCYqWwMcncfapE2TgeqNSNEexw8jM3H0NzjtqQi6USg38X9s04j1skEmcIyzwhNr5C9d yLt95IudhqLkQs0ajEmhQBCJE/DWZErwHKt3kxN7MzAqCu1rskRNf1RXj9JEl4pwUSO3i3ElkAXIi kkb9cwQSGRr8R1Cv9iMG2e+63dB8CWWXNDdIXG2MrJ/1a8oTLsDTsF7jRj4snOnsxiC7nRCtRZsVp W/grJLCYGHUEIQ==; Date: Sat, 28 Dec 2024 13:33:51 +0200 Message-Id: <868qs0t528.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Troy Brown on Mon, 16 Dec 2024 10:19:14 -0500) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Felician Nemeth , > João Távora > From: Troy Brown > Date: Mon, 16 Dec 2024 10:19:14 -0500 > > I'm working with a language server that provides an `activeParameter` > field both in SignatureHelp (set to 0) as well as in > SignatureInformation (set to 1). Under this condition, for the > signature output in the echo area, Eglot always displays the first > parameter (i.e., index 0). According to the LSP specification, when > an `activeParameter` field is specified in SignatureInformation "this > is used in place of `SignatureHelp.activeParameter`". The following > is a partial log covering this transaction: > > [jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97] > {"jsonrpc":"2.0","id":97,"method":"textDocument/signatureHelp","params":{"textDocument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb"},"position":{"line":102,"character":38}}} > [jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics > {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnostics":[{"range":{"start":{"line":102,"character":38},"end":{"line":102,"character":39}},"source":"libadalang","message":"Missing > ';'"},{"range":{"start":{"line":102,"character":38},"end":{"line":102,"character":39}},"source":"libadalang","message":"Skipped > token )"},{"range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}},"severity":4,"source":"ada.project","message":""}]}} > [jsonrpc] e[09:50:52.445] <-- textDocument/hover[95] > {"jsonrpc":"2.0","id":95,"result":null} > [jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96] > {"jsonrpc":"2.0","id":96,"result":null} > [jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97] > {"jsonrpc":"2.0","id":97,"result":{"signatures":[{"label":"function > Internal (Name : String; Thing : String) return > GType","documentation":"","parameters":[{"label":"Name"},{"label":"Thing"}],"activeParameter":1}],"activeSignature":0,"activeParameter":0}} > > I believe the reason for Eglot's behavior is due to the way > "active-param" is specified in the cl-loop within `eglot--sig-info`. > ```text > with active-param = (or sig-active activeParameter) > ``` > The value of activeParameter in SignatureInformation (activeParameter) > should be given higher priority (i.e., listed first) over the > activeParameter specified in SignatureHelp (sig-active). João, any comments or suggestions? From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Troy Brown , Felician Nemeth , 74914@debbugs.gnu.org Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.173539257219267 (code B ref 74914); Sat, 28 Dec 2024 13:30:02 +0000 Received: (at 74914) by debbugs.gnu.org; 28 Dec 2024 13:29:32 +0000 Received: from localhost ([127.0.0.1]:49779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWsl-00050g-RC for submit@debbugs.gnu.org; Sat, 28 Dec 2024 08:29:32 -0500 Received: from mail-oa1-f54.google.com ([209.85.160.54]:53337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWsj-00050R-Im for 74914@debbugs.gnu.org; Sat, 28 Dec 2024 08:29:30 -0500 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-29e91e58584so4881644fac.2 for <74914@debbugs.gnu.org>; Sat, 28 Dec 2024 05:29:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735392504; x=1735997304; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4ybqEniqV9LVKpd3Qqd3wZ0Io6bmwae+frdRRDzbyZg=; b=c9Q4TO7vsVew0Re4T5ct2Yb9/AUN/iV7dbGK3ubrsMBc0xdilNju/3SjlFUWev9l12 nl0hMFwkVFkgsK6p19syHBF4ivfxfC1H+RXvAdRcOORRgsRZAYJS7i+9EmZOh8ZUj566 CwC67DiQ8AOScGPVBZCWOkJvv+/pkCpj58ZVXz1LPWLQY0IBq64aPM5Frs/x32TVVyhF sk/fG4DWpobtoWJi8OLqNP0J5lx36OxRgaf+WZpG7w1FHAlhT7Q+DxnTlEECLaLaZNiW xo+wlGBXSGTNK9wPnQQo2lzLK39eZtytwM2D8/+yDnhrsO1hOSMqG93/nDc4xwOVJDtx NddQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735392504; x=1735997304; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4ybqEniqV9LVKpd3Qqd3wZ0Io6bmwae+frdRRDzbyZg=; b=q9KyzNOr7mjKzAAT2P1g2K39Kaa3HTr/d0MmYFnaz7IYqep7lOB2zEJcbYsbyFhHr6 UA6YSpZjSjiae4lutTbeHrx0UL38aUGQ1j5PidMia8GtezN12aqWxk+LkBgaXsfU0KtH iMhdr3IdB4vZSxZK+2g27B+U4NAxzq6+sLMU3ld64F0InY3DmoFzK7UmNNpdr+3TD3zb /9q23UCj0mfBCj1pWfQKmLH7oOH/5+X3glKs3H9GFBlEYiLYANlkZ4gWjmPhqcHyu+IS S5f4pQxm72hMHUqmjfIhw0V2upE/dvtEnbsJlCtGq2U2Iz0t6qHm62VkeneLry6QYGOL 6GXQ== X-Forwarded-Encrypted: i=1; AJvYcCUSKbPnrAlD7Iz4U++lLPAwj7cQkRb4sJA1bL4cAtOeCVPvE5uj2lpb90ktJ6ogYZBxnjsZNw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwxIqvMtPlBklwmdeuFX+Dmp/0PiMsHey2hrTqHOLPEGFbNp040 ASPoQFy5isylAdjJ4enCLe3UdxHc4CjcofwMTAMzNqEso9PWkmYcGxs9GPrqPWrilzBNPqiHWFp RcuBEypvdmAS+2mxfnLOl7zXmvr8= X-Gm-Gg: ASbGncscrPuYFPxaaP0Qoi9UwrM7T1IMw9T7RvHLpp2zE31Qbj9/ge0W3EyCKK9dfYP n4bPfXtDvJOpJa6s3JAr1r+bIUgxVu4essFF+ X-Google-Smtp-Source: AGHT+IFCG4Hq6PVClp25R/zATpxA6v2okc01rfmwaRDJ5qUWwHw4spsT28FIzhcT4jGqk2irVHflU4N3KV3XRSczlWo= X-Received: by 2002:a05:6870:2153:b0:29e:65ed:5c70 with SMTP id 586e51a60fabf-2a7fb30519emr17025716fac.30.1735392503825; Sat, 28 Dec 2024 05:28:23 -0800 (PST) MIME-Version: 1.0 References: <868qs0t528.fsf@gnu.org> In-Reply-To: <868qs0t528.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 28 Dec 2024 13:28:12 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000bc8d45062a548d8c" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bc8d45062a548d8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This looks like it's good, but i'd have to double check in 2025 (away from my machine until then) unless Felician is confident and signs off on it. Jo=C3=A3o On Sat, Dec 28, 2024, 11:33 Eli Zaretskii wrote: > > Cc: Felician Nemeth , > > Jo=C3=A3o T=C3=A1vora > > From: Troy Brown > > Date: Mon, 16 Dec 2024 10:19:14 -0500 > > > > I'm working with a language server that provides an `activeParameter` > > field both in SignatureHelp (set to 0) as well as in > > SignatureInformation (set to 1). Under this condition, for the > > signature output in the echo area, Eglot always displays the first > > parameter (i.e., index 0). According to the LSP specification, when > > an `activeParameter` field is specified in SignatureInformation "this > > is used in place of `SignatureHelp.activeParameter`". The following > > is a partial log covering this transaction: > > > > [jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97] > > > {"jsonrpc":"2.0","id":97,"method":"textDocument/signatureHelp","params":{= "textDocument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/gl= ib.adb"},"position":{"line":102,"character":38}}} > > [jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics > > > {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"ur= i":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnostic= s":[{"range":{"start":{"line":102,"character":38},"end":{"line":102,"charac= ter":39}},"source":"libadalang","message":"Missing > > > ';'"},{"range":{"start":{"line":102,"character":38},"end":{"line":102,"ch= aracter":39}},"source":"libadalang","message":"Skipped > > token > )"},{"range":{"start":{"line":0,"character":0},"end":{"line":0,"character= ":0}},"severity":4,"source":"ada.project","message":""}]}} > > [jsonrpc] e[09:50:52.445] <-- textDocument/hover[95] > > {"jsonrpc":"2.0","id":95,"result":null} > > [jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96] > > {"jsonrpc":"2.0","id":96,"result":null} > > [jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97] > > {"jsonrpc":"2.0","id":97,"result":{"signatures":[{"label":"function > > Internal (Name : String; Thing : String) return > > > GType","documentation":"","parameters":[{"label":"Name"},{"label":"Thing"= }],"activeParameter":1}],"activeSignature":0,"activeParameter":0}} > > > > I believe the reason for Eglot's behavior is due to the way > > "active-param" is specified in the cl-loop within `eglot--sig-info`. > > ```text > > with active-param =3D (or sig-active activeParameter) > > ``` > > The value of activeParameter in SignatureInformation (activeParameter) > > should be given higher priority (i.e., listed first) over the > > activeParameter specified in SignatureHelp (sig-active). > > Jo=C3=A3o, any comments or suggestions? > --000000000000bc8d45062a548d8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This looks like it's good, but i'd have to double= check in 2025 (away from my machine until then) unless Felician is confide= nt and signs off on it.=C2=A0=C2=A0

Jo=C3=A3o=C2=A0

On Sat, Dec 28, 2024, 11:33 Eli Zaretskii <eliz@gnu= .org> wrote:
> Cc: Felician Nemeth <felician.nemeth@gmail.co= m>,
>=C2=A0 Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com&= gt;
> From: Troy Brown <brownts@troybrown.dev>
> Date: Mon, 16 Dec 2024 10:19:14 -0500
>
> I'm working with a language server that provides an `activeParamet= er`
> field both in SignatureHelp (set to 0) as well as in
> SignatureInformation (set to 1).=C2=A0 Under this condition, for the > signature output in the echo area, Eglot always displays the first
> parameter (i.e., index 0).=C2=A0 According to the LSP specification, w= hen
> an `activeParameter` field is specified in SignatureInformation "= this
> is used in place of `SignatureHelp.activeParameter`".=C2=A0 The f= ollowing
> is a partial log covering this transaction:
>
> [jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97]
> {"jsonrpc":"2.0","id":97,"method&qu= ot;:"textDocument/signatureHelp","params":{"textDo= cument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80= c56171/src/glib.adb"},"position":{"line":102,"= ;character":38}}}
> [jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics
> {"jsonrpc":"2.0","method":"textDocu= ment/publishDiagnostics","params":{"uri":"fil= e:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnos= tics":[{"range":{"start":{"line":102,&qu= ot;character":38},"end":{"line":102,"characte= r":39}},"source":"libadalang","message":= "Missing
> ';'"},{"range":{"start":{"line&q= uot;:102,"character":38},"end":{"line":102,&q= uot;character":39}},"source":"libadalang","me= ssage":"Skipped
> token )"},{"range":{"start":{"line"= :0,"character":0},"end":{"line":0,"chara= cter":0}},"severity":4,"source":"ada.project&= quot;,"message":""}]}}
> [jsonrpc] e[09:50:52.445] <-- textDocument/hover[95]
> {"jsonrpc":"2.0","id":95,"result&qu= ot;:null}
> [jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96] > {"jsonrpc":"2.0","id":96,"result&qu= ot;:null}
> [jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97]
> {"jsonrpc":"2.0","id":97,"result&qu= ot;:{"signatures":[{"label":"function
> Internal (Name : String; Thing : String) return
> GType","documentation":"","parameters&qu= ot;:[{"label":"Name"},{"label":"Thing&qu= ot;}],"activeParameter":1}],"activeSignature":0,"a= ctiveParameter":0}}
>
> I believe the reason for Eglot's behavior is due to the way
> "active-param" is specified in the cl-loop within `eglot--si= g-info`.
> ```text
> with active-param =3D (or sig-active activeParameter)
> ```
> The value of activeParameter in SignatureInformation (activeParameter)=
> should be given higher priority (i.e., listed first) over the
> activeParameter specified in SignatureHelp (sig-active).

Jo=C3=A3o, any comments or suggestions?
--000000000000bc8d45062a548d8c-- From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2024 03:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Troy Brown , 74914@debbugs.gnu.org Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.173544258214330 (code B ref 74914); Sun, 29 Dec 2024 03:24:01 +0000 Received: (at 74914) by debbugs.gnu.org; 29 Dec 2024 03:23:02 +0000 Received: from localhost ([127.0.0.1]:53301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRjtO-0003ie-1C for submit@debbugs.gnu.org; Sat, 28 Dec 2024 22:23:02 -0500 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]:41043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRjtL-0003iM-SS for 74914@debbugs.gnu.org; Sat, 28 Dec 2024 22:23:00 -0500 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 73EFD25400E5; Sat, 28 Dec 2024 22:22:53 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 28 Dec 2024 22:22:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1735442573; x=1735528973; bh=rzbJlE7E9S8m1dy8E0uznIG+eo3zvWlVKW0xW0F5yaM=; b= kg9Fe4Z5Gim6QNTG057W2gCAjVKJjOZXDvlQ10qJ2KJvVblWGhQTuNFkxFnFMX5I 9hShOUbuP3MNSAnXkmA+tqs93m0IvER+4dq0jWAWXri9SbPzjVVC5ElG4XR1Du5z GolRTnXqCL2LDsYNFTVf40IfeDWiR/d49NMnGIFvNzKv8utGYxn34lEHnHfE0+BB g3fC+gKvstMMpm9A9N8aIYQuQxxDStjprnLN96AnHv1I1CnxmPgnOXuB4P/DOdqs yZ18tOmo6kDc0XkFVEaiJXM3pKGLzQ7x5K/ZhuxAhaqBMAOD/3aP9XdsBfMMbydK 5EcMnRMKsMfUGdrVDAhS3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1735442573; x= 1735528973; bh=rzbJlE7E9S8m1dy8E0uznIG+eo3zvWlVKW0xW0F5yaM=; b=H LjkF3J5/vlWFbOgivCHAuNr4MS0XIe58nYw0eYErm5OGfTJYZatMOp5pzfUSlvHq DWDPiqv29tNaYgxPwxTMPWQa9qVoci4t1dnQdE32z0HbUQDstCUmpCu1/XyGWRIZ u/39eZZjZC+TC/bh66+/XidwJYITKPawSWDnanTdMvgBQS7QgH666BNEIs6NfmBh mtPsFutqEcSzH6zVKlnU6mGfID62WgWeVH3FI+kRk7kxCQk0djB62oOFIEDr5f38 isk2w/ylcnVg+fnaKmXVgxPMXQvtXQABnwUEvivbcUeJzPmtY4NuA1V1dxZID5Fk FdOzUbbNcUa1vvOkESHjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvfedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsrhhofihnthhssehtrhhohi gsrhhofihnrdguvghvpdhrtghpthhtohepjeegledugeesuggvsggsuhhgshdrghhnuhdr ohhrghdprhgtphhtthhopehfvghlihgtihgrnhdrnhgvmhgvthhhsehgmhgrihhlrdgtoh hmpdhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Dec 2024 22:22:51 -0500 (EST) Message-ID: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> Date: Sun, 29 Dec 2024 05:22:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! On 16/12/2024 17:19, Troy Brown wrote: > I believe the reason for Eglot's behavior is due to the way > "active-param" is specified in the cl-loop within `eglot--sig-info`. > ```text > with active-param = (or sig-active activeParameter) > ``` > The value of activeParameter in SignatureInformation (activeParameter) > should be given higher priority (i.e., listed first) over the > activeParameter specified in SignatureHelp (sig-active). So, does this fix the problem for you? diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 816a1e67eca..51c19d5681a 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3416,7 +3416,7 @@ eglot--sig-info 'font-lock-function-name-face)))) ;; Now to the parameters (cl-loop - with active-param = (or sig-active activeParameter) + with active-param = (or activeParameter sig-active) for i from 0 for parameter across parameters do (eglot--dbind ((ParameterInformation) ((:label parlabel)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 20:31:22 2025 Received: (at control) by debbugs.gnu.org; 2 Jan 2025 01:31:22 +0000 Received: from localhost ([127.0.0.1]:41203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTA3W-0000pa-HQ for submit@debbugs.gnu.org; Wed, 01 Jan 2025 20:31:22 -0500 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:60846) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTA3U-0000pL-RP for control@debbugs.gnu.org; Wed, 01 Jan 2025 20:31:21 -0500 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5d8de655efaso3603260a12.1 for ; Wed, 01 Jan 2025 17:31:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735781475; x=1736386275; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Ak2df1spGexJDxTysS/1jymB+VlGc7gR6ueJCxnz3mA=; b=bxcDGia6oSm25kv/H2OFDxlTl7bsRT1OQdb5zlMw4nkhgYJVmX/aykNkQWEfrUaq+H JhiaVyiykyEBUMWHZoAyAY3iZBQp2A6Fc5A/dRoFJ4ghfwome0g9YpTaZGpGiFq21OmP fHjhE3lu7w3p4RzBSkbJu/lsa1SDV87hToPi9aSL6R6Dh6gtcbsXe+uUJ2U6RxxZZeNt vPkZIGje3s++YuM1gfWIZ3W4AUF2TjLKG/YBb8VWWxYSemFaTN/behBYAhJOUsQZ4FbG 4YmvHjkwzGtiuqrekmkyZ8csAlICFowL/CKTiGuqpdBS+Daq8MN/zxX9RrSMN9v6Zm93 pgPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735781475; x=1736386275; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ak2df1spGexJDxTysS/1jymB+VlGc7gR6ueJCxnz3mA=; b=a6NIRQOvp91c2ECse/FEzlKsgIkEEr0tnzl/FuMKAne5aX6Bx6HniPDo07DjTtbUcL x754TMHDLA1IvE+RUqk2pVNHWA2/RRmxXn5iIeWUgoLWU3snucK5aRfNhwcVWasTzn6Y PQzeMsA7AIQESRwHyhkyXkIvOYSWEhkTidES9kehvsbVMG1rTmGKY7nOmAgbp7XW8JIy gQBkO/sMGxTujONWSYQAD+Pmk5vyXqMCIANd6zo6mEuSqpWxBN5wKnWi3GdsMaAa4+bE 6zFacNA9MtqCV0yXJScWa0NmBird4OAeVD4qj1T/6fsidaD50tBTZNYpMjCjMiYAHobe 3l+A== X-Gm-Message-State: AOJu0Yw5mqlzEY1437DIU8DCP0q0t9pknZSVr596tam9J2pToYOYSxNj mYuUv1At87MKTAViBgDC0KqEE7t/Q+TVV7ZV87YVUd3BFD/bI9f36z1qRWutZyPl+z4zzdLPhOQ Ay39VTn06UnPhya8jxwjdRD9bxxNiQGjs X-Gm-Gg: ASbGncuRFDFxkozaUIMCMSe1LyJ4OkB55W5TA72OfzJ9h4oKFdDVFqAE/JrKw5EEpBG qf3FPfHh2PzjpPVoU/MTWIrA0g/wM6fprNmN/d8UP X-Google-Smtp-Source: AGHT+IHXEFb/dJh6Y2upbCJ9BOQ6mILL8IRdQKInoCHkFDeexdHsorHw1KTHmJlxsFQ2lhlVFY0mKlO7rzIcaJWaxnk= X-Received: by 2002:a05:6402:4402:b0:5cf:e9d6:cc8a with SMTP id 4fb4d7f45d1cf-5d81dda9256mr39506403a12.20.1735781474709; Wed, 01 Jan 2025 17:31:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 1 Jan 2025 19:31:14 -0600 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 1 Jan 2025 19:31:14 -0600 Message-ID: Subject: control message for bug #74914 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 74914 + patch quit From unknown Sun Jun 15 08:51:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp Resent-From: Troy Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 02:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: Felician Nemeth , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 74914@debbugs.gnu.org Received: via spool by 74914-submit@debbugs.gnu.org id=B74914.17360436579112 (code B ref 74914); Sun, 05 Jan 2025 02:21:02 +0000 Received: (at 74914) by debbugs.gnu.org; 5 Jan 2025 02:20:57 +0000 Received: from localhost ([127.0.0.1]:58165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUGG9-0002Mt-C5 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 21:20:57 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:46394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUGG7-0002Ml-Cf for 74914@debbugs.gnu.org; Sat, 04 Jan 2025 21:20:56 -0500 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a9e44654ae3so2212192666b.1 for <74914@debbugs.gnu.org>; Sat, 04 Jan 2025 18:20:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736043654; x=1736648454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/bHMk9Ca7T/QitOe30Er9VhOdKZeAnnhWNbFgjDFSM=; b=odKXfiCFVcZvgBKAb333TOCyQ2ZCoGCCp53Xusi5WiWuDD+mbJWuwlzPjnbDoUkGUH oPaEFvJK0S6OsH1pjDsQOxeB5MkV2NF/WbPVu9zkH1FI2w8QibPbAH/91N7vXAsl6Ta1 97XUWlxTcmRnFq4F9yBmXWekLVVEeoBiRKCPv5+MKanPZjL1q/OwCVLjGLXKfY5ApQZH LzhqNIMaJShltdhyCMxU4igvq+2iCWuybkL1cfzxI7tI+bzbpOPQYcf+Aas8TLbywzaS TALUTAYde9G1+HN0ypuE6sGw1Snc1RyUYN3htdCufrm7eqzc7T9b8CB7jcvNt4UWl/lo BQTw== X-Gm-Message-State: AOJu0Yw8DC2Kh2TR3uzi9+2MnkxfkGKL+GLBhESe1OBvISGs33hABh1I 8hS1jVlDCARdM+/11trJpIPZtvtZ/2zA+/iy+1cOghg8bLCEAOnIy/xXgr6c X-Gm-Gg: ASbGnct2lplY6Vd3urYU+JPHw1TsqmvFfx/e9EbEbCAEC2HmYDSws+vqmqTJwumiVw1 fl5Qz0mOpU26L7sDZpW4qrFgawz9Q8no8N4kQ1fnvkrbq4FLrsciikrtLA4DLQ9VOMgm/NeHHBx LUpuV2P5lzXqhpLRhjLoTB3Agh6i5Aze9nE2SNookrEomzJYACYmvyPqeTkXcIyUFIeapVaezF5 ivpcSDdm8ArMwQAUbYS6AIE6fEsBpbvPTOIJ9ItuYGgaYS+iPzyFM0ufHqe665EDWv3uEv2yeO0 ZRqwMGdO+AAdyyKw75nA X-Google-Smtp-Source: AGHT+IFUJMLwtXxeKks1rk2ozQviKLidqk81Y7PQGKcertniiPgfp8Ux8tvp5U/Ud0+tFShAiDw8CA== X-Received: by 2002:a17:907:3f12:b0:aa6:7220:f12f with SMTP id a640c23a62f3a-aac2ad8abccmr5778351366b.18.1736043653710; Sat, 04 Jan 2025 18:20:53 -0800 (PST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0eae71desm2064079566b.89.2025.01.04.18.20.53 for <74914@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jan 2025 18:20:53 -0800 (PST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aaeec07b705so1419483766b.2 for <74914@debbugs.gnu.org>; Sat, 04 Jan 2025 18:20:53 -0800 (PST) X-Received: by 2002:a17:907:7e8c:b0:aac:2128:c89e with SMTP id a640c23a62f3a-aac334f31fbmr5548708466b.43.1736043653102; Sat, 04 Jan 2025 18:20:53 -0800 (PST) MIME-Version: 1.0 References: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> In-Reply-To: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> From: Troy Brown Date: Sat, 4 Jan 2025 21:20:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, Dec 28, 2024 at 10:22=E2=80=AFPM Dmitry Gutov wr= ote: > > So, does this fix the problem for you? > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 816a1e67eca..51c19d5681a 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -3416,7 +3416,7 @@ eglot--sig-info > 'font-lock-function-name-face)))= ) > ;; Now to the parameters > (cl-loop > - with active-param =3D (or sig-active activeParameter) > + with active-param =3D (or activeParameter sig-active) > for i from 0 for parameter across parameters do > (eglot--dbind ((ParameterInformation) > ((:label parlabel)) > I'm not sure how the diff was created, as I couldn't get it to apply cleanly, but yes, this change does fix the issue. From unknown Sun Jun 15 08:51:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Troy Brown Subject: bug#74914: closed (Re: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp) Message-ID: References: X-Gnu-PR-Message: they-closed 74914 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 74914@debbugs.gnu.org Date: Mon, 06 Jan 2025 10:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1736160962-17868-1" This is a multi-part message in MIME format... ------------=_1736160962-17868-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 74914@debbugs.gnu.org. --=20 74914: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D74914 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1736160962-17868-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 74914-done) by debbugs.gnu.org; 6 Jan 2025 10:55:36 +0000 Received: from localhost ([127.0.0.1]:36891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUklj-0004dQ-QC for submit@debbugs.gnu.org; Mon, 06 Jan 2025 05:55:36 -0500 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]:47448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tUklg-0004dA-Sf for 74914-done@debbugs.gnu.org; Mon, 06 Jan 2025 05:55:34 -0500 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-2689e7a941fso4551451fac.3 for <74914-done@debbugs.gnu.org>; Mon, 06 Jan 2025 02:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736160931; x=1736765731; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zKA/q7d8wZWvtuVZnzUOoYEJeL9ZNj2/mBs6paXl0Bw=; b=g5eWLE6GUpecFee6NPD+djVZAE9YECtSdpjTgQLqRXMMAra9xPVdnPASdCvZXkH/lO YIFwwTAgGcdxHC8brV2MYjsTOVHwmSo5a/c54lBNDgvngDtNSJ9hVldFqlIMNOErKp+J ZsabwXEgvZXvtUQP8G8ljrkQ8o0d4VvTrACaRalVkT6hFik7tmyO9q1gzWA/chbRwfM5 1WAnPq2T9W2w18uU1Svj2vbQpPOz/JX9LHvkysGFKc27/W9UE4MDlqX6bTl0oaZC4bZ0 SGUE+r0o3jq34+MwyZ0nLucISaVl5zX7vfZ38Bczq4FS8q3JIchk2mLyDw1dEVf5m08Q RQQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736160931; x=1736765731; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zKA/q7d8wZWvtuVZnzUOoYEJeL9ZNj2/mBs6paXl0Bw=; b=mm2M4Rn6Oj8UfPrsLcf81VB9cfzsQjR0RRiq2aT0x9An9AmfHA83XecnxsVCNiR64S RxraiDKdu+sGYnuPsKRKF7wJMO49tKh5qD+TQP9cDjvCQynvzgrSLYbM2aJjKfvX/DjY lcQoGU4Bw4ffe/EPaxaT3jAVdxNEHq2gEfS/RbnSckyUHtKbiT/NrW4Sniy/OkYmMPk+ HsohRlFG1ecEp5R67xPjV2gXZsy/zu+9p5kVXr76YIM6wecS5D+SGpmuIYOBkiGYXRbn fQK1rckwyAgWlSYhh/JaQOxtWhjksExAZRi8XY5pP+H8gsxYzCnM5P8odkZXsZKRP9qh KRPA== X-Forwarded-Encrypted: i=1; AJvYcCWKfYpwaY0StWIdVlR6rhlK9Yt2VYqcxcNnIhr/7N3kCDdUHuujfyPJtLFy4T7UnH9KZlfGWgCntekB@debbugs.gnu.org X-Gm-Message-State: AOJu0YwDtpqDMKNkZYA8CiSXBNEB9dKz+bm2SCIJEXxB43ZKLlgUR+WU xMZi/WzaQqTyzOIwr7HvpF6oHM9PzyP62CIqKhVoklYLZ+ketvomopJntclWwJQQQbQ8kPJQ/wO 2OxIXfxZenZN+PJalVIEDES9zu+I= X-Gm-Gg: ASbGnctA0CIDapg8tVSXruZ0Gcwn0ki3wT8ZUQqoe45jYn0c454hefK0tqLnY/XqdJd UTIUqaFY0UCKJLuNCvccH/73PDpXrO6qp0Oy8xA== X-Google-Smtp-Source: AGHT+IHnybNjrPE+L5ntKoWB/QjcRYeVDMFIDHK/Af/NpQE9FtyVaFLNrtW7X3oKpgpKIfhayzwsPklXbTJbtu7cS2A= X-Received: by 2002:a05:6871:d114:b0:296:e10f:af14 with SMTP id 586e51a60fabf-2a7fb4c9d62mr26037472fac.39.1736160931224; Mon, 06 Jan 2025 02:55:31 -0800 (PST) MIME-Version: 1.0 References: <53ccf716-7ca6-476f-af39-36300f0a7f1e@gutov.dev> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 6 Jan 2025 10:55:26 +0000 Message-ID: Subject: Re: bug#74914: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp To: Troy Brown , 74914-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 74914-done Cc: Dmitry Gutov , Felician Nemeth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) I pushed this patch yesterday. Thanks everyone, closing the bug. On Sun, Jan 5, 2025 at 2:20=E2=80=AFAM Troy Brown w= rote: > > On Sat, Dec 28, 2024 at 10:22=E2=80=AFPM Dmitry Gutov = wrote: > > > > So, does this fix the problem for you? > > > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index 816a1e67eca..51c19d5681a 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -3416,7 +3416,7 @@ eglot--sig-info > > 'font-lock-function-name-face)= ))) > > ;; Now to the parameters > > (cl-loop > > - with active-param =3D (or sig-active activeParameter) > > + with active-param =3D (or activeParameter sig-active) > > for i from 0 for parameter across parameters do > > (eglot--dbind ((ParameterInformation) > > ((:label parlabel)) > > > > I'm not sure how the diff was created, as I couldn't get it to apply > cleanly, but yes, this change does fix the issue. --=20 Jo=C3=A3o T=C3=A1vora ------------=_1736160962-17868-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Dec 2024 15:19:33 +0000 Received: from localhost ([127.0.0.1]:55571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNCse-0007S6-MJ for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:19:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:50002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNCsc-0007Ry-Tz for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:19:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNCsc-00041X-M0 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 10:19:30 -0500 Received: from mail-ej1-f48.google.com ([209.85.218.48]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNCsa-0000DB-JD for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 10:19:30 -0500 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a9e44654ae3so649701866b.1 for ; Mon, 16 Dec 2024 07:19:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734362366; x=1734967166; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t90peEa6qUdvl7OyQlycR2BcqWEp463SRPDYqbUsD28=; b=GuFBoinKbx4hzXHuq2nYtDGvemMi8ueH0tddJXsNvOJHviiXsFfA/VKZ23BgFIKArX tczG4NiEDTsCdO7S1hXhL4/9KIOw7Cv6ryS2wpA+eqx9lXqZC9Gm2UTCssRG8HO1zaNr Ng8xKcYguSWUrQ6edTPo5B12LF4du+B8kWMExEQ0asiUP5Vkz+22WMW/gXQGVGbync6d tE/w3SdSZtzz5o6vYpIcRbKrW9ylC2kHwttaG1lI0F5QlH6BYXZWlP7vQKKFXtEFAs6u /u3ZlQIXOFvoAZX23yxfIDeXrWQu8dD6/iIHctXB2ypNhI1g90lUmwTo6ugeA5yBdwN5 Gxqw== X-Gm-Message-State: AOJu0YwB+2U4NLjUBQH1Qy4TpfmByZ6SxxBCInpNfIagRRfssRf3Rmkz NH8qFnN6PUAq/TccVo/mpQ2UsTQ0C+XznKCXB+62SLFwM7Iethh09tMDK4Ju0Rk= X-Gm-Gg: ASbGncutABKijdnTu35mj+8YEPrproqs5rrqZZ46a2Nw3Z037su8c15WUmf1UkTXVen 3ECMF7YUBC/lOr4AW0S5MREsnNxAEmlv1fCilZ7ySwWBUGOa3Z1HAgdPfromzuf7pWrrHQtrScB qiaScWJEDOWKcvhp7X6K9ExSV+o7QI50m+Imllu2oi1sEkuKjve/XeqrLJHHqhqIvPEUYdZMmYB xYD7jEHzwHw8aGrcGgkY/8Uvaa79TIc3De8vzFbpLLH5J00KEENwbP3MeGsL41sL/CqFZ6Ss1gF 7N0jgMuERuOGmWb/58Ng X-Google-Smtp-Source: AGHT+IFOX5QWWCeCUnRV10USeScbgWLRxwKg6q5Zy5BxPza2oLnkamH3EVXvlhbOXID1+U5r0jTyBA== X-Received: by 2002:a17:906:478a:b0:aa6:a21b:2a9 with SMTP id a640c23a62f3a-aab77ed4d3dmr1260738966b.57.1734362365965; Mon, 16 Dec 2024 07:19:25 -0800 (PST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com. [209.85.208.47]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab96390cbesm340022166b.158.2024.12.16.07.19.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 07:19:25 -0800 (PST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d647d5df90so4310596a12.2 for ; Mon, 16 Dec 2024 07:19:25 -0800 (PST) X-Received: by 2002:a17:907:7851:b0:aa6:9b02:7fd0 with SMTP id a640c23a62f3a-aab76d1a271mr1137822366b.0.1734362365173; Mon, 16 Dec 2024 07:19:25 -0800 (PST) MIME-Version: 1.0 From: Troy Brown Date: Mon, 16 Dec 2024 10:19:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: 30.0.90; Eglot: Incorrect parameter highlighted in signatureHelp To: "simon254--- via Bug reports for GNU Emacs, the Swiss army knife of text editors" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=209.85.218.48; envelope-from=troy.s.brown@gmail.com; helo=mail-ej1-f48.google.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.13, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Felician Nemeth , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) I'm working with a language server that provides an `activeParameter` field both in SignatureHelp (set to 0) as well as in SignatureInformation (set to 1). Under this condition, for the signature output in the echo area, Eglot always displays the first parameter (i.e., index 0). According to the LSP specification, when an `activeParameter` field is specified in SignatureInformation "this is used in place of `SignatureHelp.activeParameter`". The following is a partial log covering this transaction: [jsonrpc] e[09:50:52.423] --> textDocument/signatureHelp[97] {"jsonrpc":"2.0","id":97,"method":"textDocument/signatureHelp","params":{"t= extDocument":{"uri":"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib= .adb"},"position":{"line":102,"character":38}}} [jsonrpc] e[09:50:52.444] <-- textDocument/publishDiagnostics {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri"= :"file:///home/troy/junk/gtkada_24.0.0_80c56171/src/glib.adb","diagnostics"= :[{"range":{"start":{"line":102,"character":38},"end":{"line":102,"characte= r":39}},"source":"libadalang","message":"Missing ';'"},{"range":{"start":{"line":102,"character":38},"end":{"line":102,"char= acter":39}},"source":"libadalang","message":"Skipped token )"},{"range":{"start":{"line":0,"character":0},"end":{"line":0,"chara= cter":0}},"severity":4,"source":"ada.project","message":""}]}} [jsonrpc] e[09:50:52.445] <-- textDocument/hover[95] {"jsonrpc":"2.0","id":95,"result":null} [jsonrpc] e[09:50:52.454] <-- textDocument/documentHighlight[96] {"jsonrpc":"2.0","id":96,"result":null} [jsonrpc] e[09:50:52.454] <-- textDocument/signatureHelp[97] {"jsonrpc":"2.0","id":97,"result":{"signatures":[{"label":"function Internal (Name : String; Thing : String) return GType","documentation":"","parameters":[{"label":"Name"},{"label":"Thing"}]= ,"activeParameter":1}],"activeSignature":0,"activeParameter":0}} I believe the reason for Eglot's behavior is due to the way "active-param" is specified in the cl-loop within `eglot--sig-info`. ```text with active-param =3D (or sig-active activeParameter) ``` The value of activeParameter in SignatureInformation (activeParameter) should be given higher priority (i.e., listed first) over the activeParameter specified in SignatureHelp (sig-active). ------------=_1736160962-17868-1--