Subject: bug#74907: 31.0.50; nsm-check-local-subnet-ipv4 test fails on macOS with VPN enabled

From: Robert Pluim <[email-masked]>
Date: Wed, 18 Dec 2024 17:03:21 +0100

>>>>> On Tue, 17 Dec 2024 16:16:55 -0800, Stefan Kangas <[email-masked]> said:

    Stefan> Robert Pluim <[email-masked]> writes:
    >>>>>>> On Tue, 17 Dec 2024 12:45:26 +0000, Stefan Kangas <[email-masked]> said:
    >> 
    Stefan> Thanks, that fixes the issue.  Tested with and without VPN on macOS.
    >> 
    >> Please let me know the name of the VPN client so that I can write a
    >> suitably scathing commit message (although itʼs possible this is
    >> macOSʼ fault).

    Stefan> The client is Mullvad VPN, but without looking into it further, I'm not
    Stefan> confident if it is them or Apple that should take the blame here.

The value of sa_family in the ifa_netmask field returned via
getifaddrs is not specified in the standard, so Iʼve had to put down
the hammer of correction, and humbly accept that our code has to
change. 😀

Robert
--