From unknown Fri Jun 20 07:10:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74903 <74903@debbugs.gnu.org> To: bug#74903 <74903@debbugs.gnu.org> Subject: Status: [PATCH] Add function to show table of keys when describing keymap variable Reply-To: bug#74903 <74903@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:10:04 +0000 retitle 74903 [PATCH] Add function to show table of keys when describing ke= ymap variable reassign 74903 emacs submitter 74903 Mekeor Melire severity 74903 normal tag 74903 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 18:14:58 2024 Received: (at submit) by debbugs.gnu.org; 15 Dec 2024 23:14:58 +0000 Received: from localhost ([127.0.0.1]:52589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMxp6-0000zz-W8 for submit@debbugs.gnu.org; Sun, 15 Dec 2024 18:14:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:55050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMxp5-0000zq-Ed for submit@debbugs.gnu.org; Sun, 15 Dec 2024 18:14:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMxp4-0007R8-57 for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 18:14:50 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMxoy-0004bB-R0 for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 18:14:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 37685240027 for ; Mon, 16 Dec 2024 00:14:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1734304477; bh=qJAq2OniCTWTAzXD13lc0nYhr0+UVdOfT24g7M7ugzE=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=D87jyFNGoFxDAmvduW1/j1GgZ72L/DmpvsoWhAdF2+a0492McjdShu2tIeRQ+wwVS xUF/nEhXLyjKeb1rnANlY00JYDfvu0edG3U6du9gROR73hM1H18lswLlEuAdCowGjx y607hXN8stIZeDPnShTm9aKr2pRQJtB1BR89Vbg8eugTPMIiKnO3UUjfDAlQmMYMcz PM1wSbYP/TiDCbUIYdRjplrIXQ82+cOvMbctxvCwguxfR5hq5V/vIcVJNyJBieXX9+ nslPKEwsJriQrqBUJa6UHRBaDbUl7tTmsrV5y3pRq3S5kqyWvp0uAbNtZHWRdcSFJs +H6vpANzuRRgA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YBJn85BcSz9rxB; Mon, 16 Dec 2024 00:14:36 +0100 (CET) From: Mekeor Melire To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add function to show table of keys when describing keymap variable Date: Sun, 15 Dec 2024 23:14:15 +0000 Message-ID: <87v7vktu7s.fsf@posteo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=mekeor@posteo.de; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch It'd be nice if users could opt in to have C-h v some-map RET show a nice table of key bindings for that keymap. I wrote a function that can be added to help-fns-describe-variable-functions so that this happens. What do you think? Alternatively, we can also add a key binding to help-mode so that users can easily "switch" from describe-variable to describe-keymap, e.g. per "K": C-h v message-mode-map RET K --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-function-to-show-table-of-keys-when-describing-k.patch >From df0fbd4d61a0d0bebcb050f4f22a5ae4c67d0f65 Mon Sep 17 00:00:00 2001 From: Mekeor Melire Date: Sun, 15 Dec 2024 23:21:00 +0100 Subject: [PATCH] Add function to show table of keys when describing keymap variable * lisp/help-fns.el (help-fns-keymap-key-bindings): New function possible member of 'help-fns-describe-variable-functions' that shows a table of key bindings. * etc/NEWS: Advertise it. --- etc/NEWS | 12 ++++++++++++ lisp/help-fns.el | 10 ++++++++++ 2 files changed, 22 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 48546a2d916..9ae50ddb923 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -220,6 +220,18 @@ on the header lines are now these two: the selected window uses ** In 'customize-face', the "Font family" attribute now supports completion. +** Help + ++++ +*** New function 'help-fns-keymap-key-bindings'. +This function inserts into the current buffer a table of key bindings if +the given argument is a variable with a keymap as value. If you want +'describe-variable' ('C-h v') to insert a table of key bindings into +regular "*Help*" buffers, add the following to your init file: + + (add-hook 'help-fns-describe-function-functions + #'help-fns-keymap-key-bindings) + * Editing Changes in Emacs 31.1 diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 157ec6b8d61..4ed4c64f3ea 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -563,6 +563,16 @@ find-lisp-object-file-name (src-file (locate-library file-name t nil 'readable))) (and src-file (file-readable-p src-file) src-file)))))) +(defun help-fns-keymap-key-bindings (variable) + "Insert table of key bindings of keymap VARIABLE into the current buffer. +You can add this function to the `help-fns-describe-function-functions' +hook to show examples of using FUNCTION in *Help* buffers produced by +\\[describe-function]." + (when-let* ((value (symbol-value variable)) + ((keymapp value))) + (with-current-buffer standard-output + (help--describe-map-tree value)))) + (defun help-fns--key-bindings (function) (when (commandp function) (let ((pt2 (with-current-buffer standard-output (point))) -- 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 10:57:31 2024 Received: (at 74903) by debbugs.gnu.org; 16 Dec 2024 15:57:31 +0000 Received: from localhost ([127.0.0.1]:55650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDTO-00015D-TB for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:57:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDTJ-00014Y-8c for 74903@debbugs.gnu.org; Mon, 16 Dec 2024 10:57:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNDTB-00057J-V8; Mon, 16 Dec 2024 10:57:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hYFTDi/6XwbrcSPjarck/YyCLyRmFoZO1wgZ/vDs5ZY=; b=H9lpluLlb7Q3 Pu4TN4sLP7q0RUKu5zE5KH2N0VxWsuLDm8Q3q0Ugv6tNm8b9htG4uzT1hCRfk+2xESvIEsEkRig+L HM+4Z+xjSzoqzWa/u3yFoGuYMLTTrQFfW0twG3iUfRPXz0u5BfQ5jx/8DuvO88uNzX8SJrVjZtjI8 inuMKj7jy75KT6LemnUM49qKg+YEkQPZhclggxSImtH/sdY4yIfQlDkBahjVH0EXBhqk8hhswIv+e tc7TJ88OUdLpRhq7oks5sRiquxAebYRrCojUHTq/KY0gMVqvGdsccSN5t2QQ+dAK/zKAqLs1KaiZR 4/4Ck9M2xHJvuT1aujRZyw==; Date: Mon, 16 Dec 2024 17:57:14 +0200 Message-Id: <86zfkvpqn9.fsf@gnu.org> From: Eli Zaretskii To: Mekeor Melire , Stefan Kangas , Andrea Corallo , Stefan Monnier In-Reply-To: <87v7vktu7s.fsf@posteo.de> (message from Mekeor Melire on Sun, 15 Dec 2024 23:14:15 +0000) Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable References: <87v7vktu7s.fsf@posteo.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mekeor Melire > Date: Sun, 15 Dec 2024 23:14:15 +0000 > > It'd be nice if users could opt in to have C-h v some-map RET show a > nice table of key bindings for that keymap. I wrote a function that can > be added to help-fns-describe-variable-functions so that this happens. > > What do you think? > > Alternatively, we can also add a key binding to help-mode so that users > can easily "switch" from describe-variable to describe-keymap, e.g. per > "K": > > C-h v message-mode-map RET K We have "C-h b" and "C-h m" which show the bindings, albeit not by keymap. Is that not enough for some reason? Adding yet another help command related to key bindings needs to be justified, since we already have at least two with overlapping functionalities. What do others think about this? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 12:30:10 2024 Received: (at 74903) by debbugs.gnu.org; 16 Dec 2024 17:30:11 +0000 Received: from localhost ([127.0.0.1]:55912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNEv3-0006Qf-K0 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 12:30:10 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:56346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNEuz-0006PM-Po for 74903@debbugs.gnu.org; Mon, 16 Dec 2024 12:30:07 -0500 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-385ef8b64b3so3991542f8f.0 for <74903@debbugs.gnu.org>; Mon, 16 Dec 2024 09:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734370140; x=1734974940; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=OvG9bArxPj7ZuWo76MkqE66a5WtlnHI5Gh8nIJq2F0c=; b=irgu4zej4Z7BY+zukAyn+fuqGoZgEXw9gemg2zrDQOEurS1joWrVO5Zz6P0I4fn4r9 78eSB3DHQMgx/9trpTVc7k8ouZ01g0rcORgkJi84ZpduvQUJWJjemJXvulA7+/WjQ8Fq ZFtXiwLOYBiRTIMTYsfWsnnQXxMvjC6ts67bDl1T/np9A/EYrxIXu5ElCmPsacNWbeMy /QJcn9/6vuosqqYsH+7lxOcAyhBE4QY31gftKVnuF3EYEAQtJxOXKX8EVug3P8UO8Tde LuRNjQsiC+ZKT8jN8+qLZqrv6xjSaGGSmL+wR8RTbjf/prqTJ5oMtZfhdmOe7qB+G3E0 A3ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734370140; x=1734974940; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OvG9bArxPj7ZuWo76MkqE66a5WtlnHI5Gh8nIJq2F0c=; b=n9OCZxfiuWQH2XJyKmMXT9FDk/fTX6J1jSM7+h5+nacHzNf+aheGldYnJDdgRRYJfW 1TexZt4eApuy4nr7z5Q6ZArc7EpSI2kJBth4lS4c+mKFeP0STkUwWz9Vp/1ZTObCfIAB E2HOl4X+N1LC4EvGDo54GZcEvHJiyM9BEk1AaBEZlzEuC4b0WIE2fbaNKWSJdFL7mg39 V810U+KslUC6GqR0pTLwQe1XnV9zIgQJWOdikfZM4fVMy+npprtyCpm8CZjR9cf24fP6 ueK6RhdDxXjMWzFaJKRYz1xJj3+YW/5CFFbdinc1axkcuxtbwnW91ZgWInJf7urrIWZI S/dg== X-Forwarded-Encrypted: i=1; AJvYcCXLlRddHzqnVcRT0Eq+TLhCNIwnfg3z7Q4tc2hQSsp/NA/r4bitZ5RP8p6Dpe3VnehBIph2Hw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy+nTb7wypOPrnkWlSE2+IUNQu7hYVwCQAW2Fu9xntveRD7BjpF DXD+pj/Ivdp3a5hVxgXC0NBHrkrIkKXKvmOCo9kfk3VnbM6RbImfrBE9TQ== X-Gm-Gg: ASbGnctO5rifb8vaB7jEs+6WmlVrT1hFsfwLFnEJpgEJDtVrAtfhLHvuQhllMr+NOi8 06p5XW36YYDZoJqTJHSIVyyFc+BpQgpl/usq4fAciT6WW/+syLQuAu+Vv6tpFPd9Jcs/rmo9D34 XmoEyhRwOzMN/5khB/qMIaIENhtq7snNcVpOL2AcAT8nb7aU7Nmngz+inwYpTQVnELBpZCr4Q9s g5SAFBxIq0Hqc0ltg7CTYbOgIZKUaVAA903VpDZvfA= X-Google-Smtp-Source: AGHT+IH0dg1ifGnBiZYeCLK0D078l6xE0wKwhRQ/YKO1OH4l5s6QRQibwXXL8j3OqAURP/bU0tP6xw== X-Received: by 2002:a05:6000:154e:b0:385:ddd2:6ab7 with SMTP id ffacd0b85a97d-3889ad35628mr9231066f8f.52.1734370139561; Mon, 16 Dec 2024 09:28:59 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:a104:d8c:5af4:8136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436362b64b0sm92515125e9.30.2024.12.16.09.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 09:28:58 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <86zfkvpqn9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Dec 2024 17:57:14 +0200") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> Date: Mon, 16 Dec 2024 18:28:58 +0100 Message-ID: <87bjxb5yg5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74903 Cc: Mekeor Melire , Andrea Corallo , Stefan Kangas , 74903@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 16 Dec 2024 17:57:14 +0200, Eli Zaretskii said: >> From: Mekeor Melire >> Date: Sun, 15 Dec 2024 23:14:15 +0000 >>=20 >> It'd be nice if users could opt in to have C-h v some-map RET show a >> nice table of key bindings for that keymap. I wrote a function that= can >> be added to help-fns-describe-variable-functions so that this happen= s. >>=20 >> What do you think? >>=20 >> Alternatively, we can also add a key binding to help-mode so that us= ers >> can easily "switch" from describe-variable to describe-keymap, e.g. = per >> "K": >>=20 >> C-h v message-mode-map RET K Eli> We have "C-h b" and "C-h m" which show the bindings, albeit not by Eli> keymap. Is that not enough for some reason? "C-h b" shows all the bindings split out by major and minor mode already. I guess we could add the name of the relevant keymap as well, but the people who need to know the name of the keymap generally know enough about Emacs to figure it out (eg via "C-h k"). Eli> Adding yet another help command related to key bindings needs to be Eli> justified, since we already have at least two with overlapping Eli> functionalities. Eli> What do others think about this? I really don=CA=BCt see the need for more functionality here. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 13:41:30 2024 Received: (at 74903) by debbugs.gnu.org; 16 Dec 2024 18:41:30 +0000 Received: from localhost ([127.0.0.1]:56151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNG25-00025X-NG for submit@debbugs.gnu.org; Mon, 16 Dec 2024 13:41:30 -0500 Received: from mout01.posteo.de ([185.67.36.65]:40121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNG22-00025B-R7 for 74903@debbugs.gnu.org; Mon, 16 Dec 2024 13:41:29 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F05C3240027 for <74903@debbugs.gnu.org>; Mon, 16 Dec 2024 19:41:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1734374480; bh=GHeyBQI0kuUpfZEm/a3St173NsmZD/CdzDSDYjPRdgg=; h=Date:From:To:CC:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=CeHoFntVc1/D1wRfHjUskxdsdaRuvr+Q2IIElKRbDHOonnHGJ6mdpDn+hoxg8/SeP 1Cec9ghVYJ9IprSLJPJe/nRkizYhw9cbMmAlQf5ljRKlS4knSojuy9ePBwtoDmcHNc MgX1C3dDU0eCVMODLOJN+rd+VDGT3xth75ig/uCJuGLCNpsl2lwWsHGJrq7vTQbHkK hluG/TDSvblwRw1S6r4IXhOn4m+mYYnb09AsPdxYGn2ZScEPuKDLJwinHbEKiSPFP7 usBuBDEuEbMZuI4tOVjZo1Hr21hrQTaKIMSNVYodC3kRy8FaRAjw0q7HOMNJoXSP/Z FX1poIsEX4IpQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YBpgM4Wy8z6tyZ; Mon, 16 Dec 2024 19:41:19 +0100 (CET) Date: Mon, 16 Dec 2024 18:41:19 +0000 From: Mekeor Melire To: Robert Pluim , Eli Zaretskii Subject: =?US-ASCII?Q?Re=3A_bug=2374903=3A_=5BPATCH=5D_Add_function_to_show_?= =?US-ASCII?Q?table_of_keys_when_describing_keymap_variable?= In-Reply-To: <87bjxb5yg5.fsf@gmail.com> References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> Message-ID: <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----PVC9TI8E67RGXQYJCSIRAJUQFZ4433 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 Cc: Andrea Corallo , Stefan Kangas , 74903@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ------PVC9TI8E67RGXQYJCSIRAJUQFZ4433 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On December 16, 2024 6:28:58 PM GMT+01:00, Robert Pluim wrote: >>>>>> On Mon, 16 Dec 2024 17:57:14 +0200, Eli Zaretskii = said: > > >> From: Mekeor Melire > >> Date: Sun, 15 Dec 2024 23:14:15 +0000 > >>=20 > >> It'd be nice if users could opt in to have C-h v some-map RET show= a > >> nice table of key bindings for that keymap=2E I wrote a function = that can > >> be added to help-fns-describe-variable-functions so that this happ= ens=2E > >>=20 > >> What do you think? > >>=20 > >> Alternatively, we can also add a key binding to help-mode so that = users > >> can easily "switch" from describe-variable to describe-keymap, e= =2Eg=2E per > >> "K": > >>=20 > >> C-h v message-mode-map RET K > > Eli> We have "C-h b" and "C-h m" which show the bindings, albeit not = by > Eli> keymap=2E Is that not enough for some reason? > >"C-h b" shows all the bindings split out by major and minor mode >already=2E I guess we could add the name of the relevant keymap as well, >but the people who need to know the name of the keymap generally know >enough about Emacs to figure it out (eg via "C-h k")=2E > > Eli> Adding yet another help command related to key bindings needs to= be > Eli> justified, since we already have at least two with overlapping > Eli> functionalities=2E > > Eli> What do others think about this? > >I really don=CA=BCt see the need for more functionality here=2E > >Robert >--=20 I get the impression that you talk about M-x describe-keymap RET which doe= s already exist=2E That is not what I proposed=2E What I proposed is two things: 1=2E Allow users to opt-in to have C-h v foo-keymap RET show a table of ke= y bindings in addition to the formatting as S-expression=2E This fits well = into the existing help-fns mechanism=2E The patch I submitted implements a = prototype=2E 2=2E In help-mode, bind a single-char-key like "K" to a command that will = allow users to easily switch from describing a variable as variable to desc= ribing it as keymap a la describe-keymap=2E I proposed (2=2E) as an alternative to (1=2E) but my main proposal is (1= =2E)=2E Both approaches have a similar objection though=2E ------PVC9TI8E67RGXQYJCSIRAJUQFZ4433 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On De= cember 16, 2024 6:28:58 PM GMT+01:00, Robert Pluim <rpluim@gmail=2Ecom&g= t; wrote:
On Mon, 16 Dec=
 2024 17:57:14 +0200, Eli Zaretskii <eliz@gnu=2Eorg> said:
<=
/blockquote>

From: Mekeor Meli= re <mekeor@posteo=2Ede>
Date: Sun, 15 Dec 2024 23:14:15 +0000
<= br>It'd be nice if users could opt in to have C-h v some-map RET show a
= nice table of key bindings for that keymap=2E I wrote a function that can<= br>be added to help-fns-describe-variable-functions so that this happens=2E=

What do you think?

Alternatively, we can also add a key bind= ing to help-mode so that users
can easily "switch" from describe-variabl= e to describe-keymap, e=2Eg=2E per
"K":

C-h v message-mode-map RE= T K

Eli> We= have "C-h b" and "C-h m" which show the bindings, albeit not by
Eli= > keymap=2E Is that not enough for some reason?

"C-h b" shows al= l the bindings split out by major and minor mode
already=2E I guess we c= ould add the name of the relevant keymap as well,
but the people who nee= d to know the name of the keymap generally know
enough about Emacs to fi= gure it out (eg via "C-h k")=2E

Eli> Adding yet another help = command related to key bindings needs to be
Eli> justified, since= we already have at least two with overlapping
Eli> functionaliti= es=2E

Eli> What do others think about this?

I really d= on=CA=BCt see the need for more functionality here=2E

Robert

I get the im= pression that you talk about M-x describe-keymap RET which does already exi= st=2E

That is not what I proposed=2E What I proposed is two things:<= br>
1=2E Allow users to opt-in to have C-h v foo-keymap RET show a table= of key bindings in addition to the formatting as S-expression=2E This fits= well into the existing help-fns mechanism=2E The patch I submitted impleme= nts a prototype=2E

2=2E In help-mode, bind a single-char-key like "K= " to a command that will allow users to easily switch from describing a var= iable as variable to describing it as keymap a la describe-keymap=2E
I proposed (2=2E) as an alternative to (1=2E) but my main proposal is (1= =2E)=2E Both approaches have a similar objection though=2E

------PVC9TI8E67RGXQYJCSIRAJUQFZ4433-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 21:56:22 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 02:56:22 +0000 Received: from localhost ([127.0.0.1]:56973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNl0-0002ie-36 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 21:56:22 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNks-0002i8-SZ for 74903@debbugs.gnu.org; Mon, 16 Dec 2024 21:56:20 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 700D980848; Mon, 16 Dec 2024 21:56:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734404168; bh=wKGkucI10tFtnP6LUwvU2MXYmbwDp5K+DS2Ow2u1SHM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A2i1rFIX9atMxiaMbCdx6JQh0BrC0R7d5U/sbr8uxtqaEE3nQ08s90w/SdM/m8NcI 7g0/s5dgF2ajtAcHRL8GyajLlWKlPDwX99o4L8d99LoVVYBLnh0T5LPYeENhdoAfOP tuRDAhIEYI2cScz2WNV2MoXaqjYH32z+Xu+gqSKO/wcN0sk/7pOIPhAYeCXkXCPCFe 6ALzw17Wlo+/6VVrMN+UslMRLd/2QPG51nGOH4sBMXKfvW37BR9iEjOHFRhLl24RP8 zWKUn+zHAsldQ6kZpDOxigQf7aogNZUgpyCuz1hxKMoxqMgklIAac+3RbCc7Ud7nfG k9tBM1gQQlgxQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 90AAC806F8; Mon, 16 Dec 2024 21:56:08 -0500 (EST) Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4967612022E; Mon, 16 Dec 2024 21:56:08 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <86zfkvpqn9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Dec 2024 17:57:14 +0200") Message-ID: References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> Date: Mon, 16 Dec 2024 21:56:07 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 Cc: Mekeor Melire , Andrea Corallo , Stefan Kangas , 74903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> It'd be nice if users could opt in to have C-h v some-map RET show a >> nice table of key bindings for that keymap. I wrote a function that can >> be added to help-fns-describe-variable-functions so that this happens. >> >> What do you think? >> >> Alternatively, we can also add a key binding to help-mode so that users >> can easily "switch" from describe-variable to describe-keymap, e.g. per >> "K": >> >> C-h v message-mode-map RET K > > We have "C-h b" and "C-h m" which show the bindings, albeit not by > keymap. Is that not enough for some reason? It's quite different, since his proposal is about displaying keymap values held in variables (i.e. not necessarily currently active). > Adding yet another help command related to key bindings needs to be > justified, since we already have at least two with overlapping > functionalities. AFAICT his proposal does not add any new command (help or other). What am I missing? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 22:03:32 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 03:03:32 +0000 Received: from localhost ([127.0.0.1]:56985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNrw-00033s-1H for submit@debbugs.gnu.org; Mon, 16 Dec 2024 22:03:32 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNru-00033U-Hj for 74903@debbugs.gnu.org; Mon, 16 Dec 2024 22:03:31 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 04DD7443499; Mon, 16 Dec 2024 22:03:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734404603; bh=4GT/Hm+h4hqqGOxVErb8b4E+9h/m154eHXS0u8UFvaU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ArsFJdDbDJPo4goqsTKpkCE1ehsKiLGj1+T8NJ5FEGUxAcYm3NWCeIJhQJkYOQ0Rx Evcn6ZqIfF1rwsS4joiKgxGVgJDP14JkIKLKiv41fr3EMVrWuzBtij8GJOAZd42Cmy KK2GcvhOdns0JhUWATIf7vh77PYydik31wkhIQ0tx/IGoxUE+CrYK4bXzcewioGfI2 42wjexjFzNsJlP/+3X9O7b54HSYsdJdcNkfug0mekkKBzBNEePIi+FrrNtb/ZJ40/k Pj1kpdrABBSd7sOfDrS2fMhXEVmf+pxsGK9HSZBRMTrnqN162G1iPMzTDtwOTHCn9q fGkWtU/G0UWpg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E2FA0443494; Mon, 16 Dec 2024 22:03:23 -0500 (EST) Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A1861120384; Mon, 16 Dec 2024 22:03:23 -0500 (EST) From: Stefan Monnier To: Mekeor Melire Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> (Mekeor Melire's message of "Mon, 16 Dec 2024 18:41:19 +0000") Message-ID: References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> Date: Mon, 16 Dec 2024 22:03:22 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 Cc: Robert Pluim , Andrea Corallo , Eli Zaretskii , 74903@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > 1. Allow users to opt-in to have C-h v foo-keymap RET show a table of key > bindings in addition to the formatting as S-expression. This fits well into > the existing help-fns mechanism. The patch I submitted implements > a prototype. > > 2. In help-mode, bind a single-char-key like "K" to a command that will > allow users to easily switch from describing a variable as variable to > describing it as keymap a la describe-keymap. The table is a bit redundant with the s-exp representation and I'm not sure we want to spend all this time&space printing out a large keymap, but maybe we could use the `help-fns-describe-variable-functions` mechanism to add a one-liner that can be clicked to get to the keymap-specific description, a bit like Custom vars have a "You can customize this variable" link. WDYT? [ There is also something to be said to spice up `describe-keymap` so it can be used to *modify* a keymap. But that comes with many more difficulties (the main one being how to save those modifications so they survive a restart). ] Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 02:51:14 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 07:51:14 +0000 Received: from localhost ([127.0.0.1]:57362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNSML-0008WC-J0 for submit@debbugs.gnu.org; Tue, 17 Dec 2024 02:51:13 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:47587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNSMF-0008Vq-2E for 74903@debbugs.gnu.org; Tue, 17 Dec 2024 02:51:11 -0500 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so4599615e9.3 for <74903@debbugs.gnu.org>; Mon, 16 Dec 2024 23:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734421801; x=1735026601; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cFDEv4tk3Q0Pnqv43ZMtjOjTtEysNVndKXPMejz9Jd0=; b=K2OI08z7bxSWzVHQVYqbzZbgNsb6YidngJ2Lk5/4x6+5sJBG5eanE/HzuCiwUs7ilE 7SGC+LddoUdbIdCKY0IRpAjPcLHnXcUvcz6B4A2Zxied1bStuOYhLPvHbpBgZTJrL7pM mNemszXRJHt7laEngQO3o+Upp6nq5CSLrr20gfBgVouUnHr/IdR1YGzzb+kUBrn48X62 XHIZZabLxtTS9eeI1UtqcgiuZ3SZLYLUXeQZYnAHmOS62v+jJKVSAVo6i4IgQhPFk/Z1 qcLztoo+QeVAlpYLKsjkKjy36IACX468nqZ/BIJ1FF443By31QTR35lp61p9FHjW1l+6 xpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734421801; x=1735026601; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cFDEv4tk3Q0Pnqv43ZMtjOjTtEysNVndKXPMejz9Jd0=; b=xRNBQniVTXN3ZLh4MA+xqe0TlD06gIHlb1KbX9mPaWwVkBRLkkJ3shuHN+mvAa/7sS mjjoTfU2fKJ2vgJSUabQxzKAn4sdgc+wsoebEzcYzhHOEaYf//+dQv/0lL6fLXRnfRdT NaarHpfVneWLU1tNK1ULWb4PUAfD4WB8JVy9WaCqWBj5GBoFIMSdQ9Ghi6kRWvgLO2m0 95D/K0wdRF8qEuqext9Vrt6ZRiJ8QN/z0o9TQNjWlglAfqy5DVi5DY/szjbwrzzISIgg XS55rl6PjngRSKNr+BHgQRFpvThqi2kRAxi5jiD48og1c9WkzlXibkwwg8THI0U4Cr1X kpcw== X-Forwarded-Encrypted: i=1; AJvYcCXWrWDxq6P6hu0o/yDF73aomNFPkcRmQsnQ865bd7BtxXeO8Oc8wPb1HlQGUXOd0SWXvCbuPw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwVBmSkWH6KrQSWno/jDERhsSvaeyU07rCJeagrPo7cET3Xb2Hc gBTpndHQ9wOFcavRTDF4YyotBCLHSdMjq8YXvYGJrbUjKy8It0Xl X-Gm-Gg: ASbGncupcSZXJ5Td3L4o4OgtGqg79o+pV/vAlb2GcYEfN7uz1bcPI7OxJzMab71V9n1 nzBGnHKkVYHL4I3VIdmrQcv97Tg8kI1Vu5zWu2fI5uq1YR9uzz7iairf4SWhLowhnzO+dg2arZo tQ3m1/GOEdUK2gkI5UxCYmCHUgJmesDAJf6H9Bsv/lN06ifn7kmHwu9U2CdOuztWLTRuvuy4On8 PDJ76DDqhoWUPmbGodG+gjLDuYJBwZLPCy4TuX0aa4= X-Google-Smtp-Source: AGHT+IE6oBsZYHQkVxcsCdaWKnfPV6AbdUoepU7vPa3EZhGO3bf4HVD12O0fjc+aGhedc4HMUf4wzw== X-Received: by 2002:a05:600c:154c:b0:434:ff30:a159 with SMTP id 5b1f17b1804b1-4362a982c34mr148420555e9.0.1734421800960; Mon, 16 Dec 2024 23:50:00 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:a104:d8c:5af4:8136]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c80162a6sm10192020f8f.33.2024.12.16.23.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 23:50:00 -0800 (PST) From: Robert Pluim To: Mekeor Melire Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> (Mekeor Melire's message of "Mon, 16 Dec 2024 18:41:19 +0000") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> Date: Tue, 17 Dec 2024 08:49:59 +0100 Message-ID: <87ttb24ul4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74903 Cc: Eli Zaretskii , Andrea Corallo , Stefan Kangas , 74903@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 16 Dec 2024 18:41:19 +0000, Mekeor Melire = said: Mekeor> I get the impression that you talk about M-x describe-keymap RE= T which does already exist. No, I=CA=BCm talking about `describe-bindings'. Mekeor> That is not what I proposed. What I proposed is two things: Mekeor> 1. Allow users to opt-in to have C-h v foo-keymap RET show a ta= ble of Mekeor> key bindings in addition to the formatting as S-expression. Thi= s fits Mekeor> well into the existing help-fns mechanism. The patch I submitted Mekeor> implements a prototype. Again, I don=CA=BCt see a need for it. A user trying to figure out keybindings is not going to be inspecting keymap variables, and `describe-bindings' or `describe-mode' tells them what they need to know. A developer writing code presumably knows about keymaps, and doesn=CA=BCt need a different visual representation of them to get stuff done. Mekeor> 2. In help-mode, bind a single-char-key like "K" to a Mekeor> command that will allow users to easily switch from Mekeor> describing a variable as variable to describing it as Mekeor> keymap a la describe-keymap. See my previous paragraph. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 03:08:14 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 08:08:14 +0000 Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNSco-0000sJ-Fb for submit@debbugs.gnu.org; Tue, 17 Dec 2024 03:08:14 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNScm-0000s3-Et for 74903@debbugs.gnu.org; Tue, 17 Dec 2024 03:08:13 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 7D741E0004; Tue, 17 Dec 2024 08:08:03 +0000 (UTC) From: Juri Linkov To: Robert Pluim Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <87ttb24ul4.fsf@gmail.com> (Robert Pluim's message of "Tue, 17 Dec 2024 08:49:59 +0100") Organization: LINKOV.NET References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> <87ttb24ul4.fsf@gmail.com> Date: Tue, 17 Dec 2024 09:59:57 +0200 Message-ID: <877c7yg2e2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org, Mekeor Melire , Stefan Kangas , Eli Zaretskii , Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Mekeor> 1. Allow users to opt-in to have C-h v foo-keymap RET show a table of > Mekeor> key bindings in addition to the formatting as S-expression. This fits > Mekeor> well into the existing help-fns mechanism. The patch I submitted > Mekeor> implements a prototype. > > Again, I donʼt see a need for it. A user trying to figure out > keybindings is not going to be inspecting keymap variables, and > `describe-bindings' or `describe-mode' tells them what they need to > know. A developer writing code presumably knows about keymaps, and > doesnʼt need a different visual representation of them to get stuff > done. It would be nice if users will be able first to see keymap tables in the output of `describe-repeat-maps', then click on a map variable, and see the same keymap table individually. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 03:33:44 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 08:33:44 +0000 Received: from localhost ([127.0.0.1]:57460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNT1U-000276-3Z for submit@debbugs.gnu.org; Tue, 17 Dec 2024 03:33:44 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:49238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNT1J-00026d-W2 for 74903@debbugs.gnu.org; Tue, 17 Dec 2024 03:33:41 -0500 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43623f0c574so34684605e9.2 for <74903@debbugs.gnu.org>; Tue, 17 Dec 2024 00:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734424348; x=1735029148; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eVoetdLwYsfr15B3EliqFwWsYa8pLK5c5FzyuJCAOo4=; b=k3P+QJjAWXJHRsBwtSaRWQ0NSOPeCwXwoWGUBSOhVHHaZ0a1osUOI38dYDH/UWVOqi bJ/bF1AHvOnHSE5u5WYmBj0nShJhPswTRGVAIhHxXcfbfrujmq7vELOMsXclcM+oaxDn AVZP3PoQcKlrcY1W3vMAwtb5hKx66gSuRETFlmnA83SIcaDCz+Uv5rqI3kWCthaIxW66 vF/DGPQIlVxurRn2qQB5/xA4TW2D4clz+p22Dc8ngC0dLf5K1+dajK0rrbZSInxKvrby TjmKEfxy72MbCJl9HdysmODYYI4M5FQmOiPOk7QK15WWFrCfd0QXvJwbkggQ1SegGT/u Yj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734424348; x=1735029148; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eVoetdLwYsfr15B3EliqFwWsYa8pLK5c5FzyuJCAOo4=; b=V3BotQW8IcDBfYVglqBRG4p+cL1yoGD9/iiTtijR721McQ9JnGeti6BNu4rqWGlMrf Je4nIuONwpSEYzJZkdQxEdQGCBLi6QefUJuwUhEABfqHn0znlub0KXYfojp2YrNzKKtj 9wZGpPQxYfz/18ZaZNP4E3PKLfEQx32U/tL0yIES77FhLLRTkBfWyOVoyculIOmQaAft kWCbycE40V55vwWs0PyxQYsXe8VbGncZ08f+I3aVCRrgNJOGdh9ABSCi5VWcBGR8l8Ba mva0MTYGxr85qmmUJIOYdU6/d8HXT9mDD7ZBjulKiVoQsy4lGS1moFIj4xhCOMCaUi9O pyeQ== X-Forwarded-Encrypted: i=1; AJvYcCVh3ZeUqZmVP5ZlHD4TF8yABrEyMm74j0lVd1grFR17Csmk81R+ZRFghhgpJEtxEpIUgUOgPg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YycRQbiIu0M+e9kSaoVgmXpExrrZvPor3H1aLqlpLOGbd+2h/By eEHiagxQWD8mfQO6JSEc6SbylVwxxBLo8W7dMTW4cNxc20/UIp+r X-Gm-Gg: ASbGncs9trUxy2+b1DYo5BFg6LItGVUGKHAI5/+cqbszkbrtJMB276UtrXrnA1fG55a pfdOQcY2bpwJAR1vA5ha/pZDzd4+BtvlWI5OKVaGGNYE4FbSfRtrQQc5ch8l+lsm4Rex0RWOWre lHUKqRZXFNWDzHqyvCNtBXNYXg2lArehoQ476hi4dTYs+Z7w8hs5Tj/ecWy11GALi/EzI+bJ4K+ TZag3eFTSpJp3BGlFlTLD4DsQy47sRIZiHaasGkMiw= X-Google-Smtp-Source: AGHT+IFSazAAoLz6It6hfWaaExv23O8Zu0cMcfP9cw32VKchHsewfhHPAS3c1LTb8Y0Eiea6xi8fGw== X-Received: by 2002:a05:600c:214a:b0:434:f7e3:bfbd with SMTP id 5b1f17b1804b1-4362aa947admr139706355e9.23.1734424347803; Tue, 17 Dec 2024 00:32:27 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:a104:d8c:5af4:8136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43625717c9fsm164986925e9.44.2024.12.17.00.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 00:32:27 -0800 (PST) From: Robert Pluim To: Juri Linkov Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <877c7yg2e2.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 17 Dec 2024 09:59:57 +0200") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> <87ttb24ul4.fsf@gmail.com> <877c7yg2e2.fsf@mail.linkov.net> Date: Tue, 17 Dec 2024 09:32:25 +0100 Message-ID: <87pllq4sme.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org, Mekeor Melire , Stefan Kangas , Eli Zaretskii , Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 17 Dec 2024 09:59:57 +0200, Juri Linkov sai= d: Mekeor> 1. Allow users to opt-in to have C-h v foo-keymap RET show a ta= ble of Mekeor> key bindings in addition to the formatting as S-expression. Thi= s fits Mekeor> well into the existing help-fns mechanism. The patch I submitted Mekeor> implements a prototype. >>=20 >> Again, I don=CA=BCt see a need for it. A user trying to figure out >> keybindings is not going to be inspecting keymap variables, and >> `describe-bindings' or `describe-mode' tells them what they need to >> know. A developer writing code presumably knows about keymaps, and >> doesn=CA=BCt need a different visual representation of them to get s= tuff >> done. Juri> It would be nice if users will be able first to see keymap tables Juri> in the output of `describe-repeat-maps', then click on a map Juri> variable, and see the same keymap table individually. ? I must be misunderstanding, because that=CA=BCs already how `describe-repeat-maps' works. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 14:06:53 2024 Received: (at 74903) by debbugs.gnu.org; 17 Dec 2024 19:06:53 +0000 Received: from localhost ([127.0.0.1]:60304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNcu8-0008Tz-Ll for submit@debbugs.gnu.org; Tue, 17 Dec 2024 14:06:53 -0500 Received: from mslow1.mail.gandi.net ([217.70.178.240]:35217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNctv-0008TJ-Jm for 74903@debbugs.gnu.org; Tue, 17 Dec 2024 14:06:46 -0500 Received: from relay1-d.mail.gandi.net (unknown [217.70.183.193]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 31BD1C13AF for <74903@debbugs.gnu.org>; Tue, 17 Dec 2024 19:01:19 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 97F18240002; Tue, 17 Dec 2024 19:00:54 +0000 (UTC) From: Juri Linkov To: Robert Pluim Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <87pllq4sme.fsf@gmail.com> (Robert Pluim's message of "Tue, 17 Dec 2024 09:32:25 +0100") Organization: LINKOV.NET References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> <87ttb24ul4.fsf@gmail.com> <877c7yg2e2.fsf@mail.linkov.net> <87pllq4sme.fsf@gmail.com> Date: Tue, 17 Dec 2024 21:00:11 +0200 Message-ID: <87wmfydtj8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org, Mekeor Melire , Stefan Kangas , Eli Zaretskii , Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> It would be nice if users will be able first to see keymap tables >> in the output of `describe-repeat-maps', then click on a map >> variable, and see the same keymap table individually. > > ? I must be misunderstanding, because thatʼs already how > `describe-repeat-maps' works. I meant that after clicking on the map variable in the heading it could show the same keymap. BTW, I just finally fixed `describe-repeat-maps' to use the very useful function 'cl--map-keymap-recursively' instead of 'map-keymap'. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 19:22:08 2024 Received: (at 74903) by debbugs.gnu.org; 18 Dec 2024 00:22:08 +0000 Received: from localhost ([127.0.0.1]:60807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNhpH-0006tY-T1 for submit@debbugs.gnu.org; Tue, 17 Dec 2024 19:22:08 -0500 Received: from mout02.posteo.de ([185.67.36.66]:57623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNhpG-0006t2-3y for 74903@debbugs.gnu.org; Tue, 17 Dec 2024 19:22:06 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EFD6F240101 for <74903@debbugs.gnu.org>; Wed, 18 Dec 2024 01:21:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1734481312; bh=QiFbStKYehNZekNWTCMzZwUp7PT/5yorqB6YEMQri/8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=g9hb2e5S8gIchwXWi+a0EMxzzKVWqb5ENP74gS8ndFRya28m4y9Zvc6Gme01450f6 L13ZpafZvTeBH0BRaDl6ECQstfgBp598wHFqwtWBVTtLacfbxe3dp7ETb3se//perP CYaFXCeimka8UyvUn7f3qmmHl0BY/9231EiBRWbjsDpr/jsfp0cE9biphtO8uKNRfs agvB/RcnVPbtlNtIzRH7Qed155iH4yxnoJE0WGBM+aCYpuDNS8n/0Rd9QOqW+jlHwW D37wGxTSTx8clUFmbQ0T3tVM7NOCazTCLi9gpAJC2RnPxCsxa6VcNw5S4bIfSSZmPe iUYFANio9QGVg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YCZ9q3mwVz6tm4; Wed, 18 Dec 2024 01:21:51 +0100 (CET) From: Mekeor Melire To: Stefan Monnier Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: (Stefan Monnier's message of "Mon, 16 Dec 2024 21:56:07 -0500") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> Date: Wed, 18 Dec 2024 00:21:37 +0000 Message-ID: <877c7x3koe.fsf@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 Cc: Mekeor Melire , Eli Zaretskii , Andrea Corallo , Stefan Kangas , 74903@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Monnier> AFAICT his proposal does not add any new command (help or Monnier> other). What am I missing? I think the confusion originates in a misunderstanding between my initial mail and Eli's initial response where Eli said: Eli> We have "C-h b" and "C-h m" which show the bindings, albeit not Eli> by keymap. Most further responses seem to assume that I want to reimplement `describe-bindings' (C-h b). From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 07:05:40 2024 Received: (at 74903) by debbugs.gnu.org; 18 Dec 2024 12:05:41 +0000 Received: from localhost ([127.0.0.1]:33781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNso8-0007o1-BA for submit@debbugs.gnu.org; Wed, 18 Dec 2024 07:05:40 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:48504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNso6-0007nm-5Y for 74903@debbugs.gnu.org; Wed, 18 Dec 2024 07:05:38 -0500 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38789e5b6a7so3358755f8f.1 for <74903@debbugs.gnu.org>; Wed, 18 Dec 2024 04:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734523470; x=1735128270; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=33W8ROGzfVsqw1knJgv15K4jNTF1nDyktIw6hHaJQT4=; b=E/To0k3eYX1Qz3hOO4Y5Pq+qreqj9iffeI7WsYr316jtK0NG7237b+R6ZM257qXoWK 5H2b79E76iXpdhPDX8Q7ekppWpytiPhu0Oe8xfARduQtmmlSu2r+AVY+ueDeAcTSU6WY H4MaDqomlvk74nnvkSvvM/MRL6MFk41SWHf6p6mp7U/HkXoofYZuR+ZX6ANmS4mxvBg4 cXEeOHZuTxZWGnoMjKwv5ECyWxHr8wxcH4Iwv22LQudke82AFefbp0Il2+2xTIKgEaOg /5INZyB9MdNIDyeAFBt5ADe7iieqj23fbnoUoyQAgGJqSCdfJEEx6AxQXEzLHrvuRvQE Xddw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734523470; x=1735128270; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=33W8ROGzfVsqw1knJgv15K4jNTF1nDyktIw6hHaJQT4=; b=mflMR7GySbF5N2X2IHNp8tnJpnPFvNzU7EWTXqkduZvnBtK8JtdD1qrMdindVUuD4E OnKV3A+53XS2CFsGdkWlefwmTRJHEtvic0VBSllLM5PGj2q0vC7vrAD1FhEqJ6DYEQeh P8YtjyZtbqtw5/O+rXb8ErgQZGEgKo0b++Vsx5rAQsZFlpPvXQHxaFFTpK8KoEAwF7Xe lamI8mU8ITXrarBPc4VWUzvICITbAYjGmO1AjU0oQ6yYg07fI97IC4iSNLQ5H5BCnLms PfEXab6JnNQ/3c1BlrUquy2AW3N/U/2dfnv1TS422J+Uk7WSaFQdj/ECwRaGP9ryuLp4 jmHA== X-Forwarded-Encrypted: i=1; AJvYcCUteADc8DZf9oUX86FWfkRCO5+3QJIYfpeLQMvNHTyhIsOXVUktNe9zL6Y+PVtR1k8w6YEFxA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxjwZUB2XNW4DfuKAKxAPAYS4se+xLVIoFVOudH8ONpDdIS6X6a FeVzWT/ywm/hKJ408W4+9AoKPRFWKiNPckUhjjAJOpVNdHy/Ojpd X-Gm-Gg: ASbGncsZ13HzIvJi6/QmEfCdTaZnz188uZuCczHt8aADXZRrM8NiuFLiHku+RBO9kOh RHtbuGIKxUe2wBC49sGZCN6hY2w7aOcNXe/f03Gt1yo2Fnwvaxf7tRMSd/41vh//QrN7Qu/i3Mu Vm4KZE+zc5TnF4LxsmZ4sHfpu6rbfrRGHUyCr9uSpUHGpZKz1NbYGOLuD/GPY9cDhAVupFxarrh W5ndUc/H2M+zr/sC+miQUK2T+zCspwnHiN1Tx6+mR1G X-Google-Smtp-Source: AGHT+IFRcnqiX0xT3dgzmboGTw6+WJP/BT/wltaNPaLfqL+Fs82/Vg26fKz9dwVLTEyE4/HqUQCpYA== X-Received: by 2002:a05:6000:4021:b0:386:3272:ee68 with SMTP id ffacd0b85a97d-388e4d8ad85mr2451522f8f.28.1734523469758; Wed, 18 Dec 2024 04:04:29 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:6fcd:4268:1f56:d148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656a18a33sm19206385e9.0.2024.12.18.04.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 04:04:29 -0800 (PST) From: Robert Pluim To: Juri Linkov Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <87wmfydtj8.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 17 Dec 2024 21:00:11 +0200") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> <87ttb24ul4.fsf@gmail.com> <877c7yg2e2.fsf@mail.linkov.net> <87pllq4sme.fsf@gmail.com> <87wmfydtj8.fsf@mail.linkov.net> Date: Wed, 18 Dec 2024 13:04:28 +0100 Message-ID: <87frml2o4z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org, Mekeor Melire , Stefan Kangas , Eli Zaretskii , Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 17 Dec 2024 21:00:11 +0200, Juri Linkov sai= d: >>> It would be nice if users will be able first to see keymap tables >>> in the output of `describe-repeat-maps', then click on a map >>> variable, and see the same keymap table individually. >>=20 >> ? I must be misunderstanding, because that=CA=BCs already how >> `describe-repeat-maps' works. Juri> I meant that after clicking on the map variable in the heading Juri> it could show the same keymap. That=CA=BCs just narrowing the buffer, no? =F0=9F=98=89 Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 12:29:52 2024 Received: (at 74903) by debbugs.gnu.org; 18 Dec 2024 17:29:52 +0000 Received: from localhost ([127.0.0.1]:35827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNxrr-0007PC-Sh for submit@debbugs.gnu.org; Wed, 18 Dec 2024 12:29:52 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:55813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNxrq-0007Ot-3z for 74903@debbugs.gnu.org; Wed, 18 Dec 2024 12:29:50 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id A034FC0005; Wed, 18 Dec 2024 17:29:21 +0000 (UTC) From: Juri Linkov To: Robert Pluim Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <87frml2o4z.fsf@gmail.com> (Robert Pluim's message of "Wed, 18 Dec 2024 13:04:28 +0100") Organization: LINKOV.NET References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> <87ttb24ul4.fsf@gmail.com> <877c7yg2e2.fsf@mail.linkov.net> <87pllq4sme.fsf@gmail.com> <87wmfydtj8.fsf@mail.linkov.net> <87frml2o4z.fsf@gmail.com> Date: Wed, 18 Dec 2024 19:28:55 +0200 Message-ID: <87ttb0oq7c.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74903 Cc: 74903@debbugs.gnu.org, Mekeor Melire , Stefan Kangas , Eli Zaretskii , Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > >>> It would be nice if users will be able first to see keymap tables > >>> in the output of `describe-repeat-maps', then click on a map > >>> variable, and see the same keymap table individually. > >> > >> ? I must be misunderstanding, because thatʼs already how > >> `describe-repeat-maps' works. > > Juri> I meant that after clicking on the map variable in the heading > Juri> it could show the same keymap. > > Thatʼs just narrowing the buffer, no? 😉 Except that it also shows a docstring and a link to source code. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 17:55:57 2024 Received: (at 74903) by debbugs.gnu.org; 24 Dec 2024 22:55:57 +0000 Received: from localhost ([127.0.0.1]:35290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQDoj-0004BP-0e for submit@debbugs.gnu.org; Tue, 24 Dec 2024 17:55:57 -0500 Received: from mout02.posteo.de ([185.67.36.66]:53343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQDoe-0004B4-B4 for 74903@debbugs.gnu.org; Tue, 24 Dec 2024 17:55:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 73A05240101 for <74903@debbugs.gnu.org>; Tue, 24 Dec 2024 23:55:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1735080945; bh=VuRy4Ys+sICgt/Xw2pQtzszE/ViqdAlLAH8UI+zwPjg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=OhhUka7DUF1kl3IKXcIwy+bBnQgeU6yEmGgKKhPOchT1OR6C1VZRT6WFYpHVAL+in YvJ4Hs3VPuPaUScGTxKfvVU9ypxGQ1E8ma98A/7nnzZ+ngH2be+BHBYJPvm75PREv+ pkOOVISWbGOtqkO9W8Pos/MdvEnEkg5m5rJZA0xZDaPRgharqGR3CqCVoNafxqjOyr hIkpX1HNqSU+5UaEB+s/hlZ1il8T3OnI8ZLFXtOpP2FDnrdUQjZdpfH2rwEHOsnGcZ PCbGyg+GAsT5ycLiz/8AyAabvaeLeT9/P6M9KCN/xLI0ptyvtXSmgGyVt0z1VY82uO E46SS+OHcPfSg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHqxD4P72z9rxK for <74903@debbugs.gnu.org>; Tue, 24 Dec 2024 23:55:44 +0100 (CET) From: Mekeor Melire To: 74903@debbugs.gnu.org Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: (Stefan Monnier's message of "Mon, 16 Dec 2024 22:03:22 -0500") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> X-Debbugs-Cc: Mekeor Melire , Robert Pluim , Eli Zaretskii , Stefan Kangas , Andrea Corallo , Stefan Monnier Date: Tue, 24 Dec 2024 22:55:39 +0000 Message-ID: <87h66s1yj8.fsf@host.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I had accidentally sent following email only to Stefan Monnier rather than the whole list. I'm thus sending it again. On Mon, 16 Dec 2024 22:03:22 -0500, Stefan Monnier said: > The table is a bit redundant with the s-exp representation and > I'm not sure we want to spend all this time&space printing out a > large keymap, but maybe we could use the > `help-fns-describe-variable-functions` mechanism to add a > one-liner that can be clicked to get to the keymap-specific > description, a bit like Custom vars have a "You can customize > this variable" link. WDYT? I agree that there's redundancy. But since adding the function `help-fns-keymap-key-bindings' from my patch to `help-fns-describe-variable-functions` would be opt-in, it'd be up to the user to decide between redundancy and convenience. Nevertheless, I like your idea of a clickable button, e.g. worded "View this keymap as a table" in the *Help* buffer. Let me continue your comparison to the "You can customize this variable" button by noting that its command, `help-customize', is also bound to "c" in Help-Mode. I'd also like a key binding for "View this keymap as a table", e.g. "k". So, these key sequences would result in the same state: C-h v foo-map RET k M-x describe-keymap foo-map RET But we can build up this idea further: What if these would also result in the same state? (`ido-mode' is both a variable and a function.) C-h f ido-mode RET o C-h v ido-mode RET o C-h o ido-mode RET And also: C-h v ido-mode RET f C-h f ido-mode RET What do you think about enabling users to easily "effectively switch" between describe-* commands in this way? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 18:14:44 2024 Received: (at 74903) by debbugs.gnu.org; 24 Dec 2024 23:14:44 +0000 Received: from localhost ([127.0.0.1]:35329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQE6u-00052Y-53 for submit@debbugs.gnu.org; Tue, 24 Dec 2024 18:14:44 -0500 Received: from mout02.posteo.de ([185.67.36.66]:36381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQE6q-00052I-Vq for 74903@debbugs.gnu.org; Tue, 24 Dec 2024 18:14:43 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4D910240101 for <74903@debbugs.gnu.org>; Wed, 25 Dec 2024 00:14:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1735082074; bh=B2QrOnYA+Fj6pmKye5nDlBGqPUq1fKlEnXJWoIHxO8Y=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=gL0tVrVKYoGAFOjJXUrNvI3e5VDfqw8EodvkAzamTkhn55Byouk80Rq3TZDry5alw KDctgX2z/nVrZiihj8ofVp5QoeM4wzCksRQ9To7fwvh3cbtQepcqx16d48z+GQDu9Z +Lluhl65UawtfYycqn6u6ZB/vz2cYhT7EQgZlXPGyuf6+5HtEVb6aquNk9AgDXRa+D DNJXeF2fkDYMJHHoX9mVC1kx3Zj34gxU/KMZqPOZU4vggF241T61SetCHICwMrBsJb G1HorKep1kqLNXWn2/crPvlxYJAiGKV1lPTt7ig1/AUnK5KTH6pIlX2z9PGxgyz2jC FPKunZsvGNs8A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHrLw3yXFz9rxF for <74903@debbugs.gnu.org>; Wed, 25 Dec 2024 00:14:31 +0100 (CET) From: Mekeor Melire To: 74903@debbugs.gnu.org Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: (Stefan Monnier's message of "Mon, 16 Dec 2024 22:03:22 -0500") References: <87v7vktu7s.fsf@posteo.de> <86zfkvpqn9.fsf@gnu.org> <87bjxb5yg5.fsf@gmail.com> <37DCBABA-3D38-4FDD-8769-93E3D7F71DCE@posteo.de> X-Debbugs-Cc: Robert Pluim , Eli Zaretskii , Stefan Kangas , Andrea Corallo , Stefan Monnier Date: Tue, 24 Dec 2024 23:14:31 +0000 Message-ID: <87r05wznag.fsf@host.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Resending an email that I mistakenly had only sent to Stefan Monnier: On Mon, 16 Dec 2024 22:03:22 -0500, Stefan Monnier said: > The table is a bit redundant with the s-exp representation and > I'm not sure we want to spend all this time&space printing out a > large keymap, but maybe we could use the > `help-fns-describe-variable-functions` mechanism to add a > one-liner that can be clicked to get to the keymap-specific > description, a bit like Custom vars have a "You can customize > this variable" link. WDYT? I agree that there's redundancy. But since adding the function `help-fns-keymap-key-bindings' from my patch to `help-fns-describe-variable-functions` would be opt-in, it'd be up to the user to decide between redundancy and convenience. Nevertheless, I like your idea of a clickable button, e.g. worded "View this keymap as a table" in the *Help* buffer. Let me continue your comparison to the "You can customize this variable" button by noting that its command, `help-customize', is also bound to "c" in Help-Mode. I'd also like a key binding for "View this keymap as a table", e.g. "k". So, these key sequences would result in the same state: C-h v foo-map RET k M-x describe-keymap foo-map RET But we can build up this idea further: What if these would also result in the same state? (`ido-mode' is both a variable and a function.) C-h f ido-mode RET o C-h v ido-mode RET o C-h o ido-mode RET And also: C-h v ido-mode RET f C-h f ido-mode RET What do you think about enabling users to easily "effectively switch" between describe-* commands in this way? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 18:15:36 2024 Received: (at control) by debbugs.gnu.org; 24 Dec 2024 23:15:37 +0000 Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQE7k-0005Ar-Lg for submit@debbugs.gnu.org; Tue, 24 Dec 2024 18:15:36 -0500 Received: from mout01.posteo.de ([185.67.36.65]:48597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQE7i-0005AU-PZ for control@debbugs.gnu.org; Tue, 24 Dec 2024 18:15:35 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9674C240027 for ; Wed, 25 Dec 2024 00:15:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1735082128; bh=vzOkMKkbr0i7TyDg3NgKmCUz532hRqJ/KK6obhGELxY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=HzKfGdJ6VEfLhVMM+AdYxx63DDqLwU7SI0tkBwa0Toj4Nh0HVdEr18t9MIimZHmqT 7txAF/mO7ysv3k2PjzbUdTgp+Be7O2LGAHigP+bO76W8EwMMMYvhUGUDzru1zw0ncf uvGC5Cl7v0SV8VDyik2xGUpQP9MMt5XKTW0YB3DgKAQYoYycEO9rb7NW/rywdL3xZD ivOe/GqlynATHVwDSNZzUod/tJZ65XkUWwvd3Ebd5qJIqnFveCiI2BI+lHx5/XWbvG GERF90QrRs5rb5DB62tt6xnIHpIYtGgSG8gRQ1YYRwqdub3rE4vYYKgWGFnOseSam6 zewSlL7+uXQ5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHrN00jXgz9rxF; Wed, 25 Dec 2024 00:15:28 +0100 (CET) From: Mekeor Melire To: control@debbugs.gnu.org Subject: control message for bug #74903 Date: Tue, 24 Dec 2024 23:15:27 +0000 Message-ID: <87ldw4zn8w.fsf@host.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 74903 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 18:19:55 2024 Received: (at 74903) by debbugs.gnu.org; 24 Dec 2024 23:19:55 +0000 Received: from localhost ([127.0.0.1]:35345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQEBv-0005JY-Ae for submit@debbugs.gnu.org; Tue, 24 Dec 2024 18:19:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQEBs-0005JE-Fy for 74903@debbugs.gnu.org; Tue, 24 Dec 2024 18:19:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DA2E0240027 for <74903@debbugs.gnu.org>; Wed, 25 Dec 2024 00:19:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1735082386; bh=ZZ9tMgJheL26QDtM6757oOfaATQMW9PtwdMJha8ClAQ=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=LCV6K9SDbURQF5ZVPdXn+64aKFtjH7EFlytgWxLQLqTeFOub/Sqgmv8351sUSELgL GQgrpc3iYKsQCTZtqUgQNwCtT42govRS1oOkxICmL9bNaqaxA4OZUPRFwD44OrxyLU WZI+NvW9FjgpVW9SjVYypcBZ1IM2I6Z+tBP7w1d1XehQ22gdzg+85FVI0J2NJ9HbPn muRYSLgmGi9zzHr5/b9OOKWELwl5qBxe/WuVhAZNvcC9TcSKmFBQVtOff6Twzlh+vz 4vRmxhhHwB2Zt0RgQZfxZtoonML6F5buAtBQKasztenD8M9w2uJac7WL187thV9gek ZAmcnKvYeMxzQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHrSy3HtLz9rxB; Wed, 25 Dec 2024 00:19:46 +0100 (CET) From: Mekeor Melire To: 74903@debbugs.gnu.org Subject: Re: [PATCH] Add function to show table of keys when describing keymap variable In-Reply-To: <87v7vktu7s.fsf@posteo.de> (Mekeor Melire's message of "Sun, 15 Dec 2024 23:14:15 +0000") References: <87v7vktu7s.fsf@posteo.de> Date: Tue, 24 Dec 2024 23:19:45 +0000 Message-ID: <878qs4zn1q.fsf@posteo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I'd like to close this feature request because maintainers didn't agree with my vision. Thank y'all nevertheless. :) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 07:04:22 2024 Received: (at 74903-done) by debbugs.gnu.org; 25 Dec 2024 12:04:22 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQ7i-0000FE-H7 for submit@debbugs.gnu.org; Wed, 25 Dec 2024 07:04:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQQ7g-0000F1-UD for 74903-done@debbugs.gnu.org; Wed, 25 Dec 2024 07:04:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQQ7b-0004d5-O8; Wed, 25 Dec 2024 07:04:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J9PwTWRJsI2QJNa2x79T20DLEKTjlNOOQEe5270uRd8=; b=bMWm+ok33StU 6a3TMyHy/kQ+G2aw3VfUkHmIBhkPpzEYW7/VJau37Z/lBA+pXJn3e5Cox4CHuEoTp+Yx4NL8+M5XY qs50p9idG+ZzV55YMnZ8lm8e20kwsuGIG/uq/Gzj+elLFl7kjrYTC9CLuByVmyFuPzXp0tbxW15AY xxEs/FDviX5FG4E9aCDJZjaLFHoZcenPt/obHRJhp6jU28xGWIQe3njVdTBcTsgNfK4tzipqObRjb 1z+Z5btdiezYoiB1mZqjCEp3tgFRGLOzqQW+LWAnTkkvnLIuWzDeDecPFtlyyb3mmuR4uGurS7wF/ VZ12MplWD5bZ3AKbsglR3g==; Date: Wed, 25 Dec 2024 14:04:12 +0200 Message-Id: <86msgk0y0z.fsf@gnu.org> From: Eli Zaretskii To: Mekeor Melire In-Reply-To: <878qs4zn1q.fsf@posteo.de> (message from Mekeor Melire on Tue, 24 Dec 2024 23:19:45 +0000) Subject: Re: bug#74903: [PATCH] Add function to show table of keys when describing keymap variable References: <87v7vktu7s.fsf@posteo.de> <878qs4zn1q.fsf@posteo.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74903-done Cc: 74903-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mekeor Melire > Date: Tue, 24 Dec 2024 23:19:45 +0000 > > I'd like to close this feature request because maintainers didn't agree > with my vision. Thank y'all nevertheless. :) Thanks, done. From unknown Fri Jun 20 07:10:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Jan 2025 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator