GNU bug report logs - #74902
31.0.50; Segfault when deleting frames

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steven Allen <steven <at> stebalien.com>
Cc: rpluim <at> gmail.com, 74902 <at> debbugs.gnu.org
Subject: bug#74902: 31.0.50; Segfault when deleting frames
Date: Sat, 04 Jan 2025 14:02:28 +0200

> From: Steven Allen <steven <at> stebalien.com>
> Cc: 74902 <at> debbugs.gnu.org
> Date: Tue, 31 Dec 2024 08:53:23 -0800
> 
> 
> Robert Pluim <rpluim <at> gmail.com> writes:
> > If you do find a reproducer, then based on the trace above I think the
> > following should fix it:
> >
> > diff --git a/src/frame.c b/src/frame.c
> > index f6053fca3ef..ff9e1d24ea1 100644
> > --- a/src/frame.c
> > +++ b/src/frame.c
> > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
> >    delete_all_child_windows (f->root_window);
> >    fset_root_window (f, Qnil);
> >  
> > +  block_input();
> >    Vframe_list = Fdelq (frame, Vframe_list);
> > +  unblock_input();
> >    SET_FRAME_VISIBLE (f, 0);
> >  
> >    /* Allow the vector of menu bar contents to be freed in the next
> 
> >From what I can tell (my reproducer isn't 100% effective), this does
> indeed fix the issue. Thanks!

Robert, please install, and thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.