From unknown Tue Jun 17 20:14:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74902 <74902@debbugs.gnu.org> To: bug#74902 <74902@debbugs.gnu.org> Subject: Status: 31.0.50; Segfault when deleting frames Reply-To: bug#74902 <74902@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:14:32 +0000 retitle 74902 31.0.50; Segfault when deleting frames reassign 74902 emacs submitter 74902 Steven Allen severity 74902 normal tag 74902 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 17:01:30 2024 Received: (at submit) by debbugs.gnu.org; 15 Dec 2024 22:01:30 +0000 Received: from localhost ([127.0.0.1]:52459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMwg4-0005zT-Rd for submit@debbugs.gnu.org; Sun, 15 Dec 2024 17:01:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:49562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMwg2-0005zI-0L for submit@debbugs.gnu.org; Sun, 15 Dec 2024 17:01:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMwg1-000149-P5 for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 17:01:25 -0500 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMwfy-0003kA-CD for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 17:01:25 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id 9DD7A25400CB for ; Sun, 15 Dec 2024 17:01:19 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sun, 15 Dec 2024 17:01:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm3; t=1734300079; x=1734386479; bh=nroOosrPVqeq/IgCViBsijNu10FZBB6e 2XxBNI4oS1o=; b=ue9a0eXR0hDFCIPimEaIt6whTH2Zfi8RddnE3bvjTf/j8aOE XlunZVLqpwJpIY0ZDRTELkiBv0RrzZjFpzqN4wYcVCLN39APYMIfL5yJTFDTyNfq d3XJ787zR/gGQhT33g9troTsLlGfdjVuP4k9DGZ0aSWELKbYGCk+hSoJ483bWF8R HLHIcv28J97VVRbUQXKhhzDW04AR3X8rh76IaEgh11vlpXwmTGzoCA8WH9Mh5Swu 1cyXj5QRF44QIzFWak3r1P90qlArMO9/gXYzw5jihyRliakKuKhg/8KWxyy9+LkF MoH3JDMXPVc9v1YIGiDPgHP3xj2/SPCa6r3G8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1734300079; x= 1734386479; bh=nroOosrPVqeq/IgCViBsijNu10FZBB6e2XxBNI4oS1o=; b=V M1f5pNRiZwEEYj3KpRA1PLhFaGsK8noV+y1J7cxfPMPlRi56+AnQqQGxwcUFB+BX WwGe82LwblMmzJdJl7/C+m1W9zHg6ymkgg048lv3xw87zeJ3M5RIv5C/U4TqYKNM /ZuMTuf3n+xxrz0Apoj6+TLwnfyIFv6gvGJWG4miE5GbS2ol9je2CUcXU8CbkWue 7f+YDeknnni7aDW129lGzp+NJqqm7frV26IR4u7nY9ZvZjg/oo5ou7iVcE6ugs/y N4aw5pvclyy67o8YndNAQ/f9mInGNKFeY+AoW0guE7YPB0yWfhGYR7KxPTqXxxuT 1dyV803EERX0ruyL3oU3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrledugdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuff fkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgv vhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrthhtvghrnhepfeektddutd ethfegkeettdeggeejgedvudethefhtefhveelfeevhefhhfdvffejnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsg grlhhivghnrdgtohhmpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdp rhgtphhtthhopegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 15 Dec 2024 17:01:18 -0500 (EST) From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Segfault when deleting frames X-Debbugs-Cc: Date: Sun, 15 Dec 2024 14:01:17 -0800 Message-ID: <87frmoy5aq.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=202.12.124.154; envelope-from=steven@stebalien.com; helo=fhigh-b3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I use EXWM and, Emacs very occasionally seems to crash when closing floating windows. Specifically, it crashes when deleting the frame wrapping the floating window. Unfortunately, I don't have a great way to reproduce it with a minimal setup or to reproduce it reliably enough to grab a trace with GDB. As far as I can tell, this is because `delete-frame' calls `delq' (from C) which then handles a signal (not sure what signal) via the `FOR_EACH_TAIL' macro while deleting the frame. Unfortunately, that eventually calls `gobble_input' which operates on frames. Backtrace: /usr/bin/emacs(emacs_backtrace+0x4e) [0x61e77935447e] /usr/bin/emacs(terminate_due_to_signal+0xaf) [0x61e7791a4c5d] /usr/bin/emacs(+0x5e062) [0x61e7791a6062] /usr/lib/libc.so.6(+0x42150) [0x7e3a544dc150] /usr/bin/emacs(+0xeff78) [0x61e779237f78] /usr/bin/emacs(+0x19a564) [0x61e7792e2564] /usr/bin/emacs(+0x19a829) [0x61e7792e2829] /usr/bin/emacs(+0x1a1c58) [0x61e7792e9c58] /usr/bin/emacs(+0x1b0bb8) [0x61e7792f8bb8] /usr/bin/emacs(gobble_input+0x272) [0x61e77933f3a2] /usr/bin/emacs(probably_quit+0xc6) [0x61e7793ec666] /usr/bin/emacs(Fdelq+0xb6) [0x61e77940c196] /usr/bin/emacs(delete_frame+0x2d4) [0x61e7791d77b4] /usr/bin/emacs(Fdelete_frame+0x17) [0x61e7791d8a07] /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-9789f41c/preloaded/window-0d1b8b93-5fc421c3.eln(F77696e646f772d2d64656c657465_window__delete_0+0xf6) [0x7e3a500879e6] /usr/bin/emacs(Ffuncall+0x107) [0x61e7793fb617] /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-9789f41c/preloaded/window-0d1b8b93-5fc421c3.eln(F7265706c6163652d6275666665722d696e2d77696e646f7773_replace_buffer_in_windows_0+0x2fb) [0x7e3a5008893b] /usr/bin/emacs(Ffuncall+0x107) [0x61e7793fb617] /usr/bin/emacs(Fkill_buffer+0x179) [0x61e779367229] /home/steb/.config/emacs/eln-cache/31.0.50-9789f41c/exwm-manage-481a2a54-f343330e.eln(F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_20+0x72) [0x7e3a48615462] /usr/bin/emacs(Ffuncall+0x107) [0x61e7793fb617] /usr/bin/emacs(Fapply+0x464) [0x61e7793ec0f4] /usr/bin/emacs(Ffuncall+0x107) [0x61e7793fb617] /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-9789f41c/preloaded/timer-3ee7cfd9-4017b895.eln(F74696d65722d6576656e742d68616e646c6572_timer_event_handler_0+0x408) [0x7e3a4fa48468] /usr/bin/emacs(Ffuncall+0x107) [0x61e7793fb617] /usr/bin/emacs(timer_check+0x4de) [0x61e779331bce] /usr/bin/emacs(+0x3d325b) [0x61e77951b25b] /usr/bin/emacs(read_char+0x1c8f) [0x61e779339e0f] /usr/bin/emacs(+0x3c4c9e) [0x61e77950cc9e] /usr/bin/emacs(+0x1e60e3) [0x61e77932e0e3] /usr/bin/emacs(internal_condition_case+0x77) [0x61e7793eb237] /usr/bin/emacs(command_loop_2+0x2f) [0x61e77932d45f] /usr/bin/emacs(internal_catch+0x46) [0x61e7793eb176] /usr/bin/emacs(+0x1e58cb) [0x61e77932d8cb] /usr/bin/emacs(recursive_edit_1+0xf6) [0x61e77932da86] /usr/bin/emacs(Frecursive_edit+0x110) [0x61e77932dd30] /usr/bin/emacs(main+0x298b) [0x61e7791b9ecb] /usr/lib/libc.so.6(+0x2618e) [0x7e3a544c018e] /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7e3a544c024a] /usr/bin/emacs(_start+0x25) [0x61e7791ba695] In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.18.2) of 2024-12-07 built on Laptop Repository revision: 6f6b641975e4828f96913b29b1476c6323c952d8 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101014 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-m17n-flt --without-selinux --without-pop --without-gconf --disable-gc-mark-trace --enable-link-time-optimization --with-native-compilation=yes --with-xinput2 --with-x-toolkit=no --without-toolkit-scroll-bars --without-xft --without-xaw3d --without-gsettings --with-cairo-xcb --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fomit-frame-pointer -fno-math-errno -fno-trapping-math -fno-math-errno -fno-trapping-math -flto=auto' 'LDFLAGS=-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: journalctl Minor modes in effect: notmuch-bookmarks-mode: t windmove-mode: t global-atomic-chrome-edit-mode: t iwd-agent-mode: t i3bar-mode: t ednc-mode: t exwm-xsettings-mode: t exwm-background-mode: t exwm-systemtray-mode: t exwm-randr-mode: t auto-compile-on-load-mode: t auto-compile-on-save-mode: t save-place-mode: t savehist-mode: t openwith-mode: t org-super-agenda-mode: t global-org-modern-mode: t eat-eshell-mode: t magit-todos-mode: t global-git-commit-mode: t magit-auto-revert-mode: t server-mode: t recentf-mode: t global-treesit-auto-mode: t editorconfig-mode: t yas-global-mode: t yas-minor-mode: t async-bytecomp-package-mode: t sudo-edit-indicator-mode: t global-auto-revert-mode: t vertico-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t minibuffer-depth-indicate-mode: t minibuffer-electric-default-mode: t isearch-mb-mode: t pixel-scroll-precision-mode: t global-hl-todo-mode: t all-the-icons-completion-mode: t marginalia-mode: t visual-replace-global-mode: t global-jinx-mode: t evil-goggles-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-collection-unimpaired-mode: t evil-collection-unimpaired-mode: t evil-mode: t evil-local-mode: t desktop-environment-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-history-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t visual-line-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/steb/.cache/emacs/elpa/filechooser-0.2.1/filechooser hides /usr/share/emacs/site-lisp/filechooser /home/steb/.cache/emacs/elpa/filechooser-0.2.1/filechooser-autoloads hides /usr/share/emacs/site-lisp/filechooser-autoloads /home/steb/.cache/emacs/elpa/protobuf-mode-20240823.1417/protobuf-mode hides /usr/share/emacs/site-lisp/protobuf-mode /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch hides /usr/share/emacs/site-lisp/notmuch /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-wash hides /usr/share/emacs/site-lisp/notmuch-wash /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-tree hides /usr/share/emacs/site-lisp/notmuch-tree /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-tag hides /usr/share/emacs/site-lisp/notmuch-tag /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-show hides /usr/share/emacs/site-lisp/notmuch-show /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-query hides /usr/share/emacs/site-lisp/notmuch-query /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-print hides /usr/share/emacs/site-lisp/notmuch-print /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-parser hides /usr/share/emacs/site-lisp/notmuch-parser /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-mua hides /usr/share/emacs/site-lisp/notmuch-mua /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-message hides /usr/share/emacs/site-lisp/notmuch-message /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-maildir-fcc hides /usr/share/emacs/site-lisp/notmuch-maildir-fcc /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-lib hides /usr/share/emacs/site-lisp/notmuch-lib /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-jump hides /usr/share/emacs/site-lisp/notmuch-jump /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-hello hides /usr/share/emacs/site-lisp/notmuch-hello /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-draft hides /usr/share/emacs/site-lisp/notmuch-draft /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-crypto hides /usr/share/emacs/site-lisp/notmuch-crypto /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-compat hides /usr/share/emacs/site-lisp/notmuch-compat /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-company hides /usr/share/emacs/site-lisp/notmuch-company /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/notmuch-address hides /usr/share/emacs/site-lisp/notmuch-address /home/steb/.cache/emacs/elpa/notmuch-20240816.2039/coolj hides /usr/share/emacs/site-lisp/coolj /home/steb/.cache/emacs/elpa/modus-themes-4.6.0/theme-loaddefs hides /usr/share/emacs/31.0.50/lisp/theme-loaddefs Features: (shadow sort mail-extr emacsbug mule-util tramp-cmds cc-mode cc-fonts cc-guess cc-menus cc-cmds consult-xref evil-collection-eglot eglot external-completion jsonrpc evil-collection-ert ert ewoc evil-collection-debug debug backtrace rainbow-delimiters vc evil-collection-flymake flymake c++-ts-mode c-ts-mode c-ts-common evil-collection-consult consult magit-bookmark org-bookmark-heading notmuch-bookmarks evil-collection-bookmark bookmark texinfo texinfo-loaddefs evil-collection-vc-git vc-git vc-dispatcher misearch multi-isearch vertico-repeat windmove journalctl bash-completion eshell-syntax-highlighting em-elecslash em-glob em-extpipe em-basic em-alias pinentry evil-collection-atomic-chrome atomic-chrome websocket bindat let-alist iwd i3bar ednc filechooser dbus exwm-xsettings xcb-xsettings exwm-background exwm-systemtray xcb-systemtray xcb-xembed exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug cus-start posframe visual-wrap face-remap visual-fill-column ligature evil-org corg org-appear ws-butler oc-basic bibtex ol-man ol-info ol-docview evil-collection-doc-view doc-view jka-compr evil-collection-image image-mode exif auto-compile show-font saveplace tramp-cache time-stamp savehist openwith org-super-agenda ts ht org-habit org-crypt org-protocol ox-typst ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar evil-org-agenda org-agenda ox-html table ox-ascii ox-publish ox org-attach org-element org-persist org-id org-refile org-element-ast inline avl-tree ob-http ob-http-mode org-modern ob-dot ob-latex ob-python evil-collection-python python ob-gnuplot ob-calc calc-store calc-trail calc-ext evil-collection-calc calc calc-loaddefs calc-macs ob-shell evil-collection-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro evil-collection-xref xref org-src evil-collection-sh-script sh-script smie executable ob-comint org-pcomplete org-list org-footnote org-faces org-entities evil-collection-outline noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-version org-macs notmuch-addr evil-collection-notmuch notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser notmuch-wash coolj goto-addr icalendar diary-lib diary-loaddefs evil-collection-calendar cal-menu calendar cal-loaddefs notmuch-tag notmuch-lib notmuch-compat hl-line mm-view mml-smime smime gnutls dig eshell-prompt-extras em-dirs em-ls em-prompt em-hist em-unix em-pred esh-mode esh-var evil-collection-eat eat evil-collection-term term disp-table ehelp eshell esh-cmd generator esh-ext esh-proc esh-opt esh-io esh-arg esh-module esh-module-loaddefs esh-util forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler eieio-base evil-collection-magit-todos magit-todos pcre2el rxt advice re-builder evil-collection-grep grep evil-collection-compile compile pcase evil-collection-magit magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit evil-collection-magit-repos magit-repos magit-apply magit-wip magit-log which-func evil-collection-imenu imenu magit-diff evil-collection-smerge-mode smerge-mode diff diff-mode track-changes git-commit evil-collection-log-edit log-edit message sendmail yank-media puny evil-collection-dired dired dired-loaddefs rfc822 mml mml-sec evil-collection-epa epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process evil-collection-with-editor with-editor server magit-mode transient benchmark magit-git magit-base evil-collection-magit-section magit-section cursor-sensor crm tramp-sh recentf tree-widget easy-mmode treesit-auto editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch yasnippet async-bytecomp async sudo-edit tramp trampver tramp-integration files-x tramp-message tramp-compat shell pcomplete evil-collection-comint comint ansi-osc parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs autorevert filenotify project vertico corfu-popupinfo evil-collection-corfu corfu orderless mb-depth minibuf-eldef isearch-mb pixel-scroll cua-base hl-todo all-the-icons-completion all-the-icons all-the-icons-faces all-the-icons-data-material-icons all-the-icons-data-fluentui-system-icons all-the-icons-data-fontawesome-4 all-the-icons-data-weather-icons all-the-icons-data-vscode-codicons all-the-icons-data-octicons all-the-icons-data-mfixx all-the-icons-data-file-icons all-the-icons-data-devopicons all-the-icons-data-alltheicons svg dom xml marginalia modus-vivendi-theme modus-themes visual-replace ispell jinx evil-goggles pulse color evil-textobj-tree-sitter evil-textobj-tree-sitter-thing-at-point evil-textobj-tree-sitter-core treesit evil-args evil-surround evil-collection-unimpaired evil-collection-tabulated-list evil-collection-tab-bar evil-collection-simple evil-collection-replace evil-collection-process-menu evil-collection-package-menu evil-collection-kmacro evil-collection-info evil-collection-indent evil-collection-help evil-collection-elisp-mode evil-collection-eldoc evil-collection-custom evil-collection-buff-menu evil-collection annalist evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core comp-run evil-common thingatpt rect evil-vars ring edmacro kmacro general f dash s mode-local find-func no-littering compat finder-inf notmuch-version info all-the-icons-completion-autoloads all-the-icons-dired-autoloads all-the-icons-ibuffer-autoloads all-the-icons-autoloads app-launcher-autoloads aria2-autoloads atomic-chrome-autoloads auto-compile-autoloads bash-completion-autoloads bluetooth-autoloads buffer-move-autoloads calibre-autoloads cape-autoloads casual-autoloads clojure-mode-autoloads comint-mime-autoloads consult-eglot-autoloads consult-project-extra-autoloads corfu-autoloads corg-autoloads csv-mode-autoloads dape-autoloads devdocs-autoloads dired-filter-autoloads dired-hacks-utils-autoloads dired-k-autoloads discomfort-autoloads debase-autoloads disk-usage-autoloads eat-autoloads edit-indirect-autoloads ednc-autoloads eff-autoloads embark-consult-autoloads consult-autoloads embark-autoloads ement-autoloads eshell-prompt-extras-autoloads eshell-syntax-highlighting-autoloads evil-args-autoloads evil-collection-autoloads annalist-autoloads evil-goggles-autoloads evil-nerd-commenter-autoloads evil-org-autoloads evil-surround-autoloads evil-textobj-tree-sitter-autoloads evm-mode-autoloads expand-region-autoloads exwm-autoloads filechooser-autoloads flymake-ruff-autoloads forge-search-autoloads general-autoloads git-link-autoloads git-modes-autoloads gnuplot-autoloads gptel-autoloads graphviz-dot-mode-autoloads helpful-autoloads elisp-refs-autoloads htmlize-autoloads i3bar-autoloads igist-autoloads info-colors-autoloads isearch-mb-autoloads iwd-autoloads iwindow-autoloads jinx-autoloads journalctl-autoloads kotlin-mode-autoloads kubernetes-evil-autoloads evil-autoloads goto-chg-autoloads kubernetes-autoloads ligature-autoloads link-hint-autoloads avy-autoloads magit-popup-autoloads magit-todos-autoloads hl-todo-autoloads f-autoloads marginalia-autoloads mastodon-autoloads mathjax-autoloads microdata-autoloads modus-themes-autoloads named-pipe-autoloads nftables-mode-autoloads no-littering-autoloads notmuch-addr-autoloads notmuch-transient-autoloads nov-autoloads esxml-autoloads kv-autoloads ob-http-autoloads ol-notmuch-autoloads notmuch-autoloads openwith-autoloads orderless-autoloads org-appear-autoloads org-bookmark-heading-autoloads org-download-autoloads async-autoloads org-modern-autoloads org-super-agenda-autoloads ht-autoloads orgit-forge-autoloads orgit-autoloads forge-autoloads markdown-mode-autoloads magit-autoloads ghub-autoloads closql-autoloads emacsql-autoloads ox-typst-autoloads package-lint-flymake-autoloads package-lint-autoloads password-store-autoloads pcre2el-autoloads pdf-tools-autoloads persist-autoloads pinentry-autoloads pkgbuild-mode-autoloads playerctl-autoloads plz-autoloads posframe-autoloads proced-narrow-autoloads protobuf-mode-autoloads pulseaudio-control-autoloads qrencode-autoloads rainbow-delimiters-autoloads rainbow-mode-autoloads request-autoloads rg-autoloads rmsbolt-autoloads rust-playground-autoloads show-font-autoloads solidity-mode-autoloads ssh-config-mode-autoloads sudo-edit-autoloads svg-lib-autoloads syncthing-autoloads systemctl-autoloads systemd-autoloads tablist-autoloads taxy-magit-section-autoloads taxy-autoloads magit-section-autoloads tmr-autoloads tp-autoloads treepy-autoloads treesit-auto-autoloads ts-autoloads s-autoloads dash-autoloads tzc-autoloads udev-mode-autoloads vala-mode-autoloads cc-styles cc-align cc-engine cc-vars cc-defs varuga-autoloads vertico-autoloads vimrc-mode-autoloads visual-fill-column-autoloads visual-replace-autoloads vundo-autoloads wat-ts-mode-autoloads watch-autoloads web-mode-autoloads websocket-autoloads wgrep-autoloads whisper-autoloads with-editor-autoloads ws-butler-autoloads xelb-autoloads yaml-autoloads yasnippet-autoloads comp comp-cstr cl-extra help-mode comp-common warnings rx xdg package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 1395639 980414) (symbols 48 71688 3) (strings 32 377983 67952) (string-bytes 1 11865296) (vectors 16 132134) (vector-slots 8 1522623 421201) (floats 8 742 4321) (intervals 56 43580 33010) (buffers 992 35)) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 10:52:25 2024 Received: (at 74902) by debbugs.gnu.org; 16 Dec 2024 15:52:26 +0000 Received: from localhost ([127.0.0.1]:55635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDOT-0000ob-28 for submit@debbugs.gnu.org; Mon, 16 Dec 2024 10:52:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDOP-0000oI-CA for 74902@debbugs.gnu.org; Mon, 16 Dec 2024 10:52:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNDMD-0003u5-2M; Mon, 16 Dec 2024 10:50:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+5Bag5guJ7VdyCbJGKzfRzSyCzpGp9ZM1uIN155dASE=; b=hlyTnRx0DbO1 oFPpHNXtiyoue71/scydyysaCXJd+CZo4Hm7dqYPnTGvmimw+qwFgNZBP7KdFxInFfP0F4xEb6ukH xskhM5YlxwuadqxJyDcmuPHtQ+AnFXuzYuJOXxRwz8QPGvUBktz3+TxAKZagQ03Uw3gnITyfvOYYt EF4KmK7Q5gbDyDxu3nm8jaA24JJ4LE4y+sCf/4Qk0R7y9ws0HVZ0aTD+KibkyuMT+yTZBzNGwf5aP y79m8xhLvBBpDtWg4+vMAmieKxr3RlC85zZKDIMSf7QuyXVF/WzBsu5ZlmkTAKTkXI9B9cZzfoXS9 C5jtynhFnPtzPfrAG23xvg==; Date: Mon, 16 Dec 2024 17:50:01 +0200 Message-Id: <861py7r5jq.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <87frmoy5aq.fsf@stebalien.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames References: <87frmoy5aq.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74902 Cc: 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 Dec 2024 14:01:17 -0800 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > I use EXWM and, Emacs very occasionally seems to crash when closing > floating windows. Specifically, it crashes when deleting the frame > wrapping the floating window. Unfortunately, I don't have a great way to > reproduce it with a minimal setup or to reproduce it reliably enough to > grab a trace with GDB. > > As far as I can tell, this is because `delete-frame' calls `delq' (from > C) which then handles a signal (not sure what signal) via the > `FOR_EACH_TAIL' macro while deleting the frame. Unfortunately, that > eventually calls `gobble_input' which operates on frames. > > > Backtrace: > > /usr/bin/emacs(emacs_backtrace+0x4e) [0x61e77935447e] > /usr/bin/emacs(terminate_due_to_signal+0xaf) [0x61e7791a4c5d] > /usr/bin/emacs(+0x5e062) [0x61e7791a6062] > /usr/lib/libc.so.6(+0x42150) [0x7e3a544dc150] > /usr/bin/emacs(+0xeff78) [0x61e779237f78] > /usr/bin/emacs(+0x19a564) [0x61e7792e2564] > /usr/bin/emacs(+0x19a829) [0x61e7792e2829] > /usr/bin/emacs(+0x1a1c58) [0x61e7792e9c58] > /usr/bin/emacs(+0x1b0bb8) [0x61e7792f8bb8] > /usr/bin/emacs(gobble_input+0x272) [0x61e77933f3a2] > /usr/bin/emacs(probably_quit+0xc6) [0x61e7793ec666] > /usr/bin/emacs(Fdelq+0xb6) [0x61e77940c196] > /usr/bin/emacs(delete_frame+0x2d4) [0x61e7791d77b4] > /usr/bin/emacs(Fdelete_frame+0x17) [0x61e7791d8a07] This is less useful than a backtrace could be. Can you run Emacs under GDB, and when it crashes, type (gdb) thread apply all bt and post here everything GDB produces as result? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 11:12:57 2024 Received: (at 74902) by debbugs.gnu.org; 16 Dec 2024 16:12:57 +0000 Received: from localhost ([127.0.0.1]:55693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDiL-00023K-0Z for submit@debbugs.gnu.org; Mon, 16 Dec 2024 11:12:57 -0500 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:50803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNDiI-00022u-8w for 74902@debbugs.gnu.org; Mon, 16 Dec 2024 11:12:55 -0500 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id 94F5F1140193; Mon, 16 Dec 2024 11:12:48 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Mon, 16 Dec 2024 11:12:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1734365568; x= 1734451968; bh=0FlzJ7cHVqaMNZpQ6MbDSB6RaODZ94RixwJw51rvP5g=; b=l etArXB4Qpd2IdUv4ddXh71aq6c6GCooyg/9hwmJqUW90pW43R/jyRtb4svjFkEwO /+rU2xgr9NdJwGUi2vG44ySqVPv/O2w3jNSSC/Z2lhlPpICCb7W6NoPy0uG0yYLf TSvAPrmKanLDgVdG3RNmtP/QrTg2fozspkXagzZfUUszw0eNin+bNVISD7Ch21Ep jNBlyira7EBi4QrYGEF9XB4VU9V3FuBrxc5b/XQmidiU3WjW599UrxvthwTJxujk +3FetzAhUpxeBWHTSm/IjUVTIhp7knl+/CIBlBpMNqf8b6bZX8iGHH+nqx4RFNur LJPM5+kMvmOTHt9y5G7CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1734365568; x=1734451968; bh=0FlzJ7cHVqaMNZpQ6MbDSB6RaODZ94RixwJ w51rvP5g=; b=Oq0uftZIL11WQg6KN5KwKrbkxmI5/s7dkOmcjhdk167Eygn8Raj Fx4duf/EPqAkWPX4o70hoVsvvvPYlZs1svZtp+XhMLAWtktgIs3b3QHliL4Kmete buMJ7y0cGRn3hcizAFj5AEZJKGUdcP2o6RIPphBrZx1ahVxwu8mcegC1/gqeOJyp e25WPGJTXXHvfubW7+lq0f1+izHSMQMCXudcDMzw+0sAneZpTUBkzgmP0pXRXVL7 dkHhX8w8UyesegNdiahtjaqvWiSYM6QQwgMKGOaDoS13CR012xQXrAn+BfICmNEF yzdgyVtrIQLgAOjg07OgiPzh+toBcS3l8HQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrleefgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfh rhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrd gtohhmqeenucggtffrrghtthgvrhhnpedvkeehkeegleehheeggfduleektefhhffgueff teekgedtvdefuddutddtjeejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgspghr tghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiisehgnh hurdhorhhgpdhrtghpthhtohepjeegledtvdesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Dec 2024 11:12:47 -0500 (EST) From: Steven Allen To: Eli Zaretskii Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <861py7r5jq.fsf@gnu.org> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> Date: Mon, 16 Dec 2024 08:12:46 -0800 Message-ID: <87v7vjk3nl.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74902 Cc: 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> Date: Sun, 15 Dec 2024 14:01:17 -0800 >> From: Steven Allen via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >> I use EXWM and, Emacs very occasionally seems to crash when closing >> floating windows. Specifically, it crashes when deleting the frame >> wrapping the floating window. Unfortunately, I don't have a great way to >> reproduce it with a minimal setup or to reproduce it reliably enough to >> grab a trace with GDB. >> >> As far as I can tell, this is because `delete-frame' calls `delq' (from >> C) which then handles a signal (not sure what signal) via the >> `FOR_EACH_TAIL' macro while deleting the frame. Unfortunately, that >> eventually calls `gobble_input' which operates on frames. >> >> >> Backtrace: >> >> /usr/bin/emacs(emacs_backtrace+0x4e) [0x61e77935447e] >> /usr/bin/emacs(terminate_due_to_signal+0xaf) [0x61e7791a4c5d] >> /usr/bin/emacs(+0x5e062) [0x61e7791a6062] >> /usr/lib/libc.so.6(+0x42150) [0x7e3a544dc150] >> /usr/bin/emacs(+0xeff78) [0x61e779237f78] >> /usr/bin/emacs(+0x19a564) [0x61e7792e2564] >> /usr/bin/emacs(+0x19a829) [0x61e7792e2829] >> /usr/bin/emacs(+0x1a1c58) [0x61e7792e9c58] >> /usr/bin/emacs(+0x1b0bb8) [0x61e7792f8bb8] >> /usr/bin/emacs(gobble_input+0x272) [0x61e77933f3a2] >> /usr/bin/emacs(probably_quit+0xc6) [0x61e7793ec666] >> /usr/bin/emacs(Fdelq+0xb6) [0x61e77940c196] >> /usr/bin/emacs(delete_frame+0x2d4) [0x61e7791d77b4] >> /usr/bin/emacs(Fdelete_frame+0x17) [0x61e7791d8a07] > > This is less useful than a backtrace could be. Can you run Emacs > under GDB, and when it crashes, type > > (gdb) thread apply all bt > > and post here everything GDB produces as result? Yeah, I agree. I'll do that if I can find a reliable way to reproduce it. At the moment it happens once every few months. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 12:21:44 2024 Received: (at 74902) by debbugs.gnu.org; 16 Dec 2024 17:21:44 +0000 Received: from localhost ([127.0.0.1]:55817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNEmt-0005tF-RW for submit@debbugs.gnu.org; Mon, 16 Dec 2024 12:21:44 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:58495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNEms-0005t0-7U for 74902@debbugs.gnu.org; Mon, 16 Dec 2024 12:21:42 -0500 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43634b570c1so19116765e9.0 for <74902@debbugs.gnu.org>; Mon, 16 Dec 2024 09:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734369636; x=1734974436; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=+tyZ8ug2iapkPaazXtqnArLHhj+Nu02rvRiMVwU4rt8=; b=H5qTcd0cHAWpjaaN4ge8Ooy+o6UGY3yYOkl0fiUsZhlEXtIQKzhAm5SbD5VFOv1FZM dIwdmM3YOoArAfLmUuBHWtjTx/urMcEcRbW4feG1BpSkUqObR3sqhaessIJhChdsYAQX 5nyO6nBkw4Nr0tRLMWlxExMXlaocSKmoO2Vm2kHmwwOAZxUhAJW0Bpstuwk9W/d1shf9 aw58JnTQ+tJt3AjnPRYhLSrDdS0w6mrekU/b+kZIrBNcgda2JGWvyfdW4VpnOsiJo8nI azz3yl+F8VujNWeDtKYHDVpxgeVTinue0HliPT0La7ADVPO1KgvH3z0C9Wm6Sosqf2Xl QQow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734369636; x=1734974436; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+tyZ8ug2iapkPaazXtqnArLHhj+Nu02rvRiMVwU4rt8=; b=StD4pOu/Jmqzl7bUnUa9R+46S5++B8r8WWvDUNCEOlDOktX+/8Kjqv15hUr5qsfkkZ DhoKKCGn9MsjUKzfzKDmg/6d4m2WlYRERlONla/6m+CERKf04Hbpdy2qkT3Y2xX3QiA5 vuh82XX+yJG7vPSKplS+yI0Q4EA6+VpenTsKxI7uMg/1NFKGOwyqLFMaCJgLFRXyKctX R2X6ZB/f15NBwggROOX95r98PgTiVODv/U/fe6h9eYUVLDWlS8mJJzRwgqaNz9G/dUmO 6mzUtnJo3GgcxDEzxKxeG2UfMM8l7vgJuwXZ1CtAkYQooK/OEq8Ej9MQdWzZCJIVu+Ba qqnw== X-Forwarded-Encrypted: i=1; AJvYcCX+OPLHEoR5l7k2H9XXgKUZqTeqOVab3k+xJo8pNis7or96qehQpV2C60w7Akv+1o8GcUxD9A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz6MrUun8GC9Yw7ikfjoVRNcVp4S+kKXX8L/QDwMtY0VsIWxfeR sv9KSqqVGibYy18x0I3mYdoNWF1meXs6Gm2fqS8qAsk1Hisv8vsnuaHaLQ== X-Gm-Gg: ASbGncuii8dYyutXTWvWwqWL/wUp4Kq7Tt3EavKuKvaQvMH3ufD0D55ODpb5bcZUXwO qROqt0Z08GG69/VkoJHzdyRYbgGNUwoVHbF3U2TSu1aU6KRA20bJ33Tkh8lbHQCp5liTW9s59ow hPDgQLEUItpvm5znCP639CR4E0NxjS4IJSoyNZI5r0WamnWhhNQ1PpkQEYW5ZiU4MXWlpVSWPFj lgx65e3VYfKEDCBKngotLXTkAgllgmoYBz16Q/zvuU= X-Google-Smtp-Source: AGHT+IEXr5gwi2F2u8CbXCrJIqKb3TRGM4J1Y2+wLPmimGKcpDimLPyy4wmTkvx4lVTQwtcZY9tJNw== X-Received: by 2002:a05:600c:cc9:b0:434:fec5:4ef5 with SMTP id 5b1f17b1804b1-4362aa43bcbmr133251085e9.14.1734369635731; Mon, 16 Dec 2024 09:20:35 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:a104:d8c:5af4:8136]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436362c6ae8sm90200905e9.41.2024.12.16.09.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 09:20:35 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <87v7vjk3nl.fsf@stebalien.com> (Steven Allen via's message of "Mon, 16 Dec 2024 08:12:46 -0800") References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> Date: Mon, 16 Dec 2024 18:20:34 +0100 Message-ID: <87frmn5yu5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74902 Cc: Steven Allen , 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 16 Dec 2024 08:12:46 -0800, Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: Steven> Eli Zaretskii writes: >>> As far as I can tell, this is because `delete-frame' calls `delq' (from >>> C) which then handles a signal (not sure what signal) via the >>> `FOR_EACH_TAIL' macro while deleting the frame. Unfortunately, that >>> eventually calls `gobble_input' which operates on frames. >>> >>> >>> Backtrace: >>> >>> /usr/bin/emacs(emacs_backtrace+0x4e) [0x61e77935447e] >>> /usr/bin/emacs(terminate_due_to_signal+0xaf) [0x61e7791a4c5d] >>> /usr/bin/emacs(+0x5e062) [0x61e7791a6062] >>> /usr/lib/libc.so.6(+0x42150) [0x7e3a544dc150] >>> /usr/bin/emacs(+0xeff78) [0x61e779237f78] >>> /usr/bin/emacs(+0x19a564) [0x61e7792e2564] >>> /usr/bin/emacs(+0x19a829) [0x61e7792e2829] >>> /usr/bin/emacs(+0x1a1c58) [0x61e7792e9c58] >>> /usr/bin/emacs(+0x1b0bb8) [0x61e7792f8bb8] >>> /usr/bin/emacs(gobble_input+0x272) [0x61e77933f3a2] >>> /usr/bin/emacs(probably_quit+0xc6) [0x61e7793ec666] >>> /usr/bin/emacs(Fdelq+0xb6) [0x61e77940c196] >>> /usr/bin/emacs(delete_frame+0x2d4) [0x61e7791d77b4] >>> /usr/bin/emacs(Fdelete_frame+0x17) [0x61e7791d8a07] >> >> This is less useful than a backtrace could be. Can you run Emacs >> under GDB, and when it crashes, type >> >> (gdb) thread apply all bt >> >> and post here everything GDB produces as result? Steven> Yeah, I agree. I'll do that if I can find a reliable way to reproduce Steven> it. At the moment it happens once every few months. If you do find a reproducer, then based on the trace above I think the following should fix it: diff --git a/src/frame.c b/src/frame.c index f6053fca3ef..ff9e1d24ea1 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) delete_all_child_windows (f->root_window); fset_root_window (f, Qnil); + block_input(); Vframe_list = Fdelq (frame, Vframe_list); + unblock_input(); SET_FRAME_VISIBLE (f, 0); /* Allow the vector of menu bar contents to be freed in the next Robert -- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 06:36:01 2024 Received: (at 74902) by debbugs.gnu.org; 28 Dec 2024 11:36:01 +0000 Received: from localhost ([127.0.0.1]:49496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV6u-0008LO-Ol for submit@debbugs.gnu.org; Sat, 28 Dec 2024 06:36:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRV6t-0008LA-AT for 74902@debbugs.gnu.org; Sat, 28 Dec 2024 06:35:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRV6n-0008Tf-UC; Sat, 28 Dec 2024 06:35:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=N/1zMUnjFMe/QQjWcgmF9pKXofYpXOz0k6Vi13rw/wA=; b=UFTY5MEvzLtI BONoMQ7pblNvsvEPgXaOQfZQ4j2PNLHpIHYkXRM35M1zhazFSmHsBllgCTBVV374R4B0zJGbBVf0q jirrwiG4m/oSiReYr2QVoZF+Y1cnKYb7jwcw/1dH2+0tvXG5bYeeO2t4qzRabdNm2rThmrUsJlj6d /1Zlr5EfRcNN/zUAicyhyIiDaCH8SZa8AejN8QjkoGeeGfxYuSJilpvV3ONeVfTnmJJbivGL7thpc VzkljX3oPupevHeVo1OfY94ZunMygzWpMNL3IHqkAg4bBiGegO9GLhkkk1wl/FQeeL/9HrXRW5PuW 65IATvXtqFBXse5afcUTcQ==; Date: Sat, 28 Dec 2024 13:35:41 +0200 Message-Id: <865xn4t4z6.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87frmn5yu5.fsf@gmail.com> (message from Robert Pluim on Mon, 16 Dec 2024 18:20:34 +0100) Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74902 Cc: steven@stebalien.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Steven Allen , 74902@debbugs.gnu.org > Date: Mon, 16 Dec 2024 18:20:34 +0100 > > >>>>> On Mon, 16 Dec 2024 08:12:46 -0800, Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: > > Steven> Eli Zaretskii writes: > >>> As far as I can tell, this is because `delete-frame' calls `delq' (from > >>> C) which then handles a signal (not sure what signal) via the > >>> `FOR_EACH_TAIL' macro while deleting the frame. Unfortunately, that > >>> eventually calls `gobble_input' which operates on frames. > >>> > >>> > >>> Backtrace: > >>> > >>> /usr/bin/emacs(emacs_backtrace+0x4e) [0x61e77935447e] > >>> /usr/bin/emacs(terminate_due_to_signal+0xaf) [0x61e7791a4c5d] > >>> /usr/bin/emacs(+0x5e062) [0x61e7791a6062] > >>> /usr/lib/libc.so.6(+0x42150) [0x7e3a544dc150] > >>> /usr/bin/emacs(+0xeff78) [0x61e779237f78] > >>> /usr/bin/emacs(+0x19a564) [0x61e7792e2564] > >>> /usr/bin/emacs(+0x19a829) [0x61e7792e2829] > >>> /usr/bin/emacs(+0x1a1c58) [0x61e7792e9c58] > >>> /usr/bin/emacs(+0x1b0bb8) [0x61e7792f8bb8] > >>> /usr/bin/emacs(gobble_input+0x272) [0x61e77933f3a2] > >>> /usr/bin/emacs(probably_quit+0xc6) [0x61e7793ec666] > >>> /usr/bin/emacs(Fdelq+0xb6) [0x61e77940c196] > >>> /usr/bin/emacs(delete_frame+0x2d4) [0x61e7791d77b4] > >>> /usr/bin/emacs(Fdelete_frame+0x17) [0x61e7791d8a07] > >> > >> This is less useful than a backtrace could be. Can you run Emacs > >> under GDB, and when it crashes, type > >> > >> (gdb) thread apply all bt > >> > >> and post here everything GDB produces as result? > > Steven> Yeah, I agree. I'll do that if I can find a reliable way to reproduce > Steven> it. At the moment it happens once every few months. > > If you do find a reproducer, then based on the trace above I think the > following should fix it: > > diff --git a/src/frame.c b/src/frame.c > index f6053fca3ef..ff9e1d24ea1 100644 > --- a/src/frame.c > +++ b/src/frame.c > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) > delete_all_child_windows (f->root_window); > fset_root_window (f, Qnil); > > + block_input(); > Vframe_list = Fdelq (frame, Vframe_list); > + unblock_input(); > SET_FRAME_VISIBLE (f, 0); > > /* Allow the vector of menu bar contents to be freed in the next Robert, I think you should install this on the master branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 18:23:22 2024 Received: (at 74902) by debbugs.gnu.org; 28 Dec 2024 23:23:22 +0000 Received: from localhost ([127.0.0.1]:53036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRg9S-00089H-7b for submit@debbugs.gnu.org; Sat, 28 Dec 2024 18:23:22 -0500 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]:45245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRg9Q-00088t-16 for 74902@debbugs.gnu.org; Sat, 28 Dec 2024 18:23:20 -0500 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id B8981114008C; Sat, 28 Dec 2024 18:23:14 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Sat, 28 Dec 2024 18:23:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1735428194; x= 1735514594; bh=z9wStTAzj8M2i0j1Ey508vpRUkTUqUOUUnrxl6PQJ2k=; b=m kFJAUUWvS2EmCnWTio6ABnpU6ZnBXsv7EK+HPmjDIwUc/8PJGkkizoKhe4hCFfRw e0g/toF8LSxd66kJbOAdYvB3zBpD+FFTKVDzoHJnrCKYBS6P3OUETzUVWGynMBij TKNRMX0hcurbUl0ROJXdNFbPR4KtGpc5c41vQX4/EIMX4pvOFJccClbTPMvv2CmM HIxc8uspRYMIzxIiMNMZsVM4wRmC9+HRXcgFblPK13k5Dj3d1cUQXRAhBXukqlJw VDiar3/XwbGI2NFOTjx6uPisLp7F+Kosmxnvk6wqaYNV+3FzE01E7IpPbapyySaJ aghhYVECMf2Xu21kuqBxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1735428194; x=1735514594; bh=z9wStTAzj8M2i0j1Ey508vpRUkTUqUOUUnr xl6PQJ2k=; b=VxRKWO6NBiOI2xGK6QWSxvsofPVmxYySr4/VvGD33WNZ+GFRuyJ 2MuR9pm1yqdmj7CJVuMktAhau4YN5dIkrELAhCR2KIHdHzpH/lIiOmv2rPqTXzGf Ci0GzDPta4VurYji/OOIvomaEwcIuuCnqnRw/V+JoYGT2bhJPflFBY0Jvw688icz lq+jE9ycngivHtGI+JBv57EyXK4Tugq1F/xMi4gafa+OLXq7gkDKrzPHuDv/Hyev VOTsj4uvGxQhEfbCbfhUVIwWksj2YhzqtggVNUu3h9fDoL2BMN50VWhGRxRCl/fe +cokVe44B5m62eEtfbX+kJLO/8EuW3PTfXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvfedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehmtderredttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepjedufedvieejueektddtgedugeffveejheeh ieeulefgfffhleffheefvefhvdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesgh hnuhdrohhrghdprhgtphhtthhopehrphhluhhimhesghhmrghilhdrtghomhdprhgtphht thhopeejgeeltddvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Dec 2024 18:23:13 -0500 (EST) From: Steven Allen To: Eli Zaretskii , Robert Pluim Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <865xn4t4z6.fsf@gnu.org> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> Date: Sat, 28 Dec 2024 15:23:12 -0800 Message-ID: <87v7v3bden.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74902 Cc: 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain I was able to get a GDB backtrace after some button mashing. Let me know if you need anything else. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=gdb.txt Content-Description: GDB Backtrace #0 format_mode_line_unwind_data (target_frame=target_frame@entry=0x58a7d5394680, obuf=, owin=, save_proptrans=save_proptrans@entry=false) at ../../src/xdisp.c:13716 #1 0x000058a7c8feb3c6 in gui_consider_frame_title (frame=XIL(0x58a7d5394685)) at ../../src/xdisp.c:13910 #2 0x000058a7c90d6b89 in SET_FRAME_ICONIFIED (f=0x58a7d5394680, i=1) at ../../src/frame.h:1468 #3 handle_one_xevent (dpyinfo=, event=, finish=0x7ffe4f3c8c3c, hold_quit=) at ../../src/xterm.c:20090 #4 0x000058a7c90e40b8 in XTread_socket (terminal=, hold_quit=0x7ffe4f3c8d60) at ../../src/xterm.c:25738 #5 0x000058a7c912a962 in gobble_input () at ../../src/keyboard.c:7922 #6 0x000058a7c91d7da6 in handle_async_input () at ../../src/keyboard.c:8161 #7 process_pending_signals () at ../../src/keyboard.c:8175 #8 probably_quit () at ../../src/eval.c:1788 #9 0x000058a7c91f7826 in maybe_quit () at ../../src/lisp.h:3956 #10 Fdelq (elt=XIL(0x58a7d5394685), list=) at ../../src/fns.c:2098 #11 0x000058a7c8fbd444 in delete_frame (frame=XIL(0x58a7d5394685), force=XIL(0)) at ../../src/frame.c:2500 #12 0x000058a7c8fbe6c7 in Fdelete_frame (frame=, force=) at ../../src/frame.c:2743 #13 0x000071768fefb9e6 in F77696e646f772d2d64656c657465_window__delete_0 () from /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-523952f2/preloaded/window-0d1b8b93-d9709ebc.eln #14 0x000058a7c91e6d57 in Ffuncall (nargs=4, args=0x7ffe4f3c90f0) at ../../src/eval.c:3079 #15 0x000071768fefc93b in F7265706c6163652d6275666665722d696e2d77696e646f7773_replace_buffer_in_windows_0 () from /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-523952f2/preloaded/window-0d1b8b93-d9709ebc.eln #16 0x000058a7c91e6d57 in Ffuncall (nargs=2, args=0x7ffe4f3c91b0) at ../../src/eval.c:3079 #17 0x000058a7c91528e9 in replace_buffer_in_windows (buffer=XIL(0x58a7d89b4565)) at ../../src/window.c:3647 #18 replace_buffer_in_windows (buffer=XIL(0x58a7d89b4565)) at ../../src/window.c:3642 #19 Fkill_buffer (buffer_or_name=) at ../../src/buffer.c:2012 #20 0x000071768b655462 in F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_20 () from /home/steb/.config/emacs/eln-cache/31.0.50-523952f2/exwm-manage-481a2a54-1f060da2.eln #21 0x000058a7c91e6d57 in Ffuncall (nargs=2, args=0x7ffe4f3c9360) at ../../src/eval.c:3079 #22 0x000058a7c91d7834 in Fapply (nargs=2, args=0x7ffe4f3c9360) at ../../src/eval.c:2708 #23 0x000058a7c91e6d57 in Ffuncall (nargs=3, args=0x7ffe4f3c9358) at ../../src/eval.c:3079 #24 0x000071768e47b468 in F74696d65722d6576656e742d68616e646c6572_timer_event_handler_0 () from /usr/bin/../lib/emacs/31.0.50/native-lisp/31.0.50-523952f2/preloaded/timer-3ee7cfd9-4017b895.eln #25 0x000058a7c91e6d57 in Ffuncall (nargs=2, args=0x7ffe4f3c94a0) at ../../src/eval.c:3079 #26 0x000058a7c911d1ce in timer_check_2 (timers=, idle_timers=) at ../../src/keyboard.c:4804 #27 timer_check () at ../../src/keyboard.c:4869 #28 0x000058a7c930661b in wait_reading_process_output.constprop.1 (time_limit=, nsecs=, read_kbd=-1, do_display=true, just_wait_proc=, wait_proc=, wait_for_cell=) at ../../src/process.c:5446 #29 0x000058a7c8fb60e0 in sit_for (timeout=, reading=, display_option=) at ../../src/dispnew.c:6889 #30 0x000058a7c9127880 in read_char (commandflag=1, map=XIL(0x58a7d5e4b153), prev_event=make_fixnum(27), used_mouse_menu=0x7ffe4f3ca0eb, end_time=0x0) at ../../src/keyboard.c:2925 #31 0x000058a7c92f837e in read_key_sequence.constprop.0 (keybuf=keybuf@entry=0x7ffe4f3ca270, prevent_redisplay=prevent_redisplay@entry=false, disable_text_conversion_p=, fix_current_buffer=, can_return_switch_frame=, dont_downcase_last=, prompt=) at ../../src/keyboard.c:10746 #32 0x000058a7c91196e3 in command_loop_1 () at ../../src/keyboard.c:1424 #33 0x000058a7c91d6977 in internal_condition_case (bfun=0x58a7c91194c0 , handlers=, hfun=0x58a7c91166e0 ) at ../../src/eval.c:1607 #34 0x000058a7c9118a5f in command_loop_2 (handlers=handlers@entry=XIL(0x90)) at ../../src/keyboard.c:1163 #35 0x000058a7c91d68b6 in internal_catch (tag=, func=0x58a7c9118a30 , arg=XIL(0x90)) at ../../src/eval.c:1286 #36 0x000058a7c9118ecb in command_loop () at ../../src/keyboard.c:1141 #37 0x000058a7c9119086 in recursive_edit_1 () at ../../src/keyboard.c:749 #38 0x000058a7c9119330 in Frecursive_edit () at ../../src/keyboard.c:832 #39 0x000058a7c8fa3f8b in main (argc=, argv=) at ../../src/emacs.c:2625 Lisp Backtrace: "window--delete" (0x4f3c90f8) "replace-buffer-in-windows" (0x4f3c91b8) 0xcf2129c0 PVEC_SUBR "apply" (0x4f3c9360) "timer-event-handler" (0x4f3c94a8) Detaching from program: /usr/bin/emacs-31.0.50, process 53461 [Inferior 1 (process 53461) detached] --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 01:51:07 2024 Received: (at 74902) by debbugs.gnu.org; 29 Dec 2024 06:51:07 +0000 Received: from localhost ([127.0.0.1]:53557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRn8l-00064G-2h for submit@debbugs.gnu.org; Sun, 29 Dec 2024 01:51:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRn8j-0005xt-EN for 74902@debbugs.gnu.org; Sun, 29 Dec 2024 01:51:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRn8e-0003gH-2D; Sun, 29 Dec 2024 01:51:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8P2IJRam2MRzSfsh9vuuxA2LhnWUZfogwBP0lttGww8=; b=HHxW0CfIRnwn F0ikJq7koGpVY19g5zNWPCBLx70LDNTuti8Xz/WxKyP6ZXeHvTLKYf0G6GEAXTM2uG1MU2NzvZX7v oNh8wdjQzjG2CGd2haYW1cZ//0f1ASVZZpbodH5g84h10BDVzjzdjnIcM2OhhtA9M1CPHkBrLD6zB 48TBlCNoV9PLNIiWZT+6ScSQAd3TuHe2h6cJXoaKy2NFX3MkxLpphMlL+G4WORm+uze40Zj6I8O6g HOubMEQdqfiJSZtpeu+TIbC/xQeUTPi0F/xqOIhFyjuuXxz2dO1MGBYd+MyMfnUji+dq8I5RQOwsb sqbgKFvInu9mHt0DkiLalw==; Date: Sun, 29 Dec 2024 08:50:57 +0200 Message-Id: <86ldvzq8xa.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <87v7v3bden.fsf@stebalien.com> (message from Steven Allen on Sat, 28 Dec 2024 15:23:12 -0800) Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74902 Cc: rpluim@gmail.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: 74902@debbugs.gnu.org > Date: Sat, 28 Dec 2024 15:23:12 -0800 > > I was able to get a GDB backtrace after some button mashing. Let me know > if you need anything else. > > #0 format_mode_line_unwind_data (target_frame=target_frame@entry=0x58a7d5394680, obuf=, owin=, save_proptrans=save_proptrans@entry=false) at ../../src/xdisp.c:13716 > #1 0x000058a7c8feb3c6 in gui_consider_frame_title (frame=XIL(0x58a7d5394685)) at ../../src/xdisp.c:13910 > #2 0x000058a7c90d6b89 in SET_FRAME_ICONIFIED (f=0x58a7d5394680, i=1) at ../../src/frame.h:1468 > #3 handle_one_xevent (dpyinfo=, event=, finish=0x7ffe4f3c8c3c, hold_quit=) at ../../src/xterm.c:20090 > #4 0x000058a7c90e40b8 in XTread_socket (terminal=, hold_quit=0x7ffe4f3c8d60) at ../../src/xterm.c:25738 > #5 0x000058a7c912a962 in gobble_input () at ../../src/keyboard.c:7922 > #6 0x000058a7c91d7da6 in handle_async_input () at ../../src/keyboard.c:8161 > #7 process_pending_signals () at ../../src/keyboard.c:8175 > #8 probably_quit () at ../../src/eval.c:1788 > #9 0x000058a7c91f7826 in maybe_quit () at ../../src/lisp.h:3956 > #10 Fdelq (elt=XIL(0x58a7d5394685), list=) at ../../src/fns.c:2098 > #11 0x000058a7c8fbd444 in delete_frame (frame=XIL(0x58a7d5394685), force=XIL(0)) at ../../src/frame.c:2500 Thanks. I guess we also need a FRAME_LIVE_P test in gui_consider_frame_title? From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 11:31:15 2024 Received: (at 74902) by debbugs.gnu.org; 31 Dec 2024 16:31:15 +0000 Received: from localhost ([127.0.0.1]:36598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSf9H-0004ET-6Y for submit@debbugs.gnu.org; Tue, 31 Dec 2024 11:31:15 -0500 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:42607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSf9E-0004EE-38 for 74902@debbugs.gnu.org; Tue, 31 Dec 2024 11:31:13 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id EB29E138020B; Tue, 31 Dec 2024 11:31:06 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Tue, 31 Dec 2024 11:31:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1735662666; x= 1735749066; bh=Jkc0CJYZcsgvlk67d+42QfR3ligIFavfPAcrvjwHS30=; b=P Lo1l/KiqHTuFK1OsC9EkwYYSD31mgDxf6OUzyrUQevVMA6sMW4n+aQnbeLrOwdHs aixnOayjwkmHtDr8ZttX6XyvIGCHTD6DZ1DOpPUF/kl2WpDKDbnYUseUxs3W3B3f WV8UeiNwY9h9A5jurTRTibDJ6HS0/F/h2m8f6zshTAlqOvCmtecvWQipFm0geG1B T3xfNDm05EbCMDudmX/BhSbrCnscloCGsYi4a2j/3df6RGb24gPc/IV1+walYY3l gZsIOQ+CgV1BNbkubiBWIsKl2cVUzHwje3PL/x1nAjKuOvxo942Z1dHxYRRgWYvp A5TCa5Ivm6eEGEMb4D92w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1735662666; x=1735749066; bh=Jkc0CJYZcsgvlk67d+42QfR3ligIFavfPAc rvjwHS30=; b=lGCIvBttgdk8X4emDAvEk1kK2ZBrBHMyujDR6rtckyrU9LNV4BC 8zCj1v8np0SWfwW8gIsO0vRJYuIK2CjMY2ehq6AElAiSFrY3FhBbOP3nxREXUsJc Wpsz9bp0otYvw6Z+cR6egJ4MrXhcklEtS5PBwy6X9Gvi3sWdeD1jDbmS3Z/FpHME 1vXDhOD/8rF6YOcFxHE1orXO23et/cLpReawDsutFdyxTl+j0/J6kxeKuZhbEMvu inZIws5cZAc5CZDmLSpa9EbwhkdmZAM9UMfxcTX2cWiND0e9v5S5qrL3aAaWK/pE otSbJcZ4VirGK70hFz2/THCOkW2rxeJABfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvkedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehmtderredttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepieetvdfhffeuhfdtuedtgeefgeeiieetveev gfeufeeivedvheefjefffffgveejnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehs thgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehrphhluhhi mhesghhmrghilhdrtghomhdprhgtphhtthhopeejgeeltddvseguvggssghughhsrdhgnh hurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 Dec 2024 11:31:06 -0500 (EST) From: Steven Allen To: Eli Zaretskii Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <86ldvzq8xa.fsf@gnu.org> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> Date: Tue, 31 Dec 2024 08:31:04 -0800 Message-ID: <877c7fg6gn.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74902 Cc: rpluim@gmail.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks. I guess we also need a FRAME_LIVE_P test in > gui_consider_frame_title? I've attached a patch for that but note that it doesn't actually help in this situation because the frame isn't deleted until: https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 Whereas the crash happens here, 36 lines above: https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Avoid-operating-on-dead-frames-when-updating-titles.patch >From 4f4907bf1657b5128dc045161272c360029c6f6a Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Tue, 31 Dec 2024 07:48:47 -0800 Subject: [PATCH] Avoid operating on dead frames when updating titles * src/xdisp.c (gui_consider_frame_title): Skip over dead/dying frames when updating frame title. (Bug#74902) --- src/xdisp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/xdisp.c b/src/xdisp.c index ceb727d1135..d2ba8b10c80 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -13858,9 +13858,10 @@ gui_consider_frame_title (Lisp_Object frame) struct frame *f = XFRAME (frame); Lisp_Object format_data; - if ((FRAME_WINDOW_P (f) - || FRAME_MINIBUF_ONLY_P (f) - || f->explicit_name) + if (FRAME_LIVE_P (f) + && (FRAME_WINDOW_P (f) + || FRAME_MINIBUF_ONLY_P (f) + || f->explicit_name) && !FRAME_TOOLTIP_P (f)) { /* Do we have more than one visible frame on this X display? */ @@ -13875,6 +13876,9 @@ gui_consider_frame_title (Lisp_Object frame) { struct frame *tf = XFRAME (other_frame); + if (!FRAME_LIVE_P (tf)) + continue; + if (tf != f && FRAME_KBOARD (tf) == FRAME_KBOARD (f) && !FRAME_MINIBUF_ONLY_P (tf) -- 2.47.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 11:53:33 2024 Received: (at 74902) by debbugs.gnu.org; 31 Dec 2024 16:53:33 +0000 Received: from localhost ([127.0.0.1]:36634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSfUq-0005Dl-T5 for submit@debbugs.gnu.org; Tue, 31 Dec 2024 11:53:33 -0500 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:46285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSfUo-0005DX-GR for 74902@debbugs.gnu.org; Tue, 31 Dec 2024 11:53:30 -0500 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 642451140189; Tue, 31 Dec 2024 11:53:25 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Tue, 31 Dec 2024 11:53:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1735664005; x= 1735750405; bh=4q2gm99EqpskYaPlTSf16+qXIHB90PV2vgBfwjwYTXA=; b=n Nxqpl+AA6WHL4plysAV6UXVBgug6OtJ9A2FI3/kc0Ld6bgsVs1GQvXTYiPG1uM58 KoNcg2aW14ExcEBuYVwGuA6ft9UsN62bxVC1h2vzjBb0ga1b7xWmAvLoRgOwtxt5 k2MJdZJLCUOPcuXNwZZ2gjfhXEpg4jglRFy4mj1BPtlB2/uKkQ9TvTaeDQaCtAwH muW3AUkucB1KK6qU4xb7XBbQN3V//loSFSkUBbVdeb57N2L+wRf8vegjBM3g2icY iwfXM3QNzv1Si8e3mLcjlH5s4ZoduqKy3iq6fJpncyja/S60ucleQuF6+IW/St5s Tp6NN0e0HrxwdHmsUxQFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1735664005; x=1735750405; bh=4q2gm99EqpskYaPlTSf16+qXIHB90PV2vgB fwjwYTXA=; b=kYqkUCnC6V5k3GXrNYCTBULowRFDanJzsTMwI54t5nxaQD2HqIJ HpuG3HFZLhGQZVii2gd4miWT1eKO6bwW8u/Rh6Ky6Kgi516Vc2h6XhpdKwGJ+Yos QaKlG++nixL60RZggqYtIrlD4Qa5l/7hBVn20kHGVQjOBnMIxLq5tRpPREZ61EbU Sy1KjchN7sOuN2EJZ2AD6Abx/6PlkO2afGr42LA7LXw8nWxmA6ehJzR9JPYDuxHi qJjdkl1T9n8mYAEGg1fNz+HXg1ZgqeRZ+wulpDavd9oZ0E8Dho8kFJTiL3yDnWvE D9VO488Wqxg4T6QeCsXMAgz/QaLAlUr5cjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvkedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepvdekheekgeelheehgefgudelkeethffhgfeu ffetkeegtddvfeduuddttdejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrphhluhhimh esghhmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphht thhopeejgeeltddvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 Dec 2024 11:53:24 -0500 (EST) From: Steven Allen To: Robert Pluim , Eli Zaretskii Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <87frmn5yu5.fsf@gmail.com> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> Date: Tue, 31 Dec 2024 08:53:23 -0800 Message-ID: <87y0zveqv0.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74902 Cc: 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: > If you do find a reproducer, then based on the trace above I think the > following should fix it: > > diff --git a/src/frame.c b/src/frame.c > index f6053fca3ef..ff9e1d24ea1 100644 > --- a/src/frame.c > +++ b/src/frame.c > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) > delete_all_child_windows (f->root_window); > fset_root_window (f, Qnil); > > + block_input(); > Vframe_list = Fdelq (frame, Vframe_list); > + unblock_input(); > SET_FRAME_VISIBLE (f, 0); > > /* Allow the vector of menu bar contents to be freed in the next >From what I can tell (my reproducer isn't 100% effective), this does indeed fix the issue. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 07:02:39 2025 Received: (at 74902) by debbugs.gnu.org; 4 Jan 2025 12:02:39 +0000 Received: from localhost ([127.0.0.1]:53738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU2rX-00046S-DO for submit@debbugs.gnu.org; Sat, 04 Jan 2025 07:02:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50606) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU2rV-00046E-An for 74902@debbugs.gnu.org; Sat, 04 Jan 2025 07:02:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU2rP-0001uG-Oa; Sat, 04 Jan 2025 07:02:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JHfzwQ1UqYkrnZQRUWCLcjN0x0j8tBiqO8KMoBVJzMQ=; b=C5vKGW+Ldl6d tGAQyOlWEsYQ6zN7f13Z47CgATMeqtdAd8nIl0qyZjNnxOeaVvunsTI07DzRvfzkYk9nqYg5H/Y0q GUxOfhAZaOnVPVYB/5wdbRGIuHyVBlLhCJNQDdMXnn9i966bpTbp68L0RRB5GcnfPfVN0KJr+JDep ddSa30LOqLFNMhPsfx0qTH5FAeMbKdw2MFajnejkGciOHesDiDoiHccIx9DMlt0ek5aiycLa+ehrk fljlwBtLLbPtM+45gHK/MAp8e83FxjwHDmgCIEqV22mXG5oYuX+cBOOmYpzwmt0KfDOXKQ/rhCEIp ff5J/iK0WkCiOSC2H6D8Qg==; Date: Sat, 04 Jan 2025 14:02:28 +0200 Message-Id: <865xmueqi3.fsf@gnu.org> From: Eli Zaretskii To: Steven Allen In-Reply-To: <87y0zveqv0.fsf@stebalien.com> (message from Steven Allen on Tue, 31 Dec 2024 08:53:23 -0800) Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <87y0zveqv0.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74902 Cc: rpluim@gmail.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: 74902@debbugs.gnu.org > Date: Tue, 31 Dec 2024 08:53:23 -0800 > > > Robert Pluim writes: > > If you do find a reproducer, then based on the trace above I think the > > following should fix it: > > > > diff --git a/src/frame.c b/src/frame.c > > index f6053fca3ef..ff9e1d24ea1 100644 > > --- a/src/frame.c > > +++ b/src/frame.c > > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) > > delete_all_child_windows (f->root_window); > > fset_root_window (f, Qnil); > > > > + block_input(); > > Vframe_list = Fdelq (frame, Vframe_list); > > + unblock_input(); > > SET_FRAME_VISIBLE (f, 0); > > > > /* Allow the vector of menu bar contents to be freed in the next > > >From what I can tell (my reproducer isn't 100% effective), this does > indeed fix the issue. Thanks! Robert, please install, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 04:43:51 2025 Received: (at 74902) by debbugs.gnu.org; 7 Jan 2025 09:43:51 +0000 Received: from localhost ([127.0.0.1]:41755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tV67m-0004bS-W0 for submit@debbugs.gnu.org; Tue, 07 Jan 2025 04:43:51 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:45377) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tV67g-0004b3-AZ for 74902@debbugs.gnu.org; Tue, 07 Jan 2025 04:43:45 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-38637614567so6950433f8f.3 for <74902@debbugs.gnu.org>; Tue, 07 Jan 2025 01:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736243014; x=1736847814; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=GKeJaSR0RYfMF5TgLp1Xo2kvyD72ut5Wq4RfQ/+bFD8=; b=Bqb/imeQmzV1aVEDd6vpsn8IpsUFN4Ft1QbHV6jJa0pmEr/oN0wSI6KAjewPYl3LFT ZLtM+uuKvdKIBhx+onNynTq/KFatkjD+vJdyFhl3InDtYWVn3vUOk970KRVDFL61eHyg LPmjVsb/1DKZ3BIcriZ+odGJTvPz1OA9xE/bnjn+flg270LuZss/8ibTzc49QSClqtkM FOEaAQ/UiIvi3+/+hnyMxdfs//KCnel54A8uFJ8b8UfoORCr5C/AVkqZQw8JprX88M9r 0a6Wacka54iElECz79m8SeOHY5ojijvEDnfst8HpJxXgDpST5Xfly+/Mtwhv+sj2kFZt ULaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736243014; x=1736847814; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GKeJaSR0RYfMF5TgLp1Xo2kvyD72ut5Wq4RfQ/+bFD8=; b=jhg/LxgHRxlOkAmtWBO4nCx9lXkdddeYjNfYGMKnV9bm3cjNOX36/NN2aQANhbt7ga PnRISnMB+lgVRIgKO6DfbxQI8TFSBNsACy/YOHN9zn3hJlsmpi9mlQfKAqOhLGCdU8dN QPJkQ0F5TLUQaHuJyc9km7lwCEFei//5nq9z55cLDk6qwRBmErHeZyVwaqaSr0VZzFBG 8NWCnOcIopFb/oGX4agZq1xBz07e9bVlI74HIUsG4zlz6JRgxkPkeIeUeWpLo0kjk3kq wlz35fqhgY1h7NGAhemy/UI7qBkfub2BVWG0C+YRulZZ41dI2jTQaU6VgwjIuwdaCU7o OJnQ== X-Forwarded-Encrypted: i=1; AJvYcCX00VI8NDbWSKyB9Hjr9BMvF73jb1RrjOrgUxC4d0u7Na6seZfX5JgHQBcOxYl/QONqSLDOPQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwsqkpZ1cuG7JRBqiXjxciTpxglptSJY8Olw1qNwTnAR7GlHtaS i50Dq8W5AqE4RAU2puiRqEGy8fKJrXhHal677blLwFLh8XkPCa8ncYm+tw== X-Gm-Gg: ASbGnculGKeJt7gVicikaDf3o2NnIx3RZIlgZ7V6O2iRQGSEcmrBA/HyfctzP98xpK+ Wk5cElpMjma8JYXnwf9YzeEu7U/dQaiTULND5g6C2ll8K+Q4rcz1yzzC1nf/g1blhuoeVKnGmqu xLBr+XGjkJAIn6CcWx/Et1FC7MpL+NDEBrMxkrinKOXMGvFqYTlHrPZAXp3EXSkPPdx2CinWZnm Raw9+uDOwMjpgg+x1/DX6oY7jLPyh8Qfwmo1bxhZEwb X-Google-Smtp-Source: AGHT+IH+pl+axC7Q8eYzj5jfUsJkW+st5lKj+Mz74rmfxZ/r8mvRRoWfOC7Z3AHXupouGzW6qkL8tA== X-Received: by 2002:a05:6000:1ac8:b0:385:f071:a1c9 with SMTP id ffacd0b85a97d-38a224049f1mr47976041f8f.50.1736243013287; Tue, 07 Jan 2025 01:43:33 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:4ac5:eaa5:bd5e:2940]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c847513sm50259665f8f.49.2025.01.07.01.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 01:43:32 -0800 (PST) From: Robert Pluim To: Steven Allen Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <877c7fg6gn.fsf@stebalien.com> (Steven Allen's message of "Tue, 31 Dec 2024 08:31:04 -0800") References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> Date: Tue, 07 Jan 2025 10:43:32 +0100 Message-ID: <874j2bj6wr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74902 Cc: Eli Zaretskii , 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: Steven> Eli Zaretskii writes: >> Thanks. I guess we also need a FRAME_LIVE_P test in >> gui_consider_frame_title? Steven> I've attached a patch for that but note that it doesn't actually help in Steven> this situation because the frame isn't deleted until: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 Steven> Whereas the crash happens here, 36 lines above: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 gui_consider_frame_title looks at Vframe_list, so removing the to-be-deleted frame from it should be enough (unless this crash was with my patch applied?) Robert -- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 06:27:00 2025 Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 11:27:01 +0000 Received: from localhost ([127.0.0.1]:56547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWDAK-0004EX-II for submit@debbugs.gnu.org; Fri, 10 Jan 2025 06:27:00 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:52372) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tWDAI-0004EH-RK for 74902@debbugs.gnu.org; Fri, 10 Jan 2025 06:27:00 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso1513164f8f.0 for <74902@debbugs.gnu.org>; Fri, 10 Jan 2025 03:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736508412; x=1737113212; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=C/eKrlCIiLnd0pNb5458fqOAtf+x5KKwhphuA3bAHiw=; b=OGvEhoZnG7K9CheRCQH5gVQVjYzbUPd6fB++2ftiQBEL2xdleVkMUXBMycM3O5Twdw 8vojSiW4h635CW8UPrAI86ilCpSJvtzkZa1O79n9D3sCXa8IkEVoif+2sKGXKV40O12z qECldbH9VukL280vDLFJp3Czr10I0wOqpgSBt0tHDOezpEcEKoJthFJJsdjsWIs1YR3A D8ceKcfQS6mIYrIM3s/X2XVcYsdbMYjK15mvyJiCT4lBxKRuTA8n48FJfR5+9w5pRBXb WcgbKjJxI0N7NxQuUyd9LtHTqZGxDlUJVLMmJQ9/7vEJ+gb5liccnXJrHuncpFgKue1Y iPnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736508412; x=1737113212; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C/eKrlCIiLnd0pNb5458fqOAtf+x5KKwhphuA3bAHiw=; b=eIxAJwcsdun8VaDCDkcUNFfqxaQkc90ZnaEN260O1eGneEYMYXguLnxdrnew+1y+tR PkaaSssx05ldywGUUeBAAlID1jC//+IdGrqkPn5ts3mXy7Xj9fQLPhGSqwLAu2vKoRwj ewIlvhCKBn2shYla89iktcNSupz6mHf7KHmxnd4IyXxmnNbfGYVilKXSlrn41J4D4YuN mrSxELEwTMW68aDSEEL4kbT1xxxfaa0UKviHeDj1yYVAmcLq0ZMJB8CP6XOn9bIbKtRl XZmHuOsznn268/Z09dGAKWopk9Riw5Ng8TC1ht5gQenxGJwNKDdODXo9bkbffPsFaYgk 4cHQ== X-Forwarded-Encrypted: i=1; AJvYcCVFYa17cjg3vyQedCBgrDAOugjLYnWTmBSqMb0khzxYC+9WIMfWFsiygOGtmPfGY9HZApOEtA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyyMcYxRh1EZzuUMXM4qLxH1VmxjxhM1iEOG4aQrsWE4gtv91gv rS0o9OI9wwepFNHzu1L7o2camBaUTX8zcNJD/BnIlb+kz5vn7Aw8IMsf6w== X-Gm-Gg: ASbGncuw+qvH5mc6K4M/X4t/PhewKRAOQ7fIeUWZM6f+28jPDl+QDG2a5R6KSQSDku2 WvAge+3+eTj3X7SHkZKmHw/WylmiyvwQmenmS2vepvEyFth4TQU0S2UeVgSFmkM3RkQhFtqJaHq wsSnEw2rLW2cY4zVF1FAK13c6A1XikZCsWVRB7vNy8W9E+r2JII3eTg26uzXrfaJ4TJBlE+Zz8t nDeGdrS5QSmqv50CgPRJ0BcmEglDaorStvnNY1P3GEk X-Google-Smtp-Source: AGHT+IGic/0zduwFb3PhuR7JjmBR7zm31Owm1VJh9kcW5uRwj9SzCbBX/4txtGj7m7qxEazd/Q5S5g== X-Received: by 2002:a05:6000:1ac9:b0:385:df73:2f42 with SMTP id ffacd0b85a97d-38a873213dfmr9537498f8f.32.1736508411435; Fri, 10 Jan 2025 03:26:51 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:2075:f98f:a3af:3706]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4c1cf2sm4318868f8f.99.2025.01.10.03.26.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 03:26:50 -0800 (PST) From: Robert Pluim To: Eli Zaretskii , Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <874j2bj6wr.fsf@gmail.com> (Robert Pluim's message of "Tue, 07 Jan 2025 10:43:32 +0100") References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> Date: Fri, 10 Jan 2025 12:26:50 +0100 Message-ID: <87bjweq58l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74902 Cc: Steven Allen , 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 07 Jan 2025 10:43:32 +0100, Robert Pluim said: >>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: Steven> Eli Zaretskii writes: >>> Thanks. I guess we also need a FRAME_LIVE_P test in >>> gui_consider_frame_title? Steven> I've attached a patch for that but note that it doesn't actually help in Steven> this situation because the frame isn't deleted until: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 Steven> Whereas the crash happens here, 36 lines above: Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 Robert> gui_consider_frame_title looks at Vframe_list, so removing the Robert> to-be-deleted frame from it should be enough (unless this crash was Robert> with my patch applied?) Eli, did you still want me to push the change to master? Robert -- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 07:44:28 2025 Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 12:44:28 +0000 Received: from localhost ([127.0.0.1]:56627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWENI-0007r2-85 for submit@debbugs.gnu.org; Fri, 10 Jan 2025 07:44:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33656) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWENF-0007qk-Ec for 74902@debbugs.gnu.org; Fri, 10 Jan 2025 07:44:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWEN8-00087r-Vo; Fri, 10 Jan 2025 07:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3qesjoDpkzGwP46Z0lHvSA6ySxXLIGD9DAXILwXkdEw=; b=UU9dibU7efvA jyX255IW0Roaksyx8YGB0rusApvrHraW9/aCNyW9YrTC7ZYT9EQ2LlRO3nFfjtGIn5cDI3fC5d3w5 MlrlzD/Q2HuUG9CW5b5c4V0HtIjh/4/f8Q34B2SFZK4NQUsQ05yKtA5lOIUQQKZ9hlXtxIhqsG/jn qXDI9vDsuIYiVxEd4mADkUU8QlQSzGJYAg36eIMoXh6ejp9QzqVXRMLLZ6Tv/N0/REJHJHo4cjXGe R8IqibsH8p04s+CkZZvQIJPlJKYZgif7ly6FaWWnEiDRS7jHytjDq2nqLpo9Qw8rdBFDVDvtp7F/R 0bAb+lcbVB2Wzs5UGDDk/w==; Date: Fri, 10 Jan 2025 14:44:13 +0200 Message-Id: <86bjwe2602.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87bjweq58l.fsf@gmail.com> (message from Robert Pluim on Fri, 10 Jan 2025 12:26:50 +0100) Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> <87bjweq58l.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74902 Cc: steven@stebalien.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Steven Allen , 74902@debbugs.gnu.org > Date: Fri, 10 Jan 2025 12:26:50 +0100 > > >>>>> On Tue, 07 Jan 2025 10:43:32 +0100, Robert Pluim said: > > >>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: > Steven> Eli Zaretskii writes: > >>> Thanks. I guess we also need a FRAME_LIVE_P test in > >>> gui_consider_frame_title? > > Steven> I've attached a patch for that but note that it doesn't actually help in > Steven> this situation because the frame isn't deleted until: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 > > Steven> Whereas the crash happens here, 36 lines above: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 > > Robert> gui_consider_frame_title looks at Vframe_list, so removing the > Robert> to-be-deleted frame from it should be enough (unless this crash was > Robert> with my patch applied?) > > Eli, did you still want me to push the change to master? Yes, why not? I don't really understand the last 2 exchanges. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 10:10:39 2025 Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 15:10:39 +0000 Received: from localhost ([127.0.0.1]:58361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWGel-0007LH-HZ for submit@debbugs.gnu.org; Fri, 10 Jan 2025 10:10:39 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:58603) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tWGej-0007Ky-54; Fri, 10 Jan 2025 10:10:37 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-385eed29d17so1181538f8f.0; Fri, 10 Jan 2025 07:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736521830; x=1737126630; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=rsqxP1QD1QQ9uxA+3J2/G11IF8YCHIaGDS3gYj44t9c=; b=fh6Qx7Ew0AmQoAOZrKYkQOxVm1jAHK3jl911mF8/3i6jn9zpQzNQA/3V655AxQ5PeY dbboyTc/W9uZYU+tv1QY+mm5gAFKSRO7rlxmH+pTzpEv8qdwz63YAZ1DHOJ4Ca6zEofY +XVkiEZ0GgqjIAv/ot5rS7Rrw3DiGo4FGSFcsorV9vyfV6FX9+ZC9ZbbAXkZ7/HCftNy KvAkfSIk8TLwA3ar58OYW6vdsSOMSgd91j/pc98JNWDMLEXWQSJPMOms4TZs8Mmj8hfP DiKkkz4y9EdMbrp01b3DqLM0VnolYb9d6OtrhJR6CC9gJpXC7m4KvIlXgSGbxfC0JdXM FE3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736521830; x=1737126630; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rsqxP1QD1QQ9uxA+3J2/G11IF8YCHIaGDS3gYj44t9c=; b=aBMd6JrrHx3pijxGNuXk4kQPjxzB1aneQi5CJy70SP8Y49b6xbSt3mEkx4el5CztvT aSbnyP7vr4Ob0jnXYWsQL6TbKnMiUkhP94FLjHh4CfSty6+MtzH16VUoYgsRVk6pHS7B Xa8YofN5A0u1qdnGFBjb7gDrZPDSE5MH3ehEAuq+iidpqNMOc18KUUtsNXqLRSHf4X1D yHipcmLdcBM1mWwb2Tkh5CFCKrhoK/+TzJiKHe6SouiI6lMWYBvcyCd4CVu5Bv/4JGVo O6+Pd2MISXlpGutYHyfSUEPqFckBIy0z/2opXBsCrqv87FMVJF8IE2LrjUWjOz5KrCqa OQBw== X-Forwarded-Encrypted: i=1; AJvYcCUcnORoumfwMmtJ79t899iPUE5qtyrfTCa9M0NWiqGVvQ/O+jAY660dHR0JZ98TLfUyj/7veT4Xgg==@debbugs.gnu.org, AJvYcCV1M+2l9F0zX3mEgLzVbAEHsDNi7qnIX2sVDT1fpy7844yqlQolixYKNeLryQ4VwuupPY/22Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy2t8F7cBcBybc+WVDGGklznK+BMOKJS/1WjZDSXKD2jzFI6jM9 r5Q26M+IdNt120EwWic3HrXMb/a8SwzhY+3jCGAdN0A6DWr3Qpwqun/AlQ== X-Gm-Gg: ASbGncvQ1MKuE8fYBqTLXZhfRJz0nf1ivXdms+zlrM/tRjHvVDDTcDjeT+0i15XU6Lo j9lVKb4qz/mGVlJJpFcehppWEx4Y7BOCGgie4G3XPv7EsACUfnvj3vJQjhPKtqzh7/sRoZnixf7 vLqR9Tqgm2pQZPqAxgofwAT7LzwtCQKHI7WqG1s45IyMd+R5Ramy6q0CFPfVNU25gPmjjNB8LWK UnWcLSjlUPcWR/Vo3Rqxf+cnawZWxuHW2ZfGLWo0E0b X-Google-Smtp-Source: AGHT+IFWAt5KnRAJetZgbkXLRqRcO13cOVAGC/Ovsh97zBm461Mp4UhllaV0EBrP2o0bar6pMUqyOQ== X-Received: by 2002:a05:6000:4615:b0:385:e013:39ef with SMTP id ffacd0b85a97d-38a872f6993mr9242879f8f.6.1736521830240; Fri, 10 Jan 2025 07:10:30 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb51:709d:7749:6431:b3e8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b81d7sm4758465f8f.73.2025.01.10.07.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 07:10:29 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <86bjwe2602.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jan 2025 14:44:13 +0200") References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> <87bjweq58l.fsf@gmail.com> <86bjwe2602.fsf@gnu.org> Date: Fri, 10 Jan 2025 16:10:29 +0100 Message-ID: <877c72puvu.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74902 Cc: steven@stebalien.com, 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 74902 fixed close 74902 31.1 quit >>>>> On Fri, 10 Jan 2025 14:44:13 +0200, Eli Zaretskii said: >> >> Eli, did you still want me to push the change to master? Eli> Yes, why not? Closing. Committed as 8e9ad92a140 Robert -- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 10 11:19:21 2025 Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 16:19:21 +0000 Received: from localhost ([127.0.0.1]:58509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWHjE-0002UT-Og for submit@debbugs.gnu.org; Fri, 10 Jan 2025 11:19:21 -0500 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:47477) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWHjC-0002UC-Uv for 74902@debbugs.gnu.org; Fri, 10 Jan 2025 11:19:19 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 120BB1140143; Fri, 10 Jan 2025 11:19:13 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Fri, 10 Jan 2025 11:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1736525952; x= 1736612352; bh=gFjniOhwNZZ4vEVHc2ex/zTsy0fiYCmuWQSuQl/L6oM=; b=n DGZG/N9hXKEQzwyqMPyGEi9gRX6bi2E9kj9yeya6RvC5/U65swK/p5qLRWkfhJgW 0YzCaobI5KXQVcF10zsYvd+TLnu4HnuicKRCMK4lrV6Fjh0vPxPgoPKcloJSlOri 3sOg/FevBZVFcZodgWTWiBPd7on2sBpce0RNRPiqyFGyR/caIrB0rVka8DwkReFd LGNYlWcrtngtX9V1NJNlZ7eM3s9vNc/yntozLpR/d71r42j8GlpceVsnNJH9iX24 k9GyQoLTlwY5pfYeGzlP4WyBUEsURvAStVbOKWGymP8nWxM7wyIVFSZkw4s0ZujP mHucpKi4VwfNMiX2H69Vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1736525952; x=1736612352; bh=gFjniOhwNZZ4vEVHc2ex/zTsy0fiYCmuWQS uQl/L6oM=; b=rU+pvplOl4IZc6yWMla8EIH8zYWWPQwm4e0or61uN69KQ1v05ml u2WAym2+U4MrqpbFr8dXK1jfJb4QZG4hVs6/TDRYKkq5f7tN0OS+YznrErHXCMef PkWfXURHmdJnBC0Sfq/FXh9bBeuYdp4BQ9WqesbXYy/pOz833JolVfiSSif1wWRV 5KEbtFJ8bLibrjxhuahQA8LPapfqQwACaZez17SeAps1rmBaR2dbdOn5wY4zvi++ 6RcXKY0tanjWZ+LmaUaLQaCP31ypItZuglwixU0QdB9OSFzJsMMue5xc8+uHxhF9 8cT6k903p3/TRjCPc/VIyD3qzXi2ezcixvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudegkedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepjefffeduvdeifeegveekgefgleehhfffgeel teffteeutdetgfegffehueefkedtnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehs thgvsggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehrphhluhhimhesghhmrghilhdrtghomhdprhgtphhtthhopegv lhhiiiesghhnuhdrohhrghdprhgtphhtthhopeejgeeltddvseguvggssghughhsrdhgnh hurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Jan 2025 11:19:12 -0500 (EST) From: Steven Allen To: Robert Pluim Subject: Re: bug#74902: 31.0.50; Segfault when deleting frames In-Reply-To: <874j2bj6wr.fsf@gmail.com> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> Date: Fri, 10 Jan 2025 08:19:08 -0800 Message-ID: <87plku1w1v.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74902 Cc: Eli Zaretskii , 74902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Robert Pluim writes: >>>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: > > Steven> Eli Zaretskii writes: > >> Thanks. I guess we also need a FRAME_LIVE_P test in > >> gui_consider_frame_title? > > Steven> I've attached a patch for that but note that it doesn't actually help in > Steven> this situation because the frame isn't deleted until: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 > > Steven> Whereas the crash happens here, 36 lines above: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 > > gui_consider_frame_title looks at Vframe_list, so removing the > to-be-deleted frame from it should be enough (unless this crash was > with my patch applied?) The crash was fixed with your patch. Removing the to-be-deleted frame from the frame list earlier sounds like the best approach (maintain an invariant that the frame list will never reference a dead frame) but I don't know if that'll cause other issues. From unknown Tue Jun 17 20:14:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Feb 2025 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator