GNU bug report logs - #74900
[PATCH] Replace (guix build json) with (json) in node build system

Previous Next

Package: guix-patches;

Reported by: Daniel Khodabakhsh <d.khodabakhsh <at> gmail.com>

Date: Sun, 15 Dec 2024 20:31:01 UTC

Severity: normal

Tags: patch

Done: Jelle Licht <jlicht <at> fsfe.org>

Bug is archived. No further changes may be made.

Full log


Message #47 received at 74900 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74900 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>, jlicht <at> fsfe.org,
 d.khodabakhsh <at> gmail.com
Subject: [PATCH v2 4/6] build-system/node: Use test-target argument.
Date: Tue, 18 Feb 2025 00:43:55 +0100
* guix/build/node-build-system.scm (check): Use test-target argument.
---
 guix/build/node-build-system.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm
index ea23d92a05..9967069458 100644
--- a/guix/build/node-build-system.scm
+++ b/guix/build/node-build-system.scm
@@ -319,13 +319,12 @@ (define* (build #:key inputs #:allow-other-keys)
         (format #t "there is no build script to run~%"))
     #t))
 
-(define* (check #:key tests? inputs #:allow-other-keys)
-  "Run 'npm test' if TESTS?"
+(define* (check #:key tests? inputs test-target #:allow-other-keys)
+  "Run 'npm run TEST-TARGET' if TESTS?"
   (if tests?
       (let ((npm (string-append (assoc-ref inputs "node") "/bin/npm")))
-        (invoke npm "test"))
-      (format #t "test suite not run~%"))
-  #t)
+        (invoke npm "run" test-target))
+      (format #t "test suite not run~%")))
 
 (define* (repack #:key inputs #:allow-other-keys)
   (invoke "tar"
-- 
2.48.1





This bug report was last modified 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.