GNU bug report logs - #74881
31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74881: closed (31.0.50; [PATCH] * lisp/vc/ediff-util.el:
 Remove temp files on kill-emacs)
Date: Sat, 28 Dec 2024 12:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 28 Dec 2024 14:41:07 +0200
with message-id <86ldw0rndo.fsf <at> gnu.org>
and subject line Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
has caused the debbugs.gnu.org bug report #74881,
regarding 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74881: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74881
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on
 kill-emacs
Date: Sun, 15 Dec 2024 05:59:40 +0000

[Message part 3 (text/plain, inline)]

The ediff lefts temporary files "/tmp/fineDiff*" when kill emacs during an ediff comparing.

Reproducing steps:

1. echo 0 > /tmp/0; echo 1 > /tmp/1

2. emacs -nw -q -f ediff-files-command /tmp/0 /tmp/1 

on the ediff control buffer, press "n" to move to first difference; there should have two temp files like /tmp/fineDiffA* and /tmp/fineDiffB* were generated by ediff, stay on the ediff buffer (do not press "q" to quit the ediff session). then

3. Press "C-x C-c" or kill-emacs to quit the emacs directly.

Then two temp files /tmp/fineDiff* were left there.

This patch will make sure the temp files be removed when kill-emacs without quitting the ediff session.

[0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 74881-done <at> debbugs.gnu.org
Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp
 files on kill-emacs
Date: Sat, 28 Dec 2024 14:41:07 +0200

> From: Lin Sun <sunlin7 <at> hotmail.com>
> CC: "74881 <at> debbugs.gnu.org" <74881 <at> debbugs.gnu.org>
> Date: Sat, 28 Dec 2024 08:04:52 +0000
> 
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Sent: Friday, December 27, 2024 11:38 PM
> > > +  (let ((inhibit-interaction nil))
> >                                 ^^^
> > This should be t, not nil.
> 
> My apologies for posted the testing code (I toggled t/nil to test the behavior on my local).
> 
> And I attached a new version of the patch, please help review again. Thank you!

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.