GNU bug report logs - #74881
31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs

Previous Next

Full log

Message #23 received at 74881 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 74881 <at> debbugs.gnu.org
Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp
 files on kill-emacs
Date: Sat, 28 Dec 2024 09:38:08 +0200

> From: Lin Sun <sunlin7 <at> hotmail.com>
> CC: "74881 <at> debbugs.gnu.org" <74881 <at> debbugs.gnu.org>
> Date: Fri, 27 Dec 2024 17:34:31 +0000
> 
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Yes, probably.  For a good measure, I'd also bind inhibit-interaction
> > to a non-nil value, to make sure we never ever ask the user anything
> > inside ediff-delete-temp-files.
> 
> Sure, that's will be more reliable. I had attached the modified patch, please help review again. Thank you !
> 
> From 39b23f1b3f3d58569b7fa4742e8fd24e2cc7071f Mon Sep 17 00:00:00 2001
> From: Lin Sun <sunlin7 <at> hotmail.com>
> Date: Sun, 15 Dec 2024 06:52:17 +0000
> Subject: [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs
> 
> ---
>  lisp/vc/ediff-util.el | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el
> index 6038f3eae30..e46dc70218b 100644
> --- a/lisp/vc/ediff-util.el
> +++ b/lisp/vc/ediff-util.el
> @@ -213,6 +213,14 @@ ediff-setup-keymap
>    (fset 'ediff-mode-map ediff-mode-map)
>    (run-hooks 'ediff-keymap-setup-hook))
>  
> +(defun ediff--delete-temp-files-on-kill-emacs ()
> +  "Delete the temp-files associated with the ediff buffers."
> +  (let ((inhibit-interaction nil))
                                ^^^
This should be t, not nil.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.