From unknown Sat Jun 21 05:14:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74881 <74881@debbugs.gnu.org> To: bug#74881 <74881@debbugs.gnu.org> Subject: Status: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Reply-To: bug#74881 <74881@debbugs.gnu.org> Date: Sat, 21 Jun 2025 12:14:18 +0000 retitle 74881 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files o= n kill-emacs reassign 74881 emacs submitter 74881 Lin Sun severity 74881 normal tag 74881 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 00:59:48 2024 Received: (at submit) by debbugs.gnu.org; 15 Dec 2024 05:59:48 +0000 Received: from localhost ([127.0.0.1]:49284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMhfP-0000pV-TO for submit@debbugs.gnu.org; Sun, 15 Dec 2024 00:59:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:44170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMhfO-0000pN-IK for submit@debbugs.gnu.org; Sun, 15 Dec 2024 00:59:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMhfO-0005bH-BJ for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 00:59:46 -0500 Received: from mail-japaneastazolkn190100000.outbound.protection.outlook.com ([2a01:111:f403:d405::] helo=TY3P286CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMhfM-0007Zm-Jy for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2024 00:59:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sv6svi7rINL4uFri5b0IfmLMzpugdaeYlOYwv2+J/rcwaoGVCJSa8OIuIfrMh1EzaBa9Ckr5LQNxeNGCZH7cl61kG1MHa5LlVRKgRR1SOmYx29wANjG29sDqzhS6sd35OxjQyUvqjCCtoMlm0kFva2lzFPCmzZrOXdCFZ6Rqppl+nDO2dm97pI0i/XX0nXGBPUhNTznjteUgJvkF/Wqm5XK9PGGQFsgjTEac80tHrM3VZGVsevnXvcNCXJA13oBKmc3k/rrN8+NcINzIL6IfnRJd7t3wskJoJYfgQTMXmQJB9Hqu/3hU/hTRbrO2z3y89yNkkjT1Tk/mfqC+LSUkFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CTy2qrlrkOlShdraUkxo6H42XfVd7hSf6ffVBpK/CF8=; b=T3FuFxUxDGHeJCv9Osjzq8ZWnyF8Gx2pMhfGuuR1SZL3zW0B4JjoF5IZ6niH1lCCk7Bgk7fMv/rsdu/kI7jR9vdmOuhcKUxoIUnSSb2si1L1KNmjJeWgbrHgWyLZ8tOHysqR9GzsbCHmqb761QqjDc9CTkBrDbl3nYKc/ZDOM0sVyMIPGwUY0E1SJCdGYAbqEtiQ+qGE6jOTlE0oL70dvi4AIMhVDHXMyFZfLfBRyP1pEKuVq11AbnCpXVAKX18t1ovkSkb8j+AE9r39nv2iJ+h2AcI6RVfkNsPDY4MpYQMyLWzALp6vUOaqtO5KRrLIBircYWhiS1H84c35rnm5Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTy2qrlrkOlShdraUkxo6H42XfVd7hSf6ffVBpK/CF8=; b=lqOkgV0QcGZLjkYivg1++shrq7tZGCLDGA2EqYkLuQ5pz5sULWWBf8HE0GqnB2twWUSCAWF94Lpt2EI+zQjtLCIkwBFc33OM4XAtBPB0kLdT2K/4U5mejdsVQfeFL22lLfrMrV6+L0dWKaOZ1rUyrAC0Qgqd6i+ykZ8x2jBtyVbuKycyft4PbZiQUCnlhRCgC64+BVfGWF33W4MkLyDUyqFnUMEc6MDIkR1D7xgA+ztCEo33U5GMaMWJCTrhinDSDpiVUZbzN4sPj7GVifI48A4pR+hjI14fQEbTDR2KZ/2EIm7JpBUyUXc9yukzHlnLgkFRTWPrF7kCLLveUU0cpQ== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by OS3PR01MB8892.jpnprd01.prod.outlook.com (2603:1096:604:17d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Sun, 15 Dec 2024 05:59:41 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8251.015; Sun, 15 Dec 2024 05:59:40 +0000 From: Lin Sun To: "bug-gnu-emacs@gnu.org" Subject: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXA== Date: Sun, 15 Dec 2024 05:59:40 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|OS3PR01MB8892:EE_ x-ms-office365-filtering-correlation-id: edf1aecf-2804-43fa-a1c6-08dd1ccdaa67 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8060799006|15030799003|8062599003|461199028|6092099012|7092599003|15080799006|13095399003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?4TQQFGt2r7ZV0xWAsUskrsArIiLW5uWwwYwXP5c8/+qdIKu0DHCBV0bNop?= =?iso-8859-1?Q?KUkv4VpjVeyK7KahGBE+2taAUNwZscjweaWWbcOoIrzA5Y6hHqddtxifQv?= =?iso-8859-1?Q?OykCbReNm0b98UFoGYTCpN2hHsUmkqhYl/3bOFibkMq5HZeItJvNiAf/lP?= =?iso-8859-1?Q?zV8iMHJdIpob1ApToWcaDUUeMzEvpTnrCJqyaqgXpCa5PfmwyfGceBLUto?= =?iso-8859-1?Q?MXsRjSh+lRXVV/dP/g1GkjAtGjNDKDTq4yPp8UfNpS8ETJcHfn9gUZNwij?= =?iso-8859-1?Q?s0OzeB66krmd2za+Wb+uzcx8Kv+XYpTA2o2h7awWonks/TDleiZFL8M/qj?= =?iso-8859-1?Q?KwTroVWzlFUHI2WV/vj4uWj3d7YdNrXDzRhqeM+AwMsaGLv+HOTRQaHZVd?= =?iso-8859-1?Q?BwfX5cOCGVCwIX0c39pDsWtjFFuKer7bgkpdDQzJkLGaTSpx294udeIcA5?= =?iso-8859-1?Q?9qBbxaDLFrm4VaXPX4cE6phYoSI8UvJNYfwqPtxNuvK/eEG09uMHkqsFQG?= =?iso-8859-1?Q?nXs1DN1POQ5bz4rD8qQ2z9vaIZTskfUrqGo+UB14kD/ljy41x9uM7zVLB7?= =?iso-8859-1?Q?rW0x959zCqlNozFAqVLQ2pGjvA+rNmyLevZG9u2AJ1XnaF5JQePm2loCrC?= =?iso-8859-1?Q?hbU/s41URvtRzycKljsvnNCvKYsNKLMKlCg80eEfRoJpx+0bdiENS+xEJs?= =?iso-8859-1?Q?ec+KXA6Yg8LjmpQ9CobSKk3RC+fvzj6qi4lWig3nAc2M83ugqM48/IGiX1?= =?iso-8859-1?Q?tCMEbiKG4bxeQjNJ871hDIhohN54JLmiXPHiaJOyDKC/jM7oua737dxrzy?= =?iso-8859-1?Q?HBDK66dJ+E9Y2sgvGyJ94zrLk58QyFURNIbpXE2zQnraw10vStaklznRhv?= =?iso-8859-1?Q?VDJpaxwOYLnMHPrYN7jCl8Y38dfk6W7mFdI7o37dccirlg2MwbFC9rKyfJ?= =?iso-8859-1?Q?iydTWt0LgD9BF3bHmFp0qIVfFvNNXpTcUGU26DDcc1JdqJrXbmIhGdLoGT?= =?iso-8859-1?Q?EsaRy9u2JdETNHtQC15AJRJ+oqIrOnR0lFrpwDttAkwhRed9mFf3eRB4GR?= =?iso-8859-1?Q?bzJwCp9Gh7sliqlVwEg4HU/8ncbM1wqfcGtF1XBoylmMBNlgf/ctnSPQuD?= =?iso-8859-1?Q?buDuAolP0wUCah7B+FXHW5tARf8Q5xsBefpMRmNxyiV5mIRf98?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?w1rzcOqSY7OzyOV+sr99uZCf4P9W30brnf5njFNpvUmoUFGNMK0+7dpses?= =?iso-8859-1?Q?VQyjrbb+FpcQ2sFsrBoFg6nPLHm+qsPpIMSEurdLA0sYNmB7cCqeUrvfyO?= =?iso-8859-1?Q?xklQDFExwuBL8pr5q6tdk0cy7Dj/df7ea1zL4itq4DQzOhnHmKVuow3/c/?= =?iso-8859-1?Q?P6GBd1uXFKAjdaCa28pPLtnICFAhaHAKiVlspGfxYINx+Bg/bwOu1DOX2S?= =?iso-8859-1?Q?t9zOJRucdFcNy2gk4Eid7OXl1Y1j5humLhdekSmD6n7Y41d7xJBYSVPOGE?= =?iso-8859-1?Q?cPJYeSDs36NoAEUXS5rB8ItAQePi5cWvjsrxRwzsKBKdQknZagloQZl1e/?= =?iso-8859-1?Q?AKfeor47G80D5vYkWkAgNxnsP3lWleEd3rHLBs9+A+Sx819oZ5a1TztnQT?= =?iso-8859-1?Q?Wr/yAlCxuhniKOkD1GVzi0fVIqLeYHrKj9y+aXbvKt3/a3ueCUWayk4gx3?= =?iso-8859-1?Q?gaHqekEVSUH9zPoMPR5LDahmlMhoYXwHl33neryLReNX4ZYoFy1KbLIQ+X?= =?iso-8859-1?Q?Y4z7+EopaK2rDxqPxYWGLFKmiVdzJkiEOqOKArZd06y6Y44D4FfoM3+0Sk?= =?iso-8859-1?Q?s3HrRFpkCxRCnGzas0I0EQhh7NBr/vgFHStlzni+BzfH4VNgfLw9MNuIwk?= =?iso-8859-1?Q?FM3dL52uF87E6AXJiHJFJivfE7KcbhCb7R7ojVU/t7IOoUYKu0DtSmhFks?= =?iso-8859-1?Q?Zod34TcTvhb6FxPtTZQiwOm3fERFBY4WwZ0OEVIbKD/cJmK9kJ3jKjtyks?= =?iso-8859-1?Q?E84wji2Ax/4TxyuCs1QJIt3nF07TOMvsmY+2ac6z5fjhFbwkGrXR4tOpBi?= =?iso-8859-1?Q?vw2K96f/n1gEbAURrTEaEt2qNYjEZm7/IWjGmuwPtOcu9e8yTVVk3hB+1a?= =?iso-8859-1?Q?to6BQtJlXwyUyRIH6xL1h/9NrXOv9k+YiM1eCFJt2v/nHSlPZSrGLg7Ezw?= =?iso-8859-1?Q?M5iDW5oDt0UJHBLyLzARswdPshgMqgHqo9mWf9iNV1FtH6j3KQlwlfJbdJ?= =?iso-8859-1?Q?CBfl6esu7ipl86FJ2utP3ExyKs1Vy1F6voxoOs+Iw9vUjeQhi/ADSRRoPH?= =?iso-8859-1?Q?RL2juK6RBFe1BMyaRwBz4qSfcOHsKfA7lWQI2QO/Ej7T+2oDOnuK1UnoY2?= =?iso-8859-1?Q?8zPeT9/JjDAZ1wu6EG+QPS+nFLLEMMQzZZbl9HeJMstYPsMyp85dtIAJb7?= =?iso-8859-1?Q?/yW4sX0/MlQnGeY8GOqrTavvnHI7x04rGazLPpezVlgSjdAAV/czBsQfjh?= =?iso-8859-1?Q?8Xb8tZ4ex38Tb0scBtnA=3D=3D?= Content-Type: multipart/mixed; boundary="_002_TYCPR01MB10004D03F975826578C1C923AFB3A2TYCPR01MB10004jp_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: edf1aecf-2804-43fa-a1c6-08dd1ccdaa67 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2024 05:59:40.9080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8892 Received-SPF: pass client-ip=2a01:111:f403:d405::; envelope-from=sunlin7@hotmail.com; helo=TY3P286CU002.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --_002_TYCPR01MB10004D03F975826578C1C923AFB3A2TYCPR01MB10004jp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable The ediff lefts temporary files "/tmp/fineDiff*" when kill emacs during an = ediff comparing.=0A= =0A= Reproducing steps:=0A= =0A= 1. echo 0 > /tmp/0; echo 1 > /tmp/1=0A= =0A= 2. emacs -nw -q -f ediff-files-command /tmp/0 /tmp/1 =0A= =0A= on the ediff control buffer, press "n" to move to first difference; there s= hould have two temp files like /tmp/fineDiffA* and /tmp/fineDiffB*=A0were g= enerated by ediff, stay on the ediff buffer (do not press "q" to quit the e= diff session). then=0A= =0A= 3. Press "C-x C-c" or kill-emacs to quit the emacs directly.=0A= =0A= Then two temp files /tmp/fineDiff* were left there.=0A= =0A= This patch will make sure the temp files be removed when kill-emacs without= quitting the ediff session.= --_002_TYCPR01MB10004D03F975826578C1C923AFB3A2TYCPR01MB10004jp_ Content-Type: text/x-patch; name="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch" Content-Description: 0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch Content-Disposition: attachment; filename="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch"; size=1195; creation-date="Sun, 15 Dec 2024 05:57:20 GMT"; modification-date="Sun, 15 Dec 2024 05:57:20 GMT" Content-Transfer-Encoding: base64 RnJvbSBkZWU5NzUwMTQ0ZGY2Y2RkODI3Mzk3ZjNkOTdlNzRmNTZlMjVlMWZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT dW4sIDE1IERlYyAyMDI0IDA2OjUyOjE3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3Zj L2VkaWZmLXV0aWwuZWw6IFJlbW92ZSB0ZW1wIGZpbGVzIG9uIGtpbGwtZW1hY3MKCi0tLQogbGlz cC92Yy9lZGlmZi11dGlsLmVsIHwgNyArKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC92Yy9lZGlmZi11dGlsLmVsIGIvbGlzcC92Yy9lZGlm Zi11dGlsLmVsCmluZGV4IDYwMzhmM2VhZTMwLi5mYjQ3YjNmNzU2MyAxMDA2NDQKLS0tIGEvbGlz cC92Yy9lZGlmZi11dGlsLmVsCisrKyBiL2xpc3AvdmMvZWRpZmYtdXRpbC5lbApAQCAtMjEzLDYg KzIxMywxMiBAQCBlZGlmZi1zZXR1cC1rZXltYXAKICAgKGZzZXQgJ2VkaWZmLW1vZGUtbWFwIGVk aWZmLW1vZGUtbWFwKQogICAocnVuLWhvb2tzICdlZGlmZi1rZXltYXAtc2V0dXAtaG9vaykpCiAK KyhkZWZ1biBlZGlmZi0tZGVsZXRlLXRlbXAtZmlsZXMtb24ta2lsbC1lbWFjcyAoKQorICAiRGVs ZXRlIHRoZSB0ZW1wLWZpbGVzIGFzc29jaWF0ZWQgd2l0aCB0aGUgZWRpZmYgYnVmZmVycy4iCisg IChkb2xpc3QgKGIgKGJ1ZmZlci1saXN0KSkKKyAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBiCisg ICAgICAod2hlbiAoZXEgbWFqb3ItbW9kZSAnZWRpZmYtbW9kZSkKKyAgICAgICAgKGVkaWZmLWRl bGV0ZS10ZW1wLWZpbGVzKSkpKSkKIAogOzs7IFNldHVwIGZ1bmN0aW9ucwogCkBAIC00ODgsNiAr NDk0LDcgQEAgZWRpZmYtc2V0dXAKICAgICAgIChpZiAoZWRpZmYtYnVmZmVyLWxpdmUtcCBlZGlm Zi1tZXRhLWJ1ZmZlcikKIAkgIChlZGlmZi11cGRhdGUtbWV0YS1idWZmZXIKIAkgICBlZGlmZi1t ZXRhLWJ1ZmZlciBuaWwgZWRpZmYtbWV0YS1zZXNzaW9uLW51bWJlcikpCisgICAgICAoYWRkLWhv b2sgJ2tpbGwtZW1hY3MtaG9vayAjJ2VkaWZmLS1kZWxldGUtdGVtcC1maWxlcy1vbi1raWxsLWVt YWNzKQogICAgICAgKHJ1bi1ob29rcyAnZWRpZmYtc3RhcnR1cC1ob29rKQogICAgICAgKSA7IGV2 YWwgaW4gY29udHJvbC1idWZmZXIKICAgICBjb250cm9sLWJ1ZmZlcikpCi0tIAoyLjM0LjEKCg== --_002_TYCPR01MB10004D03F975826578C1C923AFB3A2TYCPR01MB10004jp_-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 03:04:30 2024 Received: (at 74881) by debbugs.gnu.org; 15 Dec 2024 08:04:30 +0000 Received: from localhost ([127.0.0.1]:49479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMjc5-0007G7-43 for submit@debbugs.gnu.org; Sun, 15 Dec 2024 03:04:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMjc2-0007Ft-Su for 74881@debbugs.gnu.org; Sun, 15 Dec 2024 03:04:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMjbx-00055O-Gt; Sun, 15 Dec 2024 03:04:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tR/Ce645mPDb8+9u7W61j7Uok9kiq/5Xn7GXWQynNjo=; b=rGNRjMjF1C7Z RuSOnUvIt4mRXqvLve+5/8D5+zjX0IGl4X1bVzRy1dci2AQkvszRZSsxdT6iQrGrSd6cr4VBEHuAU 79gy4lJDz09n18i39BwHqHDMw9DFsvWYvuYDeVElrUx1NoqlQiXeLc/BMZ1Wd/omHzHQmHLFIiDYR l51YbAxgjMH7t/Qd04NRZP/OnUyN1ZOvPyCCmoMMRkahvNXxWp8Am034ISykXlAHSNw9WyKvZ2cPr DemDgvy64vl6VCDv1PApz4ntgnGibb8E8YArhRi6U09Bym2SWzV+Dz8L29LGJptO8XFUWPaSIv2kt fYmJoR9Wc28m+b2YgkhX0g==; Date: Sun, 15 Dec 2024 10:04:19 +0200 Message-Id: <86h675s77g.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Sun, 15 Dec 2024 05:59:40 +0000) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881 Cc: 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > Date: Sun, 15 Dec 2024 05:59:40 +0000 > > @@ -488,6 +494,7 @@ ediff-setup > (if (ediff-buffer-live-p ediff-meta-buffer) > (ediff-update-meta-buffer > ediff-meta-buffer nil ediff-meta-session-number)) > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill-emacs) > (run-hooks 'ediff-startup-hook) > ) ; eval in control-buffer > control-buffer)) This should be carefully programmed to avoid preventing Emacs from exiting due to some problem. If ediff-delete-temp-files or one of the functions it calls can signal an error, it should be wrapped by condition-case, and if it or one of its callees can try interacting with the user, we should use kill-emacs-query-functions instead. Alternatively, we could end the Ediff session when Emacs is killed. Bottom line: this is a minor cleanup feature, so we should be very careful not to cause any regressions and problems just because we want to exit more cleanly. (On most systems, files in /tmp are routinely deleted by system's cleanup processes anyway.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 12:25:44 2024 Received: (at 74881) by debbugs.gnu.org; 15 Dec 2024 17:25:44 +0000 Received: from localhost ([127.0.0.1]:51832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMsNA-0000rY-MD for submit@debbugs.gnu.org; Sun, 15 Dec 2024 12:25:44 -0500 Received: from mail-japaneastazolkn19010003.outbound.protection.outlook.com ([52.103.43.3]:47691 helo=TY3P286CU002.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMsN7-0000rE-Uj for 74881@debbugs.gnu.org; Sun, 15 Dec 2024 12:25:38 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xt84XUd9hRtYFFzkp16Qad+cvGHoRLW4W6g7B3CkO8R1KqQxDcXRSaR4iPtUorcefvMa0Kun97RMC9HCXIC3h0/aulD7IiaUY/IqIMZ4viO8jigfC2212hFfaFNaTfXu3+OBss1g1ouoAMZA9OozazoyEvG7rgnHOcLQk03FJhCW9PIbA+2UvN1B/8ICz/FQwK/4zmDoSazod6srjQBtpjriJ68aYqX5wm/eK8PTEQJDeridriIlqxJthHdn9/dfcdhzqPQUCNPrsgaevjRsRQWMY0w9GXkDVEmfMBqyMbj7HVS8OPwzbEs8rfLo+VkpyqQjHx1QDfp0QY3O17Hc6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SYKPWnTGDQWPubT7Ef6ooKsDOvTdQwG6oI0zAr6NBAw=; b=V9D9uZp6/Hkoc07kD1cjvrphHlX6EecEqplkg++bgI+rbpK2Qx2jVR4pNc7CE0TxnMCM6nZjA11xFPqoN4XDi0CuvPig8enizAOIr44yr030kWj2feYdWQ3aob+BvnnCon+d7Epe3u1kiXuvZ5o8Z7XUTM9A/gSc6fRc9hv1w1CgCgfdIBJgzboeOBH2OmzTNFXEGBGX4Yg4ABl1elkLGAilnI0CjIeNzWpOcxNjr5DoD4Koy5iirqYIn45Jmb6DRfj0nBz2nhZWozhZH+vl0yOTAVuj2eKmFitWSzxDaiNCOXLmXVtVCcFYN3WgoRi1C1rscWVacsGlcdZ9RZVYKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SYKPWnTGDQWPubT7Ef6ooKsDOvTdQwG6oI0zAr6NBAw=; b=PDNsUdmpoMqq+wsvVphchXl0zEfd/4TG0vWDTgiTTip3Btc3OCew98LH0UdsnopiIKwdzOZL9IZTXDSwX2djRxlZT+RL8rKURMri69Y0X2+6GD44krS0PX2bS2pBuP3YlzSYzKtfeGfnnd90rxeJ3pRf7sn6FEcXiOURouwbZE7yAwx973PvsMCOhch022FB9j6k1b12wtTcmJ6WoMiHOMs3WvZ4X89F/UVJM8dx6shhZn1Pm+4Qz6vX0tt7XalCnSImHYW37MZ+/6tH6Tfb6eZ53hcTRwmpKCIVUXjp2dEX3EU2pW+lFyhmaCKC7CncotJGh9KokHxRGLWqiOD97w== Received: from TY3PR01MB10013.jpnprd01.prod.outlook.com (2603:1096:400:1de::6) by TYCPR01MB11254.jpnprd01.prod.outlook.com (2603:1096:400:3c1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.21; Sun, 15 Dec 2024 17:25:30 +0000 Received: from TY3PR01MB10013.jpnprd01.prod.outlook.com ([fe80::2b40:e5fd:fbab:bede]) by TY3PR01MB10013.jpnprd01.prod.outlook.com ([fe80::2b40:e5fd:fbab:bede%6]) with mapi id 15.20.8251.015; Sun, 15 Dec 2024 17:25:30 +0000 From: Lin Sun To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4U= Date: Sun, 15 Dec 2024 17:25:29 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> In-Reply-To: <86h675s77g.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TY3PR01MB10013:EE_|TYCPR01MB11254:EE_ x-ms-office365-filtering-correlation-id: e5d4c8df-c322-4cbf-762c-08dd1d2d792b x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|7092599003|19110799003|15030799003|8060799006|461199028|8062599003|102099032|440099028|3412199025; x-microsoft-antispam-message-info: =?iso-8859-1?Q?2VPthi8bpqdOROJDw/DFo7AjbSK3MEJ5j0xq3Xv/N0sqS/hnssEK1Xxlfw?= =?iso-8859-1?Q?igFoXpsbp2tobD+1HKa8fkh/Li6lu8ywGfB3CdFb+hyq4N0iMc/qVwRvgR?= =?iso-8859-1?Q?ZOOuoXgtbZv3fm3eoU7KXxxxmoUJ/cSDujBzrVvBR+v6Na46ZkSSLiWEpg?= =?iso-8859-1?Q?ojQBPgay6Z/yP5ra0cJ3P48Z+JOdGdm66oReqreCLkTvniLcZB2anPzZoD?= =?iso-8859-1?Q?OjUf0MjBlOzLcl5YokgZQwf14VnpXD3zVqqjpMB3XUm9JdL0RKKx8TAfBX?= =?iso-8859-1?Q?5ugLndUjPFNmgH8A1m53d1Qx6CruaxhdQpcfzWmulKZoSrAuUMfLa1jILN?= =?iso-8859-1?Q?+C4Rg5WtJcG8u/qQEdgvyUem5vzseUx8Z87y3hbN5Hta+repI/N0d0EnMV?= =?iso-8859-1?Q?cEL9dEwbMng4eIz/kxMxHwleG3iApFX9ZUzLmduR11ZIghMIHXUkEd+zXo?= =?iso-8859-1?Q?uNepgofhSgn0EpUieEpzE4QrikmH/2O2ScbO8Qu79B2x+PREk4+S1oFYLV?= =?iso-8859-1?Q?tcrRkXQHNC1nQ6Wn0qKrU2UswOBTgAI7YGxMJeoXe+0g2nwRz730Jn8WIi?= =?iso-8859-1?Q?pRVPfecAzI+mSG0b4eUbu6EIdI7ikl1zqa2bP9JB41e9zd3wMDTtBQ4m9X?= =?iso-8859-1?Q?0AuJLHssvDrOTKeDcj3UlN3PEmpc1ex19qV0ZQYFNlkDBCNnJikGV7gZUp?= =?iso-8859-1?Q?qNU1PEFACAmirhYJp9k9KYqwVuY4P8PoMt8/QNMSu0ickrEy8zAV3ZJCYM?= =?iso-8859-1?Q?RKxotL1E4yN3VJA+cAYhyy6sURnNbElCuW2CzNMLrcB6U8vOBxx+0btLin?= =?iso-8859-1?Q?fZf+Stzwi+w6ubyyHAh3nYWknzHPaPL6VVUeCz7xZFfreI4PQapwjpCt8t?= =?iso-8859-1?Q?TD8lhTjT+vDAzQdhlME4ZZNG3dD5E0gZhNKfsSHlpaw/0eEpx7y8APDCFv?= =?iso-8859-1?Q?RDFBHrf87jHA1wWc2xsheIObxY2l3KF8iPrA/Duh+5Whb2sD5jRfvdKlsC?= =?iso-8859-1?Q?7VaRn5sWeP1/maROuoAKOFh2UceTAq9qFUd24impjbR9qkVBeQMX8X5/mg?= =?iso-8859-1?Q?tmHgIyr75Hy6vNMrWKZpmAoh7KvQuUZjRdV1eWUpzCCa?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DH+7qN26rx/SFP1dKXPqXK4Y49/NGaMoezzi8ZkhcWt30o+IT/zE9XYxET?= =?iso-8859-1?Q?lbWgq23qMmXhsT6N02Z2G5igyJ7JWZz/kLMBnRZG01qAP6BHrkda5DGhtQ?= =?iso-8859-1?Q?6VXX0NDtasJEFhrE2q8j80y5MqXhio185vTC4sgbi8ESIDdKgMF2F9ShUa?= =?iso-8859-1?Q?RV+NH/uiy5/IMTzkaHbRMR5HLfa7kGvzHgfxIXbNKSO7HHyWZUCjHCLij3?= =?iso-8859-1?Q?FvXQ5o48cBeCYNsQKVTcwsDI1Wc7OVl+4FSbcNfHX32BOFmnG8g6mwuDWf?= =?iso-8859-1?Q?j/jRywvsOGmcrkk9e0XI2DBRhp6CoQ7AxZWFbdChbEwQLi6kSXTzmOeZE+?= =?iso-8859-1?Q?u21tqjAu9E0/U/ur6axjVziBqInDxEJWUQI+lQoBaonlGSmpupP2DXLehi?= =?iso-8859-1?Q?jt41Wvz3Sgie2C3k5Iak6KEZFiuye/XDA3h6juIdIFuEJmWFVYd4N/I28K?= =?iso-8859-1?Q?pYbvxqasGwuBmPEupG+Adv1k1vd/p+IuYf0bFzU5X0gbrUqoByAfzMvcNh?= =?iso-8859-1?Q?iY9ELWtjBDm+GlG77Y7RourqY/Gmd5MrYn+YBrxTWKkdSuBWx1dXgOT3iF?= =?iso-8859-1?Q?gvBjCqgMbF6SkDnlrrTaBQ3aDo6LRyX5NmJcoAJfLm4EZWJw4lYl4O2M1l?= =?iso-8859-1?Q?6ipSZej9ASXPNH3BkQtdL7tI/A0egrS30J66i2sJYIbRYoxzo0ey/DtKF7?= =?iso-8859-1?Q?qcO++xVbdsUIsRvDfpkZYruN+TFC41dvLpeNiSrF2dFaT4MXT/J1xErPS0?= =?iso-8859-1?Q?9Z02f5yUfQsn/M65qDZaYKNN/wxyua7QYzN83BGR0BeAh+R6+Z4jXRWsw7?= =?iso-8859-1?Q?j2oA6jlVv30FxVezJSvK5MxQHT9wvpdPUTYNXGg58ZPYcJ5Nw8LbgsFU4p?= =?iso-8859-1?Q?lnP9eJt64lYhR6ui5IUilX4oBD/NH1aPXIA/NQ0xBHzQBJ++tQUxATzn0w?= =?iso-8859-1?Q?zjY8LUh9zCE5VOIZ7TDS3T8vT6aWmcQv2dnlIcKB57uFZUXnqI7nVhNaVo?= =?iso-8859-1?Q?7Cvt9gIa6YIMEr0rOoAlSNVu45y7t2bUA0/CU3g4RKfJhPpxjFSCsOrsh8?= =?iso-8859-1?Q?PNeNvqBv8d8PnvD4JJ20ooPUrPlZMMv+QRjo1t164HAAiMShC9pg7VM+O+?= =?iso-8859-1?Q?snJGR7J8q4Th3k+G5H6/dWZPNV+pdazyRS8THTsCqp/y43xhIgBt2B1hmV?= =?iso-8859-1?Q?8KKI79whWFn4FrQxThjEX+NCWGnwQLNOC9VxmqJT2BMMMF1DuP8nT49Hzn?= =?iso-8859-1?Q?Tc+TER6zi8X14gaNgg2Q=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TY3PR01MB10013.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: e5d4c8df-c322-4cbf-762c-08dd1d2d792b X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2024 17:25:29.9874 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11254 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881 Cc: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > From:=A0Eli Zaretskii =0A= > Sent:=A0Sunday, December 15, 2024 12:04 AM=0A= > > From: Lin Sun =0A= > > Date: Sun, 15 Dec 2024 05:59:40 +0000=0A= > >=0A= > > @@ -488,6 +494,7 @@ ediff-setup=0A= > >=A0=A0=A0=A0=A0=A0=A0 (if (ediff-buffer-live-p ediff-meta-buffer)=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0 (ediff-update-meta-buffer=0A= > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ediff-meta-buffer nil ediff-meta-session-= number))=0A= > > +=A0=A0=A0=A0=A0 (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-= on-kill-emacs)=0A= > >=A0=A0=A0=A0=A0=A0=A0 (run-hooks 'ediff-startup-hook)=0A= > >=A0=A0=A0=A0=A0=A0=A0 ) ; eval in control-buffer=0A= > >=A0=A0=A0=A0=A0 control-buffer))=0A= >=0A= > This should be carefully programmed to avoid preventing Emacs from=0A= > exiting due to some problem.=A0 If ediff-delete-temp-files or one of the= =0A= > functions it calls can signal an error, it should be wrapped by=0A= > condition-case, and if it or one of its callees can try interacting=0A= > with the user, we should use kill-emacs-query-functions instead.=0A= =0A= The function ediff-delete-temp-files was called at the tail of Ediff quit = routine, =0A= will be also safe on kill-emacs routine, and can confirm it dose not intera= ctive =0A= with the user. Actually it deletes the temp files created by Ediff-mode, sh= ould =0A= has full privilege to do its job.=0A= =0A= > Alternatively, we could end the Ediff session when Emacs is killed.=0A= =0A= It maybe heavy to end the Ediff session if the user choose =0A= `ediff-setup-windows-plain` as the `ediff-window-setup-function` for a grap= hic =0A= frame, then ending a Ediff session will trigger emacs graphic frames layout= change =0A= (Ediff will restore frames layout to the one before its startup). So here = we just try =0A= clean up the temp files to avoid the heavy works.=0A= =0A= > Bottom line: this is a minor cleanup feature, so we should be very=0A= > careful not to cause any regressions and problems just because we want=0A= > to exit more cleanly.=A0 (On most systems, files in /tmp are routinely=0A= > deleted by system's cleanup processes anyway.)=0A= =0A= Agree and calling the ediff-delete-temp-files should only for the scenario = =0A= that user kill emacs during an Ediff-session, otherwise it will do nothing.= =0A= =0A= Thank you.= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 00:39:08 2024 Received: (at 74881) by debbugs.gnu.org; 27 Dec 2024 05:39:08 +0000 Received: from localhost ([127.0.0.1]:44382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR33z-000388-RZ for submit@debbugs.gnu.org; Fri, 27 Dec 2024 00:39:08 -0500 Received: from mail-japanwestazolkn19010006.outbound.protection.outlook.com ([52.103.66.6]:18030 helo=OS0P286CU011.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR33x-00037Z-LE for 74881@debbugs.gnu.org; Fri, 27 Dec 2024 00:39:06 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Vn3rgVnJzkwGNBa2Te+/rFc4U4H2ueOpcobXG2M/3FBDAb1YqhO0xNG5DWcbrDCGgp87jYLDb9ba/s2xj99YAcFPH9VfQqkRtSp4HsliMZoG5xCu4FXg8Rl7j8jRhA9t2irjjIk0DpJ0mmEH0TVSXblvXf8QM2NSbFTjL++H163jXSCGTWrYCJDuDLP3IkGdhg0H5WMVkeheJMnmu9wNkQiEEhUsaS7ut8IBcN23CYR7YGRd0YL99802IUKIGQD+c7aBeEqHF7WN3QEj3e7Aqr8OH1WZM9/2QWx+NezI7SAtBKVnIsCbErgxwrhQ6zpeo4yPVExoCgdUkkAt8nO3tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eIMcBQsQKowbwukUlv3D8Sn/dVUhy9i3uZIxkHjUgbY=; b=TKMTGe+3tYuaMQUGzZStPw2xlLcCCI5rpSv01W1Z9L4NzikPfb8wOdKIkfHmBDTCAIDfqAEUJLl3jFBf7/9m8bIDS1VTJsKQR0I5qMotg64NKQE5wYNCAcQLPjyhiMmbFX88Tngz7DWjPsH/yhK4BQDq5oELHCbJ3eDrwUNSe0d0OYJLjAkq/zqkogFWVYcX74EwCZjBBNsXfJU/mwidd4eX0z1WTTvt1tuN/GRnuT7cNo/WR+MDNu0/R3EcrV2DkGN9QcAUQQVsOTT38AIKNZrzfKPES45uPkiiRYSY0IC1M+1E3mritWFint/J1XTUDDErWZCfBteVA6oNp7Dgow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eIMcBQsQKowbwukUlv3D8Sn/dVUhy9i3uZIxkHjUgbY=; b=WRvGY1vEWOXfeR50iiWMKKG1MA8mWQjMW6S0+VyzAXRFMpWhFjnmQBsHElSRqU4J78Izl7tQ4Fls3jhvRoWk9rgU+CLqzAyc1ClWMyx7LR+pjcsn5kQnzUw9XY0qUzY18rdTFSouPerM5LP5XaNPzll8pAdgCvueDysCJ7AzHI9xfhaGxeXmthjmaTHZfXwolRTBq3riRshmc8agF98SYo02KBFx2tDHFvTSPQlchUG2tHqTrljkjvD0V1dpJkWL5MNl8WdLkqgrfrZgdW/hF0qaAgssgNeeVdLZTYsww9Yovy7PVyz7pA4wt53wfQE+SYLxgwtG0r2WTwKyl8CD0w== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by TY4PR01MB12719.jpnprd01.prod.outlook.com (2603:1096:405:1e9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.15; Fri, 27 Dec 2024 05:38:57 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Fri, 27 Dec 2024 05:38:57 +0000 From: Lin Sun To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpg== Date: Fri, 27 Dec 2024 05:38:57 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TY4PR01MB12719:EE_ x-ms-office365-filtering-correlation-id: 71ccb613-efb2-4c8c-5ec6-08dd2638c230 x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|461199028|8060799006|8062599003|15030799003|7092599003|19110799003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?GQ+NxDi4qc/aWfl7mcP81qTGlYKmFqPold0Dn9x2a/msVkwGNI6IkHIxRL?= =?iso-8859-1?Q?0s6pyePZVJVtC1BcJ45m0bId1b+9rxoLaFFgnHpW/rt8N27dD6dlZ5jU8Q?= =?iso-8859-1?Q?CcguSMIA6LR5m/W3aDckSbzXxykHIvJsxUjYLT5twS0yzFBdinCrkV3K3T?= =?iso-8859-1?Q?pyT/NJpRmMkjbu5wIdj55Oi3W4jpk9hQug8xZMqBZSPfPkwngZf5HHOkxJ?= =?iso-8859-1?Q?1vxv5yKQsl5DDggfOQT8LH2PMSTU378kv+7GgsFqRJhjcO6tOi2s+tq+/3?= =?iso-8859-1?Q?YBLRQNIVu+S2c4bgJBDW+uAqOqZ8YRBcQiTXn67eyCdRQDrBXjwakcISgk?= =?iso-8859-1?Q?21HMrDcjAGIc6sF7dDMJxb78qUPjyEcz+6saFYeX3V+/eeKkg4wQxft6zx?= =?iso-8859-1?Q?y8201fP60jFvcYXlsj3GBiVuX7CZTGUNHFnWGLFJ8pm7CaOV7hx7mvr4bn?= =?iso-8859-1?Q?UZkD0OoZhy7fStinmvncJwQYGGO7LfyPPqFAsUnRdbQ/eB+vKnED24YJob?= =?iso-8859-1?Q?gVt8e7hu6dOtgT/Ljg8nNpfqOx7mJmz8vIWcCSvy4OQ0lKIHyIZDDKdfav?= =?iso-8859-1?Q?KmVF5biYoJYChYDb0UlOptOQT/8CfCj0t/NpNsIiQOqdOKWjA4fB0uy2dp?= =?iso-8859-1?Q?CAv2MrskUuToKYK+1KU5fX59qpv+OC2B9z9VuNPovpJ2I7BSDOPsmHJ9HL?= =?iso-8859-1?Q?OVfCwceUmCB+gtFOYDexf3mS6ZNDyWKLlih3Yk5W/fctf3PizwG6ik/UPY?= =?iso-8859-1?Q?BHIBO5BSOYmOnMRRVNx6FWHOVPyuSHiyH5EKUyXfB/+WSDOlrejNq02ZOg?= =?iso-8859-1?Q?SsrCUEciHE5wyDSlY2QOdWMy+AfVx1NFQQZb1MWMZ2eKK90p6qFpK2eZLp?= =?iso-8859-1?Q?DhZQmptskAW3YahYloL4gtIf+c8m301yZWAFNqbLq0ea9Mle0b/G8ypJs6?= =?iso-8859-1?Q?CxIiBKKmz5NE8eN2qWdZ8AAtaIYQgAfzYk2keoUZDapoz4mf/wjXFjMk5O?= =?iso-8859-1?Q?i7QHAjscIBESU10yycVCQq2jA6FVBmIVSkogiN8npM7C2tt0uXFwBp4nAM?= =?iso-8859-1?Q?xOBuoOdM1/UaMTx7AsZS8uR7LgbNkP9NpmOLyQPCDb+m5H4z++tVb/IXwE?= =?iso-8859-1?Q?Isgre51bOrqQbzHaG1d+x+KQV9gFY=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?fzCxUB7UZzXbnmxv1dzHFjUo7SlwInuUfQrJAmPtEk7k7NeCROE815J6ow?= =?iso-8859-1?Q?ka7OE40lU1UD8eC6FFNzoo/p2Q/KwejmUhJVAEFq4zVjQKx38S7RK2JopG?= =?iso-8859-1?Q?Rqr+ZA3wtqj70CmaEeIxvMyvTY+ZvK/pHnGkDKBWQpPCFL0/iw8Zf0kLgM?= =?iso-8859-1?Q?jldCM6XUb8qbUYBwVsPLECLKFD7gc6JLCrQ8E4URc+5fNzOU3wFaQf81TU?= =?iso-8859-1?Q?E4Why8518WHYDjzNJuNRdyox84Ge25dB1aN5J38oUmNSBr21Ujm1LuupZq?= =?iso-8859-1?Q?r79ylLFuKYBJ4aN19rm2+dPFNJHGAlM/smnhaxlHVvrRfwsv7GGnGh8pQo?= =?iso-8859-1?Q?a22Ra03VBnyQzqv6ukiGLTWzmRLQyCiHv0bvERRMSdGrbXfnvMPHsCSaxc?= =?iso-8859-1?Q?YrBHDJBMOvHpLYIz06fTtU0KswLo4CA9TG75nC9zKYQplTlj+psCBpFJsw?= =?iso-8859-1?Q?1LkF5Fvv/o8IqbRSV5alWjFijjPWiz1v8SePbNWHymWeGMuZTEffVyWfpW?= =?iso-8859-1?Q?SWB/8dYX+LAZnBr/WXLczO96Mg9Gzt58qMDm5j+ZfK9ywvqa0bbhMpeVd+?= =?iso-8859-1?Q?xiHI2GGkc9o8qxIigOGmWoiZ9ESk1erIY5FjARQNG7pBYYKQKtmidCURdt?= =?iso-8859-1?Q?1GArmZjroggFKv9fwJhSpmJNQ8TwOpTQ0/zr48fPm191SqSl2gvRvIqN1m?= =?iso-8859-1?Q?Y+llZU+oRfPqwt/zglD/l2+QVLnBKnU8oE4jccrJYbdwhFTgkcAMVNpnAV?= =?iso-8859-1?Q?cY8BTtG++Tc5SkibJEWgJQ09N7n6nExifStLpphq6uq6GMZ12sNtqRPPS4?= =?iso-8859-1?Q?cdgW7kWOCPjz1pm3HUF54sWZcVKT8K5PADBfWeO7nbW7kMoIO13wM412vW?= =?iso-8859-1?Q?PI8LxRcXkhwv1Nxxs58WAMWB9QzEQn9k0i3Akyfti3/CESVjyjqV7gehUm?= =?iso-8859-1?Q?wDDNPknNlYrQkvJ1gije6dfNdxGt9zAFiW8r1iPiJvQHAGMtbcQLXDtg1E?= =?iso-8859-1?Q?BHU2yhGMfskKEIumASkCEeEexeT/5TpY9eDOBMBdx3qU+wcqwOskJ+Hazb?= =?iso-8859-1?Q?TER510v+3fKUdeu44u6Qtd4DQFOxH0vVDuPzwa1/Z6Lb8/7WK5GJj9q0Ha?= =?iso-8859-1?Q?iatldOZAFsG899rtj7rXUt9VaUoJ4+RcDGMWhMVIop/HTW6fyIsZVo1HqU?= =?iso-8859-1?Q?rDnIhB2G0pne7qYczb/RY34hHOB///DFQngEdfPeILlrI8jwdaXU/LnSQc?= =?iso-8859-1?Q?xdxw5DzuqhmshxzXcgJA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 71ccb613-efb2-4c8c-5ec6-08dd2638c230 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2024 05:38:57.4114 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4PR01MB12719 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 74881 Cc: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Eli,=0A= =0A= I checked the "ediff-delete-temp-files", it should be safe for executing.= =A0 Is it more safe to wrap it with `ignore-errors`=A0? Like: =0A= =0A= +(defun ediff--delete-temp-files-on-kill-emacs ()=0A= + "Delete the temp-files associated with the ediff buffers."=0A= + (dolist (b (buffer-list))=0A= + (with-current-buffer b=0A= + (when (eq major-mode 'ediff-mode)=0A= + (ignore-errors (ediff-delete-temp-files))))))=0A= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 03:10:47 2024 Received: (at 74881) by debbugs.gnu.org; 27 Dec 2024 08:10:47 +0000 Received: from localhost ([127.0.0.1]:44582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR5Ql-0002I1-Fh for submit@debbugs.gnu.org; Fri, 27 Dec 2024 03:10:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tR5Qj-0002Hi-As for 74881@debbugs.gnu.org; Fri, 27 Dec 2024 03:10:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tR5Qd-0002rv-Sz; Fri, 27 Dec 2024 03:10:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=uL1x35dj5qXuU7yF+JGNTdXmoiLer5XrCGbSGaZHIGE=; b=pwWNpheRy1BR1tq1R9Y1 3fw4TbRz8kjTeoEhYGLSfb9JD7HxjgRwZ5/026ae0IYhdColzYJMdgADqCFFA2tnjBtXpoQ6vqsTx MK2/6gs3GJJt+75tqZrqco80dw3y9/1HUFKyDOxn2GG3mp2oPjUtZUTMiegpCc95MLdsVTtsC9f0r G2P1FMlnVz6lw4CAaKQEq7M3ZYLS/sPA0f8beURGoMb0hic72T3LUFOVup8KPO/GV0zai7wIA2kU9 rh/EVNUv/elIzXx4uS9urdZznnlFWAunDEv7bZ5mYOb+H8ki6IZZ+s4kicJg2Fe0owSnUbnekiS05 bZhPVLJvcPv51g==; Date: Fri, 27 Dec 2024 10:10:37 +0200 Message-Id: <864j2py29u.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Fri, 27 Dec 2024 05:38:57 +0000) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881 Cc: 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > CC: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> > Date: Fri, 27 Dec 2024 05:38:57 +0000 > > Hi Eli, > > I checked the "ediff-delete-temp-files", it should be safe for executing.  Is it more safe to wrap it with `ignore-errors` ? Like: > > +(defun ediff--delete-temp-files-on-kill-emacs () > + "Delete the temp-files associated with the ediff buffers." > + (dolist (b (buffer-list)) > + (with-current-buffer b > + (when (eq major-mode 'ediff-mode) > + (ignore-errors (ediff-delete-temp-files)))))) > Yes, probably. For a good measure, I'd also bind inhibit-interaction to a non-nil value, to make sure we never ever ask the user anything inside ediff-delete-temp-files. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 12:35:01 2024 Received: (at 74881) by debbugs.gnu.org; 27 Dec 2024 17:35:01 +0000 Received: from localhost ([127.0.0.1]:47431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tREEm-0005PI-Rk for submit@debbugs.gnu.org; Fri, 27 Dec 2024 12:35:01 -0500 Received: from mail-japaneastazolkn19011027.outbound.protection.outlook.com ([52.103.43.27]:15527 helo=TYVP286CU001.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tREEj-0005Ot-Qd for 74881@debbugs.gnu.org; Fri, 27 Dec 2024 12:34:58 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aqO7vF+aqB6BUIajvL4Igz2VyKUvMq4TBRIAAThGKlXLbicL/Isdfqo6+WjdIQuDfYxh4edR4RwEfN1GzM5DjR9kPOTx7ox4HCqwhek+gcB5VS8Wp68kMUdtPcbWmqnEtOiXCbEZVCDdHWe2r6DNldpMi26gCZfRuaRGfy7rLSGUWTC08Pnhm5EUmjm6kFeUqVhOmsmKB8iSO5g4+xZgwFCBcjjcUTvcB5y6gJTgvmy2PdT1QvjB51X1/q36bxxzGd6YoSHUV7e11aYucGg3s02PydR2zeZAJ3FRWlT26gX3X7a+u9WsVPgMH+8ab/lpZcue320rs4aRlyDDYWkjTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9vv5lnqOI57jMn7tNNrVbYwVDVUia+6l0HHpg8rQT/o=; b=cv6DbaHOtxZmtIRddsUhqBDMkzi076b6sthW5oy0NPHHPrqFUStFY0DmKabnKoQhDcHLMBz6Y9VLNUm97O6az5n34vwpsAnd/THdzfEUH8aNKpO1woR59RrUDH7+VNHSsPunhcjLM3ziczTS1kRqy8Mb7GzeLDgERiapBiUs3LKb1Z0SDGIfW1HbP0FyQQypGcb7OSuWTBccmNQxIBzzavBP8L6PXHMrTCRGyElCcfwntT0RP+5kcG83bcI8pRztGQ32EhYliIhn6MdOemrdbduJd/Rac3lWQgAW0GOJwLM0NmJZpZvwWjh4VpsQfdJXZORNcTvCa20RQaAkJ+VIQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9vv5lnqOI57jMn7tNNrVbYwVDVUia+6l0HHpg8rQT/o=; b=APqLgLrCDpybK8864jcGV6rHTdKyhCv+8GyqljceH58MEpu78+6w5on16BdkGcIrH83qtBJ7qa6RBaDr7HgMM9VQpvTSXXifgFwmBO/jKbVeZ0b88c+twfXmAXDifmammw0dv+wopBIOrXB0kfy9gWmRD8eC6lGD3zHSlQnjERjHlslXXz3X2kdFi9fsMPgSmcz4TE43IW+3vrd6lq1SAiBV5Uv57Cfqc97VJc7fxGw3zU9Ja29eaBeoXpd7CRv88hFwXlaQ64uoFOACASVmtIxfETAomIcH3dmckZPGPa0O2TDtYTQbNJaJAngvx5N8Fv7MyNl3yVSZQU0zdcMZ3A== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by OSCPR01MB13313.jpnprd01.prod.outlook.com (2603:1096:604:352::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.16; Fri, 27 Dec 2024 17:34:31 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Fri, 27 Dec 2024 17:34:31 +0000 From: Lin Sun To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWw= Date: Fri, 27 Dec 2024 17:34:31 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> In-Reply-To: <864j2py29u.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|OSCPR01MB13313:EE_ x-ms-office365-filtering-correlation-id: aa5ef5a8-1d14-49a1-9379-08dd269cb908 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|15080799006|15030799003|8060799006|8062599003|461199028|7092599003|6092099012|3412199025|102099032|440099028|13095399003; x-microsoft-antispam-message-info: =?iso-8859-1?Q?CKtsETVhUjSrDicpFdAbuugS8pMrej6fmY6KCLI38KXeo9dNeVsJGRnuvr?= =?iso-8859-1?Q?4mHkgf2nBaTa7zjdUaxphW+zOIjOUnQiqfI59RYEbGNzsO8VGE/Dx7a8wK?= =?iso-8859-1?Q?ErkxGVnivWZGkO9FOW5o0AAFRG87CnTad7RhOEEn8v5ea5Ycwz2kf03wwY?= =?iso-8859-1?Q?Vx/5Zj0xHSUrSHh4kU7NjIbipb7IPkUtih/bgqKbzXV+QRQ7a2TjjKhtSD?= =?iso-8859-1?Q?RazywWxVefBOWxDvwlbcH1Rx1vNShaiNbs9x2bkth0XX/fmBoToOL/6eG1?= =?iso-8859-1?Q?APluMxvENynavMM8PfrRaVISR7TzoQaqdh3CtRHsj71z1JM8D5SZkDTZX0?= =?iso-8859-1?Q?CXJXzzYN0HQhDvfwGvNwlj78sdHNY9X/KoQriBfF3cSovKGEkFvMpxoTKW?= =?iso-8859-1?Q?bkIoeSgBMOgnvR8j64uzyFcSweBTIK5Q259clj878hc50hQR5dLc+SHAiY?= =?iso-8859-1?Q?5m218MkQ99or0MYAvLDrLJ2y879Jw/u8EFvHvqX4x8D5PqxyBS/kVghLgx?= =?iso-8859-1?Q?eAy1+KCsdkMIYOvcR61oNMVZlbY7urvWFyeNtFKK6QLor9sfS7lnXoOjHl?= =?iso-8859-1?Q?UcIUSuCthamtPOq6hfrrXxE7R8R8rFZ4i50KGwvqN2tHtmyV2JBTn5HHcU?= =?iso-8859-1?Q?cnpHaLYACSYllRjmNC+4JTPJ6QuTDVfH62oT2nedfPxG1oj4IvZIsl4vaB?= =?iso-8859-1?Q?rDLP5YW1rWQb5aXGFgBrOsAmjeM8Fi+Wp9et0Jso0UCeKcMZuBaO9iGJAO?= =?iso-8859-1?Q?MyQSrHEc1rxYK0+JsZhkk7dkG3BvBL3GW/tu4TPs+XE+ZG3hi6DonoUk/j?= =?iso-8859-1?Q?0cJvRLqXthGIv0+ZQKDIYsqMPS2c98K1o0105t7+cFk1/Z10EcZ51JITG6?= =?iso-8859-1?Q?IkPSj9BtUB7SYiVchRXfNtzTGMJpWaTSAPaV4jkuKB8QLG4ydNUgaQi24p?= =?iso-8859-1?Q?NwDPWy8ctqV+lQcck9C0tv8ORiT5M0wz+nJLv/BNKE83yjWgZhCw2V0hlW?= =?iso-8859-1?Q?FPCsL4qiP2HuhqrMVprZ8Cj002SKwINkLc8DWp+YPJIudhLcnsF312Fmtb?= =?iso-8859-1?Q?8EXRs+x/BgUkRpVWWBhUHGZVnWDKBsEugmKard7FKv6XXWF94zZGC10IuJ?= =?iso-8859-1?Q?v7cvsHBDL4fT/R5OYurQLvaOr/u52/dLku3tW5f6BwObjr8igyTkdQBKDq?= =?iso-8859-1?Q?SMJLa+v2yydUP/PXSbUNGQ0/lJLxEeLc2CY=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ewHmS9icAL3TmL1B0mjdrZ0tlyjsSyvkPZA1OGGCBjAL5eNwxfT7nBPEEu?= =?iso-8859-1?Q?yRZM1eyR9neqzOPA+LVqh4bHQKYCdQY/UEnU1K3QIf0XZNDciYHQ5/tF76?= =?iso-8859-1?Q?FqwyFvopgU6hP9G6Mr161Hyzpw92pzu+RZpWTVZ+GDh25ZDTAXMLO/zFQD?= =?iso-8859-1?Q?qR1wjzYVpOqAPpEah55Ap46lIklnTIi+uvjjKEhj5Ju3TjUUCJ3LbVz1dj?= =?iso-8859-1?Q?UmMPRHTAHVTZE7MzuiN79k0QTvUrdUZq4ZXL4xhA91NPyZUugFcopY4s1R?= =?iso-8859-1?Q?ULjbKabTw6P0A6t3DgMWyWS6VeCfzE+ITHp01AFwigW7VsDttCuLELyUcr?= =?iso-8859-1?Q?Qztqqxdq8IAh+O3hNF/q15642d+kG8lQPa3IsavxoVlt0g+Z1wSp9nJdP/?= =?iso-8859-1?Q?HLo6C7bdNlXBAXvIzQDiI1sTN9LjGm4Uwq96SZGr7wrSQkr3iHTpKScz9B?= =?iso-8859-1?Q?lA8UgERzcq7RtyYjBwLCfvuRHd4sQ1qRa2FyuROyxrxNCN1a9/eSIpPaEc?= =?iso-8859-1?Q?X3HjZuQDiEeKuV6DnSGb4gciaAPav3bZmthV4OINMJ1JAMx2P4RmDw3JZQ?= =?iso-8859-1?Q?H15TvehulQdxutVxuW0CKzpuWKqNK3lIHdWwPjjSqzSmKXXcoRSd816RXL?= =?iso-8859-1?Q?mWTdoMF5StKprDysLEy4MygwZkJpjUOqlBupN5rLWDy+hRscxnxEbN5+uo?= =?iso-8859-1?Q?B6xC+Yo4hPPf1xhjNQwwfp7xYMdepT182geqWXXR/4QXF8I4uIGp62tO8R?= =?iso-8859-1?Q?ir3cEGZA5OdVX8c23pD8XbmTBGs6oV5rEaE7Hb/c6/YtmmW8/wf0xvft0t?= =?iso-8859-1?Q?cHb9Dt+4kB/zy8zkuoOOZCQSi9mFug1JRuvtf8W9sD27pyuDK3kuy0eXTn?= =?iso-8859-1?Q?GrZU0QvoR8vN+nE7NfajXblxeoAO3nX11+QaMfPImumJb5Xo1uTIuBPI/l?= =?iso-8859-1?Q?1TGGduCSY+RYHzF0muGSsqJSPJwyFg5cw18X3Ywv4r2HM4Y39Vz++O0lpX?= =?iso-8859-1?Q?diI9iHnUFAzhqsDYTCrSIFAAZTBXlLyt4E6gNOsCCYzI6YfMPqsBdn3spP?= =?iso-8859-1?Q?x89s3YMxx9v1rZJP9XWazOw/QqsX0AwIVPcmUgaXF59kp25whDge/ru/dD?= =?iso-8859-1?Q?AHDuO1GiRRRizhd7AKvu1iM0UNMlZPAyXZw4FwxM09CpOS4uBgxXK5JHT1?= =?iso-8859-1?Q?BXWQTIEBdJGzf7A51XOcxKTcKhJCZeOKVmRJL9nbEd2nj8OOXgZwfNtdsI?= =?iso-8859-1?Q?mHS27l2awkba3GvezPrA=3D=3D?= Content-Type: multipart/mixed; boundary="_004_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: aa5ef5a8-1d14-49a1-9379-08dd269cb908 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2024 17:34:31.7273 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSCPR01MB13313 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881 Cc: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --_004_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_ Content-Type: multipart/alternative; boundary="_000_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_" --_000_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > From: Eli Zaretskii > Yes, probably. For a good measure, I'd also bind inhibit-interaction > to a non-nil value, to make sure we never ever ask the user anything > inside ediff-delete-temp-files. Sure, that's will be more reliable. I had attached the modified patch, plea= se help review again. Thank you ! --_000_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> From: Eli Zaretskii <eliz@gnu.org>
> Yes, probably.  For a good measure, I'd also bind inhibit-interac= tion
> to a non-nil value, to make sure we never ever ask the user anything > inside ediff-delete-temp-files.

Sure, that's will be more reliable. I had attached the modified patch, plea= se help review again. Thank you !
--_000_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_-- --_004_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_ Content-Type: text/x-patch; name="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch" Content-Description: 0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch Content-Disposition: attachment; filename="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch"; size=1271; creation-date="Fri, 27 Dec 2024 17:34:03 GMT"; modification-date="Fri, 27 Dec 2024 17:34:31 GMT" Content-Transfer-Encoding: base64 RnJvbSAzOWIyM2YxYjNmM2Q1ODU2OWI3ZmE0NzQyZThmZDI0ZTJjYzcwNzFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT dW4sIDE1IERlYyAyMDI0IDA2OjUyOjE3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3Zj L2VkaWZmLXV0aWwuZWw6IFJlbW92ZSB0ZW1wIGZpbGVzIG9uIGtpbGwtZW1hY3MKCi0tLQogbGlz cC92Yy9lZGlmZi11dGlsLmVsIHwgOSArKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3ZjL2VkaWZmLXV0aWwuZWwgYi9saXNwL3ZjL2Vk aWZmLXV0aWwuZWwKaW5kZXggNjAzOGYzZWFlMzAuLmU0NmRjNzAyMThiIDEwMDY0NAotLS0gYS9s aXNwL3ZjL2VkaWZmLXV0aWwuZWwKKysrIGIvbGlzcC92Yy9lZGlmZi11dGlsLmVsCkBAIC0yMTMs NiArMjEzLDE0IEBAIGVkaWZmLXNldHVwLWtleW1hcAogICAoZnNldCAnZWRpZmYtbW9kZS1tYXAg ZWRpZmYtbW9kZS1tYXApCiAgIChydW4taG9va3MgJ2VkaWZmLWtleW1hcC1zZXR1cC1ob29rKSkK IAorKGRlZnVuIGVkaWZmLS1kZWxldGUtdGVtcC1maWxlcy1vbi1raWxsLWVtYWNzICgpCisgICJE ZWxldGUgdGhlIHRlbXAtZmlsZXMgYXNzb2NpYXRlZCB3aXRoIHRoZSBlZGlmZiBidWZmZXJzLiIK KyAgKGxldCAoKGluaGliaXQtaW50ZXJhY3Rpb24gbmlsKSkKKyAgICAoaWdub3JlLWVycm9ycwor ICAgICAgKGRvbGlzdCAoYiAoYnVmZmVyLWxpc3QpKQorICAgICAgICAod2l0aC1jdXJyZW50LWJ1 ZmZlciBiCisgICAgICAgICAgKHdoZW4gKGVxIG1ham9yLW1vZGUgJ2VkaWZmLW1vZGUpCisgICAg ICAgICAgICAoZWRpZmYtZGVsZXRlLXRlbXAtZmlsZXMpKSkpKSkpCiAKIDs7OyBTZXR1cCBmdW5j dGlvbnMKIApAQCAtNDg4LDYgKzQ5Niw3IEBAIGVkaWZmLXNldHVwCiAgICAgICAoaWYgKGVkaWZm LWJ1ZmZlci1saXZlLXAgZWRpZmYtbWV0YS1idWZmZXIpCiAJICAoZWRpZmYtdXBkYXRlLW1ldGEt YnVmZmVyCiAJICAgZWRpZmYtbWV0YS1idWZmZXIgbmlsIGVkaWZmLW1ldGEtc2Vzc2lvbi1udW1i ZXIpKQorICAgICAgKGFkZC1ob29rICdraWxsLWVtYWNzLWhvb2sgIydlZGlmZi0tZGVsZXRlLXRl bXAtZmlsZXMtb24ta2lsbC1lbWFjcykKICAgICAgIChydW4taG9va3MgJ2VkaWZmLXN0YXJ0dXAt aG9vaykKICAgICAgICkgOyBldmFsIGluIGNvbnRyb2wtYnVmZmVyCiAgICAgY29udHJvbC1idWZm ZXIpKQotLSAKMi4zNC4xCgo= --_004_TYCPR01MB100041872F966B7D923610108FB0E2TYCPR01MB10004jp_-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 02:40:27 2024 Received: (at 74881) by debbugs.gnu.org; 28 Dec 2024 07:40:27 +0000 Received: from localhost ([127.0.0.1]:48603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRRQw-0005TV-Od for submit@debbugs.gnu.org; Sat, 28 Dec 2024 02:40:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRRQv-0005TK-Jc for 74881@debbugs.gnu.org; Sat, 28 Dec 2024 02:40:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRROl-000168-0W; Sat, 28 Dec 2024 02:38:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=39hBrNTX3A5EsOfYKI5pTRc0fz8rbF6qd7PuDH7xe8w=; b=XRCd1GMRq34s Se2YUNAKOfmALtiCc5xpCTEurGrvJO4gX06q5lHMu3J1/YttXqhM8XHShMP1XEG/mceEfSo1BhsYT TWwEpKtc2WgbgMIwSMfSiBoRbpomJjzJA2206pLM1F2j7ghW87XggaABa0986C6jxGkJW0OwTYX0E r2LNAoASWJCi1fXJpkJA0RcUQrsXGPr0B+SXLeUZK+FDq+s7j3acsNeCt5O9AcJ8KIAP/BJpOEhzf MGV/xfePj5PK/Y52qaYivxQHlF6Cy46KbB/hMASU1jcs3cVdxPgLExNv0yilfTV2Gyg/qpRCaF3Xf fgeOzSQVDL9OgxT34fBAdQ==; Date: Sat, 28 Dec 2024 09:38:08 +0200 Message-Id: <864j2ow93z.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Fri, 27 Dec 2024 17:34:31 +0000) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881 Cc: 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > CC: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> > Date: Fri, 27 Dec 2024 17:34:31 +0000 > > > From: Eli Zaretskii > > Yes, probably. For a good measure, I'd also bind inhibit-interaction > > to a non-nil value, to make sure we never ever ask the user anything > > inside ediff-delete-temp-files. > > Sure, that's will be more reliable. I had attached the modified patch, please help review again. Thank you ! > > From 39b23f1b3f3d58569b7fa4742e8fd24e2cc7071f Mon Sep 17 00:00:00 2001 > From: Lin Sun > Date: Sun, 15 Dec 2024 06:52:17 +0000 > Subject: [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs > > --- > lisp/vc/ediff-util.el | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el > index 6038f3eae30..e46dc70218b 100644 > --- a/lisp/vc/ediff-util.el > +++ b/lisp/vc/ediff-util.el > @@ -213,6 +213,14 @@ ediff-setup-keymap > (fset 'ediff-mode-map ediff-mode-map) > (run-hooks 'ediff-keymap-setup-hook)) > > +(defun ediff--delete-temp-files-on-kill-emacs () > + "Delete the temp-files associated with the ediff buffers." > + (let ((inhibit-interaction nil)) ^^^ This should be t, not nil. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 03:05:21 2024 Received: (at 74881) by debbugs.gnu.org; 28 Dec 2024 08:05:21 +0000 Received: from localhost ([127.0.0.1]:48638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRRp2-0006Yz-Uf for submit@debbugs.gnu.org; Sat, 28 Dec 2024 03:05:21 -0500 Received: from mail-japaneastazolkn19010009.outbound.protection.outlook.com ([52.103.43.9]:28554 helo=TY3P286CU002.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRRp0-0006Ug-CP for 74881@debbugs.gnu.org; Sat, 28 Dec 2024 03:05:19 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=efL9I2Q96njCAOg9VmHFMay/DM2UofJCJ0bQKU+TgE7ADCgbYtoZNRE9q64aw+sfTQU4eT+xMJIojAnvLtj7osYZ8/hm+Spu+M2D+JpTdj9lvgbd0RCN7Jw3o3PnbX1YU1fUfMrxrshR2chVxfy7v6v5kGyM9ikpCSUJ/0v8LfFlRr3B5D8iQwhSvmReX1H2FWz54voZHtL8mYZY2boEKJZWE5/JVpow5Tr9DpqHc18fAEDb5rxNyCjuA9+aj/SC1lE/Y2BWaT9+4PM16xJUxGU1UJrhohOCIJgu23Ehuy79u4EVrMr//om4tqha4kol0QeVeMSUUjxZVq9IM39geA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKb3oduFK5xLN2HF/r3NGj/WN/4RdUuLQacPLz3KYnE=; b=i6KY4Piq8XMMdKwZyidtE/meAGE2gkHr7LnqcZL6MY/XQrvzEoFrNXAScWw7+Oj42dCOj6bfFcWPhgOenW8/aL/re/L1F1LZCVk5CecWJzSyx8XlFPAOF+J1PTcfqBr4CH9leYo6G6eu6khz67XPcFB7EpT4Bnb90dq7/EHGKHXQ/Tc9tiIU3f9p1v+FUS+bvjILopFUZQBJYEtqJn6FcKz1fv6zv7M0uEyptk8FZK8/FuT9gT52bGyV+3rjhn6kdywclqUJ1ngUBTAUn70Y7nAx2g5oy7NLXT5lw2QUT2ZhZ/RU1LRJ68FRBSdUZIXYojDcPd3OH4BiN8MAXk8+WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OKb3oduFK5xLN2HF/r3NGj/WN/4RdUuLQacPLz3KYnE=; b=l02kIxm8XRXzZDypJygHaFYzDMVFL7cfgC2IuduOnZL7Z/8eM66jXW0ALwwTLpEnMLfvBLSNMDEalhe++rEuYMixyLfFTNTNyQO0bgI/7q+sYnPN88kU/H+ui0ZYy0F3kCmTGh5f9R0ghgfcUm+qAc3JTJw2hdnOlw5lxT8YJhG2czq6TldJfP65oPYSOi0iur8YfKVU09Hn/IS0+vnHMQSJwH/ys5bvZpEB3J5n5RcNcK7z58yJN8OnmttyiRS1Z7g1loki/UqDsRSqaIChlwYsNGVSWMhmLeyzE4LD/V8DgWC1ZpDcFQZJ5MaukimkUNLoka4r3uyrBoHr1Ptnsw== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by TY3PR01MB11113.jpnprd01.prod.outlook.com (2603:1096:400:3d1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.16; Sat, 28 Dec 2024 08:04:53 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 08:04:53 +0000 From: Lin Sun To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWyAAOzfEIAABgUa Date: Sat, 28 Dec 2024 08:04:52 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> In-Reply-To: <864j2ow93z.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TY3PR01MB11113:EE_ x-ms-office365-filtering-correlation-id: 47361eed-ca3d-4d45-cc2e-08dd27164f50 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|19110799003|8062599003|7092599003|6092099012|15030799003|461199028|15080799006|3412199025|440099028|102099032|13095399003; x-microsoft-antispam-message-info: =?iso-8859-1?Q?XQJZuOFn/M1lquvCEuqcjFJcs+RiQQCCQUMogvX2tYRwKggLoQO8LcPbLm?= =?iso-8859-1?Q?J3G2J8LNfP91yfR9neZAOuYKwq506MZgsHU7stCWvwMFqVFG6JcL2siAl+?= =?iso-8859-1?Q?3780/rslsrhvbXMCu6WNwrlM+vPPpAIbBz0K1BnRYrMr6/d51CmaKVT+oA?= =?iso-8859-1?Q?R5aeJ+bxvoMiHtWm+SL8SkX1XOiYg1JJI9YBoJ44U8bkOkbCUCTnJqRjKh?= =?iso-8859-1?Q?oXUxJX8oe4xbpcgn9jxNcfKyrcVykqWLfd2k8IKssOHsZUV+4BXkY2pQqP?= =?iso-8859-1?Q?LSq7XEZp5IJ8fbt8r66mCw5vDvMENRq9Y3oRVp6atvOrQeTEXemcaC4t+7?= =?iso-8859-1?Q?j6d08AUkTL2ksx5Cq7Y+48vW+F6OzeFK6+mhZQ6QvJK6rceJQAtxoAaPQo?= =?iso-8859-1?Q?6bSDdSX+QxrlqOQIOTA0KVxAxF+B2S754qdvvDsEUkJygA9myUCLIbRO6o?= =?iso-8859-1?Q?QQZNQmxzoSr04RUvmiK5BkkFkFWaTvmQiAOWdLfqlOE8XzjLfh593YFaSA?= =?iso-8859-1?Q?IBpudDs1c/j9JFKZfgF1Y53ptwF0UnMfEkx7adAcuCSpWfDYKGG41D2izQ?= =?iso-8859-1?Q?t83xOrVjLEf4POvUNeLqRZMzWkCKm/xHIV1JO9h448cvgGnUXvCqcevL0l?= =?iso-8859-1?Q?ptkROuWZIGeLyTBSwTe2M7vsVdE0WUofWEMJH1FjeNUFz2LNPb7wgtr0Kq?= =?iso-8859-1?Q?ufHcesyC+tNBR8BTi88KNEyvUpLN1lBZqZUhgQkKYWT0g6DrghiqB/LE2W?= =?iso-8859-1?Q?iWqgA/feZuiTYeHUHiMNjASDJ5XTdxGoStNm3SUXCdEP18YLKPnyEkRQeL?= =?iso-8859-1?Q?lesFsHoJXYr2EIZdqtP0UTwRCFMaOmwnAtUaUfWfPKiWWrT18y3apZ4UIB?= =?iso-8859-1?Q?xGN25nK8ltMdiyBRWH2L4y/raTlE3BJHxUBs4GXyOp/UQ951yORoxgtyYE?= =?iso-8859-1?Q?51bSVeTfQo7mvRtboSdD2AuvkK9ybIwpDbDhtFdxfPCSwOfeTYMPj7TsYn?= =?iso-8859-1?Q?j33MZrzI1n4C9vV/sJ2ySpAHB5SzoIwZI7OucXbU8ggxcQD6Ydiwi6DqgN?= =?iso-8859-1?Q?22TcDlqeNWPY53K8NNngZ7KnJEwHnn/OziOHj6NxOzQM81aA5X90Ye2f8g?= =?iso-8859-1?Q?p3dtrNap5S2CFBvbQ1hPWywy0zyBZfwxT0eBbEgWhGVHpf3BjOhO4rDYZV?= =?iso-8859-1?Q?q+0g8doGErL9GacJLpQ6mZDSBV/fbVrg9gU=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?T9nB94emcrT09+0ACAwtD2s7mlR7+HIqPkBXz2PZlYtBFHdOxiChuloUYv?= =?iso-8859-1?Q?9C84EM1DsoQGsG4E/wYs+7wpbDBvTBHXuphS+7EvFP1Mj7PO/mEpUktdoF?= =?iso-8859-1?Q?mVbGI5L1rztxjDyPJoPM1xmQG2aoXGEacdtNw+MLer3gpLEKnF/nLD4eMF?= =?iso-8859-1?Q?XBTKhcimjs9LeKK5lxf5UGtyxsnqbKctG9ShQ0oBu9zfy7C7WpVCsw8Kv9?= =?iso-8859-1?Q?yAD9bK3D7TWJ+d1u4EBqD28X2wpa6fLWi792UpbiCpwn1C4DyCTxiZ0G14?= =?iso-8859-1?Q?rFclaUJHQYg3DKvKDEZ3CEWCrsB73W99pz0TLWUizBdGCG/TJNqfxC3qLi?= =?iso-8859-1?Q?AvnZ/pZR5MyBGgC6MXA0NrhRWEsqPs0e6sqrtFtr1Z/qeBXQVnxuecFiBM?= =?iso-8859-1?Q?zFkjH+3afLbNP7xJmuBstnEq+tvH8uzEZGhlEAqNUB4a/Noz+3UVl/s/fF?= =?iso-8859-1?Q?Q2cR53JuJJfIPzHqcPvwZSabl0blxw7j0E0LSYbZQ2eVjeoab2/Sv475s1?= =?iso-8859-1?Q?8rDxCij3WLlNyAKIbcw7/1qbXjHQFtKN8KpMpJU8Jo2gFXIgaArVtYvb+8?= =?iso-8859-1?Q?erw3OAYBl3Dd35ChUbuWIro0vOisXEINydA0BdoDarNj0/d9gGoZmb+5pD?= =?iso-8859-1?Q?NPsgn7spGqJozZcz0ZGx5D1JAXZimY2EmiNeZ+lybAjbQljTiWA+JWRgnA?= =?iso-8859-1?Q?xqBZyk+mCfT78AwzpQX1eG3u9Ho8/I0TjvoVpB9z2kN37hg8SjRZIOsQn/?= =?iso-8859-1?Q?TcUJddbbZ0Z9eyppoOJgPbkz0bivJ33gRQyi35s+NPaXO64LldhAjNQ7OY?= =?iso-8859-1?Q?Y0FNZuv17kUnpaWtfeLF1wOXDLfNnqqLCeD3TqhC93lRGTh5JRB8/cvm4f?= =?iso-8859-1?Q?Pwr2LANTQzZ0lNJSa6PfKebHAMMInWE3bfJg4xoC2+qCkyqHGJQlV2Lc0e?= =?iso-8859-1?Q?pr1hZaR5/XqeVR+HWREnjrRfn8nLE85h8nRATEDmaiwnihbi4gmpwNUWk3?= =?iso-8859-1?Q?l0KgSuX5JMgz6yKytt9SJfkgTvYrjfQeCK7ELAMxlFSl9x1ZpFdUEu2z4m?= =?iso-8859-1?Q?GwOn0mmENbnYCTO9CzTehSKtyg8CpTHql/nQ8miMSCCAPc7vQR5ZWbmxvy?= =?iso-8859-1?Q?fP5YoZ7tK7es0k/jdz/ml7xal1Si6aon/ZofYg/t0iizMGDGLE56LOAYSB?= =?iso-8859-1?Q?V3OjsN8r5Wt2VpJtjzOVXVR++wy5C2C4rn48glySJVAYqmnUTu7eSIIGc3?= =?iso-8859-1?Q?mQqMXH020l6Vd2Cvd4kg=3D=3D?= Content-Type: multipart/mixed; boundary="_004_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 47361eed-ca3d-4d45-cc2e-08dd27164f50 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2024 08:04:52.9585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB11113 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881 Cc: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --_004_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_ Content-Type: multipart/alternative; boundary="_000_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_" --_000_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > From: Eli Zaretskii > Sent: Friday, December 27, 2024 11:38 PM > > + (let ((inhibit-interaction nil)) > ^^^ > This should be t, not nil. My apologies for posted the testing code (I toggled t/nil to test the behav= ior on my local). And I attached a new version of the patch, please help review again. Thank = you! --_000_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Friday, December 27, 2024 11:38 PM
> > +  (let ((inhibit-interaction nil))
>                    &= nbsp;            ^^^
> This should be t, not nil.

My apologies for posted the testing code (I toggled t/nil to test the behav= ior on my local).

And I attached a new version of the patch, please help review again. Thank = you!
--_000_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_-- --_004_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_ Content-Type: text/x-patch; name="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch" Content-Description: 0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch Content-Disposition: attachment; filename="0001-lisp-vc-ediff-util.el-Remove-temp-files-on-kill-emac.patch"; size=1269; creation-date="Sat, 28 Dec 2024 08:04:23 GMT"; modification-date="Sat, 28 Dec 2024 08:04:52 GMT" Content-Transfer-Encoding: base64 RnJvbSAyNTRiMDY5OTMzNjNmMjBmODJiNWYyOTE2ZTg5MGUzMGE0OTJiYTQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT dW4sIDE1IERlYyAyMDI0IDA2OjUyOjE3ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3Zj L2VkaWZmLXV0aWwuZWw6IFJlbW92ZSB0ZW1wIGZpbGVzIG9uIGtpbGwtZW1hY3MKCi0tLQogbGlz cC92Yy9lZGlmZi11dGlsLmVsIHwgOSArKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3ZjL2VkaWZmLXV0aWwuZWwgYi9saXNwL3ZjL2Vk aWZmLXV0aWwuZWwKaW5kZXggNjAzOGYzZWFlMzAuLjg3ZDZmN2M0YWVjIDEwMDY0NAotLS0gYS9s aXNwL3ZjL2VkaWZmLXV0aWwuZWwKKysrIGIvbGlzcC92Yy9lZGlmZi11dGlsLmVsCkBAIC0yMTMs NiArMjEzLDE0IEBAIGVkaWZmLXNldHVwLWtleW1hcAogICAoZnNldCAnZWRpZmYtbW9kZS1tYXAg ZWRpZmYtbW9kZS1tYXApCiAgIChydW4taG9va3MgJ2VkaWZmLWtleW1hcC1zZXR1cC1ob29rKSkK IAorKGRlZnVuIGVkaWZmLS1kZWxldGUtdGVtcC1maWxlcy1vbi1raWxsLWVtYWNzICgpCisgICJE ZWxldGUgdGhlIHRlbXAtZmlsZXMgYXNzb2NpYXRlZCB3aXRoIHRoZSBlZGlmZiBidWZmZXJzLiIK KyAgKGlnbm9yZS1lcnJvcnMKKyAgICAobGV0ICgoaW5oaWJpdC1pbnRlcmFjdGlvbiB0KSkKKyAg ICAgIChkb2xpc3QgKGIgKGJ1ZmZlci1saXN0KSkKKyAgICAgICAgKHdpdGgtY3VycmVudC1idWZm ZXIgYgorICAgICAgICAgICh3aGVuIChlcSBtYWpvci1tb2RlICdlZGlmZi1tb2RlKQorICAgICAg ICAgICAgKGVkaWZmLWRlbGV0ZS10ZW1wLWZpbGVzKSkpKSkpKQogCiA7OzsgU2V0dXAgZnVuY3Rp b25zCiAKQEAgLTQ4OCw2ICs0OTYsNyBAQCBlZGlmZi1zZXR1cAogICAgICAgKGlmIChlZGlmZi1i dWZmZXItbGl2ZS1wIGVkaWZmLW1ldGEtYnVmZmVyKQogCSAgKGVkaWZmLXVwZGF0ZS1tZXRhLWJ1 ZmZlcgogCSAgIGVkaWZmLW1ldGEtYnVmZmVyIG5pbCBlZGlmZi1tZXRhLXNlc3Npb24tbnVtYmVy KSkKKyAgICAgIChhZGQtaG9vayAna2lsbC1lbWFjcy1ob29rICMnZWRpZmYtLWRlbGV0ZS10ZW1w LWZpbGVzLW9uLWtpbGwtZW1hY3MpCiAgICAgICAocnVuLWhvb2tzICdlZGlmZi1zdGFydHVwLWhv b2spCiAgICAgICApIDsgZXZhbCBpbiBjb250cm9sLWJ1ZmZlcgogICAgIGNvbnRyb2wtYnVmZmVy KSkKLS0gCjIuMzQuMQoK --_004_TYCPR01MB100042551D4F4777D84FB2011FB0F2TYCPR01MB10004jp_-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 07:41:17 2024 Received: (at 74881-done) by debbugs.gnu.org; 28 Dec 2024 12:41:17 +0000 Received: from localhost ([127.0.0.1]:49702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRW84-0002vp-Vx for submit@debbugs.gnu.org; Sat, 28 Dec 2024 07:41:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRW82-0002vX-OC for 74881-done@debbugs.gnu.org; Sat, 28 Dec 2024 07:41:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRW7x-0003B1-Eh; Sat, 28 Dec 2024 07:41:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8tg5ppYDc8tOSNn3Gs+VIqMrE7lbzIJFJOLv3V6t+24=; b=hMumqbDCyrfl FmK/TpgMklGC1SpVWeqprVjLlNPm39ljM0bm/ns+l9hLkYSARv9b9WnRFko6HZ+aMFQ/OCGtkNQU3 /RMlFtegFd2Qpfh/ixhgqB6onlM49OGd4aTOa4q20siy+isQu52XA+Z4cTsD6aq8Wcxa82Rc6YoWH Itk4N4M6/Xb55MyVrPqSbsq8tAGfQuxGE99GUxWSd5XM6JhYkxzehHLi0vPciItYTPwgMZ3txV0hl qzLOaxYrgy+0MB3Kcq5tKReFOjCMt8vKmIsp6Zo9Conz1zkz3wJ8wMRv7tn2m5ee20zX7tyMu23S+ szwU8y1lecyJq9P0UQ3vMw==; Date: Sat, 28 Dec 2024 14:41:07 +0200 Message-Id: <86ldw0rndo.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Sat, 28 Dec 2024 08:04:52 +0000) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881-done Cc: 74881-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > CC: "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> > Date: Sat, 28 Dec 2024 08:04:52 +0000 > > > From: Eli Zaretskii > > Sent: Friday, December 27, 2024 11:38 PM > > > + (let ((inhibit-interaction nil)) > > ^^^ > > This should be t, not nil. > > My apologies for posted the testing code (I toggled t/nil to test the behavior on my local). > > And I attached a new version of the patch, please help review again. Thank you! Thanks, installed on the master branch, and closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 12:40:47 2024 Received: (at 74881-done) by debbugs.gnu.org; 28 Dec 2024 17:40:47 +0000 Received: from localhost ([127.0.0.1]:52517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRanv-0000Z9-DH for submit@debbugs.gnu.org; Sat, 28 Dec 2024 12:40:47 -0500 Received: from mail-japanwestazolkn19010005.outbound.protection.outlook.com ([52.103.66.5]:5359 helo=OS0P286CU011.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRant-0000Ys-8K for 74881-done@debbugs.gnu.org; Sat, 28 Dec 2024 12:40:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JCzs6rQ1Y4y94W1cyGLka9l0cEYbYg8EAvWvSf3GqhxsdGCusNGRQ90HE1yC9cuxykABB1ZW4fVFhCG3FdvPSBMyjJ2yRBv6wXya5e+/1wDrJOzLbG82pNvuI2nbAgHw9Vzz5S+4EunlgtcFmi6LbEZQrXemEyJm36OMynS5x4mFPJyXs8Tbp1r7XjVEpcvt0lYzRUQF+BgHrfAMeIzWZ8lOxEZIuk8bEfDIrlDDgcqFbkP8v/0Gzq1A1zjM3Ud3RhP0V+fNKU+pilokb3uJBXBWsYQX9NvFLUDX55GnNYu/8E9yr96iFHvFesJAVg1AS0LE1rHkDQjXdRa1/3LoUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jgDdzKPsgsTRBEu7PlCbnax+p4KJTnnr6oe6ZCB0eMU=; b=g6CXw4mv4b3PtuAtQnP6W/7bDIAJXVsEs19y0QyYohU6dQ2QQsVHxUuairPeZqT2JCE8cVzvwFh1h0D2NhoaDxwkymtax5WHscBh9I8HaNjbcrZ/P/wAs5C0XhOxUCwXQhblvLu+IfRJgowOKmETVj8aen/7JSlzJztB4UAzlKccbyPAV/lFd6efRCqqDSuL+FU1Yu4w9PdKk73XC51iJFgnD0mWDf2E5mjqKEwqvwSFi3IC8HfYXU6Ps0smKsTLeRNWlL61qGJHsdowq/qYi35eYX1nd9iSMvJlVSA3/Juj+wczrcBWA6rXZyAiaOIV2PXGoMzroiddLhobaqhQcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgDdzKPsgsTRBEu7PlCbnax+p4KJTnnr6oe6ZCB0eMU=; b=LAsy7JzCVZgqQSvmWZss38KoxtCCVK4zbb06fRZgWDVKCOxCQosZ5xjRo2FM20NT8mJb5kTXoMrZ/mr2hxpFUcn0ZqpCWWTB0kE5BPaNSbeuzTYu/RAq+AdQTM1As1HabrILez1Hdw3NqWBcVeLXGBKktWpnu6xLoTNaeG6BI+uORG+aVe2nUeehFM+HYugOvHdPqTv9gK/V6UP8D30PrXUXdiK6TCWRqrJCj/KBgO870JS/GPlGhPBMu3CUM69rTlKkWqAdfWglxXS6uj+QSFTxOseJkIfeWmC2yKgZTpoFLX7afSvDL2u9SE42j2rJ0O9IFI4o1TlGAPkLuHnQDg== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by TYYPR01MB7781.jpnprd01.prod.outlook.com (2603:1096:400:119::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.16; Sat, 28 Dec 2024 17:40:36 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Sat, 28 Dec 2024 17:40:36 +0000 From: Lin Sun To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWyAAOzfEIAABgUagABOol+AAFNJrQ== Date: Sat, 28 Dec 2024 17:40:35 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <86ldw0rndo.fsf@gnu.org> In-Reply-To: <86ldw0rndo.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TYYPR01MB7781:EE_ x-ms-office365-filtering-correlation-id: 7fbca3c8-d41d-4fdd-4ec5-08dd2766bc5f x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|7092599003|19110799003|15030799003|8060799006|8062599003|461199028|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?FD5xh0XKD5NLlvLmF/06NivX4yBV1P3zA/Z1JMSkUZcmxDSL7WiFVdx1c5?= =?iso-8859-1?Q?JwgKNDk3/7Exk993BOTfMal0dhkn8eP3IvH9QQ69cp6G9clvLJDwGi/yVT?= =?iso-8859-1?Q?O0pW0so0ZiPj+u+MOLm/2J7Cb84dET+0LUNdqMFy7THWH9xEV/pFj6jDsk?= =?iso-8859-1?Q?6v1dhboY7w2uulQg46OfhYVYqOMG9jzRKApjB1ZeU43+LgLG1KJjqvU5d4?= =?iso-8859-1?Q?r1ExMFq0mD/C18nT2fm5Hq9F27VidMAothsLe2Os7By9CySRAEi9VoAkay?= =?iso-8859-1?Q?JERjfg8bizNskB1CsF8iIT0JkZVFs9vIDfdslupeYAMxcxK9pSBZoXnseX?= =?iso-8859-1?Q?vzhZhJrCemE2pdMTmiTagu2IuOv+K/POcWVwn7dXmmi8ds/hXUuLCzZqrX?= =?iso-8859-1?Q?OwJhSxSTLhutCH5JnwO5RIHxvArRlqeBkdRtXu9JF3V2vxs3wAdVukVeni?= =?iso-8859-1?Q?obACwMtfzCk40tfg/ZRjtiAITbfVqQ3hFptDFmtOL8Uy81zvUO9dwpKBOh?= =?iso-8859-1?Q?evMaCY0HI4YkqlItKV9dXPgCoPrHezusiHKcswdQR59hkrSi+hqVm/zZSW?= =?iso-8859-1?Q?wwiwRUhgzMo6eGEWtek3M3BWmKy7/n52SKocD+ZNpkDj8CE/PToovW9HSc?= =?iso-8859-1?Q?6FkodZ9c2dWx8fUhDaXVOq9zYHdELYQknc5ooZHgSh2GVq4kXnLSQd1Agx?= =?iso-8859-1?Q?C29nWULAsLdq3cPSmBX6e485ZlhZnT+D0pIqOADbS4IBdKubMhXDokgRQo?= =?iso-8859-1?Q?QveTYYfHaadH5WJ7rh/BVo+zCd6CzO8W2ZiTeh4hcGYifzDiSZR6wvV5HV?= =?iso-8859-1?Q?kfvRzgEBRU+xJ+vmgedNOzzV5+vuVz0JV3zr+Fy0zWBri9i+fl9ikk3ytI?= =?iso-8859-1?Q?16y06CE/jlg3MR078iKgJ4+5CC4wA5Swm3WYnL4mGCNThCbSgQvAsDS4ti?= =?iso-8859-1?Q?9YkCSspsYAGYKz3RP2YkT37FBz9D69imPn70rGpp4/fF11JDk/HKGYVBSV?= =?iso-8859-1?Q?on+egOSBME5HPou3qL+IezZ4leWv/PWE66lvnsQDl4WQax2c3+MR6BlXzz?= =?iso-8859-1?Q?0Nix9rkC7EmbgySFcfKWwqR4K9sO3GWOF8oN1yQ0zB8vUVjqocGBal48wb?= =?iso-8859-1?Q?Q1UPrPuvpUzOINS9m0+MsoPVRLjeA=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?HqKuog7cmnnk2uOYW47Z5MAg96o5wkJYASaIHHql3VBKynGzjmuoRV5I0A?= =?iso-8859-1?Q?7R4gTxX6PSoj1Nt5AXE43yi4kuvvYeTiUmGURLjbhTE6w7oIFupWJng6xQ?= =?iso-8859-1?Q?u+8Qh+K1FxBYPYsFPigIIGorWPYG0T0kRRvzojL1r1ilRguM2REoZzoOOg?= =?iso-8859-1?Q?ZzycTPkksIowxoSVLk/7sCfJRnBwREMhZXvmH74TSqtAYyhvsDYAHfVA3U?= =?iso-8859-1?Q?XX5mZod7L9rSzILK/eibggHfByZahEtGMJpPmdTfAGR0ARUxKwkwciZ5E5?= =?iso-8859-1?Q?LjfavD7EnlVUDlK6Ub7EXwnvN9KORbFratm14MBU3D+Eo5WCKwzz5fp/Qw?= =?iso-8859-1?Q?RTA8HorCQlEQVM5+aQYvDqU2HnAWFUlnSrb9WfErz9WFi0FM00t+Al3s0m?= =?iso-8859-1?Q?Dl/exCsEQ47DkyOIKhdlUXPMQJKjLiOLL09QAZvW+hX/p+mKzWrV1+vTRf?= =?iso-8859-1?Q?KuMMgiGLDfGknrOugCuaq5XXs+nmQdUpwInOVnsmZpu0Neqa5T5dRmGBkG?= =?iso-8859-1?Q?2AaO750hMjLzbOz79+/uc2Oxy9vik6uqV4Hd5z+7BZj43sPBbOf5psYX+R?= =?iso-8859-1?Q?TDZHeGgECCqwlgQaPfEXtPQCK5d8iD507fjDM08SwgM2zCDM8QXuK4Pqcy?= =?iso-8859-1?Q?j9GgN2QJibIdOS7mZmxlNZR5Up8GAQV3fRac8OjicLGslNtO28RZfj8xaP?= =?iso-8859-1?Q?6n6vYzrCO1xEtxDyVMFAsTKDMJKiuqh567rIQiN5Lgl7UIfTBittMWOUp6?= =?iso-8859-1?Q?1kSNaDC2MbIS8AbMP1UdoiyKkNHO4OWjPiNN4d+xMywGNnTI7qHpzcM1ny?= =?iso-8859-1?Q?ZCCXFJgXFo2k5de5TD5p/6SSyCWz18F3Q4jSyrJwIKb8u2/ff6ORfddaop?= =?iso-8859-1?Q?WoXri31SJmRfY+mXo2UCYdUDIrqeqT5d6VEkDPk9MtJNbeAL1DBz8mvM5R?= =?iso-8859-1?Q?N+XztCbURnoDuRZgylaC1Ga4aoi6mbXAeVbRDRXcu0X2luS/kasFsca5P5?= =?iso-8859-1?Q?xzPkwE06zpJYNmJSCkB0mu1vjN2DjCXJ+sm/reqYi2C5nUpUgrEfSwFlHY?= =?iso-8859-1?Q?HAOMyjt1SqZ+tojYubwlHKgAiMBAQNhvFvRIRav4EHUwcJnTVtn/zdCMZk?= =?iso-8859-1?Q?WfaLffAVnoxUgasy3mMDKFvCc8se0jOP/+UBRBd9SRUwytZgTu2sWAZFCA?= =?iso-8859-1?Q?Eq5m/9u3Zp/0qchRYOXqIe1e0p1rIn5btzgTSllKXadbmXUo99kOECs9Pc?= =?iso-8859-1?Q?ul7otiKS7z0pKyuA6AiA=3D=3D?= Content-Type: multipart/alternative; boundary="_000_TYCPR01MB100043B042EC9979D02B62B36FB0F2TYCPR01MB10004jp_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbca3c8-d41d-4fdd-4ec5-08dd2766bc5f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2024 17:40:35.6757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYPR01MB7781 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881-done Cc: "74881-done@debbugs.gnu.org" <74881-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --_000_TYCPR01MB100043B042EC9979D02B62B36FB0F2TYCPR01MB10004jp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > From: Eli Zaretskii > Sent: Saturday, December 28, 2024 04:41 AM > > Thanks, installed on the master branch, and closing the bug. Thank you ! --_000_TYCPR01MB100043B042EC9979D02B62B36FB0F2TYCPR01MB10004jp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Saturday, December 28, 2024 04:41 AM
>
> Thanks, installed on the master branch, and closing the bug.

Thank you !
--_000_TYCPR01MB100043B042EC9979D02B62B36FB0F2TYCPR01MB10004jp_-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 20:48:18 2024 Received: (at 74881) by debbugs.gnu.org; 29 Dec 2024 01:48:18 +0000 Received: from localhost ([127.0.0.1]:53175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRiPh-0007BL-UM for submit@debbugs.gnu.org; Sat, 28 Dec 2024 20:48:18 -0500 Received: from mout.web.de ([212.227.15.4]:47417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRiPf-0007B0-ME for 74881@debbugs.gnu.org; Sat, 28 Dec 2024 20:48:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735436885; x=1736041685; i=michael_heerdegen@web.de; bh=0T5XLYNm/bELtivhrseHgnbydDzMSZRbZQBO+mtJW3U=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ti/rQW+CmV2cHYZVv/9Sn1f7DirJmMJlKxenNvjESsKZ1lORtbI5bBmgNXd+ULYx qN9RNg/4FfuLc6SwmmPr9paJ1i9MqiKRK5etIxT3CvQtE7/Py4hMnkcqEAnlsmM9l svPaaVjN8DilKsLRJngVpNeSG+Ju4zBguXuTlPmA/MgztqQDFH25mgZmhpnJclWij tM+iDcKsqVuiQ1rx6hL/2U/6udOmJip7NQoYgyQkjnRKc79mKIr4P8TGD529UgKiy 2hR+DKhyf9suYTqdNqyeT3V98uOMniF4pzvDILFZXcZzeNgHnkor3fjTvUHVx6wQE MDkpKM8kDU3uTZnyNQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M28SL-1tUBO13zLN-006DlP; Sun, 29 Dec 2024 02:48:05 +0100 From: Michael Heerdegen To: Lin Sun Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs In-Reply-To: (Lin Sun's message of "Sat, 28 Dec 2024 08:04:52 +0000") References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> Date: Sun, 29 Dec 2024 02:49:14 +0100 Message-ID: <875xn3jm1x.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:GvP4xiUocENdc1PayPC1tfDxxOwvOgQ88vSam2Gu/aHXTA7FHGr WvdgB8RWlbZKVcT40PikKHefntvcYDD7Qc8dIS174Mpay5ZVQwEL8Sp9RMviPqYOuIMRRcR b8KdLjnUnQE0kiLyV0C1iB1xZ7J5mnnW8jqvFRTnmrcPLHehTl8rNwh48lxOK+B2MYlw7Pe EwMoivzbVrSXxWYBIqSrw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Ecp4XJGggWA=;uCzaL0zt6aImJgRmJ3XDxNEVhBA jZm83TLnO+nhLB2NOPZipPfH5HnLkC5IMZESQWGh+LhcPaa0NbiklVDW2CyLKUyKF83xheGxb nsGvpVLmPKdWTkeRe+CpIfHw/97LRb2ClHgM2VKitrj8GKDlSfED6XKLx3JT0iZB6ydvtfD41 29jJCvzEwFHINPIP6UlygjcztSHnlfl8F82H1ABUkh5F0q70mgUQ0EtE4vBB1Pn3uIZhLJzDq I5I1NQkz2isvjvw5bwb+FoXcGZ1u8B2h4GsDsUVqLiqAgQAD4jUd9lqQJet24V5s+O5SfDVrA P4dSHw/5hoigvF0n0UN7gYst9k0xsXGWLDL/YNu3sz2Ss7zzS2hqVUOGuU02dW4Q/r3V/Rt0Y Md3d144W9dlAQssyoNeVAPoe6Ax0H3VWdyxgDUskb52pFbC9cYTi5lAuAZ6cfNXaWdryYDYZu exkc5pnUZV708ZJGO4UOG1G5ryUXvPu7C5Ev6qgc9srfpKx3FnCI9RQGgDWVyOztnw8oICBN0 OGsF26cOQozDUTD57NrhN3vZGjpOnfus6Cjr7fKkTrIYiaap3QEWUBuIsY5tRgkj8f72ico2y qr2SiZj7zt9eErmZHVQvPQRLQeVY65uX4gJLlP4J+SH52te/MEEDH8DnubtKfiQUHEC3zoMBe vzqJg/DE5M2GQwuQ8ZAvG54ZP9pWW/OZPUYOWFTyv2r1ugCXGSDKEq0Xs2n+/3/aoq/PSLLrT vuvoafIr7Mj6C9RBuo8Za7hmSlrTgUJ4/0kSN7yD7VdhvMlNV4DR/27/cdJW2X7fcgjdkGrry IVznYuXueOaS12GqZcFvSnys8u5wl8aQmGm69LJAZ/IPlIWewlc8vRAJbxfhiU1NaoPiNQryk Pw9SMa7cIjyAiPhtVNbZuNocgMuGMgkn72rEEAU4xEqJegYSGjyekAyFLN6llgUOVgCWp6TWX MABonkqpg7vLENwtvVDVUc2+dOuBKT1Dt2eV+uhmHdavSLYrZNV16dizSTVycsfXyZboYfDu6 dMCt2bVIIoza2eXNPmWlTWUr/Sf/RcYyha/KHJXg3Z+VSdHTrrEiLR/z5YQfBt2sjKj7mQFuy 73eAeIvYg= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74881 Cc: Eli Zaretskii , "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, I'm a bit late, feel free to ignore may comments if you think it's not worth the trouble. Lin Sun writes: > +(defun ediff--delete-temp-files-on-kill-emacs () > + "Delete the temp-files associated with the ediff buffers." > + (ignore-errors > + (let ((inhibit-interaction t)) > + (dolist (b (buffer-list)) > + (with-current-buffer b > + (when (eq major-mode 'ediff-mode) > + (ediff-delete-temp-files))))))) I think this is the same as mapping over `ediff-session-registry' which should hold exactly the list of buffers we want. Second: Can we move the `ignore-errors' inwards so that an error in one case doesn't abort the complete loop? > ;;; Setup functions > > @@ -488,6 +496,7 @@ ediff-setup > (if (ediff-buffer-live-p ediff-meta-buffer) > (ediff-update-meta-buffer > ediff-meta-buffer nil ediff-meta-session-number)) > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill-ema= cs) Would it be ok to avoid the above loop completely by using the buffer local version of `kill-emacs-hook' instead? Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 21:25:45 2024 Received: (at 74881) by debbugs.gnu.org; 29 Dec 2024 02:25:45 +0000 Received: from localhost ([127.0.0.1]:53217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRizw-0000jN-IW for submit@debbugs.gnu.org; Sat, 28 Dec 2024 21:25:44 -0500 Received: from mail-japaneastazolkn19011029.outbound.protection.outlook.com ([52.103.43.29]:64324 helo=TYVP286CU001.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRizu-0000j4-E6 for 74881@debbugs.gnu.org; Sat, 28 Dec 2024 21:25:43 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=O3Zqpo6/vXwMIW4qX2wG2wceKdYPY2827D2rRJx/FglNu1ykzWtW3CoqAql8GYrf4l+qmhPoJlW1fA/gY4CpOtXP5WBbqpWrNEJuLVIEHzlhnPcCOjU+MuDVYxiFGq2rZNh60BDyXEEPZXXQo1kNooAZIv5erPaWpuP34+MYzbXPYM5extVmktubCUm57ZD631zXTMRIyx1ookgeG5sLVeBNRK8OJX1K0VyjxZ2SDxhG1jJnCDEtEO+mbOsJ9bJuiVzqVlMWa7HGskYU2H0ATT9ua1iszO9O8G3LnPlobY/tT5Djctvz49EW7ZfEs69wFon7CvTt/xTF0Vk/KCXlsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=01vxz1tycj0w2i8p+UkmeD5ZjwLCuyWtIbtgqE21po0=; b=GD7brO5HfklgYaUdOf/vW/ClQgBGWzwXHnM8+wVl18zyPXycAmmaLqFOvDjxo9OxOxNeWEGvYwa27PRpqWUpJfNk5shQcMgQqW/940vyoZ4WVbTGVm4blqI4H53RHEEXJW2tWVqIIsPWqcAviD32IXLt531aXaa/E3wr1v/7eCwuBxucduIr/RYToVfSLjNDS3pGs24wftWrfMki1VOtSuWosNstECZ993hElgi2hEnO0NiWDPpliUP+o7b9T4E9rEcxVNc76YUQYNMlHusAgI2MjOBOVeWNMUwJsqhYphyhPfHYQFWeW1OZLlcHq7YKjNXLoIKRmgnrX63BQ0kK5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=01vxz1tycj0w2i8p+UkmeD5ZjwLCuyWtIbtgqE21po0=; b=K1H01WjS40yWHtqlNSVcmIZqBLc2YlgxM/n4nbZezPXequiH8nr7RQzFYJro+SqSDJahOwp2UJGMKzdwBHsAmwEolUa2nW4JV/s75XZu7E/0MKZ9+Y/rFhR21F8LoeiMrTwOwcU9+nsm0hR3ueJg2Yy8MIhkl1p3X+NISSHYzm1+JkcgWVxIFxMymJJtai6iMsIQf9RR3VvnO+8BcWIv5G/fBOsd+gCXZ5KiXmDmXmRmMOaYtaKn+dnS/0CEDXcrL7SCuWaa1aa4M1MquHFoGeT3aOXqwCDlIWI6QY0Uh6Mdihi2AqvsmtVgkyHHixHKV84Ni+ZUxGWk//Kd+BxBIw== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by OSCPR01MB13123.jpnprd01.prod.outlook.com (2603:1096:604:333::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.17; Sun, 29 Dec 2024 02:25:16 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Sun, 29 Dec 2024 02:25:16 +0000 From: Lin Sun To: Michael Heerdegen Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWyAAOzfEIAABgUagAEqgPuAAAjhSQ== Date: Sun, 29 Dec 2024 02:25:16 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> In-Reply-To: <875xn3jm1x.fsf@web.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|OSCPR01MB13123:EE_ x-ms-office365-filtering-correlation-id: d0efd68d-5b31-4f4c-559d-08dd27b00877 x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|6092099012|7092599003|8062599003|461199028|8060799006|15030799003|19110799003|13095399003|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?LgRrw223P8iww8xCRK0xRzw7w55RY+gOqowPixB5g4VUcEwB8nB5LPWSPE?= =?iso-8859-1?Q?dy8/pCcH2cOpDBBo2yROVc7/Bimt6U5hkYRBeINFhR7Vov2OK8QIZcXLsq?= =?iso-8859-1?Q?cqM3LVK2Y0pzqHlTNo15yCWxq+DgRL6rMkzGYq0B/HJJjAyAxWcJERHbWt?= =?iso-8859-1?Q?SR9DwieQsg41k93QLuFUODayyxsMF9GsV/T1IHwPRXTfQsWVzrDsZaAL+x?= =?iso-8859-1?Q?qEIZkwQmV3OpehU+ArFzZKM+MvPz4RqtsBi9B6fbIr97G27GIUyPg9tPZD?= =?iso-8859-1?Q?46OhtROxjLs2ZIyvt8ykxSXnIsz2OxVv0YKLURP187GrPas+7Zsr1yVTq8?= =?iso-8859-1?Q?r0CYvPPXSth8b/Y+M9NOJLoMB5w/N41JfCL39Yy0H3Y9hNOegSrDH6ckHz?= =?iso-8859-1?Q?lZhWOhZfizgEVKqOxgogjnDm1YqGT+8tNBBnW840BWWuIquY1A6QaRWJ2e?= =?iso-8859-1?Q?Tp+wppfMBcgvmBok2+Zm1b1WDr2fhqOZWYiuCxdT0C1ACNe0VFRPaBaAAP?= =?iso-8859-1?Q?wjJj484/GWXy0cy2CfdqqUGFXeWwldbFi3WGcn3/oBsvYu1lo79oIocDNH?= =?iso-8859-1?Q?q2ShW+O5RzTbiOhMQJYZpBZ4tbbzEDIh2R8VrA90CFsl3pnvQpMb3H2qki?= =?iso-8859-1?Q?cKknsk+M+zApdppgrhD+9+9WqVBcUW0zu51oC6w6sXUgAm5mFrrekrXrp4?= =?iso-8859-1?Q?Pw1bQYpcOcDsg7iNSCCKIr/prmp2RSsCvEPm2VUde+GuSvmEfeTLscVRvf?= =?iso-8859-1?Q?gXvritvG+HV2jXGwUa8tuQznGYL1NpRaz3R0wBZLqHaNtl6TYm+KZccFPP?= =?iso-8859-1?Q?EDUlNZq+50q2zL5oBiC2lfDc10LpgzeYEaGbqGarazTzg8vEyxAu95bN2R?= =?iso-8859-1?Q?CXZDAIJGMvRl6kFRS+laEm6+nPImDP9NWHOVSM6sBW+OPB2lSsqz+cB8qz?= =?iso-8859-1?Q?qJtvtadCHE+Oosr/Ecn/F4MGPQz/Y07Kxn9jcvPmwXErdYwn++BauZxd3Z?= =?iso-8859-1?Q?p2A5QPokPUmsOnez9GU3kPoesvtp1zt8tOs/i/3utCuNByYAtbpS8b7v/D?= =?iso-8859-1?Q?0RdTKKFoiw4Pac0C+MJK4/ihYQ3CF/oD6dr2ryqBaBdjXL3N2O7euQRPKs?= =?iso-8859-1?Q?bjuFJnyNUDosMn0DdYR/RjQS/sH9A5xOdVE0mG8Hq8oCE1yHd2CWLxi7Qk?= =?iso-8859-1?Q?WHoN57o7cGyEvjGrQC11DPai6QjRVsiz+f8=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Qj842Q4U7qVdGaLLNXkICqwgjTOLyO4XPu1VG0UArJcQeqzG2AcQRQJnBF?= =?iso-8859-1?Q?TpLYsF9ZbGxdEI0GAlGM+l0BTz8siA1c7Rj55FonSMTB24bHiRak5mh4sW?= =?iso-8859-1?Q?COnU/kjWGhAzHDwx+3vy0MPJ04OWtNQyoJYDVCmeXgLNdDQSQytwYMQgoU?= =?iso-8859-1?Q?vwPycoMt/5xwgXMVjmFNApxOr+jM2hkmCIbCb/kk4cmpXJzom2L2dEMJj7?= =?iso-8859-1?Q?OwICnoVefPUKW9l+dIpsFwuLY/N+jOKMlgnqN69bbEKGXMaSACdLCcsNBg?= =?iso-8859-1?Q?041z9UfPZGCRU6IADQNYs/Ste0s5qOpc9ZyeTcK1R/IyBgP81hb+A6I0A4?= =?iso-8859-1?Q?21ngIw5mnt9tAooYXhvLkxka37ag36aHXhRY5HEm/xvN8hX0fzWOL36rq7?= =?iso-8859-1?Q?TLZJaxB9n4Xx2BDoGh1oRk/5dwruaoaPsh9utuwq9PZokqXRKhT5Lw4Ykf?= =?iso-8859-1?Q?Ed//yCKydIxHRSWrsEY7T//rqafPG/EWeJwMfIMD1EYdSg8vo7P87bxu3L?= =?iso-8859-1?Q?g0kUW+0jmulyeZrKAjEPXwxjMa0z/isAgIdllhmJZEu3Jf/jzg4Hf8Ya06?= =?iso-8859-1?Q?LEvj+Ml8cKUAEBtvGcvs0/sKVO9zc2ElHlNP1Y2OGTsYrzRe7VmWkRMfNX?= =?iso-8859-1?Q?knrDB1LwXb7JnjVVVM0XjWujF8ERwON1g4J05HjwLI8eG8cLhARC3T9QZV?= =?iso-8859-1?Q?l3fBS++HObRPUj3SZNiXWdS+A1OXwMw8KYxDmPIa4gVikzhxGJL6FSThd+?= =?iso-8859-1?Q?qR+R4b0OnlEt9pxtGgGscyi8BSxwkxYYV2b++lRRP/0bv5bjUZqywq57m5?= =?iso-8859-1?Q?IrqwxZyIbarEoSNPwI92gBKRMd1zQMSDUu7T79Lm12vkQAGdv3achFynsf?= =?iso-8859-1?Q?33K36FI3j2oEzPF/+VVUy0Vqu891Z3J3dIgH1bwL4faSuFr8lLGFNO7Yje?= =?iso-8859-1?Q?T3ci5AYH7Yhik+5soQyEOX2fZKBKuvBfQ6FaM9nWA1PZ6KAJbo8Wnfun+R?= =?iso-8859-1?Q?gd4Z8G8mknjvogUaBhZrjs9rrveQDZZlM5ta0L4QpORetbPhRSHUDqabyn?= =?iso-8859-1?Q?YOLh/gjgTNpG59rV1EC+/5RfiM0rPezjieS3zdQFzWNfpqkPBE1tvWstHx?= =?iso-8859-1?Q?jkZaSAhTZf5fGhJYjSliOaOkoXNAFauFr6JslWLqQby4wmEgTcV3FPVE3p?= =?iso-8859-1?Q?+tGaUTB1unycFyCA9/05lFiNwDYSZqfIgVrE77EmfPCF74dWJxZmNpW7KJ?= =?iso-8859-1?Q?mD4JrqERVrf6cVGQlBqw=3D=3D?= Content-Type: multipart/mixed; boundary="_002_TYCPR01MB10004F2BBF48917C06E73BE29FB082TYCPR01MB10004jp_" MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: d0efd68d-5b31-4f4c-559d-08dd27b00877 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2024 02:25:16.6229 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSCPR01MB13123 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 74881 Cc: Eli Zaretskii , "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --_002_TYCPR01MB10004F2BBF48917C06E73BE29FB082TYCPR01MB10004jp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > From:=A0Michael Heerdegen =0A= > Sent:=A0Saturday, December 28, 2024 05:49 PM=0A= > > +(defun ediff--delete-temp-files-on-kill-emacs ()=0A= > > +=A0 "Delete the temp-files associated with the ediff buffers."=0A= > > +=A0 (ignore-errors=0A= >=A0> +=A0=A0=A0 (let ((inhibit-interaction t))=0A= >=A0> +=A0=A0=A0=A0=A0 (dolist (b (buffer-list))=0A= >=A0> +=A0=A0=A0=A0=A0=A0=A0 (with-current-buffer b=0A= >=A0> +=A0=A0=A0=A0=A0=A0=A0=A0=A0 (when (eq major-mode 'ediff-mode)=0A= >=A0> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (ediff-delete-temp-files)))))))=0A= >=A0I think this is the same as mapping over `ediff-session-registry' which= =0A= > =A0should hold exactly the list of buffers we want.=0A= > =A0Second: Can we move the `ignore-errors' inwards so that an error in on= e=0A= >=A0case doesn't abort the complete loop?=0A= =0A= Sure, I had attached the modified one towards your comments.=0A= =0A= >=A0>=A0 ;;; Setup functions=0A= >=A0>=0A= >=A0> @@ -488,6 +496,7 @@ ediff-setup=0A= >=A0>=A0=A0=A0=A0=A0=A0=A0 (if (ediff-buffer-live-p ediff-meta-buffer)=0A= >=A0>=A0=A0=A0=A0=A0=A0=A0=A0=A0 (ediff-update-meta-buffer=0A= >=A0>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ediff-meta-buffer nil ediff-meta-sessio= n-number))=0A= >=A0> +=A0=A0=A0=A0=A0 (add-hook 'kill-emacs-hook #'ediff--delete-temp-file= s-on-kill-emacs)=0A= >=A0Would it be ok to avoid the above loop completely by using the buffer= =0A= > =A0local version of `kill-emacs-hook' instead?=0A= =0A= I didn't found a local version of `kill-emacs-hook`=A0example in emacs git = repo. =0A= Current version also work for the killing from command line, for example ex= ecuting a "pkill emacs" during ediff session.= --_002_TYCPR01MB10004F2BBF48917C06E73BE29FB082TYCPR01MB10004jp_ Content-Type: text/x-patch; name="0001-lisp-vc-ediff-util.el-Loop-the-ediff-session-registr.patch" Content-Description: 0001-lisp-vc-ediff-util.el-Loop-the-ediff-session-registr.patch Content-Disposition: attachment; filename="0001-lisp-vc-ediff-util.el-Loop-the-ediff-session-registr.patch"; size=1121; creation-date="Sun, 29 Dec 2024 02:25:14 GMT"; modification-date="Sun, 29 Dec 2024 02:25:14 GMT" Content-Transfer-Encoding: base64 RnJvbSA1ZDIxYjY1ZWFhNDVjOTk2MTgyY2UzMTgxYjEyODllZDAzZmYxYzI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBT dW4sIDI5IERlYyAyMDI0IDA2OjU1OjAxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3Zj L2VkaWZmLXV0aWwuZWw6IExvb3AgdGhlIGVkaWZmLXNlc3Npb24tcmVnaXN0cnkKIGluc3RlYWQg b2YgYnVmZmVycwoKLS0tCiBsaXNwL3ZjL2VkaWZmLXV0aWwuZWwgfCA5ICsrKystLS0tLQogMSBm aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9saXNwL3ZjL2VkaWZmLXV0aWwuZWwgYi9saXNwL3ZjL2VkaWZmLXV0aWwuZWwKaW5kZXggMzM2 NjY1MzU4NDMuLmQ0NDg5NzNiMzQ1IDEwMDY0NAotLS0gYS9saXNwL3ZjL2VkaWZmLXV0aWwuZWwK KysrIGIvbGlzcC92Yy9lZGlmZi11dGlsLmVsCkBAIC0yMTksMTIgKzIxOSwxMSBAQCBlZGlmZi0t ZGVsZXRlLXRlbXAtZmlsZXMtb24ta2lsbC1lbWFjcwogICA7OyB3aGVyZSB0aGlzIGhvb2sgY291 bGQgcHJldmVudCBraWxsLWVtYWNzIGZyb20gc2h1dHRpbmcgZG93biBFbWFjcywKICAgOzsgYmVj YXVzZSB1c2VyIGludGVyYWN0aW9uIGlzIG5vdCBwb3NzaWJsZSAoZS5nLiwgaW4gYSBkYWVtb24p LCBvcgogICA7OyBpZiBkZWxldGluZyB0aGVzZSBmaWxlcyBzaWduYWxzIGFuIGVycm9yLgotICAo aWdub3JlLWVycm9ycwotICAgIChsZXQgKChpbmhpYml0LWludGVyYWN0aW9uIHQpKQotICAgICAg KGRvbGlzdCAoYiAoYnVmZmVyLWxpc3QpKQorICAobGV0ICgoaW5oaWJpdC1pbnRlcmFjdGlvbiB0 KSkKKyAgICAoZG9saXN0IChiIGVkaWZmLXNlc3Npb24tcmVnaXN0cnkpCisgICAgICAoaWdub3Jl LWVycm9ycwogICAgICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBiCi0gICAgICAgICAgKHdoZW4g KGVxIG1ham9yLW1vZGUgJ2VkaWZmLW1vZGUpCi0gICAgICAgICAgICAoZWRpZmYtZGVsZXRlLXRl bXAtZmlsZXMpKSkpKSkpCisgICAgICAgICAgKGVkaWZmLWRlbGV0ZS10ZW1wLWZpbGVzKSkpKSkp CiAKIDs7OyBTZXR1cCBmdW5jdGlvbnMKIAotLSAKMi4zNC4xCgo= --_002_TYCPR01MB10004F2BBF48917C06E73BE29FB082TYCPR01MB10004jp_-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 02:04:58 2024 Received: (at 74881) by debbugs.gnu.org; 29 Dec 2024 07:04:58 +0000 Received: from localhost ([127.0.0.1]:53575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRnMA-0006f0-1V for submit@debbugs.gnu.org; Sun, 29 Dec 2024 02:04:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRnM7-0006ee-OS for 74881@debbugs.gnu.org; Sun, 29 Dec 2024 02:04:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRnM2-0005rm-1Q; Sun, 29 Dec 2024 02:04:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J2r9RlNC9+OKJiPTgEpFR4xYlBORhGWWi8F2XzxkRZw=; b=BtAUz5x7YSw+ luBvWsx2shFVkg0vV/2MowCLKxWhBRjMgY2UtDyCSVjiWlE/bpcTGnlL83W/sX0BTW0vcr77b+y/a 60d39n+7mDaKE6EPHIhWx4Iy1c7Q5Y/KXfDKc69DK4fk7EgqmRBNEyVypsfWoXASxpF/tnku+nyDT gwSfYTl1kTa12yqJRQZmEUEC2c0xIBREl10a0k1hSed1tB7Wcnc20LlrXhZli8vEvfCsy9clxRUFg S86AiWeGw1FvDy+xw2Bt3qAn8B+RTzUEwv/feDZSfCrgy+3I4L50XyyNFUsWbDAkgd5aPXDdK42Cu FTO0cifZwIqfU0wi9sH+PA==; Date: Sun, 29 Dec 2024 09:04:47 +0200 Message-Id: <86jzbjq8a8.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <875xn3jm1x.fsf@web.de> (message from Michael Heerdegen on Sun, 29 Dec 2024 02:49:14 +0100) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881 Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Eli Zaretskii , "74881@debbugs.gnu.org" > <74881@debbugs.gnu.org> > Date: Sun, 29 Dec 2024 02:49:14 +0100 > > Second: Can we move the `ignore-errors' inwards so that an error in one > case doesn't abort the complete loop? Binding inhibit-interaction non-nil could cause the body signal an error, so this should be taken into account if we move ignore-errors inwards. This code must NOT signal any errors, ever. Which AFAIU means that if we want ignore-errors not to abort the rest of the loop (why not, btw? these are just temporary files, after all), we should redesign this loop such that it catches the errors and continues with the rest of the buffers. > > ;;; Setup functions > > > > @@ -488,6 +496,7 @@ ediff-setup > > (if (ediff-buffer-live-p ediff-meta-buffer) > > (ediff-update-meta-buffer > > ediff-meta-buffer nil ediff-meta-session-number)) > > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill-emacs) > > Would it be ok to avoid the above loop completely by using the buffer > local version of `kill-emacs-hook' instead? You assume that the temporary Ediff files are always visited in some buffer? Is that assumption true? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 18:33:28 2024 Received: (at 74881) by debbugs.gnu.org; 29 Dec 2024 23:33:28 +0000 Received: from localhost ([127.0.0.1]:56565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2mm-0003hj-DV for submit@debbugs.gnu.org; Sun, 29 Dec 2024 18:33:28 -0500 Received: from mout.web.de ([217.72.192.78]:47501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS2mk-0003hV-D1 for 74881@debbugs.gnu.org; Sun, 29 Dec 2024 18:33:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735515193; x=1736119993; i=michael_heerdegen@web.de; bh=38+VSkw76FMUR+0SA1rUc+xN0FjokHvzNOlZXraH1tY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ROONbBeUNKvsKils8vxEIIjurpxrE2InCZXAN4a5NtjUml+PCX67zpxXau2JGSw8 CCbD9maxIXcTLQ4WB7Z3yr47gajl3h+TGab1kCvrsB5RyLZ7307BVkqmy4JdAeqN+ 55kB71MSO/FGkqdWBgKnPO9ExeqS6/33BbP5BVAR7exstGSM3J/w/9bbMG+qW3Uw1 Z4m8J6DTCCASmFmCASg/HI1hcvEBcvCXj0DhNPVSIlLKhcfmj5OCrZj3ClH+v9PJ5 WfF5cCsPl39c3ODgvhd+B6NbNA8DaAp8XGonxXtSTVjLa1L2qyJvQzTdDiYMAc6PF 0m1D1F40+2VYsxzF1w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MCXVZ-1tJYaY23oB-00FawS; Mon, 30 Dec 2024 00:33:13 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs In-Reply-To: <86jzbjq8a8.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Dec 2024 09:04:47 +0200") References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <86jzbjq8a8.fsf@gnu.org> Date: Mon, 30 Dec 2024 00:34:22 +0100 Message-ID: <87zfkevzb5.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:6CUcQraqU9rAkyB4eC9CJMeSFW5PqMqHZg585XqTmD9n66FoZmF 3PL5A8nyCI12dXNKc/SAe8pob8Xa4XF3XhDAU+K63cdLn7ozuZ6yFdYyxQUwYMS4L/BVLvD Oby/cYgUsIpiXGjKN2XO/ukkaZ2Jmo6iKg5DdN2wEYJ447pU1gVgaUUBytEqmtakf8HQV6q ZtwZJG1uGWo26479CiOxA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:+N7544LpjCk=;RvnamCoRODXJgzaekKoYNS5OgfW 8LP7ABDBIWbAGXUSTnvWqkC69M2e+LlpqSmgQrr+PIQVgG7/93kT4asyWISocnq7jV81q/Pc6 GhcfcmwgQlLxcY+tV5qHwpQLzw5TwTLbfViIh+OLVIKseor7zbjIr7oc8gGmCywQTUVflWYJy fW/256PdLjA9onEs+iXPDAM8PPBpVnU56Cn2LPGktS79k5FjVd26xSycY7N353diSyUZgvHYy fbMYEr9TCl/XG3Tx0fTQR0QaCnVz62Z+lpnSG07v1UikF5zI+4w2NUZyTNwzPN1BjZenCfhhm mlKTPE6Fmgt6VtL2IObDoE8dvxTLs9lGAOtUEzbYMbn5idOo5tMUCApWwL4PcqMMpehwv+14R 1e+HyOAoiq8z2iimLrz5gcRzmqfICyIjo60mkfVzUgaqiGrYFyj3IECu+cKTLCyhm+arCWmq2 M6rVXysdb9coJg46yKVXXcz/UoaPQQyoyFKoNV6vKEvlAWr+yfOO9yQtxBnYY8EwdGm05rD8c beZ4jr/gsAB+JGJnU/eo8Oe30RtPG5CG44DAAZeCC0D2znFLPDgStsQMjIitnQ3i5k2mwhnid Yp6z6Wj9a50w2AinRhnoRwY9IkM6TKqPqI1XON50+3J0EKZdd5Peo7tPtteCl9dycJDIXRTGg tizdG723duogR2UwZsnCHTwHDyCWRppP0arUqwamClE5H4vG/gdAF6T5oZRyUmtok5hTsgbvw Qhb+SdzFDPQl0fRqeFeUqRUQm7zSYD2Gd3PxgyOgR84goEclPtriece135NT4uHHDai+Bv+WD 7Eu0UGStP/aAz5hi+Uuv3b5FORJp7D/0v/TsPQmMfT/BcKgDlIODe4PCIvmDnLrO+Xt0KLz1x rBwj6UcXO2zGlgFnyIG4FD2TVoc9+oJ7WF0XelWmIqhWSN6DhHZujXzWZN+vUaxgxztYvB6AB B2QeXETdJhfWYBMCy8A7Q069FritW3L+n2Voheh6IAyCKMObypEa0iXBCZkyyhB243EMxEUOx 4UxyLImv9OXve2fEFswlqS08gByEpfDNxzjmuHDUlyp8jIhc+8pb+syyVC/7UbaXr13XgrGrz nKQo9xhrI= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74881 Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > > > @@ -488,6 +496,7 @@ ediff-setup > > > (if (ediff-buffer-live-p ediff-meta-buffer) > > > (ediff-update-meta-buffer > > > ediff-meta-buffer nil ediff-meta-session-number)) > > > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill= -emacs) > > > > Would it be ok to avoid the above loop completely by using the buffer > > local version of `kill-emacs-hook' instead? > > You assume that the temporary Ediff files are always visited in some > buffer? Is that assumption true? I think you misunderstood: my idea was to put `ediff-delete-temp-files' to the local hook binding of the ediff control buffers (which we currently consult anyway). This would result in the same calls as now - at least when local `kill-emacs-hook' bindings worked. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 20:36:41 2024 Received: (at 74881) by debbugs.gnu.org; 30 Dec 2024 01:36:41 +0000 Received: from localhost ([127.0.0.1]:56703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS4i1-0000fb-4w for submit@debbugs.gnu.org; Sun, 29 Dec 2024 20:36:41 -0500 Received: from mout.web.de ([212.227.17.11]:40735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS4hz-0000fN-C9 for 74881@debbugs.gnu.org; Sun, 29 Dec 2024 20:36:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735522585; x=1736127385; i=michael_heerdegen@web.de; bh=Fm4x3ZDk75mNKL5kPLOx3BFj9/0swSYdHNgUz91FiXw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=od1Q8N7X1WEw8jyG9S8o957uilDEqnUSOOogZ3mbd4Zlq1QC/6ceoa+sm/oEHPDR fNeBHSr3qw8+5mgWGm3REpxCbN43bV5tq+EmtOJaTIpOrWhakpAVfjGbsLe4HZnsQ t7Jk1CspkVpARm5kYekLYTbulHERvUhw9p86ZUgRCUr/xvBm8YvbvnoKz8C+7EN3v RpDNqeKbtIRLeb9caGedZQW+KDiiCWEugDruAJ8yHm3SPapYYw/6oVeSbaq/WtPt3 kJhY3t0dCFI6x/WaJ3S9syNf6cWfVPDGPDht8YICsWxDXtV7l2eQpzzms+fupqDDp OL1Ok/RzR71tQGrWjQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MW9vU-1sztsQ45tq-00QvQE; Mon, 30 Dec 2024 02:36:25 +0100 From: Michael Heerdegen To: Lin Sun Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs In-Reply-To: (Lin Sun's message of "Sun, 29 Dec 2024 02:25:16 +0000") References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> Date: Mon, 30 Dec 2024 02:37:33 +0100 Message-ID: <87cyhavtlu.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:COMsTIgsDywxjfroK5arH23oEo69+P9zdcmblz7/NY3+7nqYW+s kai8jRzyEaZxkKD8KZCkVO8+odev3w6jSCxZN+6g3GQNYra2LW5KZr47/IUPktxq5CgiPCC BmVm5Ve+wxvqC/WUEwXGIsWCS+R+QNJBhzMMTEQDblPTRfsacu+M5JmxWr8I9jVwiAkjouY zxo7ZCe8hiPXkXW0hmT4A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:dswS9f7kT8w=;rvqvvNU5lQGyk6YzTlJCJ/nAHk/ 88cqxuMZlzXzFC0bZwWpqBwM6iPTFUGbbbE7ayMXLbU7O80dmpxmATTzMAA4lmDNBzojV8MDN r3XN+oHqiVCzRWFoHmsB/t6AHME508olYueBHS2uV68NrEmpJg4riL+rCt1BxtW9oWDrodzwX 8Rces6qG71nKzYiBlAvg2g422tkP8TA4l5XXYYarGCd0t6QzxndFzi923avAJriMaDf2hrUqc vkMWLDlzo8u93WAh5oEuPjGEP09N42YYnbmm2xVEJx2u9iO0iOB4/8rK3Ct8ds9xb4/fswYsg aoKriKfwoY0y/qzjkcLNVRqvqKUIke3qDo15B3kecaaGb2DSk5QjmMCfjdi6rYk3m8s2O/YHX pYzDnyj80+xZp6AAlawXzMJLCKvO5bA/JueluKdIpB7GSfX9qeUK7XyiOIq/WjVAwFguiSeFd iuRHY54I/8Rlrh0nMDH4YUwyq70lN/m0Ay/THP8YkTufYYKdlsmMLfNDpFYG6N2dVi/KNwVB7 ktW6mSFdt7ld1qda37LtOp0zqZaaDqXVmwPMxPeBFWT+U4N0GHN3Yhe1PIhpKuRgiP7tu6pS6 yxD0RqllgoYcVEP7/cSLK0K469ZTmLWjqYrb6KdLAAPZv8ZmAtuBJcgVMxGw0j21sy7BA7YG3 DQDItGpa95RfRo86Gl+E13wtY3yVm+8EXSjazgIPoSTfkLeEz+76JTLKIZQLOtECgONDhBVCy FunBj/2s2JVNQE5/sNaMdkWhrznXphqYlNaliArdfJoQFZF5S4FMt14ryV9OIwygMdm/sx8Ag 8mnksVCnbCVmFkJQZq3RlKCS1fIQgHL/bTBgbTWEbtD8V1au2nmAjfCafZqyRdqDpuKrLQ9oX OtAnrgkYPAD7pETNEwtHc2eEyxMmBnEobvaC2/RThwnmovkd9VgfXCqhW1YspINNOzzUys5P+ 9AvpG/R4BNPvacQilpeOqcHG+2vmw8ukH/AhphMW+alPSnBbAdpNNLOq25uEsfW8d3Gcw7Hl5 wIsQnbkfDQy0em2tR9Ay5snI8udFwpo1//jhSHAhOeEP3U1+oWBojAk9lFewMT8LgR4GFgVii lt8WpN1ls= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74881 Cc: Eli Zaretskii , "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lin Sun writes: > I didn't found a local version of `kill-emacs-hook`=C2=A0example in emacs > git repo. I would expect it to work. I found one in Gnu Elpa, in "subed.el". > Current version also work for the killing from command line, for > example executing a "pkill emacs" during ediff session. I think this feature would not go. > diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el > index 33666535843..d448973b345 100644 > --- a/lisp/vc/ediff-util.el > +++ b/lisp/vc/ediff-util.el > @@ -219,12 +219,11 @@ ediff--delete-temp-files-on-kill-emacs > ;; where this hook could prevent kill-emacs from shutting down Emacs, > ;; because user interaction is not possible (e.g., in a daemon), or > ;; if deleting these files signals an error. > - (ignore-errors > - (let ((inhibit-interaction t)) > - (dolist (b (buffer-list)) > + (let ((inhibit-interaction t)) > + (dolist (b ediff-session-registry) > + (ignore-errors > (with-current-buffer b > - (when (eq major-mode 'ediff-mode) > - (ediff-delete-temp-files))))))) > + (ediff-delete-temp-files)))))) >=20=20 > ;;; Setup functions Yes, this is what I had in mind when the local hook can't be used. Thank you, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 21:08:22 2024 Received: (at 74881) by debbugs.gnu.org; 30 Dec 2024 02:08:22 +0000 Received: from localhost ([127.0.0.1]:56744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS5Cf-0001zy-6T for submit@debbugs.gnu.org; Sun, 29 Dec 2024 21:08:21 -0500 Received: from mail-japanwestazolkn19010011.outbound.protection.outlook.com ([52.103.66.11]:4555 helo=OS0P286CU011.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tS5Cc-0001zh-2Z for 74881@debbugs.gnu.org; Sun, 29 Dec 2024 21:08:19 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bYr/+uXVUQ7LZMsI7eC6FGYdAejj1p0zUrzlL3i2sQkQghoGpuRY/2usIu7GwxXDgA6FC/6MxN5xH0+/J8wOnmNZUoNna9IB7LJjEvZU85nVEH/0yHGAMg1xIuzCiwLzdKhuepsFc8Dw27Qa2hKdKVzfP6aZ65qAuLMiKdVof4C/3dMRsJ2zNIX608loWvnkxUIsv2sox+/wMF/lT5wjCacb/gUvbO2qTpzumGeKS6qCiPFVhKF1ZRlWPVhsDeDmXnFTQacYD0TcizSqONfaxVEkMfZmY8QyBKBgle4nXH+0fqW7dUroIyLkZLtv3PFsJpOU8Htn+Mt390i6JrmwaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Om3LlKGUMxsRaaLf0mUftwummWg+ukulY749OHecRLQ=; b=DEVXpgB5DWCHvWO6MFvmzr0TRkEW3B1h3tnGZE7msL9hzCvL6M5Jwh7UBZfQ7MZ1nYoIlRgkBoXCDHMHh/1eNehoEM0TS01RiP2VJLHhrmX+Ky07jJwhtOTkXo9j+FruY7q7JcEYoTzdlwZlBHpL/wzSz5yKIueasQTE9VpAcMssIlBWS5cKhpRux2e+g3NGTm2cQGnDH9KKzxQxvAj/tQn35nuNoUJGf84U6dUMTwKi5L4+1uWN5DwQ6tOb0vY+106gIKxFIdKXXOafBIaJY4AOvf6glKa8WXMIqo57bjzrU8w0+qN6cMcY+gmPfZwhXZfjNL8Za5U8oREKEQ/XxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Om3LlKGUMxsRaaLf0mUftwummWg+ukulY749OHecRLQ=; b=ZslUN/5pVXofO58K9ikdiD7nr4kSTX0tYbSVRVYz2IaSo2HtrvDPum3xU7W+cSUVC3wZleAIxUchsGVb9JQ2OSjOaIApgqUDwMjVsc99SqrgPvzDWFYKxfXxzi2x9qoq/iGf1Arpp4bhzobSvsgoZsR33wnX7Fl2CiPA//bCWt4M1Iiu4fAzRJHCm9ZBvlvsfT6v7Hr6VjJzSIlLTWqT6fTXQIjvBam6/UKYwK4Z5kKNLUqs37ItkUaHl6WsKQqV5klNXzjNYsl3L5/DUaI6uGVtvB+So48INjt0IgMXaUL1AT2ymSBRxfK/cAM8JrpoK/Qyn+4XP5c6XPMP+VeB1Q== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by TY4PR01MB15178.jpnprd01.prod.outlook.com (2603:1096:405:26b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.19; Mon, 30 Dec 2024 02:07:51 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%7]) with mapi id 15.20.8293.000; Mon, 30 Dec 2024 02:07:51 +0000 From: Lin Sun To: Michael Heerdegen Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWyAAOzfEIAABgUagAEqgPuAAAjhSYABhi8igAAEefQ= Date: Mon, 30 Dec 2024 02:07:51 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <87cyhavtlu.fsf@web.de> In-Reply-To: <87cyhavtlu.fsf@web.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TY4PR01MB15178:EE_ x-ms-office365-filtering-correlation-id: c442d211-dfeb-423d-90d6-08dd2876c3d2 x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|7092599003|15080799006|8060799006|15030799003|19110799003|461199028|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?NSNYZf3CIvxPB8EEmkIkx9WuzYR2yPG2bo+/oJe2icj2uUPpSfxiA6Rnu5?= =?iso-8859-1?Q?xaWUm4LGsTdEaO0fjlfbjkuDrE2vDVdIadIqBCwfe3OiyED92olrs6/3qC?= =?iso-8859-1?Q?1Am7cHGkt0PY0AFy2AlQWIgJex9134PG1GDaOg0MjUd8gKxod//jtcLdfc?= =?iso-8859-1?Q?tk7iaR4+uJUZdLfjMAwDxNgnNFI+p2lYqUoAMrcx5PBZlxZcSj45Cn3Ae3?= =?iso-8859-1?Q?//ekZrjiuaxZNtn3oVskL1B7bKYBgOQAkPsV2JG+eWUhTAHJFQ9GIV8o2g?= =?iso-8859-1?Q?qfSolCGAb6koxlLhb0b0YSM1cltRH/68LDvif9VA2jKeSEwGeWf9eMxz+0?= =?iso-8859-1?Q?FJSSx3owCRI7lO7T/aZta8OUXOqOEROC020UTWpXppItp5KEq2JLQCSk8S?= =?iso-8859-1?Q?SVb3oo5+1hbsvs/JCIX6wJ+SAHCzs1QfuGjP5WQv0ulk/NgxzWxnVTd99L?= =?iso-8859-1?Q?XCz5BeWbRHL6pTNNVD3UBPP3ymbRmlXR4aEeyVDncqPAWHIzxcb8jFcIXV?= =?iso-8859-1?Q?jZHeFkVk0+2OLpgn0Vp55ay/j5v1ucdNY102QMxkY7ssvR4Rnj8q4XX4B1?= =?iso-8859-1?Q?Ee4fl8tROA87b/Oca0BwsqrJJVqQapY5rWHBGhRK97Rt8qPzsrZKz5nJjU?= =?iso-8859-1?Q?XLVXuOyNlm9eZc5SDjBAnvfQOIy+3AMNWHr8ipjINGzfm7sijyvsWAoGA9?= =?iso-8859-1?Q?WMvpiVpCMZKUotDTO5PJBAMYe7hFi5i5xc108wfhUcqzCIZ0f46oqaLFP5?= =?iso-8859-1?Q?GjE7drX6jhv0NB+oTTCZs5YKKDqLWYsWv2HPxd4NXeYLfnl0yT2id0JMtV?= =?iso-8859-1?Q?jnnh6JSKhpCd1emmkJLziLiFfViGsMo8IHNdpzn9FAeC4oKRx2qLyRw17c?= =?iso-8859-1?Q?2pITxJShSyDTO7gUY7UJ2djtmdkif7hZ6q5OKmrd20Ur8sxhTEd1UMfR1y?= =?iso-8859-1?Q?RaHgJHtaas4iiBbc2YvRTnrUV/8tTwmfvo4AB1pmMpUzWJmE/srmSu5cRK?= =?iso-8859-1?Q?X5+UjfrzNVNm0fQ+afI7xk9SbNnmnDWaVsdY2F2uE0VJkANbgGM5OkPIt/?= =?iso-8859-1?Q?ViwtEFNGcxa7+Lk+GQwHGsJ79qVJOFCWxouTPQkUYxEN20gNFHH660yqgk?= =?iso-8859-1?Q?4Yjn6vhvZvaDkZJkvZPaZV7gDiWGc=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?FjWmiTVNHOW5A69ESwWwqDPhhAXv7EV3WplfHuOpD9W2ilZDgHmzvfPjns?= =?iso-8859-1?Q?i9QhL+RKMijXbdA4ZNcHG9AYdMlPfdVAdnkQK/d6ndYIBsSRzbHtPr4Nki?= =?iso-8859-1?Q?GrZIg6qAEN9/xSFPuw9vizt2T1t0gGj0JV5aJ0VpFx5tPW3jwVAdUQXpQF?= =?iso-8859-1?Q?caYLH4EsUg+qiiFEx9i6weaGyvstq5CqQiJo0qv+oZYMTuWWPq/dRpJmYe?= =?iso-8859-1?Q?CtjtlUazY4OCfz1MHVO1Tn5F5apXrFqe8ryty7Kc2PZaApwLbn2ecabVGj?= =?iso-8859-1?Q?SAJAjfr/iKwPNISgwJG1+rOV/XTq2w5SwfexBsJzTrGalEEN3ZUVpmRZvg?= =?iso-8859-1?Q?CgGJgC+gfRnrj21YTCfhV6oFwhmz1Rg2I/H4l3H9EFR5tqYr9CCglJzrpL?= =?iso-8859-1?Q?pJVySa5t7Cx9AlRPRUfUx0NaFfS3JC3GUVDoBHKSlcqQjGwcOtWkhfYry2?= =?iso-8859-1?Q?GI9+o05YaEUTFxIyfP6icVSsFiLFPsRPanHZO0f2W2C7CiJo9rdgJH4Lkg?= =?iso-8859-1?Q?ttrit8qtXjbrj3mcGQCuMjFccOenXZsNUr/3bcRK7PFA34KWoZD2mszPdW?= =?iso-8859-1?Q?bME1wN+MDYFfi0f06rbCnNPmYdJxyp5M6g217sx4hOuqyOEddSugW+Em24?= =?iso-8859-1?Q?n0eRV7flj+VoZXlvB/Ky8iALEnjx7FVQu6+xPMgLpEqa16TNhbqz0B17rq?= =?iso-8859-1?Q?XjjqKyDMNmABkCZKNsFLzSnNW+7opmqdObccGeija7SxEcnDxiuCBQ+a10?= =?iso-8859-1?Q?exud20XZbgyJg44BsZHtlh5EnI90hJ3GNxRBPnCoZ2MHBat4Rbfic5/mum?= =?iso-8859-1?Q?u3FTs2yMh0Qu7aI1bJr5vLjUeTDbEiZszekVXTSROyIJCP+IZt7xVxs00M?= =?iso-8859-1?Q?zmYIsoS94AF3wNuWPe1H448A0ZvmyxysuKDdLM+gDDL9OKHLf96n18UheL?= =?iso-8859-1?Q?1mU3FHXdBj7xzBQq3njf5Ofpv6iEejZV+dnjUZ/+Fg8jB9QCrYjKyoJrDe?= =?iso-8859-1?Q?46sd2q2W9I9BGHuYNN5xsAFpJ1LMPnt9Zhq2pXJ8i8QDWW2uitkIkQUeuh?= =?iso-8859-1?Q?RjBPj2rdWDHY4ksIpLuBe85YUxr7jcOKhoo0g4S28DHQb3eIUv2QSonPx3?= =?iso-8859-1?Q?hWJFw4HH9muT6qa4cB2zwJiZxLDvL+iOCF46QYGSDeWB92MOc1u/kRzKbM?= =?iso-8859-1?Q?lA+oznzuTuvn+z0RrtEuHbkxVHR8aauLLflvF23xqgy+newCOKustC9xP+?= =?iso-8859-1?Q?5Fr3KRiKmFChsU4CDjyw=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c442d211-dfeb-423d-90d6-08dd2876c3d2 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Dec 2024 02:07:51.2966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4PR01MB15178 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881 Cc: Eli Zaretskii , "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > From:=A0Michael Heerdegen =0A= > Sent:=A0Sunday, December 29, 2024 05:37 PM=0A= > ...=0A= > I would expect it to work.=A0 I found one in Gnu Elpa, in "subed.el".=0A= > ...=0A= > Yes, this is what I had in mind when the local hook can't be used.=0A= =0A= Hi Michael, thank you for comments.=0A= =0A= And I had tried adding the function to kill-emacs-hook with "local" flag bu= t it does NOT work with kill/pkill emacs during a ediff-session, I don't k= now the "local" kill-emacs-hook behavior is a feature or bug.=0A= =0A= So the previous patch maybe the suitable one for current situation, it avoi= d looping all buffers and almost won't affect any user experience. Thanks= From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 08:02:48 2024 Received: (at 74881) by debbugs.gnu.org; 30 Dec 2024 13:02:48 +0000 Received: from localhost ([127.0.0.1]:57745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSFPv-0000Ek-C5 for submit@debbugs.gnu.org; Mon, 30 Dec 2024 08:02:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSFPs-0000ER-CH for 74881@debbugs.gnu.org; Mon, 30 Dec 2024 08:02:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSFPm-0000dB-Hp; Mon, 30 Dec 2024 08:02:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=37o0Zrpiwdb4lt2oNRdeTl5P7IhbTDmzLc4J6uaCde8=; b=NETdvjwARUgm hHVOh1oTsK0KAj3OMwBXsAfaYxtjdNjkRdCtkmoJteriJU8KT4tJkggJLGA8sscEbiOGTMhTikRNA By+EVBi0O5nCxTo0MKV0CrRyCs2AvxpiJX0I5VZg+bmC+NDSjmvd50vvICEZKcVVbasJdh1UmOdlt QPJZL2tnnXY1RxHOjA4oURyptOzDwamef5hZ0yhE9BEZqibhTOVvWhIrz5Jh2uALt5/1yj/ypwwaN hsbs/fb8ZaQiAO4zuW87mxGyznVew4i2iISDeaFseP+mI1QeCFLEJ5OdzFaD8uAnaCk0XY0oIwMbm rGFBK+JcaA+AuiG2K8hjPA==; Date: Mon, 30 Dec 2024 15:02:31 +0200 Message-Id: <86ed1ppbmg.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87zfkevzb5.fsf@web.de> (message from Michael Heerdegen on Mon, 30 Dec 2024 00:34:22 +0100) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <86jzbjq8a8.fsf@gnu.org> <87zfkevzb5.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881 Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org > Date: Mon, 30 Dec 2024 00:34:22 +0100 > > Eli Zaretskii writes: > > > > > @@ -488,6 +496,7 @@ ediff-setup > > > > (if (ediff-buffer-live-p ediff-meta-buffer) > > > > (ediff-update-meta-buffer > > > > ediff-meta-buffer nil ediff-meta-session-number)) > > > > + (add-hook 'kill-emacs-hook #'ediff--delete-temp-files-on-kill-emacs) > > > > > > Would it be ok to avoid the above loop completely by using the buffer > > > local version of `kill-emacs-hook' instead? > > > > You assume that the temporary Ediff files are always visited in some > > buffer? Is that assumption true? > > I think you misunderstood: my idea was to put `ediff-delete-temp-files' > to the local hook binding of the ediff control buffers (which we > currently consult anyway). This would result in the same calls as now - > at least when local `kill-emacs-hook' bindings worked. I don't understand how a buffer-local kill-emacs-hook could work. Emacs calls the value of this hook only once, when it is going to exit. So if the value is buffer-local, whether or not the hook is called will depend on which buffer is the current buffer when Emacs is killed. Or did I miss something? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 17:33:26 2024 Received: (at 74881) by debbugs.gnu.org; 30 Dec 2024 22:33:26 +0000 Received: from localhost ([127.0.0.1]:60333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSOKD-0003WB-PT for submit@debbugs.gnu.org; Mon, 30 Dec 2024 17:33:26 -0500 Received: from mout.web.de ([212.227.17.11]:54383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSOKA-0003Vx-4r for 74881@debbugs.gnu.org; Mon, 30 Dec 2024 17:33:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735597991; x=1736202791; i=michael_heerdegen@web.de; bh=IMWlcfr/c/yObca1hVYAn20fWfxhO9qbQvINhFmsTQ8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=YFXCCKA4OPknLiQB6T+4b7BHRekzxMVzFzDmb7VoVWL1gZWe3foNKgastsfgQfqL wrs9rIRzrWuGwEFNdroX9vErTjxgUtWivknOC4VUvEPUrTY25qTenemHVpwy8qp/L 22GWwpSPiWxKoLYG/A3JAr7hWrEKYFfOnJC+I6dT38MXK6tO3eckC4S4IGA/iK+Ga 4Hz45acKgOiDN5LjiylEq7+I5BO6/kFGNY/02cS3J8zRDI7VW9GzFWVzfYMdXI2d5 orQ8d5R47eZ9SL8sYrvsG3YPBUuL3kw41AIjYkHpQgYpwESPOFfqDev8v9vFBSNaJ PjrxxwuUSNE3bMpsIA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N4vNe-1tcWhv1zb2-010xY4; Mon, 30 Dec 2024 23:33:11 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs In-Reply-To: <86ed1ppbmg.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Dec 2024 15:02:31 +0200") References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <86jzbjq8a8.fsf@gnu.org> <87zfkevzb5.fsf@web.de> <86ed1ppbmg.fsf@gnu.org> Date: Mon, 30 Dec 2024 23:34:23 +0100 Message-ID: <8734i47qc0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:GyTjs1D1Z8hW3hJ4I1O/m679PyEpsJ1/ZgvhiEAkGJDdLQc6+OD gMq1vyYTM7oaBdKDa8t6bKMVKGC0okLq7Hs+TIkAbgZvx8Ir2Mwdxu2agaypv5qlE1Hn7DM EmEJCCFVj+U6hF4W3ICBHOdA/Dv1W9XgL9/29hXbD8jz1ud6E/vTcm1F/OrygR6es9jedpF mD4hlESFJfVnrSFoMLU8Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:aQnnPy56gmM=;9MHY0pSS6QWlgFrOrOaDreyY49Q RMmn4CEtsD/u8WWS09MmP/KBjuFkQvVWzO8gBTrD2+cwTwqcnle2lbMQ11zFjKKmIyRBK0Avo KWoCgEQ5Y9HckR4+dVvQseYzSM8by+5L1pfjBJuHVTH5rMM+nDLfzmI5YJJCqTsljq5YhDBCh s6TQSYl6/cZ12SEpXoUUuhu3TDJyFykifCJU38DWCRsVeO8WAYpfIMFc03u2P/ZXeDRbIMe45 hD8neq8ypxOWZVPzx9O38PuG4lsAepvEkVZ1bGFsnf90wp2LP1PevmkQBOfOoE5thvCW6i/km bllVhYsZ0W7keh0tzGoHn6Psu/yXUatI17dJn+rer4sZQnUwNXKegvp501V9fbtCvgHJiWz1U F3gVPVWLx0tWInJypml90DoyTCRifXuVu/+XVytkzmBOWMY/qC3ewQotr7DSWYX83sPIuC6na WVOX1tshxiQiRP89N0YaVUaYlgdl4i71aZBje52LMVxhgJmcqSzgO4M99Jm1DCXf0A33FD3de NWog8xnORFm1MboSbzMkkUBPDgP8NIDWcynPj/En9JgNAzgti1JlddqCw9YqmouQobpZ37J/P XECGuvmAZ2kwpw6OcJE57jUWnzMmKtneu7h2pEZPqG3lwRtcYmg/dH7lSoLHExE2b0Hf/Gx71 5SVfHGYELkRw/gVeOLdfV3i2FemPXgEzNPIfkIQ8RJJAxD9Nv4/R8uAZYVr6/WoRqdAF7sEVG Y6A8huZIL2hLxPuQAfkCgozfMAv/bWk0DYUxmn9Wl+fvRSfW5bRe9XLbAKql7QQT0K8cO1Yng EQ9KfQs9QlXZe9lzACC2Mok5e5mTWakFCP5UPWprilP06Gka+ssUafXYn5nYF6hEX9I0XTYLr W1B1UiAmAEUHKUhNvYgFYzC/+L0WT3BQ685pBtFowV9z4CNSLG8cXBGs4xq2ccKa3i13RA38u SDBq/yYlRlXMCAvL7rVw/Xc6EZfPaFm+lBNAwrnvKgERYCactCUDxZA6lA3kpkps3r6i34iy6 p0Mf2NaVxXFWJPoQhUeXFK9l9QuxfdCfKUy6NAxRfqfXDmvEYwoF6F9ikiqTWmmAAlFiE1Jel p9yR0vr2k= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 74881 Cc: sunlin7@hotmail.com, 74881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > > [...] at least when local `kill-emacs-hook' bindings worked. > > I don't understand how a buffer-local kill-emacs-hook could work. > Emacs calls the value of this hook only once, when it is going to > exit. I see - then my idea won't work. Thx, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 17:36:10 2024 Received: (at 74881) by debbugs.gnu.org; 30 Dec 2024 22:36:10 +0000 Received: from localhost ([127.0.0.1]:60340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSOMs-0003g0-Ab for submit@debbugs.gnu.org; Mon, 30 Dec 2024 17:36:10 -0500 Received: from mout.web.de ([217.72.192.78]:34071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSOMq-0003fm-IE for 74881@debbugs.gnu.org; Mon, 30 Dec 2024 17:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1735598158; x=1736202958; i=michael_heerdegen@web.de; bh=gT/fNsN441/eeIw96MZyAW1exfpAqaAjpXjxS2YUbSI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=HMiAFuoTq51ZYdcqA/OmuVmWEAdg7Yhs60clvN2ZmwVd0FO2/c8wLBNVvdVj3l0i kAykFDzv3LBBqYX5FwehLzMeR46Is8rdPbh/TiGLOEZgWcqm5mXDIfaOp2N6/ZXRh 7vzz5OzQdL4FoI3Mo/nSaaUCiA9NjesbYRbpdtNeKTau1biTNUhudtbAUhGXyKar0 /fQkuIUmIJ2YBSWKQ2yvFpCdJSH+8sEA1nNHnnN59epN7NBt6/5KCvwCkrAK29ZOW ulu90fnRXaCS4GWoQxj8jSjc6l20ZHUgaYlCJTrlSf/IJZwIVW+PuZNCppQtMwWXa goSzB+pr4AvZqQMy7Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.75.138.197]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MV2Ka-1t2aHw0QjO-00SAoW; Mon, 30 Dec 2024 23:35:58 +0100 From: Michael Heerdegen To: Lin Sun Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs In-Reply-To: (Lin Sun's message of "Mon, 30 Dec 2024 02:07:51 +0000") References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <87cyhavtlu.fsf@web.de> Date: Mon, 30 Dec 2024 23:37:10 +0100 Message-ID: <87y0zw6bmx.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:O1W0IN+QuW4/A/l00iHO6rO4a4irqsMKfMNHP+famFrWMp7tD0U xO6hSXMdvq/QAyhw6thE56QLpmJhBYQAYtcqUcNvOuF1H6t3WULNLDPoO1/ItAAjixBgrXi mfWwoiWk/oCa2eBzcOQe27E5hFBFxCkZmKyUCA3s+ZXWxAEHVlvcuP3qbbLFqEr6OG5FKTZ zST0cf4wezwXmSid/gPhQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ubndhrezBRQ=;nr+h0Hi8SlA9M3D+Z1fN+VQDpOa rrCWJ5cinwwXSNnmA1cIcv0TxriMcpFuHbpPiQaKvhA4cBk2tE7NVisf9TNM9Ine3cB7Owkh2 fQaOUTbAiPiHgiBt8jwA1mdOggGmIjL9JSOR3G79zeuDCAwyx3nZ+9OhiQ9zogfbFl6BCLXoe R1FAWPn7p0BftzmIlnWsmrZDa/6R1sb85zjo/f7+KX7Ve6ki0qkFIaHwUruZojD9JFRMIEXEt X/NfyPxt+YN5Ai5Mjn+igqp9o4ku2OWO4zmQW5lHTQebTenmpTfCaP/5y3oma9eyrS01C2XAy uP0DsDPGNOeUD6fBz8Mp4zOZWMxm19TH4sIR7dhhoq1+tOHjkPiHP/ukB+fVsamftd4x2d3xV LtEcyH0Rc9geUX5y6gMTVtduLQu+l440W6r/HZBg1AQvCO8V3MxVNbX+rKIQXyGhG8OtW34nj YCkeIFRrJP8ayoQ/uRVzTmWMwqL/vurVHKHWRWODPQmvd6VAFwEeJRiO0nywArAcmb8CIzLQl 6uW5oBVCN7vxEUnRHpdWJcNP6zo13vIJVDOdUEy1BcvkiDBH9mZ4vKSfPtznh0tpJ2wai0bOE +QtycQrg3CtcMGCk4bGx6vRJ/q7z9CXaJNkwi/S7dphoo0ltyMN1QDq6TH4ldE4QkNVcVzUFo PumHHMkB9Qy/jrXmWmI7wEQZzZrMfvTBPEY8ikVXnzRVPBsQHEo0CM7xvn3YbK9H7LX/vmaOH 6FPwDuWeQHZxFidXUPnDzcJ4RP4QQoOrqVPc/gG7g6SVuW3UfPOhcW84mZAfD9OMdwgp503zN +NYyGIS8D/roNDdttqa5gNRbYMa7MCmpq94FG7Vg4iTJJeSDBiiHqpAzMy7hb5U1uIdYdxWUu PY535Pp5Ih7gbFBw5IbSAn0pqdvBgu0sbUrSVS0QOVcTMtiZvgS635GmgMACRfHexN2JPMen8 yUrK67Y3VtUl5WQVaDvz7itHWoHCIrbpCwJ5p2bvM8+baiSUvp9cq/DllFMTS5rm78Jxz9iSc Bb1Kms0elQYoZkZnt4dI+RarPUPAXWMgnQZH69HrqOFh8XRLA5kKvnDKQaFohh25B/GsRk3AQ 8my6QUNw0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74881 Cc: Eli Zaretskii , "74881@debbugs.gnu.org" <74881@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lin Sun writes: > I don't know the "local" kill-emacs-hook behavior is a feature or bug. I also don't know, but it seems the behavior of the hook is not special in any way. > So the previous patch maybe the suitable one for current situation, it > avoid looping all buffers and almost won't affect any user experience. Ok, so let's stick to it. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 07:39:52 2025 Received: (at 74881-done) by debbugs.gnu.org; 4 Jan 2025 12:39:52 +0000 Received: from localhost ([127.0.0.1]:53802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU3RW-0005jm-H6 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 07:39:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49614) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU3RT-0005jX-Ds for 74881-done@debbugs.gnu.org; Sat, 04 Jan 2025 07:39:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU3RN-000372-RM; Sat, 04 Jan 2025 07:39:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=akTZxXigjSxprunwBdanNWLZp309a8rVPgTDCf18pXg=; b=TucyiCtwl5fG Zy1kDodPfokf5x1/4eiTW9olaQWiF7Xyi9mWtAESbu34su4Dh+PAtru9ZA2OnLD8AxdHTVeBpHbaR vWCT5YLmnmmLvAMTpw5Fxu+Syyry6M7jHaXLDK9FbuDkLyJEhBGAy+woOdb61cnFUMROcXbQmwCku ebcnTIceScWMVDQcNYDf/3pnJD92aWqCWwhgAURUpW3fJb/UBZaiP0RWlX3EJt11QOB1sy60631nT iWcFUOFFkeDFxnw+ebhuOSEGx0jjtAfymJnje9IFKaXCGBCx2TiQHJL2shFLBB2H1yzR0oX0TCh+3 pvkPFNgKuM//iE/3RjuHjg==; Date: Sat, 04 Jan 2025 14:39:35 +0200 Message-Id: <86zfk6da7s.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87y0zw6bmx.fsf@web.de> (message from Michael Heerdegen on Mon, 30 Dec 2024 23:37:10 +0100) Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <87cyhavtlu.fsf@web.de> <87y0zw6bmx.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74881-done Cc: sunlin7@hotmail.com, 74881-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Eli Zaretskii , "74881@debbugs.gnu.org" > <74881@debbugs.gnu.org> > Date: Mon, 30 Dec 2024 23:37:10 +0100 > > Lin Sun writes: > > > I don't know the "local" kill-emacs-hook behavior is a feature or bug. > > I also don't know, but it seems the behavior of the hook is not special > in any way. > > > So the previous patch maybe the suitable one for current situation, it > > avoid looping all buffers and almost won't affect any user experience. > > Ok, so let's stick to it. Installed on master, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 02:15:55 2025 Received: (at 74881-done) by debbugs.gnu.org; 6 Jan 2025 07:15:56 +0000 Received: from localhost ([127.0.0.1]:36515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUhL9-0002ZU-KE for submit@debbugs.gnu.org; Mon, 06 Jan 2025 02:15:55 -0500 Received: from mail-japaneastazolkn19010003.outbound.protection.outlook.com ([52.103.43.3]:18090 helo=TY3P286CU002.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUhL7-0002ZC-C2 for 74881-done@debbugs.gnu.org; Mon, 06 Jan 2025 02:15:54 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IkK5xxKKD9E7DK+o8nyC8hwnFhilsENOD0sRY5GWEXM+Bx3WRnyJ55xocgq3uXDQH21aZF3UTiaxja0L5ApDkz1UCorJcvHVBzx5ju+LmvYyjmTKVNSm7x8ioCF7AGmDJ3RX+Q/aASEKiBhqZNuDNmrz/f5F+KDXtspHoALREMvpow06VbaZ+o0llDOu5QUimEUya//vLvKw6tykTzfcrpEYrqZ8OoFWNU63ekRZjYUCSJ0E1IM0s8V4usK4BYukRZlCxJ8keJqr2UPn6nCsjVKcJ2PieV5PK71wTeGCmBSTkOYpoEhQOqBHUU34AhYbMwXn/O0Rhh2SIFF1lXjYxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FQ+I0xTnDr9UrATq7T1hlwJBlUeh7I+z+lchcUBFDzU=; b=qXlo86Aww/1xHZ94rRh1an92mQXpUFPB+wKCpnXRRLX90jJoLjgpZuJhvkaPl/EAjQ9Izc4skQrfcvrWMeaecwysV0dSYH+PYGxSZgq8Nsn4I8gl/7PXfFr1VvTZMkVdjAa+S2U3TwRD4crNVnGpvrv6DGbV/86no+BRsF6j3aQlrjqbgCvK7mUSTtfZIvhRyJba/Q++RrTwnqNm8C29QTkz9ZZ3/s5zE/EZpktAsdkPn8c8DuPV9LKEXvLYHIFu9hVij2gelfAU/uYV3FdmNVAauCZls21q+a16N7uO+jjHLhwrZ6eyLhJmrjS69Gv4l99kUCNeZJk9qAeVwl4yzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQ+I0xTnDr9UrATq7T1hlwJBlUeh7I+z+lchcUBFDzU=; b=Uo6E0phkzKT/cnMp+RX2T6rj4CNI/HSsH0DCJJanXK97Ui42bXFAzjogT2MxDuILTIbvRRTxQ8bfCv2U0jyzt9Ujl9GzLwoJD7FYiFDRuK207Tk1MtvVjcKzAdmxuIu9k7n4nZ3m7q7BDJcZH97+K6DyppUj4CModmNXkXVc6lnyc7vCG3baJNNnsTSe8r0+pfu5WkyKHvpZp8J8YJ4F+PDeFZYFyE0I/XKdpruXfiW8zKjSSDMkh1ymLXXsbQySE1XOEBS9j6gXH1OGMiSmgsHdOMw/JbOXsKWGFJnV7y5tpJRlbzWFWvL5tFKpwUsCk/rjxr0Ghvbg4IYqse5m/A== Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com (2603:1096:400:1e8::14) by TYCPR01MB6834.jpnprd01.prod.outlook.com (2603:1096:400:b5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Mon, 6 Jan 2025 07:15:44 +0000 Received: from TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8]) by TYCPR01MB10004.jpnprd01.prod.outlook.com ([fe80::8ecd:43a5:333:1c8%5]) with mapi id 15.20.8314.015; Mon, 6 Jan 2025 07:15:44 +0000 From: Lin Sun To: Eli Zaretskii , Michael Heerdegen Subject: Re: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Topic: bug#74881: 31.0.50; [PATCH] * lisp/vc/ediff-util.el: Remove temp files on kill-emacs Thread-Index: AQHbTrQ6C9gBTPBRPkO0xoraS9YsXLLm8oALgACRi4WAEiBNpoAAK+jtgACcYWyAAOzfEIAABgUagAEqgPuAAAjhSYABhi8igAAEefSAAVt0MIAHNQ74gALJ0Ms= Date: Mon, 6 Jan 2025 07:15:43 +0000 Message-ID: References: <86h675s77g.fsf@gnu.org> <864j2py29u.fsf@gnu.org> <864j2ow93z.fsf@gnu.org> <875xn3jm1x.fsf@web.de> <87cyhavtlu.fsf@web.de> <87y0zw6bmx.fsf@web.de> <86zfk6da7s.fsf@gnu.org> In-Reply-To: <86zfk6da7s.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYCPR01MB10004:EE_|TYCPR01MB6834:EE_ x-ms-office365-filtering-correlation-id: 79abb428-69f7-4159-0dca-08dd2e21ef53 x-microsoft-antispam: BCL:0; ARA:14566002|7092599003|8062599003|8060799006|19110799003|15030799003|15080799006|461199028|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?fBvGGLTAwM6wM6GEl4sayHHT+svHX0ZNau0AegOwPx/b7VT56/3ePcQI58?= =?iso-8859-1?Q?678HZ4m23ckE2Va3E0B2K0XTFp8DyKQ/leTbZQ9+dmZxgSB7n7bHH3k8g+?= =?iso-8859-1?Q?t5Bl0LZwwyZzPyvcvLTb53g61qfe0GQ9zPQPfIiL1IGJplFiQLUN5RICE5?= =?iso-8859-1?Q?6GPtrW0AtUZB3u+nMR8L3lX8yEK9q7GV8Jig4B2uAnfXBQYwepkQ/exb7r?= =?iso-8859-1?Q?f44/3S2ces1vjMPuNR1Zd4BpN1Er7OnGpovLKINHLaA3CDE6YFqiSwTqFp?= =?iso-8859-1?Q?iTAtGXJkyL7HLkX1JR7a0CVb/U+DIXSUMMMrOkhkO5XRvDfUj2lIBq4DZ2?= =?iso-8859-1?Q?drwUOuhqf2UDos40c7BlzXNcXW+Nm8u8Ld7OPJQv1mexWSpQMUrPMerPMP?= =?iso-8859-1?Q?1HWXZpiJdo9sa3sf5EzPfFDUxvVitaYxGE/JLbBJLKvf7362+9wGUuhVmD?= =?iso-8859-1?Q?sF2tq+SsOmlcyS4z8MefwSqB8c3QmOJt7Pj/jYH/VmPmkAHLAiPLDy+nAr?= =?iso-8859-1?Q?jl/Rnn6gq3eZzeGy1HCxuZcFJ5zdpB/+sy0IjIRe1eeeHOAurjtoGSaD4s?= =?iso-8859-1?Q?/ilJIVjbxlum1JuAXSAZLQofH/ZJBaxQ3gR1pC8qbSIvoZO3sgHX0s2Pwo?= =?iso-8859-1?Q?ArTBHyoMHDoKY7a1+TRCWF2Mb/blNHYyuZt7YVbir9Lq/l1tyT8ycKbWjF?= =?iso-8859-1?Q?aUXMqH1mJ6CQ0T2tENwwuHzIkLXbHmTPm2+Y54Cwnpndm2/qEkrN/UMOLU?= =?iso-8859-1?Q?gGZOki30dXEGz9a0K2MdKdb/dQWRMuQFG3FtcVgfWKfSs+nt3moJt+lf6e?= =?iso-8859-1?Q?MtpUeBn9Uw5x3kltcNKv1zc1VUPU9OtqZH+gycm4H47toVNeiEiyjb99Et?= =?iso-8859-1?Q?b5jYX6sByyR4l2OtbOjS3CTDvEfWv8mhbR112kK6fvFZlGtcCE51gDg3hF?= =?iso-8859-1?Q?cW+QIxrLwIS8v4dP5IHYADSx89MdcoQFzIXbfVfRmqblPQlmze/iJNlORZ?= =?iso-8859-1?Q?LIHIB6gtn/ytWzfSuu5ubLHtGQcvxqvgYZmuE8D392Hk+C5ezZpO3gk4iq?= =?iso-8859-1?Q?k/0DuIMJiQx8wd+xXjtulFECYB7XEEIEfGWyEFqiZVU7FE8+cH9UrCj8/9?= =?iso-8859-1?Q?1cgLfk4VxJ6qpenhDw7hTgwIjTAYo=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?I/d05eRcsse+mDasJb5EDIQcze8WjXVDs4gQGhjY6RBts/TtvHRgd+732Z?= =?iso-8859-1?Q?+ajW3yw5/yvPuSvwih6ND88qBt45C1JGRO4y+m4PYt/b0agrhPKRQFMnPC?= =?iso-8859-1?Q?6p0Xv/vm3yqJYfQO48P9p90GsDH0y5l3ZK7NhUIoGhmakJyTWqXVQ5LNCS?= =?iso-8859-1?Q?yCmM2WKrzYANBaE5iLSMcxHtINhQWfeHjXQ2RwWm3xyzdAGEEttFKcatnA?= =?iso-8859-1?Q?vp65uMoTAt0XK4qb8byqXA68Ny2olei27k1cGjQnEgBHr4xS5b73uP3Rgs?= =?iso-8859-1?Q?rBPHo51xoRAY9wXukoK1FBde1UVvMLv+/LRKMoTid13GH1Ig34eA0QSewm?= =?iso-8859-1?Q?Y9gL4Wj49PFbKq1Yk3ezsJs1QWfTLqdBXKZHs4i5R3fekSvnVUgzf2cZC2?= =?iso-8859-1?Q?U9bQaSbqBqBvJVmxXU0hDImbBv920+D1dPsC+3QFFcGd7k9cxjFtoQCwMF?= =?iso-8859-1?Q?/gpmfdQz4vB6HVxKH1us3WQf8I+D1LYIeySwyWyDkl1ws/6LMYizwZFQq+?= =?iso-8859-1?Q?5RiB7ZpXMD3Gdod9DNjQqTKAr+KhOiwHasH8K6UjxvLiNItiagRzOcpbs2?= =?iso-8859-1?Q?/O/H6XtKvAhi4KUEEWBmidtw4a8Kl0OHNngZulw75udAe5TXjToSy6jPgL?= =?iso-8859-1?Q?yBAmYIg6RtHJvmFPQ5md3FL9TqlvMVurTjXfhMDjv0S+ne7MyDpVxNeJwi?= =?iso-8859-1?Q?UvXy2MtlERySeroMdOihmpyoMjSVDNFB03Kt1krXoNPKvn2g+gOvlWQtaC?= =?iso-8859-1?Q?P+AvBFZVQaqbzVCqejhur+PWtEqF2k4p6PUQWKvjyQq23ZBEu1/3x/m3bu?= =?iso-8859-1?Q?q1tXK9af2I0ubEtXxtFrJsxc9g9QrdZqGuPemkZ8QWMYZ3S+PjjfMwZSq2?= =?iso-8859-1?Q?LdaCH+oexZzS4lRcWNEXjw0bNkoQ/wGWBTYDEueg4XOpec/esCQLmA0cWo?= =?iso-8859-1?Q?XO8busTJznJVcHECUVmi3Fix2I/1/p9JMs1E2yjzGpRV/cXbpAPBHAYgDx?= =?iso-8859-1?Q?BJOlvetVVB7SjWuyg5EDVmFxQAdWZlkuPNTM9k7kF+djOClyrltiT2OWQ6?= =?iso-8859-1?Q?iGVxmsp1b8iDtptEUqUXhu5ZSFgFK/uFKhzaDmAASM+4Y/CY8HWA6oGS63?= =?iso-8859-1?Q?UJk7BvqsJwmoQD35uBrKaLfgdAIezwiTG4jrRnv8vo49wnpyxQ1LnaQ2a2?= =?iso-8859-1?Q?R7aWK0dntStB1kHcBb4EZhJ+zOp2Fltenx7bYA+8rF+ZEFgG8vUI6bBXI2?= =?iso-8859-1?Q?SstY0GgPWEqent67MBYw=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-15995.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10004.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 79abb428-69f7-4159-0dca-08dd2e21ef53 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2025 07:15:43.9844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB6834 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 74881-done Cc: "74881-done@debbugs.gnu.org" <74881-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > From:=A0Eli Zaretskii =0A= > Sent:=A0Saturday, January 4, 2025 12:39 PM=0A= > Installed on master, thanks.=0A= =0A= Thank you, appreciate it. = From unknown Sat Jun 21 05:14:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Feb 2025 12:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator