From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 26 12:29:26 2010 Received: (at submit) by debbugs.gnu.org; 26 Nov 2010 17:29:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PM26v-0002w1-W4 for submit@debbugs.gnu.org; Fri, 26 Nov 2010 12:29:26 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PM26t-0002vp-5u for submit@debbugs.gnu.org; Fri, 26 Nov 2010 12:29:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PM2C8-0003Nb-Hy for submit@debbugs.gnu.org; Fri, 26 Nov 2010 12:34:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PM2C8-0003NX-F8 for submit@debbugs.gnu.org; Fri, 26 Nov 2010 12:34:48 -0500 Received: from [140.186.70.92] (port=59235 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PM2C7-0000RE-Iu for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 12:34:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PM2C6-0003NG-Cp for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 12:34:47 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:57173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PM2C6-0003N8-6e for bug-gnu-emacs@gnu.org; Fri, 26 Nov 2010 12:34:46 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oAQHYhsF019676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Nov 2010 17:34:44 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oAQHYc4G005498 for ; Fri, 26 Nov 2010 17:34:38 GMT Received: from abhmt020.oracle.com by acsmt355.oracle.com with ESMTP id 808632081290792849; Fri, 26 Nov 2010 09:34:09 -0800 Received: from dradamslap1 (/10.159.217.104) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 26 Nov 2010 09:34:09 -0800 From: "Drew Adams" To: Subject: 24.0.50; format-decode-region acts on whole buffer, not on region Date: Fri, 26 Nov 2010 09:34:13 -0800 Message-ID: <6A85A72454A944B98ADFC09FCA3AC821@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuNkCRPSCYRBCuSTVK9gC0TTtc6kQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) emacs -Q ;; On Windows, load cygwin-mount.el and setup-cygwin.el, from Emacs wiki: http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)% 3F%24 ;; (That just gives you a bash shell etc.) C-x b *scratch* Select the text "notes you don't want". M-x format-encode-region RET rot13 RET Select the same region (text that was just encoded). M-x format-decode-region RET rot13 RET The entire buffer gets ROT13'd, not just the region. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-11-22 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 29 06:22:31 2010 Received: (at submit) by debbugs.gnu.org; 29 Nov 2010 11:22:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN1oV-0000zS-Aq for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:22:31 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN1oS-0000zF-Hr for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:22:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN1to-00040m-Qy for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:28:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:42368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN1to-00040e-GD for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:28:00 -0500 Received: from [140.186.70.92] (port=35097 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN1tl-0005Qg-R4 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:28:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN1tk-0003zg-Ba for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:27:57 -0500 Received: from lo.gmane.org ([80.91.229.12]:44015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN1tk-0003zM-0f for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:27:56 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PN1th-0001Dg-3I for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 12:27:53 +0100 Received: from garnet.epcc.ed.ac.uk ([129.215.56.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Nov 2010 12:27:53 +0100 Received: from wence by garnet.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Nov 2010 12:27:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Lawrence Mitchell Subject: Re: bug#7488: 24.0.50; format-decode-region acts on whole buffer, not on region Date: Mon, 29 Nov 2010 11:27:40 +0000 Lines: 54 Message-ID: References: <6A85A72454A944B98ADFC09FCA3AC821@us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: garnet.epcc.ed.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (usg-unix-v) Cancel-Lock: sha1:zXNKwlSHHyCbGYJULHnQIMV28KU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Drew Adams wrote: > emacs -Q > ;; On Windows, load cygwin-mount.el and setup-cygwin.el, from Emacs wiki: > http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)% > 3F%24 format-decode-run-method seems to ignore the values of its region arguments (assuming the buffer is narrowed maybe?) Here's a patch: >From d1bc7ad648e75979169765d6384314a21c9dcf17 Mon Sep 17 00:00:00 2001 From: Lawrence Mitchell Date: Mon, 29 Nov 2010 11:24:57 +0000 Subject: [PATCH] Make format-decode-run-method pay attention to region arguments. Instead of assuming a narrowed buffer and apply the decoding method to the whole buffer, use the passed in values of FROM and TO. --- lisp/ChangeLog | 6 ++++++ lisp/format.el | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 58fce7a..9a12f5e 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2010-11-29 Lawrence Mitchell + + * format.el (format-decode-run-method): Use values of FROM and TO + rather than point-min and point-max to operate on the region + correctly. + 2010-11-15 Agustín Martín * textmodes/flyspell.el (flyspell-generic-progmode-verify): diff --git a/lisp/format.el b/lisp/format.el index 0436187..b4277ef 100644 --- a/lisp/format.el +++ b/lisp/format.el @@ -181,8 +181,7 @@ it should be a Lisp function. Decoding is done for the given BUFFER." ;; We should perhaps go via a temporary buffer and copy it ;; back, in case of errors. (if (and (zerop (save-window-excursion - (shell-command-on-region (point-min) (point-max) - method t t + (shell-command-on-region from to method t t error-buff))) ;; gzip gives zero exit status with bad args, for instance. (zerop (with-current-buffer error-buff -- 1.7.2.2.180.g9841a.dirty From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:30:45 2010 Received: (at 7488) by debbugs.gnu.org; 6 Dec 2010 19:30:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPglp-0001js-4m for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:30:45 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgln-0001jf-1R for 7488@debbugs.gnu.org; Mon, 06 Dec 2010 14:30:43 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6JaYiW016376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 6 Dec 2010 14:36:35 -0500 Received: by furball (Postfix, from userid 1000) id E8A8B160C98; Mon, 6 Dec 2010 14:36:34 -0500 (EST) From: Chong Yidong To: Lawrence Mitchell Subject: Re: bug#7488: 24.0.50; format-decode-region acts on whole buffer, not on region References: <6A85A72454A944B98ADFC09FCA3AC821@us.oracle.com> Date: Mon, 06 Dec 2010 14:36:34 -0500 In-Reply-To: (Lawrence Mitchell's message of "Mon, 29 Nov 2010 11:27:40 +0000") Message-ID: <87wrnmk81p.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7488 Cc: 7488@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lawrence Mitchell writes: > format-decode-run-method seems to ignore the values of its region > arguments (assuming the buffer is narrowed maybe?) > > Here's a patch: Thanks. Strange that this bug hadn't been caught before. I've committed your patch to the emacs-23 branch. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 06 14:30:59 2010 Received: (at control) by debbugs.gnu.org; 6 Dec 2010 19:30:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgm3-0001kL-FZ for submit@debbugs.gnu.org; Mon, 06 Dec 2010 14:30:59 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPgm1-0001k9-Ct for control@debbugs.gnu.org; Mon, 06 Dec 2010 14:30:57 -0500 Received: from furball (dhcp128036014234.central.yale.edu [128.36.14.234]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oB6JanrD016477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 6 Dec 2010 14:36:50 -0500 Received: by furball (Postfix, from userid 1000) id 22AEE160C98; Mon, 6 Dec 2010 14:36:50 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7488 Date: Mon, 06 Dec 2010 14:36:50 -0500 Message-ID: <87bp4yvgkt.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 7488 thanks From unknown Mon Jun 23 13:11:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator