GNU bug report logs - #74869
[PATCH] Add predicates for decoded times and time deltas

Previous Next

Full log

Message #8 received at 74869 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 74869 <at> debbugs.gnu.org
Cc: Richard Lawrence <rwl <at> recursewithless.net>
Subject: Fwd: [PATCH] Add predicates for decoded times and time deltas
Date: Sun, 29 Dec 2024 11:17:33 -0800

Argh, I now see that I cc'ed the wrong bug report. It should be bug 
74869, not 74689. Forwarding this two-day-old email to the correct bug 
report. Sorry about the duplication.


-------- Forwarded Message --------
Subject: Re: [PATCH] Add predicates for decoded times and time deltas
Date: Fri, 27 Dec 2024 16:44:32 -0800
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Richard Lawrence <rwl <at> recursewithless.net>
CC: 74689 <at> debbugs.gnu.org

What's the use case for these proposed predicates? I'm finding it hard 
to review the patch without knowing what it's for.

Surely this should be in time-date.el rather than simple.el.

The implementation of decoded-time-p seems complicated and doesn't match 
what decode-time produces. Wouldn't it be simpler to call (ignore-errors 
(equal val (decode-time (encode-time val))))?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.