From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 22:07:18 2024 Received: (at submit) by debbugs.gnu.org; 13 Dec 2024 03:07:18 +0000 Received: from localhost ([127.0.0.1]:41090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLw1N-0001Zl-Ex for submit@debbugs.gnu.org; Thu, 12 Dec 2024 22:07:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:47018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLw1C-0001ZO-Db for submit@debbugs.gnu.org; Thu, 12 Dec 2024 22:07:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLw1C-000137-0J for bug-guix@gnu.org; Thu, 12 Dec 2024 22:07:06 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLw1A-0001ob-3y for bug-guix@gnu.org; Thu, 12 Dec 2024 22:07:05 -0500 Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-4675feed835so11325171cf.1 for ; Thu, 12 Dec 2024 19:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734059223; x=1734664023; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ynokv01acwsLEY0a5JAVtCb/xLlBAaAJSlWAUw+Dl3w=; b=bLJZMtJib6L0GvW+8SCZ6ypj5NmvlFqFxwTNVcjRl+XvKg/s8L0YrkFqG0oub2anZe i1B/QK/iN2/tCWQyLPCXpTxkW7TKOhTIeQQcxux3inuOYd9PivRpSEJ8cg95yAs2GOqb MWArEn0l7J4Ugl9Nx7tyky/dn8uVMkIRj0k/EutSAz6bHw9/tR98OPQLA3S6CSzvXD+h k2OiWX6nNjUEW2VfSgXjrjodUNDfwWOqry1Jg/sZ47GISPauMlkfDqGcrR0WGenbrcV/ /xZ+i8FJqLgDMV/iS+GK4QY1R1lZRKLRjODsoGQeLrjiRaK6ZEd7MaXX914mYQmSNpax qHIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734059223; x=1734664023; h=mime-version:user-agent:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ynokv01acwsLEY0a5JAVtCb/xLlBAaAJSlWAUw+Dl3w=; b=hzIveEmixIMs26W5kDR/C8LXWJ/HrYZL2A69gzfcxYh8uiTFaOBanfftlJG6KUbT0x vV0IIgwHSC1ru1DCI8FmhYFhmYrIaduDVDSnWt74T89wDuYNFsr+LaPmwzv1kGvKI2xg hiEHWxXZQyE5WCE4ae1iK28mEOy75qNxvhg616O39ar++xUCUGHsgy8ctUeCgIALL0ai J/Q2euDysrV2MRBxxp4nZHEfO6AmUtovCoVmh5+OTt2J0wv7VnrnqIoxFj09dvktgOyB P7DzvEBWfTNCqsnRIONg+iPromCa6GpvB+1LhQmDoLDKDkcYz6nAmKVe9+8zAeKodsDl 4zdw== X-Gm-Message-State: AOJu0YwxUcmo++b3lKIHoOmZIuBe0j8XI2t0igNJ8q10gQaXUjx9e5VL n9OX/6dc9uWIz8SvvoTq94AIk4iVsNdxw8AqNXWYc1TYDHeG1gtBcKbuUhTd X-Gm-Gg: ASbGncupWqqbaGSdT1aFmDxNhOIxwmV9mVDb89B2trwQHJTU9wXBSPjsuQAXEvU0Lkk xwx3kiqByJbErarsAOWYvrjyqpBBrMAQcEsrVY+2K3rL9Ql49JDikSwE7lqSJT2wfVURnU0VtwH OXLWIpVLCtyFW1h2HHX+IcJREJ6Iq7oMVBFXYx+vpm6u9kUgMewx3BE9Jo9WmNXnHSkYZcfxMm9 wJ04YEByiPK/Uft4ulNNTzMr1DJGPYbJEZ0URB37RyE2Lryd9FYkY6cNOChGwb47zIzdz85NuHM EeqrNNd6A7j1TP62Hg== X-Google-Smtp-Source: AGHT+IGlzoXLQJXOii46qNPBAW4lvD0hFizNJppCqn9SOMhl/5ftakBd3NobFITiCDV6miBdxs51Gw== X-Received: by 2002:a05:622a:606:b0:467:53c8:7578 with SMTP id d75a77b69052e-467a577f318mr19657841cf.17.1734059222688; Thu, 12 Dec 2024 19:07:02 -0800 (PST) Received: from gnus (mtrlpq0776w-70-26-179-129.dsl.bell.ca. [70.26.179.129]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b6ea8389e1sm252708085a.71.2024.12.12.19.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 19:07:02 -0800 (PST) From: Suhail Singh To: Guix-bugs mailing list Subject: Guix racket: binaries installed via "raco pkg install" missing --config directory Date: Thu, 12 Dec 2024 22:07:01 -0500 Message-ID: <87ttb8b7sa.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::841; envelope-from=suhailsingh247@gmail.com; helo=mail-qt1-x841.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: submit Cc: Philip McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hello Guix, Currently, binaries installed via "raco" (included in Guix's "racket" package) don't include the -G / --config configuration option specifying the "Main configuration directory". This is problematic. Specifically, when installing "rash" via raco using the below: #+begin_src sh raco pkg install rash #+end_src The resulting rash-repl binary is missing the -G configuration option in the call to the racket binary. Invoking the installed rash-repl binary results in the following error: #+begin_src sh standard-module-name-resolver: collection not found for module path: (lib "rash/repl.rkt") collection: "rash" in collection directories: ${HOME}/.local/share/racket/8.14/collects /gnu/store/vn20i9xk22czljr9drwzwpgw209l49s8-racket-vm-cs-8.14/opt/racket-vm/collects/ #+end_src Adding the -G configuration option similar to what's included in the "raco" script itself, fixes the above error. The executable scripts (at least on linux) seem to be generated via make-unix-launcher in ./racket/collects/launcher/launcher.rkt . What's unclear is the best way in which to address this issue. For one thing, the -G configuration option in the "raco" script (which addressed the issue in the rash-repl script above) references the store location of the racket guix package. However, the launcher.rkt (which contains the definition of make-unix-launcher) file is compiled as part of racket-vm-cs (which is an input of racket). -- Suhail From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 00:39:13 2024 Received: (at 74845) by debbugs.gnu.org; 17 Dec 2024 05:39:13 +0000 Received: from localhost ([127.0.0.1]:57194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNQIa-00022r-OD for submit@debbugs.gnu.org; Tue, 17 Dec 2024 00:39:13 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:42032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNQIX-00022Z-7P for 74845@debbugs.gnu.org; Tue, 17 Dec 2024 00:39:10 -0500 Received: by mail-qk1-f195.google.com with SMTP id af79cd13be357-7b6ed0de64aso441609485a.0 for <74845@debbugs.gnu.org>; Mon, 16 Dec 2024 21:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734413882; x=1735018682; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=sZXb9hLqGWHxuACn3y9RCFtgLnYA2GcI75ukVdvsw94=; b=jD21bDnyuUk4Qzf7K+mFttAcq+DJqLnb3OicS6vlKwLnWj/tp8ltoRGo3fyjz+vJVR tzN81BNM1zF9w3AzsJLwVjqBCmPBX6TA//BR6AW3OEwedudyNFGnXIEEEwwK2ZnL5cuB ticW3sjAzMn+kA6vbBY4Uzwz3xBhiJZLSXGGaMPY5hKER39DsnVyBlqyPPWoKFTWSIgX YBM+CZbv63GnH+Z3zTH9NM/nWnlM2pomH29LEfi2QvpqYoq6vILvWylwE9AhMA+ieaCR N6r5kQ/G78qpbRWUGiP8Y+6XS3pm864wOAk7o1G1ALNJ5YN1lQ9FVBELMzktDWfHqwMZ 7dHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734413882; x=1735018682; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sZXb9hLqGWHxuACn3y9RCFtgLnYA2GcI75ukVdvsw94=; b=IsQ7Lz5PnUUbUHbefzRnbFXXmksp1eMPsk+f8+w3WlyHHc9brvj0NXC0Fsobwn1FXs InZk6S+9Uan6iIGaHSZ8pD4NMPWXwTqXKfKKtQCmguPvmu2yqSVVY63vPrGujsVlgE1A 8IiKFzCkzTeGbSzCpayawKysDD7yhpj3jhYTNI0cmfKoIeFjaZhclFET0cF2MG9BqnGS hjurXu/O5NllHMPflwFMt+hYMiIbo6jQ6cW2WaGIpMac+gli5leB9SGvu0GFItyhP7ck H61kDJV+FWYl0q/JqgO6obZHZqN2yXoEaaEWLtVCbPxkGKAya4vXAfcDmuZq0nypD980 hweA== X-Gm-Message-State: AOJu0YyL7BP0ev4yn2fJA7a+V5Jf0sozcjhDOGxkwtCXUlEoYXz+BJuV 57RdO7P2gcAZC+0uCn8rEJ6SE1GkwdZ8XrUClUJxZ4ctMwmOipojCEufrfRe X-Gm-Gg: ASbGncvuT9lk4fnDN8ho3ZnEcT+w9EGQcb89qg292DaimpGniotns4U5lIh6LDHAY0H 9b7kHCJuXahXb4xfOu15wwCpQg3xT+9fRNrlw/P88uq2+8QGZmofgN/eq87Dcy1JNZ3tJCiCfYq n5NN0pFI0QK4fD8sKgCKqPhOWrWZKUhBWPEbw3UVOpYdxUYTWqHesgDKA4EWqgDhmp8lSoQERXp LGFu0NpUMH+bt3Sh7Fj291ao6RkNBXaUx51ngtvSwlkahJ63NqI X-Google-Smtp-Source: AGHT+IHYggn/YEzpPHBPq/QDb2MTBw4THSrg870AjUkpLaFch0Zx5/ZmXctG/B3t+nZzy0Rk7xsPZA== X-Received: by 2002:a05:620a:454e:b0:7b1:44ee:644d with SMTP id af79cd13be357-7b8595bc28dmr377978985a.10.1734413882167; Mon, 16 Dec 2024 21:38:02 -0800 (PST) Received: from gnus ([70.26.179.129]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b7048ca246sm286687685a.114.2024.12.16.21.38.00 for <74845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 21:38:01 -0800 (PST) From: "Suhail Singh" To: 74845@debbugs.gnu.org Subject: [PATCH] gnu: racket: Ensure package launchers reference config directory. Date: Mon, 16 Dec 2024 15:25:48 -0500 X-Debbugs-Cc: Philip McGrath Message-Id: <1e53d03ab96410d841ed154d1c866e07b2973f84.1734413825.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this patch, packages installed at runtime via raco have configuration directory correctly set. * gnu/local.mk (dist_patch_DATA): [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.222.195 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.222.195 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.222.195 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.222.195 listed in sa-trusted.bondedsender.org] X-Debbugs-Envelope-To: 74845 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this patch, packages installed at runtime via raco have configuration directory correctly set. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/racket.scm (%racket-origin): Use it. Change-Id: Ibba2d73b72a66e58a3c51dad8cf4fbf0c8969c4e --- gnu/local.mk | 1 + .../patches/racket-launcher-config-dir.patch | 33 +++++++++++++++++++ gnu/packages/racket.scm | 1 + 3 files changed, 35 insertions(+) create mode 100644 gnu/packages/patches/racket-launcher-config-dir.patch diff --git a/gnu/local.mk b/gnu/local.mk index ffb8eb6d29..774cc97a83 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2124,6 +2124,7 @@ dist_patch_DATA = \ %D%/packages/patches/rpcbind-CVE-2017-8779.patch \ %D%/packages/patches/rtags-separate-rct.patch \ %D%/packages/patches/racket-chez-scheme-bin-sh.patch \ + %D%/packages/patches/racket-launcher-config-dir.patch \ %D%/packages/patches/racket-rktio-bin-sh.patch \ %D%/packages/patches/remake-impure-dirs.patch \ %D%/packages/patches/restartd-update-robust.patch \ diff --git a/gnu/packages/patches/racket-launcher-config-dir.patch b/gnu/packages/patches/racket-launcher-config-dir.patch new file mode 100644 index 0000000000..575e3b6151 --- /dev/null +++ b/gnu/packages/patches/racket-launcher-config-dir.patch @@ -0,0 +1,33 @@ +From 6b3aed3d71ea9481762de7bd42395704176b6625 Mon Sep 17 00:00:00 2001 +From: Suhail +Date: Mon, 16 Dec 2024 15:07:55 -0500 +Subject: [PATCH v2] racket: raco: Ensure launchers of packages include config + directory. + +--- + racket/collects/launcher/launcher.rkt | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/racket/collects/launcher/launcher.rkt b/racket/collects/launcher/launcher.rkt +index 0faacec4ce..2c77d55caf 100644 +--- a/racket/collects/launcher/launcher.rkt ++++ b/racket/collects/launcher/launcher.rkt +@@ -405,7 +405,14 @@ + [x-flags? (and (eq? kind 'mred) + (eq? (cross-system-type) 'unix) + (not (script-variant? variant)))] +- [flags (let ([m (assq 'wm-class aux)]) ++ [flags (let ([m (assq 'wm-class aux)] ++ [flags (if (or (member "-G" flags) ++ (member "--config" flags)) ++ flags ++ (list* "-G" ++ (format "~a" ++ (find-system-path 'config-dir)) ++ flags))]) + (if m + (list* "-J" (cdr m) flags) + flags))] +-- +2.47.1 + diff --git a/gnu/packages/racket.scm b/gnu/packages/racket.scm index 1016915b47..75f333c468 100644 --- a/gnu/packages/racket.scm +++ b/gnu/packages/racket.scm @@ -214,6 +214,7 @@ (define %racket-origin (base32 "0hg113fnd4nkvisf0ia9b367h02xfww9kysnb6fc6iac059lpard")) (file-name (git-file-name "racket" %racket-version)) (patches (search-patches "racket-chez-scheme-bin-sh.patch" + "racket-launcher-config-dir.patch" "racket-rktio-bin-sh.patch")) (modules '((guix build utils))) (snippet base-commit: 2e8a8b3ddb4ca31b918d63ff2957c6da1424a2a9 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 21:50:45 2025 Received: (at 74845) by debbugs.gnu.org; 16 Feb 2025 02:50:45 +0000 Received: from localhost ([127.0.0.1]:59281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjUk0-0002Gv-Mo for submit@debbugs.gnu.org; Sat, 15 Feb 2025 21:50:45 -0500 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]:56777) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tjUjv-0002GZ-33 for 74845@debbugs.gnu.org; Sat, 15 Feb 2025 21:50:41 -0500 Received: by mail-qk1-x744.google.com with SMTP id af79cd13be357-7c0845844a0so195337985a.1 for <74845@debbugs.gnu.org>; Sat, 15 Feb 2025 18:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739674233; x=1740279033; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0KCyv2vPavu5Ng2v5/tKaJe/CNPIo+D5kBW6FxjaVcI=; b=b2zhxWBOjQbVVpJA0G1kVvwlhJnxyq7qrlMGIFzxhPBobPeN/uo4IoGnhl3hdA6Wjc rie1Dte84C9R9fgyE8PEfM6VyncTQGtWLLleelIO2+5Y11s+Y4FOz3xOSCHpvVvBIAdc Afu2jIJJzWR0SvJiakPJ7UIQNrvNjaWUXEkt6r4Ep/36bseIGM1sm1T/13BDmYaqUuQW H8Iof9sXd6YXTxYUz6eZlL11EK3kQsEDPz/lzF1ChY0KvEvTID7AZ7NI+7MFMmkdDjEQ G6cJJmazfK9SEePLyzDk26M44+xqYZBt1E/CreaLUFreWoAG3AjryX/drDBq1yoHtTeN Sbhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739674233; x=1740279033; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0KCyv2vPavu5Ng2v5/tKaJe/CNPIo+D5kBW6FxjaVcI=; b=sZJdt04YOOGnhtsyMggZK7+Q6qHMN9hrS/KBP1Mfai02dDLEEZ0BksEjQ0Cw4XvL7e yj9ZogkbdhCDmQwIM+ZdPc8Otgw8ZUnqoj3jfTmkQBvAlXgxFwO957FTRnIQxuH5kvRk phe6eZ/svAJEB1qCj4joNjxHcJY56vp6HsjFuZPH78VMctBZsZkPK/pU62LJZdfQ+AK5 cqZ3WQ7QlSfttXy75VsAeCp207PUFVzDHIbvye7lEFMRB2EVVCba8Inp3/Me3kpcm4aO qwVvpkb+3NG06WyfX0FWAcF4Kdu6bfEo9E6wPs+0TUt1ZRbHQc4YkvH+E2ZI6Wzrnd1E Udbw== X-Gm-Message-State: AOJu0YwGdVJCKiU//KquxsgaWeen+xquKN/2FcJs73cmOpEruhVF/wbL OuY5FSgiqGfF7cb8ChUsEFWOkNCPVCeAfos5CcIc7ZXJAMy5B2tqkmo3IhCf X-Gm-Gg: ASbGnct30PUBdWfDcZzDbvyZeGD+xLoOwEkWH+yrRk4RTBDnvCsbw2d9TrQ1am5LKtI yc9ZhCBvccWtq3eD4hlojxRm8iaBUeA5kLyf5Cd1aGcfsoMTaCgBVXVHEnvnnsUDbUaPNkUyEHN B5k1SylZP/gDdeW6EAz68rr3ZEKgcLl3yQd5fKRLlBrwMhHoW4eYC/AbzlsueopaoQuVeYTC1M7 Tv9dJ2zPH8aMo0yA6LKtVoefclOp6CkxxV20zmiEHeGmTZTpff4p9AZOFZSGrARJGR7UI05iP+O tgpWDyvJsw== X-Google-Smtp-Source: AGHT+IH3Bu8LRLUSjDeoCR3sDV3Dar9qZWUf+W7AGlQ3W+Y/kiKM5q9nbMt4fuPQuLuNG7Extk08iQ== X-Received: by 2002:a05:620a:8904:b0:7c0:7e88:79c2 with SMTP id af79cd13be357-7c08a9c8a13mr726696785a.22.1739674232813; Sat, 15 Feb 2025 18:50:32 -0800 (PST) Received: from gnus ([70.24.232.14]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c07c5f3679sm382551085a.17.2025.02.15.18.50.30 for <74845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2025 18:50:31 -0800 (PST) From: "Suhail Singh" To: 74845@debbugs.gnu.org Subject: [PATCH v2] gnu: racket: Ensure package launchers reference config directory. Date: Mon, 16 Dec 2024 15:25:48 -0500 X-Debbugs-Cc: Philip McGrath , Leo Famulari Message-Id: <5164a7d37979deb66284219e1d500d502668aad2.1739674090.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this patch, packages installed at runtime via raco have configuration directory correctly set. * gnu/local.mk (dist_patch_DATA): [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:744 listed in] [list.dnswl.org] X-Debbugs-Envelope-To: 74845 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this patch, packages installed at runtime via raco have configuration directory correctly set. * gnu/local.mk (dist_patch_DATA): [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:744 listed in] [list.dnswl.org] 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (suhailsingh247[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (suhailsingh247[at]gmail.com) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this patch, packages installed at runtime via raco have configuration directory correctly set. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/racket.scm (%racket-origin): Use it. Change-Id: Ibba2d73b72a66e58a3c51dad8cf4fbf0c8969c4e --- gnu/local.mk | 1 + .../patches/racket-launcher-config-dir.patch | 65 +++++++++++++++++++ gnu/packages/racket.scm | 1 + 3 files changed, 67 insertions(+) create mode 100644 gnu/packages/patches/racket-launcher-config-dir.patch diff --git a/gnu/local.mk b/gnu/local.mk index bbe6fe4fce..9690bbe647 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -2165,6 +2165,7 @@ dist_patch_DATA = \ %D%/packages/patches/rpcbind-CVE-2017-8779.patch \ %D%/packages/patches/rtags-separate-rct.patch \ %D%/packages/patches/racket-chez-scheme-bin-sh.patch \ + %D%/packages/patches/racket-launcher-config-dir.patch \ %D%/packages/patches/racket-rktio-bin-sh.patch \ %D%/packages/patches/reduce-unbundle-libffi.patch \ %D%/packages/patches/remake-impure-dirs.patch \ diff --git a/gnu/packages/patches/racket-launcher-config-dir.patch b/gnu/packages/patches/racket-launcher-config-dir.patch new file mode 100644 index 0000000000..9a1eec6e8b --- /dev/null +++ b/gnu/packages/patches/racket-launcher-config-dir.patch @@ -0,0 +1,65 @@ +From 6b3aed3d71ea9481762de7bd42395704176b6625 Mon Sep 17 00:00:00 2001 +From: Suhail +Date: Mon, 16 Dec 2024 15:07:55 -0500 +Subject: [PATCH v2] racket: raco: Ensure launchers of packages include config + directory. + +Currently, binaries installed via "raco" (included in Guix's "racket" package) +don't include the -G / --config configuration option specifying the "Main +configuration directory". This is problematic. + +Specifically, when installing "rash" via raco using the below: + +#+begin_src sh + raco pkg install rash +#+end_src + +The resulting rash-repl binary (which is missing the -G configuration option +in the call to the racket binary), when invoked, results in the following +error: + +#+begin_src sh + standard-module-name-resolver: collection not found + for module path: (lib "rash/repl.rkt") + collection: "rash" + in collection directories: + ${HOME}/.local/share/racket/8.14/collects + /gnu/store/vn20i9xk22czljr9drwzwpgw209l49s8-racket-vm-cs-8.14/opt/racket-vm/collects/ +#+end_src + +Adding the -G configuration option in the call to the racket binary fixes the +above error. + +The executable scripts (at least on linux) are generated via +make-unix-launcher in ./racket/collects/launcher/launcher.rkt . The patch +below ensures that the -G flag is added to such launcher scripts. The patch +is conservative in that it allows it to be overwritten by callers of +launcher.rkt as desired. + +--- + racket/collects/launcher/launcher.rkt | 9 ++++++++- + 1 file changed, 8 insertions(+), 1 deletion(-) + +diff --git a/racket/collects/launcher/launcher.rkt b/racket/collects/launcher/launcher.rkt +index 0faacec4ce..2c77d55caf 100644 +--- a/racket/collects/launcher/launcher.rkt ++++ b/racket/collects/launcher/launcher.rkt +@@ -405,7 +405,14 @@ + [x-flags? (and (eq? kind 'mred) + (eq? (cross-system-type) 'unix) + (not (script-variant? variant)))] +- [flags (let ([m (assq 'wm-class aux)]) ++ [flags (let ([m (assq 'wm-class aux)] ++ [flags (if (or (member "-G" flags) ++ (member "--config" flags)) ++ flags ++ (list* "-G" ++ (format "~a" ++ (find-system-path 'config-dir)) ++ flags))]) + (if m + (list* "-J" (cdr m) flags) + flags))] +-- +2.47.1 + diff --git a/gnu/packages/racket.scm b/gnu/packages/racket.scm index 2ff1d159fa..30c8e4df53 100644 --- a/gnu/packages/racket.scm +++ b/gnu/packages/racket.scm @@ -214,6 +214,7 @@ (define %racket-origin (base32 "1lci426vvi64s077vwkxdgpkda4aggafxz52k7km2p8ngwmg9f78")) (file-name (git-file-name "racket" %racket-version)) (patches (search-patches "racket-chez-scheme-bin-sh.patch" + "racket-launcher-config-dir.patch" "racket-rktio-bin-sh.patch")) (modules '((guix build utils))) (snippet base-commit: 1afbf48b250f667ce45de40a6c275e3e42ade67c From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 23:00:41 2025 Received: (at 74845-done) by debbugs.gnu.org; 16 Feb 2025 04:00:41 +0000 Received: from localhost ([127.0.0.1]:59338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjVph-0005VH-71 for submit@debbugs.gnu.org; Sat, 15 Feb 2025 23:00:41 -0500 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:52955) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tjVpe-0005Uz-3G for 74845-done@debbugs.gnu.org; Sat, 15 Feb 2025 23:00:39 -0500 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 8336F1380265; Sat, 15 Feb 2025 23:00:32 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Sat, 15 Feb 2025 23:00:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739678432; x= 1739764832; bh=dpoCezj+EIzVd/Fv85VT8UBFHO6mPlhjwZPcrJvOLxI=; b=i y1LLHftw8qKPjvJR7HGNMDv/vFpgq9jzEht+l26QM5Z5Fr+Gt6NblOYkmc5hJGdM 6OFy/eKLIwoHdExyEgcK+euvzZtDLsjaACQ6qYqzD0O3Sqq3Gf6zYn7D1Gm9fqSb MyODEdGhnDj6++kNaR/pSVBHwr7nxMCt99y0KIS3oY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739678432; x=1739764832; bh=dpoCezj+EIzVd/Fv85VT8UBFHO6mPlhjwZP crJvOLxI=; b=Koy1p2GHiS38/Gpw0HnGObVf9UckdBiBCXiHkwpvBE5Z7Ic9hTc duI5JUq8EI+cBYzoObvtzkL1+AtVLv1ViIDYaR2tyh+oFxgo7vDSAlQDvVLHXlTt TXqV9PpojeXsSCCqWsfu+LocQt0IoDDfWfWOj/whOG18KKCL6jTYzENYTzz6WKUU yaN3Jk4My1ZJ3Wb4EsbG+9fvEzW/beYNpN76sjn7GmhrIf8f5zEOf5xBXDmunfvY HXmnL85us4ElUjX7pZyCrU/qXUWs+gnW+Cka5rcSISXRZ8EarPQUc5ys0b4RtpHB 2vAKd/D+8LPB4y1/iPHRWPDlKuEH21MFdZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehgeegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeu hfeffffgueduleehvdejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvpdhnsggprhgtphht thhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsuhhhrghilhhsihhngh hhvdegjeesghhmrghilhdrtghomhdprhgtphhtthhopeejgeekgeehqdguohhnvgesuggv sggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehphhhilhhiphesphhhihhlihhpmh gtghhrrghthhdrtghomh X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Feb 2025 23:00:31 -0500 (EST) Date: Sat, 15 Feb 2025 23:00:30 -0500 From: Leo Famulari To: Suhail Singh Subject: Re: bug#74845: [PATCH v2] gnu: racket: Ensure package launchers reference config directory. Message-ID: References: <87ttb8b7sa.fsf@gmail.com> <5164a7d37979deb66284219e1d500d502668aad2.1739674090.git.suhail@bayesians.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5164a7d37979deb66284219e1d500d502668aad2.1739674090.git.suhail@bayesians.ca> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74845-done Cc: Philip McGrath , 74845-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, Dec 16, 2024 at 03:25:48PM -0500, Suhail Singh wrote: > * gnu/packages/patches/racket-launcher-config-dir.patch: New file. With this > patch, packages installed at runtime via raco have configuration directory > correctly set. > * gnu/local.mk (dist_patch_DATA): Register it. > * gnu/packages/racket.scm (%racket-origin): Use it. Thanks! Pushed as 696f2acbc7ba0ab7874d7ee4766135b623f88424 From unknown Mon Aug 18 04:47:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Mar 2025 11:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator