From unknown Sun Sep 21 01:21:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74820 <74820@debbugs.gnu.org> To: bug#74820 <74820@debbugs.gnu.org> Subject: Status: [PATCH] browse-url-with-browser-kind: Improve browser function selection Reply-To: bug#74820 <74820@debbugs.gnu.org> Date: Sun, 21 Sep 2025 08:21:56 +0000 retitle 74820 [PATCH] browse-url-with-browser-kind: Improve browser functio= n selection reassign 74820 emacs submitter 74820 Daniel Mendler severity 74820 normal tag 74820 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 06:42:26 2024 Received: (at submit) by debbugs.gnu.org; 12 Dec 2024 11:42:26 +0000 Received: from localhost ([127.0.0.1]:37959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhaL-0002pS-PJ for submit@debbugs.gnu.org; Thu, 12 Dec 2024 06:42:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:49796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLhaJ-0002pJ-Bk for submit@debbugs.gnu.org; Thu, 12 Dec 2024 06:42:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLhaH-0006Ik-Lb for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 06:42:22 -0500 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLhaD-0006Zo-OP for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2024 06:42:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eok/6WYYOToTcXoTpjFA2SbKiTsonXHmwDkfFTAHick=; b=RTmB6g6adEcgis9y4xZRyvkrqt Fj3IDW28u23YG1Dzgzq5Qh3AN+x7a2us2CCb2NuIgFEiqKNoBs/wJc1lYoEOv2uWO8s8Z34yomKrB dzw+p4zgiVc+tWENZq5/EeJBC4Mj8m22stfN+JSmBQ+aas4sRBfSH6Tsy4hvpt9UY1bo=; From: Daniel Mendler To: bug-gnu-emacs@gnu.org Subject: [PATCH] browse-url-with-browser-kind: Improve browser function selection Date: Thu, 12 Dec 2024 12:41:50 +0100 Message-ID: <87pllx9lhd.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch In order to find an appropriate browser function for the given kind, first the browser handler lists are consulted. If no handler is found, the `browse-url-browser-function', `browse-url-secondary-browser-function`, `browse-url-default-browser' and `eww' are tried in that order until a browser function with a matching kind is found. This way the user customization of `browse-url-browser-function' and `browse-url-secondary-browser-function` is respected by `browse-url-with-browser-kind'. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-browse-url-with-browser-kind-Improve-browser-functio.patch >From f2972d6074e314e43fbb9630e5b597ff2ae47b22 Mon Sep 17 00:00:00 2001 From: Daniel Mendler Date: Thu, 12 Dec 2024 12:15:10 +0100 Subject: [PATCH] browse-url-with-browser-kind: Improve browser function selection In order to find an appropriate browser function for the given kind, first the browser handler lists are consulted. If no handler is found, the `browse-url-browser-function', `browse-url-secondary-browser-function`, `browse-url-default-browser' and `eww' are tried in that order until a browser function with a matching kind is found. This way the user customization of `browse-url-browser-function' and `browse-url-secondary-browser-function` is respected by `browse-url-with-browser-kind'. * lisp/net/browse-url.el (browse-url-with-browser-kind): Try the browser functions in the aforementioned order. --- lisp/net/browse-url.el | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el index 10165465921..e43f96c1fd5 100644 --- a/lisp/net/browse-url.el +++ b/lisp/net/browse-url.el @@ -976,7 +976,13 @@ browse-url-at-point ;;;###autoload (defun browse-url-with-browser-kind (kind url &optional arg) "Browse URL with a browser of the given browser KIND. -KIND is either `internal' or `external'. + +KIND is either `internal' or `external'. In order to find an +appropriate browser for the given KIND, first the `browse-url-handlers' +and `browse-url-default-handlers' lists are consulted. If no handler is +found, the functions `browse-url-browser-function', +`browse-url-secondary-browser-function', `browse-url-default-browser' +and `eww' are tried in that order. When called interactively, the default browser kind is the opposite of the browser kind of `browse-url-browser-function'." @@ -996,9 +1002,14 @@ browse-url-with-browser-kind (cons k url-arg))) (let ((function (browse-url-select-handler url kind))) (unless function - (setq function (if (eq kind 'external) - #'browse-url-default-browser - #'eww))) + (setq function + (seq-find + (lambda (fun) + (eq kind (browse-url--browser-kind fun url))) + (list browse-url-browser-function + browse-url-secondary-browser-function + #'browse-url-default-browser + #'eww)))) (funcall function url arg))) ;;;###autoload -- 2.45.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 06:19:25 2024 Received: (at 74820) by debbugs.gnu.org; 17 Dec 2024 11:19:25 +0000 Received: from localhost ([127.0.0.1]:57771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNVbp-0001cS-AS for submit@debbugs.gnu.org; Tue, 17 Dec 2024 06:19:25 -0500 Received: from [49.12.34.165] (port=54239 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNVbn-0001bw-Df for 74820@debbugs.gnu.org; Tue, 17 Dec 2024 06:19:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lOgEHWeGcA9eKQyOIxHGY6KhscQFDD6UMT8Agwdni7s=; b=m5sf0RdiYNcmc9cC/c/qwgvlAH 4rRxz2kta1WRIceHYMNuebHc7D1o/HcCq3n/WATmX8s4pl1v0kylv1IPqPiA9skNyjxOAAS8C7Msq 4LXxUy0azGlQDxKG5hwxhBI5r+SqQ+V8qHeKE07Nd5q9aik205xr0MO75tooxSRecXFc=; From: Daniel Mendler To: 74820@debbugs.gnu.org Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve browser function selection In-Reply-To: <87pllx9lhd.fsf@daniel-mendler.de> (Daniel Mendler's message of "Thu, 12 Dec 2024 12:41:50 +0100") References: <87pllx9lhd.fsf@daniel-mendler.de> Date: Tue, 17 Dec 2024 12:16:54 +0100 Message-ID: <87jzby1rvd.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 74820 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Daniel Mendler writes: > Tags: patch > > In order to find an appropriate browser function for the given > kind, first the browser handler lists are consulted. If no > handler is found, the `browse-url-browser-function', > `browse-url-secondary-browser-function`, > `browse-url-default-browser' and `eww' are tried in that order > until a browser function with a matching kind is found. This > way the user customization of `browse-url-browser-function' and > `browse-url-secondary-browser-function` is respected by > `browse-url-with-browser-kind'. Eli, do you have comments on this patch? I think it improves the behavior of `browse-url-with-browser-kind' in relation to our recent changes to `browse-url-browser-function' and `browse-url-secondary-browser-function', which users can set to either internal or external browsers. Thanks. Daniel From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 08:49:55 2024 Received: (at 74820) by debbugs.gnu.org; 17 Dec 2024 13:49:55 +0000 Received: from localhost ([127.0.0.1]:58136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNXxT-0000Xc-7d for submit@debbugs.gnu.org; Tue, 17 Dec 2024 08:49:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNXxQ-0000XN-S9 for 74820@debbugs.gnu.org; Tue, 17 Dec 2024 08:49:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNXxJ-0006RH-NQ; Tue, 17 Dec 2024 08:49:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Fhos3e2iPouuqKCGAMPUKjuo8WoOHRZwz+dUm96bXNw=; b=eRzRB0KN0XJ3 XFo8uK7thgBkkkkgwijFQTiiCLYlhyCI8WiWwiOa4h/njlDw7IeES5pMkIBjTNJNthW5mhSl9/nQU VuSc46FPYTDjMOe717KYv8vj15J7HHoNUxOTctikKLi9x4K8cXF/x/PXRrSFwJUq3OHJM5Ao7qzy9 6MiOeWkW/hEPN+sTQRFbTOEY5wfIiFXrqxbUp5CC3L6J8kdkxU2xzLnEJLI+dhYe1XWfjX9cYrCV3 t86MtcDgXAJoWc70MRtbPwfyzI3w/pW4/Vf5riYi2EE2xVDdK56fY0vHmkBTpRjbuvhvAKBo+pxi3 mtlzZOJLxIvRO/3tGAZcQw==; Date: Tue, 17 Dec 2024 15:49:38 +0200 Message-Id: <86bjxao1vx.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87jzby1rvd.fsf@daniel-mendler.de> (message from Daniel Mendler on Tue, 17 Dec 2024 12:16:54 +0100) Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve browser function selection References: <87pllx9lhd.fsf@daniel-mendler.de> <87jzby1rvd.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74820 Cc: 74820@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: Eli Zaretskii > Date: Tue, 17 Dec 2024 12:16:54 +0100 > > Daniel Mendler writes: > > > Tags: patch > > > > In order to find an appropriate browser function for the given > > kind, first the browser handler lists are consulted. If no > > handler is found, the `browse-url-browser-function', > > `browse-url-secondary-browser-function`, > > `browse-url-default-browser' and `eww' are tried in that order > > until a browser function with a matching kind is found. This > > way the user customization of `browse-url-browser-function' and > > `browse-url-secondary-browser-function` is respected by > > `browse-url-with-browser-kind'. > > Eli, do you have comments on this patch? I think it improves the > behavior of `browse-url-with-browser-kind' in relation to our recent > changes to `browse-url-browser-function' and `browse-url-secondary-browser-function', > which users can set to either internal or external browsers. Thanks. I didn't yet have time to review the patch. Too little free time, sorry. Will do soon. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 08:57:52 2024 Received: (at 74820) by debbugs.gnu.org; 17 Dec 2024 13:57:52 +0000 Received: from localhost ([127.0.0.1]:58163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNY58-0000xU-Bv for submit@debbugs.gnu.org; Tue, 17 Dec 2024 08:57:50 -0500 Received: from server.qxqx.de ([49.12.34.165]:38211 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNY56-0000xG-2k for 74820@debbugs.gnu.org; Tue, 17 Dec 2024 08:57:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oUHXKc4J8w+5wsD4Ze5etWq6dNXNhubRddLThYV61kM=; b=b6Kumi40CKms7I1aHP4ibrF8xM f+1yvgp00jAVrOvrrMJHE+yv5E7yJ98NofIeseMdqhwFT7ZdMeDHpJE7MkgJOzc1dBA1Dpjm7GH4Z gyOYQi/so7OPAEI61HSVyrE3L0A5cpQvsZx7z/EYnYsFcfLjSXiXAFUG+jNnADpCCmkM=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve browser function selection In-Reply-To: <86bjxao1vx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Dec 2024 15:49:38 +0200") References: <87pllx9lhd.fsf@daniel-mendler.de> <87jzby1rvd.fsf@daniel-mendler.de> <86bjxao1vx.fsf@gnu.org> Date: Tue, 17 Dec 2024 14:57:40 +0100 Message-ID: <87ed261kff.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 74820 Cc: 74820@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: Eli Zaretskii >> Date: Tue, 17 Dec 2024 12:16:54 +0100 >> >> Daniel Mendler writes: >> >> > Tags: patch >> > >> > In order to find an appropriate browser function for the given >> > kind, first the browser handler lists are consulted. If no >> > handler is found, the `browse-url-browser-function', >> > `browse-url-secondary-browser-function`, >> > `browse-url-default-browser' and `eww' are tried in that order >> > until a browser function with a matching kind is found. This >> > way the user customization of `browse-url-browser-function' and >> > `browse-url-secondary-browser-function` is respected by >> > `browse-url-with-browser-kind'. >> >> Eli, do you have comments on this patch? I think it improves the >> behavior of `browse-url-with-browser-kind' in relation to our recent >> changes to `browse-url-browser-function' and `browse-url-secondary-browser-function', >> which users can set to either internal or external browsers. Thanks. > > I didn't yet have time to review the patch. Too little free time, > sorry. Will do soon. Thanks. Take your time. There is no urgency regarding this patch. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 04:34:58 2024 Received: (at 74820-done) by debbugs.gnu.org; 21 Dec 2024 09:34:58 +0000 Received: from localhost ([127.0.0.1]:45284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOvsw-0007Uy-4R for submit@debbugs.gnu.org; Sat, 21 Dec 2024 04:34:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOvst-0007Uk-Gm for 74820-done@debbugs.gnu.org; Sat, 21 Dec 2024 04:34:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOvsn-0006qn-0g; Sat, 21 Dec 2024 04:34:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7NUKtowb9g2un3fvda//k/JabnPF9o0m2OHaEgLrDp8=; b=WvTeSoeIuHvK qn3V14JpJGe4HJXxgcj+Avst7gs8/Xyfkmonwjwfe+xAo+JlfqPtq33XMmJ+kAkGMSuEwPFwudqjy +LSzWI1WxSdeojtWKYcQPKwFsY56oOHMZxzimoJCNPnO7XDLxA0kf0UNQvecQl3No80BLOrM0IfDM vqQs+xCXVy3uerpZPYkmPQklUdiIL6aDeuuKIkfN+jKd506ac6u+evMNzbRtNNrj0OWntFvvXs1rN UprYV92YmwR98meVCmULChxGYokRBomL59e9tqu9drqQWZRrp2o3FX5Nl7Pf+vcVBaIyltdE/n7CE ghe3/40O6eySAUrE/b90vg==; Date: Sat, 21 Dec 2024 11:34:45 +0200 Message-Id: <86cyhl8jm2.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87pllx9lhd.fsf@daniel-mendler.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve browser function selection References: <87pllx9lhd.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 74820-done Cc: 74820-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 12 Dec 2024 12:41:50 +0100 > From: Daniel Mendler via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In order to find an appropriate browser function for the given > kind, first the browser handler lists are consulted. If no > handler is found, the `browse-url-browser-function', > `browse-url-secondary-browser-function`, > `browse-url-default-browser' and `eww' are tried in that order > until a browser function with a matching kind is found. This > way the user customization of `browse-url-browser-function' and > `browse-url-secondary-browser-function` is respected by > `browse-url-with-browser-kind'. Thanks, I've now installed this on the master branch, and I'm therefore closing this bug. From unknown Sun Sep 21 01:21:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Jan 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator