GNU bug report logs - #74818
[PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6.

Previous Next

Full log

Message #8 received at 74818 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: GNU Guix Live <cage-dev <at> twistfold.it>
Cc: 74818 <at> debbugs.gnu.org
Subject: Re: [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6.
Date: Tue, 17 Dec 2024 10:50:36 +0000

[Message part 1 (text/plain, inline)]

GNU Guix Live <cage-dev <at> twistfold.it> skribis:

> Change-Id: If230ce77603bfc30686a1036908687d461312b75
> ---
>  gnu/packages/lisp-xyz.scm | 25 ++++++++-----------------
>  1 file changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
> index 16f3fe6b1b..ecbbd125f6 100644
> --- a/gnu/packages/lisp-xyz.scm
> +++ b/gnu/packages/lisp-xyz.scm
> @@ -22844,11 +22844,11 @@ (define-public ecl-nkeymaps
>    (sbcl-package->ecl-package sbcl-nkeymaps))
>  
>  (define-public sbcl-nodgui
> [...]
> +      (propagated-inputs
> +       (list tk tklib))
>        (inputs
>         (list sbcl-alexandria
>               sbcl-bordeaux-threads
> @@ -22878,19 +22880,8 @@ (define-public sbcl-nodgui
>               sbcl-sdl2-ttf
>               sbcl-static-vectors
>               sbcl-trivial-garbage
> -             sbcl-zpng
> -             tk
> -             tklib))
> -      (arguments
> -       (list #:phases
> -             #~(modify-phases %standard-phases
> -                 (add-after 'unpack 'fix-paths
> -                   (lambda* (#:key inputs #:allow-other-keys)
> -                     (substitute* "src/wish-communication.lisp"
> -                       (("#-freebsd \"wish\"")
> -                        (string-append "#-freebsd \""
> -                                       (search-input-file inputs "/bin/wish")
> -                                       "\""))))))))

Hi.
Why did you replace the 'fix-paths' phase by propagated inputs?
We usually try to avoid propagating inputs if possible as it can create
conflicts in profiles.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.