GNU bug report logs - #74801
[PATCH] gnu: home: services: Add home-mpv-service-type.

Previous Next

Full log

Message #50 received at 74801 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Gabriel Wicki <gabriel <at> erlikon.ch>, Andrew Tropin <andrew <at> trop.in>,
 Hilton Chain <hako <at> ultrarare.space>, 74801 <at> debbugs.gnu.org,
 Janneke Nieuwenhuizen <janneke <at> gnu.org>
Subject: Re: bug#74801: [PATCH] gnu: home: services: Add home-mpv-service-type.
Date: Mon, 12 May 2025 09:10:58 +0200

Hi,

Tomas Volf <~@wolfsden.cz> writes:

> This commit adds a new service type to generate configuration file for the mpv
> media player.
>
> * gnu/home/services/mpv.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Register it.
> * doc/guix.texi (mpv Media Player): Document it.
>
> Change-Id: I2deb44799a28047cb5d67da97dc6007a9df873af

[...]

> v3:
> - Drop majority of commit message.  (I am not sold on this.)
> - Use ? suffix for boolean options.
> - Include link to the updater script.

[...]

> +          #:global (make-mpv-profile-configuration
> +                    #:fullscreen #t

Are we missing a question mark?

> + #:profiles `((fullscreen . ,(make-mpv-profile-configuration
> +                              #:fullscreen #t))))

Here also.

Otherwise LGTM.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.