GNU bug report logs - #74801
[PATCH] gnu: home: services: Add home-mpv-service-type.

Previous Next

Package: guix-patches;

Reported by: Tomas Volf <~@wolfsden.cz>

Date: Wed, 11 Dec 2024 21:54:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Gabriel Wicki <gabriel <at> erlikon.ch>, Andrew Tropin <andrew <at> trop.in>, Hilton Chain <hako <at> ultrarare.space>, 74801 <at> debbugs.gnu.org, Janneke Nieuwenhuizen <janneke <at> gnu.org>
Subject: [bug#74801] [PATCH v2] gnu: home: services: Add home-mpv-service-type.
Date: Fri, 09 May 2025 10:49:14 +0200
Hello,

Tomas Volf <~@wolfsden.cz> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> Could you include the code you used to generate the options?
>
> I definitely *could* do that.  While the code is maybe a bit ugly, it is
> not intended to be kept secret.  Couple of questions though.
>
> 1. Where should I put it?  Somewhere in etc directory?  Or next to the
>    service, so e.g. gnu/home/services/mpv-refresh.sh?
>
> 2. It has external dependencies, some of which are packaged in Guix
>    (emacs, emacs-paredit) and some of them are not (guile-wolfsden).  Is
>    that a problem?  Do I need to rewrite it to use just packaged
>    libraries and programs?

Well, in that case, maybe just include the URL in the script in the
comment (“Generated by …”).

Had it been pure Scheme (possibly based on (guix read-print) rather than
Emacs), we could have included it straight in the code, as is done for
Dovecot IIRC.  Someone updating it could use the relevant procedures at
the REPL to re-generate the option definitions.

Thanks,
Ludo’.




This bug report was last modified 24 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.