From unknown Sat Jun 21 03:28:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#74795 <74795@debbugs.gnu.org> To: bug#74795 <74795@debbugs.gnu.org> Subject: Status: [PATCH] remote: Do not double-quote the repl-command. Reply-To: bug#74795 <74795@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:28:05 +0000 retitle 74795 [PATCH] remote: Do not double-quote the repl-command. reassign 74795 guix-patches submitter 74795 Tomas Volf <~@wolfsden.cz> severity 74795 normal tag 74795 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 11:29:34 2024 Received: (at submit) by debbugs.gnu.org; 11 Dec 2024 16:29:34 +0000 Received: from localhost ([127.0.0.1]:35908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLPag-00037p-0R for submit@debbugs.gnu.org; Wed, 11 Dec 2024 11:29:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tLPae-00037g-Gh for submit@debbugs.gnu.org; Wed, 11 Dec 2024 11:29:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tLPad-0004I5-QJ for guix-patches@gnu.org; Wed, 11 Dec 2024 11:29:32 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tLPac-0000lr-43 for guix-patches@gnu.org; Wed, 11 Dec 2024 11:29:31 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 6AA9A35149D; Wed, 11 Dec 2024 16:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733934567; bh=juVAUPIlGrC5hCvs4lnZ+eSzRMzNa+M4JYXvbS2cKPc=; h=From:To:Cc:Subject:Date; b=UpNJEBlIz4Ei1Sz+84aDxPeUWh4JkGwdij1QTxENyfg2bJaFwQpbKGYxZ9dS5pyZL BkxBjsQNfNZ6K0MDOocps57H4RXKuaJRbHjzoKKae0v0WXaGAfeEHwRYB0soa1pAF1 HEq5rcmhRHR9D5fF5L/OysfmImsX90MEjHMar9TnFyCLzCHSU6a5If0EXecpKRzNSr 1UROm2vQL60L0GhETmj1vehMawDrOHGw18L/0vrQOylw/tQzQluaGAASwBn0a3nR7e 56Lmzh7ckoaVIgqeKodD3kicMcGPtiZrSbVG2IwNUYkMn5Z68H+2N4OhNj0rqVkVLL qoJ9HoCxOLRiySo+i8dU2z5l52TEO031X6R7iisD2FwAsb9MCuhAJQDJO8+bYX1E3e Q8NekpxC+kB4Y54uCCiDS61Vor/kN9tV3gacSdVPsjNLNrM48ChmxL3AgS/qamx7ki foxb6P2/OznbDlqauiaVR7mmzU6qFExAdu9isTb+ppOSYatKlF6MV0kzXrY0rmzdy2 46WDM6tPWO1/z9/ab5S9+olndzGsC+scK9Su1Se1h0ROv7L/1CP1LvfzeWaaULQLiq siGeyz2fZMIDkEyqA7gkg0+Fl5jRPHJUV6VlfDi7itkOddNRNchgDkr8HtfibmQjsC 29MaTpbShkskLZ4C8OcTtFlI= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id D1B46350E09; Wed, 11 Dec 2024 16:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733934566; bh=juVAUPIlGrC5hCvs4lnZ+eSzRMzNa+M4JYXvbS2cKPc=; h=From:To:Cc:Subject:Date; b=ZMUwWkfl28yV9lI6VzUoyI6pM+njKt4IdsB9BvqcdrF+R8pmMHiyT1Eqr187kwkIF LuG8fK57RGeXgYHK7XKkuRW9Jihif52m6UAzpFU5eqPLEHYZXMMx15gNE1QVLf7aif cCDhBYhqbQ6pe1D1fbWatba8rKfbm1w1abA0VdCHi3MjGbgtghkTHWepqqx+gHRIRh L++5AG4Vrp711o9zE2J1I9z1pegUmSCbFdLBgJ/xcGjm8+JBcSWFBZJzKE3ydh2p8X ZXrJeT2HLo9WfRGRvueGmDPuvbwovEX74IR6UY+SvPjzcCEN8M8HeQiCsu52tkd7hH AzbhfvSSUT08eAPQ66D/XDafcl//aLVU2ANlrch/ZlR9iYJlUvnr6v9m2lqoJR+wh/ +8R09Eb6puikySpvttaeXV1YNdhI/t2T9onoV5w6r5Z4OhRYLojiUJCj5WOFzx+yls hzyKz75Km5S0yyqd/PlQ3ASlUJ/81SfEjgYfVOXOPZcz8ckmSx1z4fnC/1H/dQzOwY 3hMTczS+LgtV2HWABZM6C/DgmXiZH4RNhy86PfjfzSRerIiyom8ALJ3ZSOELZmc4oI DKF52OdSeq8uotXNhi3utBsvkuQmw9RlqTJxGLq2W28dpuyfN6qNgDfKPPhiqKU9+7 8OnW+mjRdMjLAmK+s0v5Sld4= From: Tomas Volf <~@wolfsden.cz> To: 74787@debbugs.gnu.org, guix-patches@gnu.org Subject: [PATCH] remote: Do not double-quote the repl-command. Date: Wed, 11 Dec 2024 17:27:55 +0100 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) In 0.18.0, the `open-remote-pipe*' now correctly quotes the arguments, so the double quoting that was done by `shell-quote' is not harmful and breaks at least offloading and deploy. * guix/remote.scm (remote-pipe-for-gexp): Call object->string just once. Change-Id: Id922d26d318bfdd4714e267687c1b27461196d90 --- I checked all places where the changed procedures are used and those look correct. Nothing else in the NEWS file for 0.18.0 jumps out as a potential issue. guix/remote.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/guix/remote.scm b/guix/remote.scm index a58ec2103c..9423f9af12 100644 --- a/guix/remote.scm +++ b/guix/remote.scm @@ -48,9 +48,6 @@ (define-module (guix remote) (define* (remote-pipe-for-gexp lowered session #:optional become-command) "Return a remote pipe for the given SESSION to evaluate LOWERED. If BECOME-COMMAND is given, use that to invoke the remote Guile REPL." - (define shell-quote - (compose object->string object->string)) - (define repl-command (append (or become-command '()) (list @@ -65,7 +62,7 @@ (define* (remote-pipe-for-gexp lowered session #:optional become-command) `("-C" ,directory)) (lowered-gexp-load-path lowered)) `("-c" - ,(shell-quote (lowered-gexp-sexp lowered))))) + ,(object->string (lowered-gexp-sexp lowered))))) (let ((pipe (apply open-remote-pipe* session OPEN_READ repl-command))) (when (eof-object? (peek-char pipe)) -- 2.46.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 15:25:33 2024 Received: (at control) by debbugs.gnu.org; 11 Dec 2024 20:25:33 +0000 Received: from localhost ([127.0.0.1]:36380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLTH2-0004y3-Rw for submit@debbugs.gnu.org; Wed, 11 Dec 2024 15:25:33 -0500 Received: from wolfsden.cz ([37.205.8.62]:43278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tLTGx-0004xb-Be for control@debbugs.gnu.org; Wed, 11 Dec 2024 15:25:30 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id BB8DB350BEF; Wed, 11 Dec 2024 20:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733948725; bh=mLS2IzyoupG4E7h6EwF4Khwm3QbeiC9I3bRonlC3d80=; h=Date:To:From:Subject; b=ihsuvUoKyeBqk5K9KDL/Gw9sykMIrXk6OqbXEcGSf6VePLAxizt1JjQCzLAPd/zr9 TX9c6yPNqrQ4Ufuh7eK7YYCiMv+vBnEM+xbnsKmcvOeUo49zEP30O2T3REmlWJk1G/ BTlguFzmkJIGdXfz/7uuu3oH30vIPy2fpC+OlwmBuvRRZflNcd0CpZyAWab4fRx8/G 5b1v/Tes0IG+ogGQ+A4mKA7U4UlyK3qbfFKx5zEa1qf16qtOxVuj+83fSlZzAqNZ2l vqW40QRFBoHBABtsEviZVbQScQuGLfDd1S1+lFsXm48Gb7aBzP5mpT0VnU2hXKVkKh keEI64RkjxJXeTK0EVGs5l+0FhRlLcIdVoD2TdojkZECUz5ETLE8qHBUPRj6sp2hdI Rup1l2sAeLdlQPgNWIwlcKSJXmxWLHPp3jhPMgxRMw7n3SqZg5FXi3G6TIELX33EKI 3ZrMMhCP/s5KM6r+yyXQAV3r9ibJhjfx6byqXWryl2tvgV1VyREVpYF3u7hGlanQjZ uBlxFIg46+oh0/IsdHbXClYiw9Ojw0dA/hPFkx64fddoGf2qVdvBNLYrU0+wsNf5Rq wKx3Vkjj9H0xvymMX+nqglRLSnLN1LFmlPVMkj2S4b42PAt5DJopOia2PSMKWf7w8p KRb8JQZx+/v8kKZ68LXVeibU= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id DF568350CD0 for ; Wed, 11 Dec 2024 20:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1733948725; bh=mLS2IzyoupG4E7h6EwF4Khwm3QbeiC9I3bRonlC3d80=; h=Date:To:From:Subject; b=ihsuvUoKyeBqk5K9KDL/Gw9sykMIrXk6OqbXEcGSf6VePLAxizt1JjQCzLAPd/zr9 TX9c6yPNqrQ4Ufuh7eK7YYCiMv+vBnEM+xbnsKmcvOeUo49zEP30O2T3REmlWJk1G/ BTlguFzmkJIGdXfz/7uuu3oH30vIPy2fpC+OlwmBuvRRZflNcd0CpZyAWab4fRx8/G 5b1v/Tes0IG+ogGQ+A4mKA7U4UlyK3qbfFKx5zEa1qf16qtOxVuj+83fSlZzAqNZ2l vqW40QRFBoHBABtsEviZVbQScQuGLfDd1S1+lFsXm48Gb7aBzP5mpT0VnU2hXKVkKh keEI64RkjxJXeTK0EVGs5l+0FhRlLcIdVoD2TdojkZECUz5ETLE8qHBUPRj6sp2hdI Rup1l2sAeLdlQPgNWIwlcKSJXmxWLHPp3jhPMgxRMw7n3SqZg5FXi3G6TIELX33EKI 3ZrMMhCP/s5KM6r+yyXQAV3r9ibJhjfx6byqXWryl2tvgV1VyREVpYF3u7hGlanQjZ uBlxFIg46+oh0/IsdHbXClYiw9Ojw0dA/hPFkx64fddoGf2qVdvBNLYrU0+wsNf5Rq wKx3Vkjj9H0xvymMX+nqglRLSnLN1LFmlPVMkj2S4b42PAt5DJopOia2PSMKWf7w8p KRb8JQZx+/v8kKZ68LXVeibU= Date: Wed, 11 Dec 2024 21:25:23 +0100 Message-ID: <05d9cc72fe44100c624c44823563dbcc@wolfsden.cz> To: control@debbugs.gnu.org From: Tomas Volf <~@wolfsden.cz> Subject: control message for bug #74795 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 74795 quit From unknown Sat Jun 21 03:28:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Jan 2025 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator