GNU bug report logs - #74793
[PATCH] Add support for TCP_NODELAY on network streams

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74793 in the body.
You can then email your comments to 74793 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Marsden <eric.marsden <at> risk-engineering.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add support for TCP_NODELAY on network streams
Date: Wed, 11 Dec 2024 17:17:38 +0100

[Message part 1 (text/plain, inline)]

Hi,

The attached patch adds support for the socket option TCP_NODELAY,
to disable Nagle's algorithm. This means that network segments are
sent as soon as possible, even when they contain little data. This
reduces network latency on the network connection, but can lead to
many small packets being sent.

I have only tested on Linux/AMD64, but support for this socket option
is very widespread. Patch reformatted following feedback from Robert
Pluim and Eli Zaretskii.

My motivation for adding this support is that Emacs is very slow
when connecting to the PostgreSQL database over the network, using
my pg-el library, and is unable to saturate CPU when sending a
stream of messages. It is much faster when using a local Unix
connection and saturates CPU.

With this patch, a test case that takes 911 seconds goes down to
76 seconds (x 12 speedup).

Eric

[net-tcp-nodelay.patch (text/x-patch, attachment)]

Message #8 received at 74793 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eric Marsden <eric.marsden <at> risk-engineering.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 74793 <at> debbugs.gnu.org
Subject: Re: bug#74793: [PATCH] Add support for TCP_NODELAY on network streams
Date: Fri, 13 Dec 2024 09:29:10 +0100

>>>>> On Wed, 11 Dec 2024 17:17:38 +0100, Eric Marsden <eric.marsden <at> risk-engineering.org> said:

    Eric> I have only tested on Linux/AMD64, but support for this socket option
    Eric> is very widespread. Patch reformatted following feedback from Robert
    Eric> Pluim and Eli Zaretskii.

It builds and works on macOS for me.

Can it be applied with "Copyright-paperwork-exempt: yes"?

Robert
-- 

Message #11 received at 74793 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eric Marsden <eric.marsden <at> risk-engineering.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 74793 <at> debbugs.gnu.org
Subject: Re: bug#74793: [PATCH] Add support for TCP_NODELAY on network streams
Date: Fri, 13 Dec 2024 10:13:11 +0100

>>>>> On Fri, 13 Dec 2024 09:39:17 +0100, Eric Marsden <eric.marsden <at> risk-engineering.org> said:

    Eric> On 13/12/2024 09:29, Robert Pluim wrote:
    >> It builds and works on macOS for me.
    >> 
    >> Can it be applied with "Copyright-paperwork-exempt: yes"?
    Eric> Thanks for the testing.

    Eric> FWIW, I have signed FSF copyright transfer papers sometime in the
    Eric> early 2000s.

Was that using a different email address? In any case, the maintainers
have access to the master list of people who have signed the papers.

Robert
-- 

Message #14 received at 74793 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eric Marsden <eric.marsden <at> risk-engineering.org>
Cc: rpluim <at> gmail.com, 74793 <at> debbugs.gnu.org
Subject: Re: bug#74793: [PATCH] Add support for TCP_NODELAY on network streams
Date: Fri, 13 Dec 2024 14:03:59 +0200

> Date: Fri, 13 Dec 2024 09:39:17 +0100
> Cc: 74793 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> From: Eric Marsden <eric.marsden <at> risk-engineering.org>
> 
> On 13/12/2024 09:29, Robert Pluim wrote:
> 
>  It builds and works on macOS for me.
> 
> Can it be applied with "Copyright-paperwork-exempt: yes"?
> 
> Thanks for the testing. 
> 
> FWIW, I have signed FSF copyright transfer papers sometime in the early 2000s. 

Yes, Eric's assignment is on file (using a different email address).

Message #17 received at 74793 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eric Marsden <eric.marsden <at> risk-engineering.org>
Cc: rpluim <at> gmail.com, 74793 <at> debbugs.gnu.org
Subject: Re: bug#74793: [PATCH] Add support for TCP_NODELAY on network streams
Date: Fri, 13 Dec 2024 14:21:15 +0200

> Date: Fri, 13 Dec 2024 10:29:22 +0100
> Cc: 74793 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> From: Eric Marsden <eric.marsden <at> risk-engineering.org>
> 
> 
> On 13/12/2024 10:13, Robert Pluim wrote:
> 
>      Eric> FWIW, I have signed FSF copyright transfer papers sometime in
>  the
>     Eric> early 2000s.
> 
> Was that using a different email address? In any case, the maintainers
> have access to the master list of people who have signed the papers.
> 
> Most likely with the address emarsden <at> laas.fr

No, it's emarsden <at> mail.dotcom.fr

Message #20 received at 74793 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74793 <at> debbugs.gnu.org, Eric Marsden <eric.marsden <at> risk-engineering.org>
Subject: Re: bug#74793: [PATCH] Add support for TCP_NODELAY on network streams
Date: Fri, 13 Dec 2024 14:40:52 +0100

tags 74793 fixed
close 74793 31.1
quit

>>>>> On Fri, 13 Dec 2024 14:03:59 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    Eli> Yes, Eric's assignment is on file (using a different email address).

Closing.
Committed as c265febd97e

Eric, I added the bug# in the commit message.

Robert
-- 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.